Re: Review Request 121722: Bring back computer-laptop icon for kickoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/ --- (Updated Dec. 28, 2014, 8:35 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Sebastian Kügler. Repository: plasma-desktop Description --- Show computer-laptop icon when we're on a laptop (now checks whether you have a lid in your computer rather than if there are any batteries like the 4.x one did, much more reliable) Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 0a3d26c Diff: https://git.reviewboard.kde.org/r/121722/diff/ Testing --- Shows a laptop on my laptop. It's the little things ;) File Attachments Laptop in action https://git.reviewboard.kde.org/media/uploaded/files/2014/12/28/c6e09113-df47-4147-a399-26fe4622cf01__kickofflaptop.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121722: Bring back computer-laptop icon for kickoff
> On Dez. 28, 2014, 8:14 nachm., Lukáš Tinkl wrote: > > > > Lukáš Tinkl wrote: > Oh and, for the record, check the "Chassis" property in > http://www.freedesktop.org/wiki/Software/systemd/hostnamed/ Yeah I had that one at the back of my mind :) - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/#review72619 --- On Dez. 28, 2014, 8:13 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121722/ > --- > > (Updated Dez. 28, 2014, 8:13 nachm.) > > > Review request for Plasma and Sebastian Kügler. > > > Repository: plasma-desktop > > > Description > --- > > Show computer-laptop icon when we're on a laptop (now checks whether you have > a lid in your computer rather than if there are any batteries like the 4.x > one did, much more reliable) > > > Diffs > - > > applets/kickoff/package/contents/ui/FullRepresentation.qml 0a3d26c > > Diff: https://git.reviewboard.kde.org/r/121722/diff/ > > > Testing > --- > > Shows a laptop on my laptop. It's the little things ;) > > > File Attachments > > > Laptop in action > > https://git.reviewboard.kde.org/media/uploaded/files/2014/12/28/c6e09113-df47-4147-a399-26fe4622cf01__kickofflaptop.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121722: Bring back computer-laptop icon for kickoff
> On Pro. 28, 2014, 9:14 odp., Lukáš Tinkl wrote: > > Oh and, for the record, check the "Chassis" property in http://www.freedesktop.org/wiki/Software/systemd/hostnamed/ - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/#review72619 --- On Pro. 28, 2014, 9:13 odp., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121722/ > --- > > (Updated Pro. 28, 2014, 9:13 odp.) > > > Review request for Plasma and Sebastian Kügler. > > > Repository: plasma-desktop > > > Description > --- > > Show computer-laptop icon when we're on a laptop (now checks whether you have > a lid in your computer rather than if there are any batteries like the 4.x > one did, much more reliable) > > > Diffs > - > > applets/kickoff/package/contents/ui/FullRepresentation.qml 0a3d26c > > Diff: https://git.reviewboard.kde.org/r/121722/diff/ > > > Testing > --- > > Shows a laptop on my laptop. It's the little things ;) > > > File Attachments > > > Laptop in action > > https://git.reviewboard.kde.org/media/uploaded/files/2014/12/28/c6e09113-df47-4147-a399-26fe4622cf01__kickofflaptop.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121722: Bring back computer-laptop icon for kickoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/#review72619 --- Ship it! - Lukáš Tinkl On Pro. 28, 2014, 9:13 odp., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121722/ > --- > > (Updated Pro. 28, 2014, 9:13 odp.) > > > Review request for Plasma and Sebastian Kügler. > > > Repository: plasma-desktop > > > Description > --- > > Show computer-laptop icon when we're on a laptop (now checks whether you have > a lid in your computer rather than if there are any batteries like the 4.x > one did, much more reliable) > > > Diffs > - > > applets/kickoff/package/contents/ui/FullRepresentation.qml 0a3d26c > > Diff: https://git.reviewboard.kde.org/r/121722/diff/ > > > Testing > --- > > Shows a laptop on my laptop. It's the little things ;) > > > File Attachments > > > Laptop in action > > https://git.reviewboard.kde.org/media/uploaded/files/2014/12/28/c6e09113-df47-4147-a399-26fe4622cf01__kickofflaptop.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121722: Bring back computer-laptop icon for kickoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121722/ --- Review request for Plasma and Sebastian Kügler. Repository: plasma-desktop Description --- Show computer-laptop icon when we're on a laptop (now checks whether you have a lid in your computer rather than if there are any batteries like the 4.x one did, much more reliable) Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 0a3d26c Diff: https://git.reviewboard.kde.org/r/121722/diff/ Testing --- Shows a laptop on my laptop. It's the little things ;) File Attachments Laptop in action https://git.reviewboard.kde.org/media/uploaded/files/2014/12/28/c6e09113-df47-4147-a399-26fe4622cf01__kickofflaptop.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
