Review Request 121724: Use rgba color with 0.5 alpha channel for placheolder

2014-12-28 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121724/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

Before the move to QQC we used a Label with opacity 0.5 to gray it out.
I suggested using Qt.tint but tinting a black label (in case of a light theme) 
with semi-transparent black still stays black.

Instead I read the documentation and found a little paragraph Oh, by the way, 
there's r, g, b, a properties on every color.


Diffs
-

  src/declarativeimports/plasmastyle/TextFieldStyle.qml 2e5b718 

Diff: https://git.reviewboard.kde.org/r/121724/diff/


Testing
---

Works fine on both light and dark breeze again.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121724: Use rgba color with 0.5 alpha channel for placheolder

2014-12-28 Thread Lukáš Tinkl

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121724/#review72622
---

Ship it!


Ship It!

- Lukáš Tinkl


On Pro. 28, 2014, 9:17 odp., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121724/
 ---
 
 (Updated Pro. 28, 2014, 9:17 odp.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-framework
 
 
 Description
 ---
 
 Before the move to QQC we used a Label with opacity 0.5 to gray it out.
 I suggested using Qt.tint but tinting a black label (in case of a light 
 theme) with semi-transparent black still stays black.
 
 Instead I read the documentation and found a little paragraph Oh, by the 
 way, there's r, g, b, a properties on every color.
 
 
 Diffs
 -
 
   src/declarativeimports/plasmastyle/TextFieldStyle.qml 2e5b718 
 
 Diff: https://git.reviewboard.kde.org/r/121724/diff/
 
 
 Testing
 ---
 
 Works fine on both light and dark breeze again.
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121724: Use rgba color with 0.5 alpha channel for placheolder

2014-12-28 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121724/
---

(Updated Dec. 28, 2014, 8:34 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-framework


Description
---

Before the move to QQC we used a Label with opacity 0.5 to gray it out.
I suggested using Qt.tint but tinting a black label (in case of a light theme) 
with semi-transparent black still stays black.

Instead I read the documentation and found a little paragraph Oh, by the way, 
there's r, g, b, a properties on every color.


Diffs
-

  src/declarativeimports/plasmastyle/TextFieldStyle.qml 2e5b718 

Diff: https://git.reviewboard.kde.org/r/121724/diff/


Testing
---

Works fine on both light and dark breeze again.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel