Re: Review Request 121790: Port plasmasehll away from kscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- (Updated Feb. 8, 2017, 12:37 p.m.) Status -- This change has been discarded. Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl
Re: Review Request 121790: Port plasmasehll away from kscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/#review102453 --- this is now done. - David Edmundson On Jan. 2, 2015, noon, Lukáš Tinkl wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121790/ > --- > > (Updated Jan. 2, 2015, noon) > > > Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel > Vrátil. > > > Repository: plasma-workspace > > > Description > --- > > This patch gets us rid of kscreen dependency in plasma-workspace. No more > problems with having a half usable area for the desktop or panels dancing > around. Plasmashell starts fine and much faster w/o kscreen installed. > > Drawbacks: > - QScreen currently doesn't notify of outputs added/removed when one unplugs > the cable or undocks the laptop > > > Diffs > - > > CMakeLists.txt c6d89c1 > shell/CMakeLists.txt cb48ab8 > shell/panelview.h d1ef282 > shell/panelview.cpp b7f043d > shell/shellcorona.h 3321adf > shell/shellcorona.cpp c26efe5 > > Diff: https://git.reviewboard.kde.org/r/121790/diff/ > > > Testing > --- > > To disable ext screen: xrandr --output HDMI3 --off > To enable it again and put it right of the primary one: xrandr --output HDMI3 > --preferred --right-of LVDS1 > > > Thanks, > > Lukáš Tinkl > >
Re: Review Request 121790: Port plasmasehll away from kscreen
On Jan. 2, 2015, 2:25 p.m., Aleix Pol Gonzalez wrote: How do you figure out what's the primary screen with QScreen? https://bugreports.qt-project.org/browse/QTBUG-38404 -2 Lukáš Tinkl wrote: Ugh, that's nasty, I wasn't aware of this bug... Aleix Pol Gonzalez wrote: Yes, well, I don't know. People keep discussing the dependency of KScreen as if it was something that happened because there was an explicit interest for using it. I spent quite some time with the port and it was (and still is) the only option. Fixing Qt is possible, but I'm quite sure it won't happen if we don't make it happen. Changing hte Plasma side, is indeed the easy part. ok, so focus on Qt part for now.. tough let's keep this open, that i would like having this merged when will be possible :) - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/#review72949 --- On Jan. 2, 2015, noon, Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- (Updated Jan. 2, 2015, noon) Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121790: Port plasmasehll away from kscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/#review72938 --- Definitely where we want to go long term, and if it fixes our immediate main problem then maybe we should aim for 5.2 The KScreen changes were done because QScreen had problems not just for fun. I really want to put this under some stress testing to make sure we don't regress anything. shell/shellcorona.cpp https://git.reviewboard.kde.org/r/121790/#comment50771 maybe put screen-name() here too so it matches with SCREEN ADDED. Will make debugging easier. shell/shellcorona.cpp https://git.reviewboard.kde.org/r/121790/#comment50772 We still need this. It's for the case where we have mirrored mode i.e two screens on top of each other. That will still happen with QScreen. shell/shellcorona.cpp https://git.reviewboard.kde.org/r/121790/#comment50773 slightly offtopic, but maybe this is the cause of our original kscreen error. With the kscreen part now being out of process, we might be processing KScreens before the XCB backend of plasmashell has had a chance to load everything. Previously when it was in process we just had to wait one event loop to be sure that they were using the same data and in sync. - David Edmundson On Jan. 2, 2015, noon, Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- (Updated Jan. 2, 2015, noon) Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121790: Port plasmasehll away from kscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/#review72937 --- shell/shellcorona.cpp https://git.reviewboard.kde.org/r/121790/#comment50770 This fixes the panels dancing around btw :D - Lukáš Tinkl On Led. 2, 2015, 1 odp., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- (Updated Led. 2, 2015, 1 odp.) Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121790: Port plasmasehll away from kscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121790: Port plasmasehll away from kscreen
On Jan. 2, 2015, 2:25 p.m., Aleix Pol Gonzalez wrote: How do you figure out what's the primary screen with QScreen? https://bugreports.qt-project.org/browse/QTBUG-38404 -2 Lukáš Tinkl wrote: Ugh, that's nasty, I wasn't aware of this bug... Yes, well, I don't know. People keep discussing the dependency of KScreen as if it was something that happened because there was an explicit interest for using it. I spent quite some time with the port and it was (and still is) the only option. Fixing Qt is possible, but I'm quite sure it won't happen if we don't make it happen. Changing hte Plasma side, is indeed the easy part. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/#review72949 --- On Jan. 2, 2015, noon, Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- (Updated Jan. 2, 2015, noon) Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121790: Port plasmasehll away from kscreen
On Led. 2, 2015, 3:25 odp., Aleix Pol Gonzalez wrote: How do you figure out what's the primary screen with QScreen? https://bugreports.qt-project.org/browse/QTBUG-38404 -2 Ugh, that's nasty, I wasn't aware of this bug... - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/#review72949 --- On Led. 2, 2015, 1 odp., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- (Updated Led. 2, 2015, 1 odp.) Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121790: Port plasmasehll away from kscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/#review72949 --- How do you figure out what's the primary screen with QScreen? https://bugreports.qt-project.org/browse/QTBUG-38404 -2 - Aleix Pol Gonzalez On Jan. 2, 2015, noon, Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- (Updated Jan. 2, 2015, noon) Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel Vrátil. Repository: plasma-workspace Description --- This patch gets us rid of kscreen dependency in plasma-workspace. No more problems with having a half usable area for the desktop or panels dancing around. Plasmashell starts fine and much faster w/o kscreen installed. Drawbacks: - QScreen currently doesn't notify of outputs added/removed when one unplugs the cable or undocks the laptop Diffs - CMakeLists.txt c6d89c1 shell/CMakeLists.txt cb48ab8 shell/panelview.h d1ef282 shell/panelview.cpp b7f043d shell/shellcorona.h 3321adf shell/shellcorona.cpp c26efe5 Diff: https://git.reviewboard.kde.org/r/121790/diff/ Testing --- To disable ext screen: xrandr --output HDMI3 --off To enable it again and put it right of the primary one: xrandr --output HDMI3 --preferred --right-of LVDS1 Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel