Review Request 121974: Don't invoke context menu when there is only one ContainmentAction contextualAction

2015-01-10 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121974/
---

Review request for Plasma.


Bugs: 342702
http://bugs.kde.org/show_bug.cgi?id=342702


Repository: plasma-framework


Description
---

This fixes a broken context menu appearing when middle clicking in Plasma 
popups. That unlabled item is actually the "Paste" action. The check is taken 
straight from the containmentinterface.


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.cpp ec96224 

Diff: https://git.reviewboard.kde.org/r/121974/diff/


Testing
---

Middle clicking system tray popup now gives me a sticky note in my panel :) no 
more broken context menu.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121974: Don't invoke context menu when there is only one ContainmentAction contextualAction

2015-01-11 Thread Lukáš Tinkl

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121974/#review73727
---

Ship it!


Ship It!

- Lukáš Tinkl


On Led. 11, 2015, 12:15 dop., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121974/
> ---
> 
> (Updated Led. 11, 2015, 12:15 dop.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 342702
> http://bugs.kde.org/show_bug.cgi?id=342702
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This fixes a broken context menu appearing when middle clicking in Plasma 
> popups. That unlabled item is actually the "Paste" action. The check is taken 
> straight from the containmentinterface.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp ec96224 
> 
> Diff: https://git.reviewboard.kde.org/r/121974/diff/
> 
> 
> Testing
> ---
> 
> Middle clicking system tray popup now gives me a sticky note in my panel :) 
> no more broken context menu.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 121974: Don't invoke context menu when there is only one ContainmentAction contextualAction

2015-01-14 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121974/
---

(Updated Jan. 14, 2015, 4:38 nachm.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Bugs: 342702
http://bugs.kde.org/show_bug.cgi?id=342702


Repository: plasma-framework


Description
---

This fixes a broken context menu appearing when middle clicking in Plasma 
popups. That unlabled item is actually the "Paste" action. The check is taken 
straight from the containmentinterface.


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.cpp ec96224 

Diff: https://git.reviewboard.kde.org/r/121974/diff/


Testing
---

Middle clicking system tray popup now gives me a sticky note in my panel :) no 
more broken context menu.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel