Re: Review Request 122451: Whitelist brightness keys in the lockscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122451/#review75518 --- ksmserver/screenlocker/globalaccel.cpp https://git.reviewboard.kde.org/r/122451/#comment52221 isn't this missing QListQString or is C++11 even smarter than I expected? - Martin Gräßlin On Feb. 6, 2015, 11:04 a.m., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122451/ --- (Updated Feb. 6, 2015, 11:04 a.m.) Review request for Plasma, Daniel Vrátil and Martin Gräßlin. Repository: plasma-workspace Description --- Based on popular request, add brightness keys (increase, decrease) to the lockscreen white list of allowed shortcuts. Diffs - ksmserver/screenlocker/globalaccel.cpp 169515a Diff: https://git.reviewboard.kde.org/r/122451/diff/ Testing --- Tested, works fine Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122451: Whitelist brightness keys in the lockscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122451/ --- (Updated Feb. 6, 2015, 10:40 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, Daniel Vrátil and Martin Gräßlin. Repository: plasma-workspace Description --- Based on popular request, add brightness keys (increase, decrease) to the lockscreen white list of allowed shortcuts. Diffs - ksmserver/screenlocker/globalaccel.cpp 169515a Diff: https://git.reviewboard.kde.org/r/122451/diff/ Testing --- Tested, works fine Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122451: Whitelist brightness keys in the lockscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122451/ --- Review request for Plasma, Daniel Vrátil and Martin Gräßlin. Repository: plasma-workspace Description --- Based on popular request, add brightness keys (increase, decrease) to the lockscreen white list of allowed shortcuts. Diffs - ksmserver/screenlocker/globalaccel.cpp 169515a Diff: https://git.reviewboard.kde.org/r/122451/diff/ Testing --- Tested, works fine Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122451: Whitelist brightness keys in the lockscreen
On Feb. 6, 2015, 11:21 a.m., Martin Gräßlin wrote: ksmserver/screenlocker/globalaccel.cpp, line 52 https://git.reviewboard.kde.org/r/122451/diff/1/?file=347187#file347187line52 isn't this missing QListQString or is C++11 even smarter than I expected? Lukáš Tinkl wrote: It's that smart ;) I was expecting a QStringList instead of QListQString, but either is really not necessary with modern compilers. wohoo, learn something new each day :-) - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122451/#review75518 --- On Feb. 6, 2015, 11:04 a.m., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122451/ --- (Updated Feb. 6, 2015, 11:04 a.m.) Review request for Plasma, Daniel Vrátil and Martin Gräßlin. Repository: plasma-workspace Description --- Based on popular request, add brightness keys (increase, decrease) to the lockscreen white list of allowed shortcuts. Diffs - ksmserver/screenlocker/globalaccel.cpp 169515a Diff: https://git.reviewboard.kde.org/r/122451/diff/ Testing --- Tested, works fine Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122451: Whitelist brightness keys in the lockscreen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122451/#review75521 --- Ship it! Ship It! - Martin Gräßlin On Feb. 6, 2015, 11:04 a.m., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122451/ --- (Updated Feb. 6, 2015, 11:04 a.m.) Review request for Plasma, Daniel Vrátil and Martin Gräßlin. Repository: plasma-workspace Description --- Based on popular request, add brightness keys (increase, decrease) to the lockscreen white list of allowed shortcuts. Diffs - ksmserver/screenlocker/globalaccel.cpp 169515a Diff: https://git.reviewboard.kde.org/r/122451/diff/ Testing --- Tested, works fine Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122451: Whitelist brightness keys in the lockscreen
On Úno. 6, 2015, 11:21 dop., Martin Gräßlin wrote: ksmserver/screenlocker/globalaccel.cpp, line 52 https://git.reviewboard.kde.org/r/122451/diff/1/?file=347187#file347187line52 isn't this missing QListQString or is C++11 even smarter than I expected? It's that smart ;) I was expecting a QStringList instead of QListQString, but either is really not necessary with modern compilers. - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122451/#review75518 --- On Úno. 6, 2015, 11:04 dop., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122451/ --- (Updated Úno. 6, 2015, 11:04 dop.) Review request for Plasma, Daniel Vrátil and Martin Gräßlin. Repository: plasma-workspace Description --- Based on popular request, add brightness keys (increase, decrease) to the lockscreen white list of allowed shortcuts. Diffs - ksmserver/screenlocker/globalaccel.cpp 169515a Diff: https://git.reviewboard.kde.org/r/122451/diff/ Testing --- Tested, works fine Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
