Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

2015-02-21 Thread Heiko Tietze 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/#review76325
---

Ship it!


Design with transparent background is nice. But please consider multiple 
notifications. For instance, "You got 5 new mails", "You have been mentioned on 
IRC", plus the loudness indicator. It would be nice to not only show the last 
item but to implement a carousell pattern.

- Heiko Tietze


On Feb. 10, 2015, 10:07 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122452/
> ---
> 
> (Updated Feb. 10, 2015, 10:07 vorm.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Emitting dbus signals allows interested parties to be notified about
> OSD changes. E.g. the lock screen might want to show the OSD values,
> but blocks the actual OSD, so it needs to be informed about changes
> to react on them.
> 
> [lookandfeel] Split mainItem of Osd into a dedicated OsdItem
> 
> Allows to reuse the content of the Osd in other parts without
> having it to be a Dialog.
> 
> [screenlocker] Support OnScreenDisplay messages
> 
> KSld connects to the DBus signals for the OnScreenDisplay and forwards
> them to the greeter application through the private Wayland protocol.
> The idea here is to not have the greeter connect to the DBus as in future
> it would be preferable if the greeter cannot connect to DBus.
> 
> The lookandfeel package might expose an object called "onScreenDisplay".
> Whenever an OSD message is recieved by the greeter it looks for such an
> object and updates the osd specific properties.
> 
> The default breeze lookandfeel package integrates the OsdItem from the
> same lookandfeel package.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/greeter/greeterapp.h 
> 4a90fafee810940c3f932c8e2bfed10459adc425 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> a23b5625adc99661ab07534403ee23d005581c03 
>   ksmserver/screenlocker/protocols/ksld.xml 
> bfb32190bf2529a14b39fac4c7e6029a5df811d0 
>   ksmserver/screenlocker/waylandserver.h 
> 5a8ed2249152277b505fe7a944b1b7251ef995d3 
>   ksmserver/screenlocker/waylandserver.cpp 
> 746032e1a7b1bad3625b9f0a156de059e5fba31a 
>   lookandfeel/contents/lockscreen/LockScreen.qml 
> 1c4e4a510dd9196ae2b36bc355490580c06a78a6 
>   lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 
>   lookandfeel/contents/osd/OsdItem.qml PRE-CREATION 
>   shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 
>   shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 
> 
> Diff: https://git.reviewboard.kde.org/r/122452/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Lock screen with volume OSD
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png
> With background
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/09/05e26071-2b79-4c75-85af-68cff6e163ee__missing-tasks-applet1.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

2015-02-21 Thread Heiko Tietze 


> On Feb. 20, 2015, 9:39 vorm., Heiko Tietze wrote:
> > Design with transparent background is nice. But please consider multiple 
> > notifications. For instance, "You got 5 new mails", "You have been 
> > mentioned on IRC", plus the loudness indicator. It would be nice to not 
> > only show the last item but to implement a carousell pattern.
> 
> Martin Gräßlin wrote:
> Heiko: this is just the OSD, not notificatons. For the notifications I 
> created a forum thread in VDG, with not much feedback so far.

And I thought you want to get the feedback here :-).


- Heiko


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/#review76325
---


On Feb. 10, 2015, 10:07 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122452/
> ---
> 
> (Updated Feb. 10, 2015, 10:07 vorm.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Emitting dbus signals allows interested parties to be notified about
> OSD changes. E.g. the lock screen might want to show the OSD values,
> but blocks the actual OSD, so it needs to be informed about changes
> to react on them.
> 
> [lookandfeel] Split mainItem of Osd into a dedicated OsdItem
> 
> Allows to reuse the content of the Osd in other parts without
> having it to be a Dialog.
> 
> [screenlocker] Support OnScreenDisplay messages
> 
> KSld connects to the DBus signals for the OnScreenDisplay and forwards
> them to the greeter application through the private Wayland protocol.
> The idea here is to not have the greeter connect to the DBus as in future
> it would be preferable if the greeter cannot connect to DBus.
> 
> The lookandfeel package might expose an object called "onScreenDisplay".
> Whenever an OSD message is recieved by the greeter it looks for such an
> object and updates the osd specific properties.
> 
> The default breeze lookandfeel package integrates the OsdItem from the
> same lookandfeel package.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/greeter/greeterapp.h 
> 4a90fafee810940c3f932c8e2bfed10459adc425 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> a23b5625adc99661ab07534403ee23d005581c03 
>   ksmserver/screenlocker/protocols/ksld.xml 
> bfb32190bf2529a14b39fac4c7e6029a5df811d0 
>   ksmserver/screenlocker/waylandserver.h 
> 5a8ed2249152277b505fe7a944b1b7251ef995d3 
>   ksmserver/screenlocker/waylandserver.cpp 
> 746032e1a7b1bad3625b9f0a156de059e5fba31a 
>   lookandfeel/contents/lockscreen/LockScreen.qml 
> 1c4e4a510dd9196ae2b36bc355490580c06a78a6 
>   lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 
>   lookandfeel/contents/osd/OsdItem.qml PRE-CREATION 
>   shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 
>   shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 
> 
> Diff: https://git.reviewboard.kde.org/r/122452/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Lock screen with volume OSD
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png
> With background
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/09/05e26071-2b79-4c75-85af-68cff6e163ee__missing-tasks-applet1.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

2015-02-20 Thread Martin Gräßlin 


> On Feb. 20, 2015, 10:39 a.m., Heiko Tietze wrote:
> > Design with transparent background is nice. But please consider multiple 
> > notifications. For instance, "You got 5 new mails", "You have been 
> > mentioned on IRC", plus the loudness indicator. It would be nice to not 
> > only show the last item but to implement a carousell pattern.

Heiko: this is just the OSD, not notificatons. For the notifications I created 
a forum thread in VDG, with not much feedback so far.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/#review76325
---


On Feb. 10, 2015, 11:07 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122452/
> ---
> 
> (Updated Feb. 10, 2015, 11:07 a.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Emitting dbus signals allows interested parties to be notified about
> OSD changes. E.g. the lock screen might want to show the OSD values,
> but blocks the actual OSD, so it needs to be informed about changes
> to react on them.
> 
> [lookandfeel] Split mainItem of Osd into a dedicated OsdItem
> 
> Allows to reuse the content of the Osd in other parts without
> having it to be a Dialog.
> 
> [screenlocker] Support OnScreenDisplay messages
> 
> KSld connects to the DBus signals for the OnScreenDisplay and forwards
> them to the greeter application through the private Wayland protocol.
> The idea here is to not have the greeter connect to the DBus as in future
> it would be preferable if the greeter cannot connect to DBus.
> 
> The lookandfeel package might expose an object called "onScreenDisplay".
> Whenever an OSD message is recieved by the greeter it looks for such an
> object and updates the osd specific properties.
> 
> The default breeze lookandfeel package integrates the OsdItem from the
> same lookandfeel package.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/greeter/greeterapp.h 
> 4a90fafee810940c3f932c8e2bfed10459adc425 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> a23b5625adc99661ab07534403ee23d005581c03 
>   ksmserver/screenlocker/protocols/ksld.xml 
> bfb32190bf2529a14b39fac4c7e6029a5df811d0 
>   ksmserver/screenlocker/waylandserver.h 
> 5a8ed2249152277b505fe7a944b1b7251ef995d3 
>   ksmserver/screenlocker/waylandserver.cpp 
> 746032e1a7b1bad3625b9f0a156de059e5fba31a 
>   lookandfeel/contents/lockscreen/LockScreen.qml 
> 1c4e4a510dd9196ae2b36bc355490580c06a78a6 
>   lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 
>   lookandfeel/contents/osd/OsdItem.qml PRE-CREATION 
>   shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 
>   shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 
> 
> Diff: https://git.reviewboard.kde.org/r/122452/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Lock screen with volume OSD
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png
> With background
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/09/05e26071-2b79-4c75-85af-68cff6e163ee__missing-tasks-applet1.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

2015-02-10 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/
---

(Updated Feb. 10, 2015, 10:07 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Martin Klapetek.


Repository: plasma-workspace


Description
---

Emitting dbus signals allows interested parties to be notified about
OSD changes. E.g. the lock screen might want to show the OSD values,
but blocks the actual OSD, so it needs to be informed about changes
to react on them.

[lookandfeel] Split mainItem of Osd into a dedicated OsdItem

Allows to reuse the content of the Osd in other parts without
having it to be a Dialog.

[screenlocker] Support OnScreenDisplay messages

KSld connects to the DBus signals for the OnScreenDisplay and forwards
them to the greeter application through the private Wayland protocol.
The idea here is to not have the greeter connect to the DBus as in future
it would be preferable if the greeter cannot connect to DBus.

The lookandfeel package might expose an object called "onScreenDisplay".
Whenever an OSD message is recieved by the greeter it looks for such an
object and updates the osd specific properties.

The default breeze lookandfeel package integrates the OsdItem from the
same lookandfeel package.


Diffs
-

  ksmserver/screenlocker/greeter/greeterapp.h 
4a90fafee810940c3f932c8e2bfed10459adc425 
  ksmserver/screenlocker/greeter/greeterapp.cpp 
a23b5625adc99661ab07534403ee23d005581c03 
  ksmserver/screenlocker/protocols/ksld.xml 
bfb32190bf2529a14b39fac4c7e6029a5df811d0 
  ksmserver/screenlocker/waylandserver.h 
5a8ed2249152277b505fe7a944b1b7251ef995d3 
  ksmserver/screenlocker/waylandserver.cpp 
746032e1a7b1bad3625b9f0a156de059e5fba31a 
  lookandfeel/contents/lockscreen/LockScreen.qml 
1c4e4a510dd9196ae2b36bc355490580c06a78a6 
  lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 
  lookandfeel/contents/osd/OsdItem.qml PRE-CREATION 
  shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 
  shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 

Diff: https://git.reviewboard.kde.org/r/122452/diff/


Testing
---


File Attachments


Lock screen with volume OSD
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png
With background
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/09/05e26071-2b79-4c75-85af-68cff6e163ee__missing-tasks-applet1.png


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

2015-02-10 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/#review75763
---

Ship it!


A few minor nitpicks. Nice work!
We can fix and make the OSD placement consistent later.


ksmserver/screenlocker/greeter/greeterapp.cpp


if (version >= 2) {



lookandfeel/contents/osd/OsdItem.qml


Avoid property variant, use property var instead. But in this case property 
Item might be what you want, since you're always expecing an Item subtype.


- Kai Uwe Broulik


On Feb. 9, 2015, 7:35 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122452/
> ---
> 
> (Updated Feb. 9, 2015, 7:35 vorm.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Emitting dbus signals allows interested parties to be notified about
> OSD changes. E.g. the lock screen might want to show the OSD values,
> but blocks the actual OSD, so it needs to be informed about changes
> to react on them.
> 
> [lookandfeel] Split mainItem of Osd into a dedicated OsdItem
> 
> Allows to reuse the content of the Osd in other parts without
> having it to be a Dialog.
> 
> [screenlocker] Support OnScreenDisplay messages
> 
> KSld connects to the DBus signals for the OnScreenDisplay and forwards
> them to the greeter application through the private Wayland protocol.
> The idea here is to not have the greeter connect to the DBus as in future
> it would be preferable if the greeter cannot connect to DBus.
> 
> The lookandfeel package might expose an object called "onScreenDisplay".
> Whenever an OSD message is recieved by the greeter it looks for such an
> object and updates the osd specific properties.
> 
> The default breeze lookandfeel package integrates the OsdItem from the
> same lookandfeel package.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/greeter/greeterapp.h 
> 4a90fafee810940c3f932c8e2bfed10459adc425 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> a23b5625adc99661ab07534403ee23d005581c03 
>   ksmserver/screenlocker/protocols/ksld.xml 
> bfb32190bf2529a14b39fac4c7e6029a5df811d0 
>   ksmserver/screenlocker/waylandserver.h 
> 5a8ed2249152277b505fe7a944b1b7251ef995d3 
>   ksmserver/screenlocker/waylandserver.cpp 
> 746032e1a7b1bad3625b9f0a156de059e5fba31a 
>   lookandfeel/contents/lockscreen/LockScreen.qml 
> 1c4e4a510dd9196ae2b36bc355490580c06a78a6 
>   lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 
>   lookandfeel/contents/osd/OsdItem.qml PRE-CREATION 
>   shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 
>   shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 
> 
> Diff: https://git.reviewboard.kde.org/r/122452/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Lock screen with volume OSD
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png
> With background
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/09/05e26071-2b79-4c75-85af-68cff6e163ee__missing-tasks-applet1.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

2015-02-08 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/
---

(Updated Feb. 9, 2015, 8:35 a.m.)


Review request for Plasma and Martin Klapetek.


Changes
---

Added the background


Repository: plasma-workspace


Description
---

Emitting dbus signals allows interested parties to be notified about
OSD changes. E.g. the lock screen might want to show the OSD values,
but blocks the actual OSD, so it needs to be informed about changes
to react on them.

[lookandfeel] Split mainItem of Osd into a dedicated OsdItem

Allows to reuse the content of the Osd in other parts without
having it to be a Dialog.

[screenlocker] Support OnScreenDisplay messages

KSld connects to the DBus signals for the OnScreenDisplay and forwards
them to the greeter application through the private Wayland protocol.
The idea here is to not have the greeter connect to the DBus as in future
it would be preferable if the greeter cannot connect to DBus.

The lookandfeel package might expose an object called "onScreenDisplay".
Whenever an OSD message is recieved by the greeter it looks for such an
object and updates the osd specific properties.

The default breeze lookandfeel package integrates the OsdItem from the
same lookandfeel package.


Diffs (updated)
-

  ksmserver/screenlocker/greeter/greeterapp.h 
4a90fafee810940c3f932c8e2bfed10459adc425 
  ksmserver/screenlocker/greeter/greeterapp.cpp 
a23b5625adc99661ab07534403ee23d005581c03 
  ksmserver/screenlocker/protocols/ksld.xml 
bfb32190bf2529a14b39fac4c7e6029a5df811d0 
  ksmserver/screenlocker/waylandserver.h 
5a8ed2249152277b505fe7a944b1b7251ef995d3 
  ksmserver/screenlocker/waylandserver.cpp 
746032e1a7b1bad3625b9f0a156de059e5fba31a 
  lookandfeel/contents/lockscreen/LockScreen.qml 
1c4e4a510dd9196ae2b36bc355490580c06a78a6 
  lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 
  lookandfeel/contents/osd/OsdItem.qml PRE-CREATION 
  shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 
  shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 

Diff: https://git.reviewboard.kde.org/r/122452/diff/


Testing
---


File Attachments


Lock screen with volume OSD
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png
With background
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/09/05e26071-2b79-4c75-85af-68cff6e163ee__missing-tasks-applet1.png


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

2015-02-08 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/
---

(Updated Feb. 9, 2015, 8:33 a.m.)


Review request for Plasma and Martin Klapetek.


Changes
---

new screenshot with a plasma background.


Repository: plasma-workspace


Description (updated)
---

Emitting dbus signals allows interested parties to be notified about
OSD changes. E.g. the lock screen might want to show the OSD values,
but blocks the actual OSD, so it needs to be informed about changes
to react on them.

[lookandfeel] Split mainItem of Osd into a dedicated OsdItem

Allows to reuse the content of the Osd in other parts without
having it to be a Dialog.

[screenlocker] Support OnScreenDisplay messages

KSld connects to the DBus signals for the OnScreenDisplay and forwards
them to the greeter application through the private Wayland protocol.
The idea here is to not have the greeter connect to the DBus as in future
it would be preferable if the greeter cannot connect to DBus.

The lookandfeel package might expose an object called "onScreenDisplay".
Whenever an OSD message is recieved by the greeter it looks for such an
object and updates the osd specific properties.

The default breeze lookandfeel package integrates the OsdItem from the
same lookandfeel package.


Diffs
-

  ksmserver/screenlocker/greeter/greeterapp.h 
4a90fafee810940c3f932c8e2bfed10459adc425 
  ksmserver/screenlocker/greeter/greeterapp.cpp 
a23b5625adc99661ab07534403ee23d005581c03 
  ksmserver/screenlocker/protocols/ksld.xml 
bfb32190bf2529a14b39fac4c7e6029a5df811d0 
  ksmserver/screenlocker/waylandserver.h 
5a8ed2249152277b505fe7a944b1b7251ef995d3 
  ksmserver/screenlocker/waylandserver.cpp 
746032e1a7b1bad3625b9f0a156de059e5fba31a 
  lookandfeel/contents/lockscreen/LockScreen.qml 
1c4e4a510dd9196ae2b36bc355490580c06a78a6 
  lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 
  lookandfeel/contents/osd/OsdItem.qml PRE-CREATION 
  shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 
  shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 

Diff: https://git.reviewboard.kde.org/r/122452/diff/


Testing
---


File Attachments (updated)


Lock screen with volume OSD
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png
With background
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/09/05e26071-2b79-4c75-85af-68cff6e163ee__missing-tasks-applet1.png


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

2015-02-07 Thread Martin Klapetek 


> On Feb. 7, 2015, 1 a.m., Kai Uwe Broulik wrote:
> > File Attachment: Lock screen with volume OSD - missing-tasks-applet1.png
> > 
> >
> > I suggest you add a dialog background framesvg item around it to ease 
> > visiblity. Also y should be  2 * (background.height - osd.height) * 3
> > 
> > This ensures consistency between the real OSD and this one.
> 
> Martin Klapetek wrote:
> Personally I thought this actually looks better in here than the huge 
> rectangle around. Though maybe it should have at least some rectangle around 
> if not the whole background. Also there are the cases with custom wallpaper 
> which might make this not very clearly seen (well hello blurred desktop 
> background ^_^), sooo...probably should have the whole background, yeah :S

Second thought - this should have the background of the lock strip maybe? The 
dark one? Maybe?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/#review75551
---


On Feb. 6, 2015, 1:03 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122452/
> ---
> 
> (Updated Feb. 6, 2015, 1:03 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Emitting dbus signals allows interested parties to be notified about
> OSD changes. E.g. the lock screen might want to show the OSD values,
> but blocks the actual OSD, so it needs to be informed about changes
> to react on them.
> 
> [lookandfeel] Split mainItem of Osd into a dedicated OsdItem
> 
> Allows to reuse the content of the Osd in other parts without
> having it to be a Dialog.
> 
> [screenlocker] Support OnScreenDisplay messages
> 
> KSld connects to the DBus signals for the OnScreenDisplay and forwards
> them to the greeter application through the private Wayland protocol.
> The idea here is to not have the greeter connect to the DBus as in future
> it would be preferable if the greeter cannot connect to DBus.
> 
> The lookandfeel package might expose an object called "onScreenDisplay".
> Whenever an OSD message is recieved by the greeter it looks for such an
> object and updates the osd specific properties.
> 
> The default breeze lookandfeel package integrates the OsdItem from the
> same lookandfeel package.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/greeter/greeterapp.h 
> 4a90fafee810940c3f932c8e2bfed10459adc425 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> a23b5625adc99661ab07534403ee23d005581c03 
>   ksmserver/screenlocker/protocols/ksld.xml 
> bfb32190bf2529a14b39fac4c7e6029a5df811d0 
>   ksmserver/screenlocker/waylandserver.h 
> 5a8ed2249152277b505fe7a944b1b7251ef995d3 
>   ksmserver/screenlocker/waylandserver.cpp 
> 746032e1a7b1bad3625b9f0a156de059e5fba31a 
>   lookandfeel/contents/lockscreen/LockScreen.qml 
> 1c4e4a510dd9196ae2b36bc355490580c06a78a6 
>   lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 
>   lookandfeel/contents/osd/OsdItem.qml PRE-CREATION 
>   shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 
>   shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 
> 
> Diff: https://git.reviewboard.kde.org/r/122452/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Lock screen with volume OSD
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

2015-02-07 Thread Martin Klapetek 


> On Feb. 7, 2015, 1 a.m., Kai Uwe Broulik wrote:
> > File Attachment: Lock screen with volume OSD - missing-tasks-applet1.png
> > 
> >
> > I suggest you add a dialog background framesvg item around it to ease 
> > visiblity. Also y should be  2 * (background.height - osd.height) * 3
> > 
> > This ensures consistency between the real OSD and this one.

Personally I thought this actually looks better in here than the huge rectangle 
around. Though maybe it should have at least some rectangle around if not the 
whole background. Also there are the cases with custom wallpaper which might 
make this not very clearly seen (well hello blurred desktop background ^_^), 
sooo...probably should have the whole background, yeah :S


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/#review75551
---


On Feb. 6, 2015, 1:03 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122452/
> ---
> 
> (Updated Feb. 6, 2015, 1:03 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Emitting dbus signals allows interested parties to be notified about
> OSD changes. E.g. the lock screen might want to show the OSD values,
> but blocks the actual OSD, so it needs to be informed about changes
> to react on them.
> 
> [lookandfeel] Split mainItem of Osd into a dedicated OsdItem
> 
> Allows to reuse the content of the Osd in other parts without
> having it to be a Dialog.
> 
> [screenlocker] Support OnScreenDisplay messages
> 
> KSld connects to the DBus signals for the OnScreenDisplay and forwards
> them to the greeter application through the private Wayland protocol.
> The idea here is to not have the greeter connect to the DBus as in future
> it would be preferable if the greeter cannot connect to DBus.
> 
> The lookandfeel package might expose an object called "onScreenDisplay".
> Whenever an OSD message is recieved by the greeter it looks for such an
> object and updates the osd specific properties.
> 
> The default breeze lookandfeel package integrates the OsdItem from the
> same lookandfeel package.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/greeter/greeterapp.h 
> 4a90fafee810940c3f932c8e2bfed10459adc425 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> a23b5625adc99661ab07534403ee23d005581c03 
>   ksmserver/screenlocker/protocols/ksld.xml 
> bfb32190bf2529a14b39fac4c7e6029a5df811d0 
>   ksmserver/screenlocker/waylandserver.h 
> 5a8ed2249152277b505fe7a944b1b7251ef995d3 
>   ksmserver/screenlocker/waylandserver.cpp 
> 746032e1a7b1bad3625b9f0a156de059e5fba31a 
>   lookandfeel/contents/lockscreen/LockScreen.qml 
> 1c4e4a510dd9196ae2b36bc355490580c06a78a6 
>   lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 
>   lookandfeel/contents/osd/OsdItem.qml PRE-CREATION 
>   shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 
>   shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 
> 
> Diff: https://git.reviewboard.kde.org/r/122452/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Lock screen with volume OSD
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

2015-02-07 Thread Andrew Lake 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/#review75566
---


Looks great! Might be helpful to see what it looks like with Kai suggestion for 
using a dialog background for improved visibility.

- Andrew Lake


On Feb. 6, 2015, 12:03 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122452/
> ---
> 
> (Updated Feb. 6, 2015, 12:03 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Emitting dbus signals allows interested parties to be notified about
> OSD changes. E.g. the lock screen might want to show the OSD values,
> but blocks the actual OSD, so it needs to be informed about changes
> to react on them.
> 
> [lookandfeel] Split mainItem of Osd into a dedicated OsdItem
> 
> Allows to reuse the content of the Osd in other parts without
> having it to be a Dialog.
> 
> [screenlocker] Support OnScreenDisplay messages
> 
> KSld connects to the DBus signals for the OnScreenDisplay and forwards
> them to the greeter application through the private Wayland protocol.
> The idea here is to not have the greeter connect to the DBus as in future
> it would be preferable if the greeter cannot connect to DBus.
> 
> The lookandfeel package might expose an object called "onScreenDisplay".
> Whenever an OSD message is recieved by the greeter it looks for such an
> object and updates the osd specific properties.
> 
> The default breeze lookandfeel package integrates the OsdItem from the
> same lookandfeel package.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/greeter/greeterapp.h 
> 4a90fafee810940c3f932c8e2bfed10459adc425 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> a23b5625adc99661ab07534403ee23d005581c03 
>   ksmserver/screenlocker/protocols/ksld.xml 
> bfb32190bf2529a14b39fac4c7e6029a5df811d0 
>   ksmserver/screenlocker/waylandserver.h 
> 5a8ed2249152277b505fe7a944b1b7251ef995d3 
>   ksmserver/screenlocker/waylandserver.cpp 
> 746032e1a7b1bad3625b9f0a156de059e5fba31a 
>   lookandfeel/contents/lockscreen/LockScreen.qml 
> 1c4e4a510dd9196ae2b36bc355490580c06a78a6 
>   lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 
>   lookandfeel/contents/osd/OsdItem.qml PRE-CREATION 
>   shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 
>   shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 
> 
> Diff: https://git.reviewboard.kde.org/r/122452/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Lock screen with volume OSD
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

2015-02-06 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/#review75551
---


Nice!


File Attachment: Lock screen with volume OSD - missing-tasks-applet1.png


I suggest you add a dialog background framesvg item around it to ease 
visiblity. Also y should be  2 * (background.height - osd.height) * 3

This ensures consistency between the real OSD and this one.


- Kai Uwe Broulik


On Feb. 6, 2015, 12:03 nachm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122452/
> ---
> 
> (Updated Feb. 6, 2015, 12:03 nachm.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Emitting dbus signals allows interested parties to be notified about
> OSD changes. E.g. the lock screen might want to show the OSD values,
> but blocks the actual OSD, so it needs to be informed about changes
> to react on them.
> 
> [lookandfeel] Split mainItem of Osd into a dedicated OsdItem
> 
> Allows to reuse the content of the Osd in other parts without
> having it to be a Dialog.
> 
> [screenlocker] Support OnScreenDisplay messages
> 
> KSld connects to the DBus signals for the OnScreenDisplay and forwards
> them to the greeter application through the private Wayland protocol.
> The idea here is to not have the greeter connect to the DBus as in future
> it would be preferable if the greeter cannot connect to DBus.
> 
> The lookandfeel package might expose an object called "onScreenDisplay".
> Whenever an OSD message is recieved by the greeter it looks for such an
> object and updates the osd specific properties.
> 
> The default breeze lookandfeel package integrates the OsdItem from the
> same lookandfeel package.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/greeter/greeterapp.h 
> 4a90fafee810940c3f932c8e2bfed10459adc425 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> a23b5625adc99661ab07534403ee23d005581c03 
>   ksmserver/screenlocker/protocols/ksld.xml 
> bfb32190bf2529a14b39fac4c7e6029a5df811d0 
>   ksmserver/screenlocker/waylandserver.h 
> 5a8ed2249152277b505fe7a944b1b7251ef995d3 
>   ksmserver/screenlocker/waylandserver.cpp 
> 746032e1a7b1bad3625b9f0a156de059e5fba31a 
>   lookandfeel/contents/lockscreen/LockScreen.qml 
> 1c4e4a510dd9196ae2b36bc355490580c06a78a6 
>   lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 
>   lookandfeel/contents/osd/OsdItem.qml PRE-CREATION 
>   shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 
>   shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 
> 
> Diff: https://git.reviewboard.kde.org/r/122452/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Lock screen with volume OSD
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

2015-02-06 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/#review75533
---

Ship it!


Looks good, can't really comment on the wayland stuff tho

- Martin Klapetek


On Feb. 6, 2015, 1:03 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122452/
> ---
> 
> (Updated Feb. 6, 2015, 1:03 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Emitting dbus signals allows interested parties to be notified about
> OSD changes. E.g. the lock screen might want to show the OSD values,
> but blocks the actual OSD, so it needs to be informed about changes
> to react on them.
> 
> [lookandfeel] Split mainItem of Osd into a dedicated OsdItem
> 
> Allows to reuse the content of the Osd in other parts without
> having it to be a Dialog.
> 
> [screenlocker] Support OnScreenDisplay messages
> 
> KSld connects to the DBus signals for the OnScreenDisplay and forwards
> them to the greeter application through the private Wayland protocol.
> The idea here is to not have the greeter connect to the DBus as in future
> it would be preferable if the greeter cannot connect to DBus.
> 
> The lookandfeel package might expose an object called "onScreenDisplay".
> Whenever an OSD message is recieved by the greeter it looks for such an
> object and updates the osd specific properties.
> 
> The default breeze lookandfeel package integrates the OsdItem from the
> same lookandfeel package.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/greeter/greeterapp.h 
> 4a90fafee810940c3f932c8e2bfed10459adc425 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> a23b5625adc99661ab07534403ee23d005581c03 
>   ksmserver/screenlocker/protocols/ksld.xml 
> bfb32190bf2529a14b39fac4c7e6029a5df811d0 
>   ksmserver/screenlocker/waylandserver.h 
> 5a8ed2249152277b505fe7a944b1b7251ef995d3 
>   ksmserver/screenlocker/waylandserver.cpp 
> 746032e1a7b1bad3625b9f0a156de059e5fba31a 
>   lookandfeel/contents/lockscreen/LockScreen.qml 
> 1c4e4a510dd9196ae2b36bc355490580c06a78a6 
>   lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 
>   lookandfeel/contents/osd/OsdItem.qml PRE-CREATION 
>   shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 
>   shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 
> 
> Diff: https://git.reviewboard.kde.org/r/122452/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Lock screen with volume OSD
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

2015-02-06 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122452/
---

Review request for Plasma and Martin Klapetek.


Repository: plasma-workspace


Description
---

Emitting dbus signals allows interested parties to be notified about
OSD changes. E.g. the lock screen might want to show the OSD values,
but blocks the actual OSD, so it needs to be informed about changes
to react on them.

[lookandfeel] Split mainItem of Osd into a dedicated OsdItem

Allows to reuse the content of the Osd in other parts without
having it to be a Dialog.

[screenlocker] Support OnScreenDisplay messages

KSld connects to the DBus signals for the OnScreenDisplay and forwards
them to the greeter application through the private Wayland protocol.
The idea here is to not have the greeter connect to the DBus as in future
it would be preferable if the greeter cannot connect to DBus.

The lookandfeel package might expose an object called "onScreenDisplay".
Whenever an OSD message is recieved by the greeter it looks for such an
object and updates the osd specific properties.

The default breeze lookandfeel package integrates the OsdItem from the
same lookandfeel package.


Diffs
-

  ksmserver/screenlocker/greeter/greeterapp.h 
4a90fafee810940c3f932c8e2bfed10459adc425 
  ksmserver/screenlocker/greeter/greeterapp.cpp 
a23b5625adc99661ab07534403ee23d005581c03 
  ksmserver/screenlocker/protocols/ksld.xml 
bfb32190bf2529a14b39fac4c7e6029a5df811d0 
  ksmserver/screenlocker/waylandserver.h 
5a8ed2249152277b505fe7a944b1b7251ef995d3 
  ksmserver/screenlocker/waylandserver.cpp 
746032e1a7b1bad3625b9f0a156de059e5fba31a 
  lookandfeel/contents/lockscreen/LockScreen.qml 
1c4e4a510dd9196ae2b36bc355490580c06a78a6 
  lookandfeel/contents/osd/Osd.qml b63338c2f94c074b405bba5509623ef38eef5350 
  lookandfeel/contents/osd/OsdItem.qml PRE-CREATION 
  shell/osd.h 356b073b2b9c88e57c324701ae47e0e969b75a51 
  shell/osd.cpp b5d40ab3539bbbe37386fa6ecf4a1f8cb130c100 

Diff: https://git.reviewboard.kde.org/r/122452/diff/


Testing
---


File Attachments


Lock screen with volume OSD
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/06/7e2f82a5-4ec4-46cc-9697-7cead41d2a45__missing-tasks-applet1.png


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel