Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/ --- (Updated Feb. 10, 2015, 1:35 p.m.) Review request for Plasma. Changes --- Changed to StandAloneApp Repository: plasma-framework Description --- We can use this option to figure out which applets should be exposed as windows. It doesn't make sense to do that for all of them. Diffs (updated) - src/plasma/data/servicetypes/plasma-applet.desktop ff48afa Diff: https://git.reviewboard.kde.org/r/122502/diff/ Testing --- Tried by using this option to filter them in the windowed widgets runner. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/#review75780 --- +1 - David Edmundson On Feb. 10, 2015, 1:35 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/ --- (Updated Feb. 10, 2015, 1:35 p.m.) Review request for Plasma. Repository: plasma-framework Description --- We can use this option to figure out which applets should be exposed as windows. It doesn't make sense to do that for all of them. Diffs - src/plasma/data/servicetypes/plasma-applet.desktop ff48afa Diff: https://git.reviewboard.kde.org/r/122502/diff/ Testing --- Tried by using this option to filter them in the windowed widgets runner. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/#review75781 --- Ship it! Ship It! - Marco Martin On Feb. 10, 2015, 1:35 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/ --- (Updated Feb. 10, 2015, 1:35 p.m.) Review request for Plasma. Repository: plasma-framework Description --- We can use this option to figure out which applets should be exposed as windows. It doesn't make sense to do that for all of them. Diffs - src/plasma/data/servicetypes/plasma-applet.desktop ff48afa Diff: https://git.reviewboard.kde.org/r/122502/diff/ Testing --- Tried by using this option to filter them in the windowed widgets runner. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/ --- (Updated Feb. 10, 2015, 1:43 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description --- We can use this option to figure out which applets should be exposed as windows. It doesn't make sense to do that for all of them. Diffs - src/plasma/data/servicetypes/plasma-applet.desktop ff48afa Diff: https://git.reviewboard.kde.org/r/122502/diff/ Testing --- Tried by using this option to filter them in the windowed widgets runner. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/#review75709 --- +1 to the idea src/plasma/data/servicetypes/plasma-applet.desktop https://git.reviewboard.kde.org/r/122502/#comment52339 everything else is in the form X-Plasma-CamelCasedName - David Edmundson On Feb. 9, 2015, 4:22 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/ --- (Updated Feb. 9, 2015, 4:22 p.m.) Review request for Plasma. Repository: plasma-framework Description --- We can use this option to figure out which applets should be exposed as windows. It doesn't make sense to do that for all of them. Diffs - src/plasma/data/servicetypes/plasma-applet.desktop ff48afa Diff: https://git.reviewboard.kde.org/r/122502/diff/ Testing --- Tried by using this option to filter them in the windowed widgets runner. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/#review75706 --- +1, I assume this defaults to false - Bhushan Shah On Feb. 9, 2015, 9:52 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/ --- (Updated Feb. 9, 2015, 9:52 p.m.) Review request for Plasma. Repository: plasma-framework Description --- We can use this option to figure out which applets should be exposed as windows. It doesn't make sense to do that for all of them. Diffs - src/plasma/data/servicetypes/plasma-applet.desktop ff48afa Diff: https://git.reviewboard.kde.org/r/122502/diff/ Testing --- Tried by using this option to filter them in the windowed widgets runner. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/#review75710 --- a bit on the fence about it, hmm.. I assume it would just not list them in krunner, but plasma-windowed would still load them from commandline Anyways, I would call it X-Plasma-StandAloneApp or a formulation like that, then it mirrors nicely the similar current entry X-Plasma-NotificationArea used for the ones that go in the systray - Marco Martin On Feb. 9, 2015, 4:22 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/ --- (Updated Feb. 9, 2015, 4:22 p.m.) Review request for Plasma. Repository: plasma-framework Description --- We can use this option to figure out which applets should be exposed as windows. It doesn't make sense to do that for all of them. Diffs - src/plasma/data/servicetypes/plasma-applet.desktop ff48afa Diff: https://git.reviewboard.kde.org/r/122502/diff/ Testing --- Tried by using this option to filter them in the windowed widgets runner. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/ --- Review request for Plasma. Repository: plasma-framework Description --- We can use this option to figure out which applets should be exposed as windows. It doesn't make sense to do that for all of them. Diffs - src/plasma/data/servicetypes/plasma-applet.desktop ff48afa Diff: https://git.reviewboard.kde.org/r/122502/diff/ Testing --- Tried by using this option to filter them in the windowed widgets runner. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
