Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

2015-09-29 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122510/
---

(Updated Sept. 29, 2015, 9:37 a.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Bugs: 271731
https://bugs.kde.org/show_bug.cgi?id=271731


Repository: plasma-workspace


Description
---

See the idle recommendations on [1]. Binding it to the lock screen does
not exactly match the recommendation, but it has some advantages:
* we know it's idle when it's locked
* it kicks in after the user's configured idle timeout
* if the user unlocks we know it's no longer idle

FEATURE: 271731
FIXED-IN: 5.3.0

[1] 
http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/


Diffs
-

  ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 
  ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 
  ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 

Diff: https://git.reviewboard.kde.org/r/122510/diff/


Testing
---

Run the test application and verified using loginctl from tty1 while the screen 
was locked and after unlocked.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

2015-02-13 Thread David Edmundson 


> On Feb. 10, 2015, 1:29 p.m., David Edmundson wrote:
> > I'm not convinced this is right.
> > 
> > From the doc you linked: 
> >  This is necessary for the system to implement auto-suspend when all 
> > sessions are idle.
> >  
> > When we lock the screen, powerdevil is still running, no?
> > 
> > Powerdevil has an inhibition blocking logind suspending, so I think overall 
> > this will just do nothing.
> 
> Martin Gräßlin wrote:
> The linked bug report gives another use case: cross-desktop check to see 
> whether the session is idle.
> 
> > Powerdevil has an inhibition blocking logind suspending, so I think 
> overall this will just do nothing.
> 
> Why is powerdevil holding an inhibition lock?
> 
> David Edmundson wrote:
> So we can implement auto suspend / key handling based on the user's KDE 
> configs, not based on some global configs.
> 
> Kai Uwe Broulik wrote:
> PowerDevil inhibits the following: 
> ["handle-power-key:handle-suspend-key:handle-hibernate-key:handle-lid-switch",
>  "PowerDevil", "KDE handles power events", "block"]
> Also, "IdleAction" is "ignore" here.
> 
> Martin Gräßlin wrote:
> If I understand that correctly David's concern doesn't hold?
> 
> David Edmundson wrote:
> I still want a question answered.
> 
> Why do we want logind to do it's idle action when we are showing a lock 
> screen when we're managing auto suspend ourselves?
> 
> Martin Gräßlin wrote:
> to properly handle idle in a multi-user setup?
> 
> Kai Uwe Broulik wrote:
> Would that fix https://bugs.kde.org/show_bug.cgi?id=340427 ? But I think 
> PowerDevil does some session active tracking magic.
> 
> Martin Gräßlin wrote:
> > Would that fix https://bugs.kde.org/show_bug.cgi?id=340427
> 
> no, that looks like needs fixing in Powerdevil (release inhibition locks 
> when it becomes the non-active session).
> 
> Kai Uwe Broulik wrote:
> Ok, I'll fix PowerDevil, +1 from me.

Screen is locked is not the same as "user is on another session".


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122510/#review75777
---


On Feb. 10, 2015, 1:21 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122510/
> ---
> 
> (Updated Feb. 10, 2015, 1:21 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 271731
> https://bugs.kde.org/show_bug.cgi?id=271731
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> See the idle recommendations on [1]. Binding it to the lock screen does
> not exactly match the recommendation, but it has some advantages:
> * we know it's idle when it's locked
> * it kicks in after the user's configured idle timeout
> * if the user unlocks we know it's no longer idle
> 
> FEATURE: 271731
> FIXED-IN: 5.3.0
> 
> [1] 
> http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 
>   ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 
>   ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 
> 
> Diff: https://git.reviewboard.kde.org/r/122510/diff/
> 
> 
> Testing
> ---
> 
> Run the test application and verified using loginctl from tty1 while the 
> screen was locked and after unlocked.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

2015-02-13 Thread Kai Uwe Broulik 


> On Feb. 10, 2015, 1:29 nachm., David Edmundson wrote:
> > I'm not convinced this is right.
> > 
> > From the doc you linked: 
> >  This is necessary for the system to implement auto-suspend when all 
> > sessions are idle.
> >  
> > When we lock the screen, powerdevil is still running, no?
> > 
> > Powerdevil has an inhibition blocking logind suspending, so I think overall 
> > this will just do nothing.
> 
> Martin Gräßlin wrote:
> The linked bug report gives another use case: cross-desktop check to see 
> whether the session is idle.
> 
> > Powerdevil has an inhibition blocking logind suspending, so I think 
> overall this will just do nothing.
> 
> Why is powerdevil holding an inhibition lock?
> 
> David Edmundson wrote:
> So we can implement auto suspend / key handling based on the user's KDE 
> configs, not based on some global configs.
> 
> Kai Uwe Broulik wrote:
> PowerDevil inhibits the following: 
> ["handle-power-key:handle-suspend-key:handle-hibernate-key:handle-lid-switch",
>  "PowerDevil", "KDE handles power events", "block"]
> Also, "IdleAction" is "ignore" here.
> 
> Martin Gräßlin wrote:
> If I understand that correctly David's concern doesn't hold?
> 
> David Edmundson wrote:
> I still want a question answered.
> 
> Why do we want logind to do it's idle action when we are showing a lock 
> screen when we're managing auto suspend ourselves?
> 
> Martin Gräßlin wrote:
> to properly handle idle in a multi-user setup?
> 
> Kai Uwe Broulik wrote:
> Would that fix https://bugs.kde.org/show_bug.cgi?id=340427 ? But I think 
> PowerDevil does some session active tracking magic.
> 
> Martin Gräßlin wrote:
> > Would that fix https://bugs.kde.org/show_bug.cgi?id=340427
> 
> no, that looks like needs fixing in Powerdevil (release inhibition locks 
> when it becomes the non-active session).

Ok, I'll fix PowerDevil, +1 from me.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122510/#review75777
---


On Feb. 10, 2015, 1:21 nachm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122510/
> ---
> 
> (Updated Feb. 10, 2015, 1:21 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 271731
> https://bugs.kde.org/show_bug.cgi?id=271731
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> See the idle recommendations on [1]. Binding it to the lock screen does
> not exactly match the recommendation, but it has some advantages:
> * we know it's idle when it's locked
> * it kicks in after the user's configured idle timeout
> * if the user unlocks we know it's no longer idle
> 
> FEATURE: 271731
> FIXED-IN: 5.3.0
> 
> [1] 
> http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 
>   ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 
>   ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 
> 
> Diff: https://git.reviewboard.kde.org/r/122510/diff/
> 
> 
> Testing
> ---
> 
> Run the test application and verified using loginctl from tty1 while the 
> screen was locked and after unlocked.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

2015-02-13 Thread Martin Gräßlin 


> On Feb. 10, 2015, 2:29 p.m., David Edmundson wrote:
> > I'm not convinced this is right.
> > 
> > From the doc you linked: 
> >  This is necessary for the system to implement auto-suspend when all 
> > sessions are idle.
> >  
> > When we lock the screen, powerdevil is still running, no?
> > 
> > Powerdevil has an inhibition blocking logind suspending, so I think overall 
> > this will just do nothing.
> 
> Martin Gräßlin wrote:
> The linked bug report gives another use case: cross-desktop check to see 
> whether the session is idle.
> 
> > Powerdevil has an inhibition blocking logind suspending, so I think 
> overall this will just do nothing.
> 
> Why is powerdevil holding an inhibition lock?
> 
> David Edmundson wrote:
> So we can implement auto suspend / key handling based on the user's KDE 
> configs, not based on some global configs.
> 
> Kai Uwe Broulik wrote:
> PowerDevil inhibits the following: 
> ["handle-power-key:handle-suspend-key:handle-hibernate-key:handle-lid-switch",
>  "PowerDevil", "KDE handles power events", "block"]
> Also, "IdleAction" is "ignore" here.
> 
> Martin Gräßlin wrote:
> If I understand that correctly David's concern doesn't hold?
> 
> David Edmundson wrote:
> I still want a question answered.
> 
> Why do we want logind to do it's idle action when we are showing a lock 
> screen when we're managing auto suspend ourselves?
> 
> Martin Gräßlin wrote:
> to properly handle idle in a multi-user setup?
> 
> Kai Uwe Broulik wrote:
> Would that fix https://bugs.kde.org/show_bug.cgi?id=340427 ? But I think 
> PowerDevil does some session active tracking magic.

> Would that fix https://bugs.kde.org/show_bug.cgi?id=340427

no, that looks like needs fixing in Powerdevil (release inhibition locks when 
it becomes the non-active session).


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122510/#review75777
---


On Feb. 10, 2015, 2:21 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122510/
> ---
> 
> (Updated Feb. 10, 2015, 2:21 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 271731
> https://bugs.kde.org/show_bug.cgi?id=271731
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> See the idle recommendations on [1]. Binding it to the lock screen does
> not exactly match the recommendation, but it has some advantages:
> * we know it's idle when it's locked
> * it kicks in after the user's configured idle timeout
> * if the user unlocks we know it's no longer idle
> 
> FEATURE: 271731
> FIXED-IN: 5.3.0
> 
> [1] 
> http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 
>   ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 
>   ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 
> 
> Diff: https://git.reviewboard.kde.org/r/122510/diff/
> 
> 
> Testing
> ---
> 
> Run the test application and verified using loginctl from tty1 while the 
> screen was locked and after unlocked.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

2015-02-13 Thread Kai Uwe Broulik 


> On Feb. 10, 2015, 1:29 nachm., David Edmundson wrote:
> > I'm not convinced this is right.
> > 
> > From the doc you linked: 
> >  This is necessary for the system to implement auto-suspend when all 
> > sessions are idle.
> >  
> > When we lock the screen, powerdevil is still running, no?
> > 
> > Powerdevil has an inhibition blocking logind suspending, so I think overall 
> > this will just do nothing.
> 
> Martin Gräßlin wrote:
> The linked bug report gives another use case: cross-desktop check to see 
> whether the session is idle.
> 
> > Powerdevil has an inhibition blocking logind suspending, so I think 
> overall this will just do nothing.
> 
> Why is powerdevil holding an inhibition lock?
> 
> David Edmundson wrote:
> So we can implement auto suspend / key handling based on the user's KDE 
> configs, not based on some global configs.
> 
> Kai Uwe Broulik wrote:
> PowerDevil inhibits the following: 
> ["handle-power-key:handle-suspend-key:handle-hibernate-key:handle-lid-switch",
>  "PowerDevil", "KDE handles power events", "block"]
> Also, "IdleAction" is "ignore" here.
> 
> Martin Gräßlin wrote:
> If I understand that correctly David's concern doesn't hold?
> 
> David Edmundson wrote:
> I still want a question answered.
> 
> Why do we want logind to do it's idle action when we are showing a lock 
> screen when we're managing auto suspend ourselves?
> 
> Martin Gräßlin wrote:
> to properly handle idle in a multi-user setup?

Would that fix https://bugs.kde.org/show_bug.cgi?id=340427 ? But I think 
PowerDevil does some session active tracking magic.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122510/#review75777
---


On Feb. 10, 2015, 1:21 nachm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122510/
> ---
> 
> (Updated Feb. 10, 2015, 1:21 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 271731
> https://bugs.kde.org/show_bug.cgi?id=271731
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> See the idle recommendations on [1]. Binding it to the lock screen does
> not exactly match the recommendation, but it has some advantages:
> * we know it's idle when it's locked
> * it kicks in after the user's configured idle timeout
> * if the user unlocks we know it's no longer idle
> 
> FEATURE: 271731
> FIXED-IN: 5.3.0
> 
> [1] 
> http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 
>   ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 
>   ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 
> 
> Diff: https://git.reviewboard.kde.org/r/122510/diff/
> 
> 
> Testing
> ---
> 
> Run the test application and verified using loginctl from tty1 while the 
> screen was locked and after unlocked.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

2015-02-12 Thread Martin Gräßlin 


> On Feb. 10, 2015, 2:29 p.m., David Edmundson wrote:
> > I'm not convinced this is right.
> > 
> > From the doc you linked: 
> >  This is necessary for the system to implement auto-suspend when all 
> > sessions are idle.
> >  
> > When we lock the screen, powerdevil is still running, no?
> > 
> > Powerdevil has an inhibition blocking logind suspending, so I think overall 
> > this will just do nothing.
> 
> Martin Gräßlin wrote:
> The linked bug report gives another use case: cross-desktop check to see 
> whether the session is idle.
> 
> > Powerdevil has an inhibition blocking logind suspending, so I think 
> overall this will just do nothing.
> 
> Why is powerdevil holding an inhibition lock?
> 
> David Edmundson wrote:
> So we can implement auto suspend / key handling based on the user's KDE 
> configs, not based on some global configs.
> 
> Kai Uwe Broulik wrote:
> PowerDevil inhibits the following: 
> ["handle-power-key:handle-suspend-key:handle-hibernate-key:handle-lid-switch",
>  "PowerDevil", "KDE handles power events", "block"]
> Also, "IdleAction" is "ignore" here.
> 
> Martin Gräßlin wrote:
> If I understand that correctly David's concern doesn't hold?
> 
> David Edmundson wrote:
> I still want a question answered.
> 
> Why do we want logind to do it's idle action when we are showing a lock 
> screen when we're managing auto suspend ourselves?

to properly handle idle in a multi-user setup?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122510/#review75777
---


On Feb. 10, 2015, 2:21 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122510/
> ---
> 
> (Updated Feb. 10, 2015, 2:21 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 271731
> https://bugs.kde.org/show_bug.cgi?id=271731
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> See the idle recommendations on [1]. Binding it to the lock screen does
> not exactly match the recommendation, but it has some advantages:
> * we know it's idle when it's locked
> * it kicks in after the user's configured idle timeout
> * if the user unlocks we know it's no longer idle
> 
> FEATURE: 271731
> FIXED-IN: 5.3.0
> 
> [1] 
> http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 
>   ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 
>   ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 
> 
> Diff: https://git.reviewboard.kde.org/r/122510/diff/
> 
> 
> Testing
> ---
> 
> Run the test application and verified using loginctl from tty1 while the 
> screen was locked and after unlocked.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

2015-02-12 Thread David Edmundson 


> On Feb. 10, 2015, 1:29 p.m., David Edmundson wrote:
> > I'm not convinced this is right.
> > 
> > From the doc you linked: 
> >  This is necessary for the system to implement auto-suspend when all 
> > sessions are idle.
> >  
> > When we lock the screen, powerdevil is still running, no?
> > 
> > Powerdevil has an inhibition blocking logind suspending, so I think overall 
> > this will just do nothing.
> 
> Martin Gräßlin wrote:
> The linked bug report gives another use case: cross-desktop check to see 
> whether the session is idle.
> 
> > Powerdevil has an inhibition blocking logind suspending, so I think 
> overall this will just do nothing.
> 
> Why is powerdevil holding an inhibition lock?
> 
> David Edmundson wrote:
> So we can implement auto suspend / key handling based on the user's KDE 
> configs, not based on some global configs.
> 
> Kai Uwe Broulik wrote:
> PowerDevil inhibits the following: 
> ["handle-power-key:handle-suspend-key:handle-hibernate-key:handle-lid-switch",
>  "PowerDevil", "KDE handles power events", "block"]
> Also, "IdleAction" is "ignore" here.
> 
> Martin Gräßlin wrote:
> If I understand that correctly David's concern doesn't hold?

I still want a question answered.

Why do we want logind to do it's idle action when we are showing a lock screen 
when we're managing auto suspend ourselves?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122510/#review75777
---


On Feb. 10, 2015, 1:21 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122510/
> ---
> 
> (Updated Feb. 10, 2015, 1:21 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 271731
> https://bugs.kde.org/show_bug.cgi?id=271731
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> See the idle recommendations on [1]. Binding it to the lock screen does
> not exactly match the recommendation, but it has some advantages:
> * we know it's idle when it's locked
> * it kicks in after the user's configured idle timeout
> * if the user unlocks we know it's no longer idle
> 
> FEATURE: 271731
> FIXED-IN: 5.3.0
> 
> [1] 
> http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 
>   ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 
>   ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 
> 
> Diff: https://git.reviewboard.kde.org/r/122510/diff/
> 
> 
> Testing
> ---
> 
> Run the test application and verified using loginctl from tty1 while the 
> screen was locked and after unlocked.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

2015-02-11 Thread Martin Gräßlin 


> On Feb. 10, 2015, 2:29 p.m., David Edmundson wrote:
> > I'm not convinced this is right.
> > 
> > From the doc you linked: 
> >  This is necessary for the system to implement auto-suspend when all 
> > sessions are idle.
> >  
> > When we lock the screen, powerdevil is still running, no?
> > 
> > Powerdevil has an inhibition blocking logind suspending, so I think overall 
> > this will just do nothing.
> 
> Martin Gräßlin wrote:
> The linked bug report gives another use case: cross-desktop check to see 
> whether the session is idle.
> 
> > Powerdevil has an inhibition blocking logind suspending, so I think 
> overall this will just do nothing.
> 
> Why is powerdevil holding an inhibition lock?
> 
> David Edmundson wrote:
> So we can implement auto suspend / key handling based on the user's KDE 
> configs, not based on some global configs.
> 
> Kai Uwe Broulik wrote:
> PowerDevil inhibits the following: 
> ["handle-power-key:handle-suspend-key:handle-hibernate-key:handle-lid-switch",
>  "PowerDevil", "KDE handles power events", "block"]
> Also, "IdleAction" is "ignore" here.

If I understand that correctly David's concern doesn't hold?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122510/#review75777
---


On Feb. 10, 2015, 2:21 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122510/
> ---
> 
> (Updated Feb. 10, 2015, 2:21 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 271731
> https://bugs.kde.org/show_bug.cgi?id=271731
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> See the idle recommendations on [1]. Binding it to the lock screen does
> not exactly match the recommendation, but it has some advantages:
> * we know it's idle when it's locked
> * it kicks in after the user's configured idle timeout
> * if the user unlocks we know it's no longer idle
> 
> FEATURE: 271731
> FIXED-IN: 5.3.0
> 
> [1] 
> http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 
>   ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 
>   ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 
> 
> Diff: https://git.reviewboard.kde.org/r/122510/diff/
> 
> 
> Testing
> ---
> 
> Run the test application and verified using loginctl from tty1 while the 
> screen was locked and after unlocked.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

2015-02-11 Thread Kai Uwe Broulik 


> On Feb. 10, 2015, 1:29 nachm., David Edmundson wrote:
> > I'm not convinced this is right.
> > 
> > From the doc you linked: 
> >  This is necessary for the system to implement auto-suspend when all 
> > sessions are idle.
> >  
> > When we lock the screen, powerdevil is still running, no?
> > 
> > Powerdevil has an inhibition blocking logind suspending, so I think overall 
> > this will just do nothing.
> 
> Martin Gräßlin wrote:
> The linked bug report gives another use case: cross-desktop check to see 
> whether the session is idle.
> 
> > Powerdevil has an inhibition blocking logind suspending, so I think 
> overall this will just do nothing.
> 
> Why is powerdevil holding an inhibition lock?
> 
> David Edmundson wrote:
> So we can implement auto suspend / key handling based on the user's KDE 
> configs, not based on some global configs.

PowerDevil inhibits the following: 
["handle-power-key:handle-suspend-key:handle-hibernate-key:handle-lid-switch", 
"PowerDevil", "KDE handles power events", "block"]
Also, "IdleAction" is "ignore" here.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122510/#review75777
---


On Feb. 10, 2015, 1:21 nachm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122510/
> ---
> 
> (Updated Feb. 10, 2015, 1:21 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 271731
> https://bugs.kde.org/show_bug.cgi?id=271731
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> See the idle recommendations on [1]. Binding it to the lock screen does
> not exactly match the recommendation, but it has some advantages:
> * we know it's idle when it's locked
> * it kicks in after the user's configured idle timeout
> * if the user unlocks we know it's no longer idle
> 
> FEATURE: 271731
> FIXED-IN: 5.3.0
> 
> [1] 
> http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 
>   ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 
>   ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 
> 
> Diff: https://git.reviewboard.kde.org/r/122510/diff/
> 
> 
> Testing
> ---
> 
> Run the test application and verified using loginctl from tty1 while the 
> screen was locked and after unlocked.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

2015-02-10 Thread David Edmundson 


> On Feb. 10, 2015, 1:29 p.m., David Edmundson wrote:
> > I'm not convinced this is right.
> > 
> > From the doc you linked: 
> >  This is necessary for the system to implement auto-suspend when all 
> > sessions are idle.
> >  
> > When we lock the screen, powerdevil is still running, no?
> > 
> > Powerdevil has an inhibition blocking logind suspending, so I think overall 
> > this will just do nothing.
> 
> Martin Gräßlin wrote:
> The linked bug report gives another use case: cross-desktop check to see 
> whether the session is idle.
> 
> > Powerdevil has an inhibition blocking logind suspending, so I think 
> overall this will just do nothing.
> 
> Why is powerdevil holding an inhibition lock?

So we can implement auto suspend / key handling based on the user's KDE 
configs, not based on some global configs.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122510/#review75777
---


On Feb. 10, 2015, 1:21 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122510/
> ---
> 
> (Updated Feb. 10, 2015, 1:21 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 271731
> https://bugs.kde.org/show_bug.cgi?id=271731
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> See the idle recommendations on [1]. Binding it to the lock screen does
> not exactly match the recommendation, but it has some advantages:
> * we know it's idle when it's locked
> * it kicks in after the user's configured idle timeout
> * if the user unlocks we know it's no longer idle
> 
> FEATURE: 271731
> FIXED-IN: 5.3.0
> 
> [1] 
> http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 
>   ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 
>   ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 
> 
> Diff: https://git.reviewboard.kde.org/r/122510/diff/
> 
> 
> Testing
> ---
> 
> Run the test application and verified using loginctl from tty1 while the 
> screen was locked and after unlocked.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

2015-02-10 Thread Martin Gräßlin 


> On Feb. 10, 2015, 2:29 p.m., David Edmundson wrote:
> > I'm not convinced this is right.
> > 
> > From the doc you linked: 
> >  This is necessary for the system to implement auto-suspend when all 
> > sessions are idle.
> >  
> > When we lock the screen, powerdevil is still running, no?
> > 
> > Powerdevil has an inhibition blocking logind suspending, so I think overall 
> > this will just do nothing.

The linked bug report gives another use case: cross-desktop check to see 
whether the session is idle.

> Powerdevil has an inhibition blocking logind suspending, so I think overall 
> this will just do nothing.

Why is powerdevil holding an inhibition lock?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122510/#review75777
---


On Feb. 10, 2015, 2:21 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122510/
> ---
> 
> (Updated Feb. 10, 2015, 2:21 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 271731
> https://bugs.kde.org/show_bug.cgi?id=271731
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> See the idle recommendations on [1]. Binding it to the lock screen does
> not exactly match the recommendation, but it has some advantages:
> * we know it's idle when it's locked
> * it kicks in after the user's configured idle timeout
> * if the user unlocks we know it's no longer idle
> 
> FEATURE: 271731
> FIXED-IN: 5.3.0
> 
> [1] 
> http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 
>   ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 
>   ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 
> 
> Diff: https://git.reviewboard.kde.org/r/122510/diff/
> 
> 
> Testing
> ---
> 
> Run the test application and verified using loginctl from tty1 while the 
> screen was locked and after unlocked.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

2015-02-10 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122510/#review75777
---


I'm not convinced this is right.

>From the doc you linked: 
 This is necessary for the system to implement auto-suspend when all sessions 
are idle.
 
When we lock the screen, powerdevil is still running, no?

Powerdevil has an inhibition blocking logind suspending, so I think overall 
this will just do nothing.

- David Edmundson


On Feb. 10, 2015, 1:21 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122510/
> ---
> 
> (Updated Feb. 10, 2015, 1:21 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 271731
> https://bugs.kde.org/show_bug.cgi?id=271731
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> See the idle recommendations on [1]. Binding it to the lock screen does
> not exactly match the recommendation, but it has some advantages:
> * we know it's idle when it's locked
> * it kicks in after the user's configured idle timeout
> * if the user unlocks we know it's no longer idle
> 
> FEATURE: 271731
> FIXED-IN: 5.3.0
> 
> [1] 
> http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 
>   ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 
>   ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 
> 
> Diff: https://git.reviewboard.kde.org/r/122510/diff/
> 
> 
> Testing
> ---
> 
> Run the test application and verified using loginctl from tty1 while the 
> screen was locked and after unlocked.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

2015-02-10 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122510/
---

(Updated Feb. 10, 2015, 2:21 p.m.)


Review request for Plasma.


Changes
---

simplify


Bugs: 271731
https://bugs.kde.org/show_bug.cgi?id=271731


Repository: plasma-workspace


Description
---

See the idle recommendations on [1]. Binding it to the lock screen does
not exactly match the recommendation, but it has some advantages:
* we know it's idle when it's locked
* it kicks in after the user's configured idle timeout
* if the user unlocks we know it's no longer idle

FEATURE: 271731
FIXED-IN: 5.3.0

[1] 
http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/


Diffs (updated)
-

  ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 
  ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 
  ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 

Diff: https://git.reviewboard.kde.org/r/122510/diff/


Testing
---

Run the test application and verified using loginctl from tty1 while the screen 
was locked and after unlocked.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

2015-02-10 Thread Lukáš Tinkl 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122510/#review75776
---



ksmserver/screenlocker/logind.cpp


Just FYI, an easier way to do this is:

msg << idle;


- Lukáš Tinkl


On Úno. 10, 2015, 1:34 odp., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122510/
> ---
> 
> (Updated Úno. 10, 2015, 1:34 odp.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 271731
> https://bugs.kde.org/show_bug.cgi?id=271731
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> See the idle recommendations on [1]. Binding it to the lock screen does
> not exactly match the recommendation, but it has some advantages:
> * we know it's idle when it's locked
> * it kicks in after the user's configured idle timeout
> * if the user unlocks we know it's no longer idle
> 
> FEATURE: 271731
> FIXED-IN: 5.3.0
> 
> [1] 
> http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 
>   ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 
>   ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 
> 
> Diff: https://git.reviewboard.kde.org/r/122510/diff/
> 
> 
> Testing
> ---
> 
> Run the test application and verified using loginctl from tty1 while the 
> screen was locked and after unlocked.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

2015-02-10 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122510/
---

Review request for Plasma.


Bugs: 271731
https://bugs.kde.org/show_bug.cgi?id=271731


Repository: plasma-workspace


Description
---

See the idle recommendations on [1]. Binding it to the lock screen does
not exactly match the recommendation, but it has some advantages:
* we know it's idle when it's locked
* it kicks in after the user's configured idle timeout
* if the user unlocks we know it's no longer idle

FEATURE: 271731
FIXED-IN: 5.3.0

[1] 
http://www.freedesktop.org/wiki/Software/systemd/writing-desktop-environments/


Diffs
-

  ksmserver/screenlocker/logind.cpp 5335b150bce8f38aee75ad30055bc0e248ed1bf1 
  ksmserver/screenlocker/ksldapp.cpp e23b50fbcaac659bb6ef1b36a4de6efc63573978 
  ksmserver/screenlocker/logind.h 99836734923740a1f0b23144f9effd815f104b74 

Diff: https://git.reviewboard.kde.org/r/122510/diff/


Testing
---

Run the test application and verified using loginctl from tty1 while the screen 
was locked and after unlocked.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel