Review Request 122592: Align digital clock to full minutes

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/
---

Review request for Plasma and Martin Klapetek.


Bugs: 343872
https://bugs.kde.org/show_bug.cgi?id=343872


Repository: plasma-workspace


Description
---

This aligns the digital clock to full minutes so it's no longer off by up to 30 
seconds, and it allows us to increase the polling interval to 60s.


Diffs
-

  applets/digital-clock/package/contents/ui/main.qml 4cc83e8 

Diff: https://git.reviewboard.kde.org/r/122592/diff/


Testing
---

Compared with xclock, plasmoid is now within 1/2 seconds of the full minute

This patch would require us to bump the plasma-framework dependency to 5.8


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/#review76128
---


Does this still work as intended even when seconds are shown?

- Lukáš Tinkl


On Úno. 16, 2015, 3:24 odp., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122592/
> ---
> 
> (Updated Úno. 16, 2015, 3:24 odp.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 343872
> https://bugs.kde.org/show_bug.cgi?id=343872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This aligns the digital clock to full minutes so it's no longer off by up to 
> 30 seconds, and it allows us to increase the polling interval to 60s.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/main.qml 4cc83e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122592/diff/
> 
> 
> Testing
> ---
> 
> Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
> 
> This patch would require us to bump the plasma-framework dependency to 5.8
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/#review76131
---


All I'm getting with this patch is "Error loading QML file: 
file:///opt/kde5/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/main.qml:57:9:
 Cannot assign to non-existent property "intervalAlignment" "

And I've just rebuilt things. Am I missing anything else?

- Martin Klapetek


On Feb. 16, 2015, 3:24 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122592/
> ---
> 
> (Updated Feb. 16, 2015, 3:24 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 343872
> https://bugs.kde.org/show_bug.cgi?id=343872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This aligns the digital clock to full minutes so it's no longer off by up to 
> 30 seconds, and it allows us to increase the polling interval to 60s.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/main.qml 4cc83e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122592/diff/
> 
> 
> Testing
> ---
> 
> Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
> 
> This patch would require us to bump the plasma-framework dependency to 5.8
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Bhushan Shah]

> On Feb. 16, 2015, 8:36 p.m., Martin Klapetek wrote:
> > All I'm getting with this patch is "Error loading QML file: 
> > file:///opt/kde5/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/main.qml:57:9:
> >  Cannot assign to non-existent property "intervalAlignment" "
> > 
> > And I've just rebuilt things. Am I missing anything else?

plasma-framework?


- Bhushan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/#review76131
---


On Feb. 16, 2015, 7:54 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122592/
> ---
> 
> (Updated Feb. 16, 2015, 7:54 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 343872
> https://bugs.kde.org/show_bug.cgi?id=343872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This aligns the digital clock to full minutes so it's no longer off by up to 
> 30 seconds, and it allows us to increase the polling interval to 60s.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/main.qml 4cc83e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122592/diff/
> 
> 
> Testing
> ---
> 
> Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
> 
> This patch would require us to bump the plasma-framework dependency to 5.8
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Martin Klapetek]

> On Feb. 16, 2015, 4:06 p.m., Martin Klapetek wrote:
> > All I'm getting with this patch is "Error loading QML file: 
> > file:///opt/kde5/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/main.qml:57:9:
> >  Cannot assign to non-existent property "intervalAlignment" "
> > 
> > And I've just rebuilt things. Am I missing anything else?
> 
> Bhushan Shah wrote:
> plasma-framework?

"I've just rebuilt things" included plasma-framework too. But apparently I've 
rebuilt about 20 minutes before that patch was pushed (I believed it's already 
in for days) -.-

Nevertheless, with showSeconds the seconds now won't update at all ^_^


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/#review76131
---


On Feb. 16, 2015, 3:24 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122592/
> ---
> 
> (Updated Feb. 16, 2015, 3:24 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 343872
> https://bugs.kde.org/show_bug.cgi?id=343872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This aligns the digital clock to full minutes so it's no longer off by up to 
> 30 seconds, and it allows us to increase the polling interval to 60s.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/main.qml 4cc83e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122592/diff/
> 
> 
> Testing
> ---
> 
> Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
> 
> This patch would require us to bump the plasma-framework dependency to 5.8
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/#review76138
---



applets/digital-clock/package/contents/ui/main.qml


perhaps should be noalignment when showing seconds? (however is very weird 
that it's not working when the interval is a secons?)


- Marco Martin


On Feb. 16, 2015, 2:24 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122592/
> ---
> 
> (Updated Feb. 16, 2015, 2:24 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 343872
> https://bugs.kde.org/show_bug.cgi?id=343872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This aligns the digital clock to full minutes so it's no longer off by up to 
> 30 seconds, and it allows us to increase the polling interval to 60s.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/main.qml 4cc83e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122592/diff/
> 
> 
> Testing
> ---
> 
> Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
> 
> This patch would require us to bump the plasma-framework dependency to 5.8
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Kai Uwe Broulik]

> On Feb. 16, 2015, 3:53 nachm., Marco Martin wrote:
> > applets/digital-clock/package/contents/ui/main.qml, line 57
> > 
> >
> > perhaps should be noalignment when showing seconds? (however is very 
> > weird that it's not working when the interval is a secons?)

That it doesn't work with seconds is understandable since it aligns it to 
minutes always.
On the other hand it doesn't work when I change it at runtime since the 
datasource says "already connected to a relay of the same interval"


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/#review76138
---


On Feb. 16, 2015, 2:24 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122592/
> ---
> 
> (Updated Feb. 16, 2015, 2:24 nachm.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 343872
> https://bugs.kde.org/show_bug.cgi?id=343872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This aligns the digital clock to full minutes so it's no longer off by up to 
> 30 seconds, and it allows us to increase the polling interval to 60s.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/main.qml 4cc83e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122592/diff/
> 
> 
> Testing
> ---
> 
> Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
> 
> This patch would require us to bump the plasma-framework dependency to 5.8
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/
---

(Updated Feb. 16, 2015, 4:04 nachm.)


Review request for Plasma and Martin Klapetek.


Changes
---

Don't align when seconds are shown

It doesn't catch it up at runtime though


Bugs: 343872
https://bugs.kde.org/show_bug.cgi?id=343872


Repository: plasma-workspace


Description
---

This aligns the digital clock to full minutes so it's no longer off by up to 30 
seconds, and it allows us to increase the polling interval to 60s.


Diffs (updated)
-

  applets/digital-clock/package/contents/ui/main.qml 4cc83e8 

Diff: https://git.reviewboard.kde.org/r/122592/diff/


Testing
---

Compared with xclock, plasmoid is now within 1/2 seconds of the full minute

This patch would require us to bump the plasma-framework dependency to 5.8


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Marco Martin]

> On Feb. 16, 2015, 3:53 p.m., Marco Martin wrote:
> > applets/digital-clock/package/contents/ui/main.qml, line 57
> > 
> >
> > perhaps should be noalignment when showing seconds? (however is very 
> > weird that it's not working when the interval is a secons?)
> 
> Kai Uwe Broulik wrote:
> That it doesn't work with seconds is understandable since it aligns it to 
> minutes always.
> On the other hand it doesn't work when I change it at runtime since the 
> datasource says "already connected to a relay of the same interval"

that could use a little change in datasource (libplasma side), making it 
distinguish not only by time interval but also alignment.
Or, it can just be made to disconnect then reconnect when changing alignment 
(qml binding side)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/#review76138
---


On Feb. 16, 2015, 4:04 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122592/
> ---
> 
> (Updated Feb. 16, 2015, 4:04 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 343872
> https://bugs.kde.org/show_bug.cgi?id=343872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This aligns the digital clock to full minutes so it's no longer off by up to 
> 30 seconds, and it allows us to increase the polling interval to 60s.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/main.qml 4cc83e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122592/diff/
> 
> 
> Testing
> ---
> 
> Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
> 
> This patch would require us to bump the plasma-framework dependency to 5.8
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/#review76143
---

Ship it!


Ship It!

- Marco Martin


On Feb. 16, 2015, 4:04 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122592/
> ---
> 
> (Updated Feb. 16, 2015, 4:04 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 343872
> https://bugs.kde.org/show_bug.cgi?id=343872
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This aligns the digital clock to full minutes so it's no longer off by up to 
> 30 seconds, and it allows us to increase the polling interval to 60s.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/main.qml 4cc83e8 
> 
> Diff: https://git.reviewboard.kde.org/r/122592/diff/
> 
> 
> Testing
> ---
> 
> Compared with xclock, plasmoid is now within 1/2 seconds of the full minute
> 
> This patch would require us to bump the plasma-framework dependency to 5.8
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122592: Align digital clock to full minutes

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122592/
---

(Updated Feb. 16, 2015, 5:48 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Martin Klapetek.


Bugs: 343872
https://bugs.kde.org/show_bug.cgi?id=343872


Repository: plasma-workspace


Description
---

This aligns the digital clock to full minutes so it's no longer off by up to 30 
seconds, and it allows us to increase the polling interval to 60s.


Diffs
-

  applets/digital-clock/package/contents/ui/main.qml 4cc83e8 

Diff: https://git.reviewboard.kde.org/r/122592/diff/


Testing
---

Compared with xclock, plasmoid is now within 1/2 seconds of the full minute

This patch would require us to bump the plasma-framework dependency to 5.8


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel