Re: Review Request 122602: Get rid of brightness percentage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122602/ --- (Updated Feb. 17, 2015, 1:35 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Solid and Nikita Skovoroda. Repository: powerdevil Description --- This renames all the fooValue things to just foo, everywhere. Set brightness no longer returns bool since we don't really check success anymore anyway. Also adds a bit of C++11 sugar. Diffs - daemon/actions/bundled/brightnesscontrol.h a802174 daemon/actions/bundled/brightnesscontrol.cpp 84d4f66 daemon/actions/bundled/dimdisplay.h b4b0517 daemon/actions/bundled/dimdisplay.cpp ae578a8 daemon/actions/bundled/keyboardbrightnesscontrol.h cbbbc85 daemon/actions/bundled/keyboardbrightnesscontrol.cpp ee7449c daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.BrightnessControl.xml 63f96f4 daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.KeyboardBrightnessControl.xml 777df2f daemon/actions/dpms/powerdevildpmsaction.h c74b45b daemon/actions/dpms/powerdevildpmsaction.cpp 42ff8f1 daemon/backends/hal/powerdevilhalbackend.h b34b893 daemon/backends/hal/powerdevilhalbackend.cpp 8904f52 daemon/backends/upower/backlighthelper.h cb53ec9 daemon/backends/upower/backlighthelper.cpp bf630fa daemon/backends/upower/powerdevilupowerbackend.h 9c6c38f daemon/backends/upower/powerdevilupowerbackend.cpp ff99137 daemon/backends/upower/xrandrbrightness.h d3a78b1 daemon/backends/upower/xrandrbrightness.cpp 493483b daemon/powerdevilbackendinterface.h f5bc652 daemon/powerdevilbackendinterface.cpp 37d56f4 daemon/powerdevilbrightnesslogic.h 90b42b5 daemon/powerdevilbrightnesslogic.cpp 25c5de0 daemon/backends/upower/backlight_helper_actions.actions 14b714f Diff: https://git.reviewboard.kde.org/r/122602/diff/ Testing --- Seems to work as before but needs more extensive testing Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122602: Get rid of brightness percentage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122602/#review76180 --- Ship it! daemon/powerdevilbrightnesslogic.cpp https://git.reviewboard.kde.org/r/122602/#comment52535 Seems to be unused now (only the one that has no arguments). Could be safely removed. - Nikita Skovoroda On Фев. 17, 2015, 1:35 п.п., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122602/ --- (Updated Фев. 17, 2015, 1:35 п.п.) Review request for Plasma, Solid and Nikita Skovoroda. Repository: powerdevil Description --- This renames all the fooValue things to just foo, everywhere. Set brightness no longer returns bool since we don't really check success anymore anyway. Also adds a bit of C++11 sugar. Diffs - daemon/actions/bundled/brightnesscontrol.h a802174 daemon/actions/bundled/brightnesscontrol.cpp 84d4f66 daemon/actions/bundled/dimdisplay.h b4b0517 daemon/actions/bundled/dimdisplay.cpp ae578a8 daemon/actions/bundled/keyboardbrightnesscontrol.h cbbbc85 daemon/actions/bundled/keyboardbrightnesscontrol.cpp ee7449c daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.BrightnessControl.xml 63f96f4 daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.KeyboardBrightnessControl.xml 777df2f daemon/actions/dpms/powerdevildpmsaction.h c74b45b daemon/actions/dpms/powerdevildpmsaction.cpp 42ff8f1 daemon/backends/hal/powerdevilhalbackend.h b34b893 daemon/backends/hal/powerdevilhalbackend.cpp 8904f52 daemon/backends/upower/backlighthelper.h cb53ec9 daemon/backends/upower/backlighthelper.cpp bf630fa daemon/backends/upower/powerdevilupowerbackend.h 9c6c38f daemon/backends/upower/powerdevilupowerbackend.cpp ff99137 daemon/backends/upower/xrandrbrightness.h d3a78b1 daemon/backends/upower/xrandrbrightness.cpp 493483b daemon/powerdevilbackendinterface.h f5bc652 daemon/powerdevilbackendinterface.cpp 37d56f4 daemon/powerdevilbrightnesslogic.h 90b42b5 daemon/powerdevilbrightnesslogic.cpp 25c5de0 daemon/backends/upower/backlight_helper_actions.actions 14b714f Diff: https://git.reviewboard.kde.org/r/122602/diff/ Testing --- Seems to work as before but needs more extensive testing Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122602: Get rid of brightness percentage
On Фев. 17, 2015, 1:37 п.п., Nikita Skovoroda wrote: daemon/powerdevilbrightnesslogic.cpp, line 117 https://git.reviewboard.kde.org/r/122602/diff/1/?file=350053#file350053line117 Seems to be unused now (only the one that has no arguments). Could be safely removed. It is actually used from the inside of that class, but is unnecessary, the inner call to `percentage()` could be replaced with `percentage(m_value)`. - Nikita --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122602/#review76180 --- On Фев. 17, 2015, 1:35 п.п., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122602/ --- (Updated Фев. 17, 2015, 1:35 п.п.) Review request for Plasma, Solid and Nikita Skovoroda. Repository: powerdevil Description --- This renames all the fooValue things to just foo, everywhere. Set brightness no longer returns bool since we don't really check success anymore anyway. Also adds a bit of C++11 sugar. Diffs - daemon/actions/bundled/brightnesscontrol.h a802174 daemon/actions/bundled/brightnesscontrol.cpp 84d4f66 daemon/actions/bundled/dimdisplay.h b4b0517 daemon/actions/bundled/dimdisplay.cpp ae578a8 daemon/actions/bundled/keyboardbrightnesscontrol.h cbbbc85 daemon/actions/bundled/keyboardbrightnesscontrol.cpp ee7449c daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.BrightnessControl.xml 63f96f4 daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.KeyboardBrightnessControl.xml 777df2f daemon/actions/dpms/powerdevildpmsaction.h c74b45b daemon/actions/dpms/powerdevildpmsaction.cpp 42ff8f1 daemon/backends/hal/powerdevilhalbackend.h b34b893 daemon/backends/hal/powerdevilhalbackend.cpp 8904f52 daemon/backends/upower/backlighthelper.h cb53ec9 daemon/backends/upower/backlighthelper.cpp bf630fa daemon/backends/upower/powerdevilupowerbackend.h 9c6c38f daemon/backends/upower/powerdevilupowerbackend.cpp ff99137 daemon/backends/upower/xrandrbrightness.h d3a78b1 daemon/backends/upower/xrandrbrightness.cpp 493483b daemon/powerdevilbackendinterface.h f5bc652 daemon/powerdevilbackendinterface.cpp 37d56f4 daemon/powerdevilbrightnesslogic.h 90b42b5 daemon/powerdevilbrightnesslogic.cpp 25c5de0 daemon/backends/upower/backlight_helper_actions.actions 14b714f Diff: https://git.reviewboard.kde.org/r/122602/diff/ Testing --- Seems to work as before but needs more extensive testing Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122602: Get rid of brightness percentage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122602/ --- Review request for Plasma, Solid and Nikita Skovoroda. Repository: powerdevil Description --- This renames all the fooValue things to just foo, everywhere. Set brightness no longer returns bool since we don't really check success anymore anyway. Also adds a bit of C++11 sugar. Diffs - daemon/actions/bundled/brightnesscontrol.h a802174 daemon/actions/bundled/brightnesscontrol.cpp 84d4f66 daemon/actions/bundled/dimdisplay.h b4b0517 daemon/actions/bundled/dimdisplay.cpp ae578a8 daemon/actions/bundled/keyboardbrightnesscontrol.h cbbbc85 daemon/actions/bundled/keyboardbrightnesscontrol.cpp ee7449c daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.BrightnessControl.xml 63f96f4 daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.KeyboardBrightnessControl.xml 777df2f daemon/actions/dpms/powerdevildpmsaction.h c74b45b daemon/actions/dpms/powerdevildpmsaction.cpp 42ff8f1 daemon/backends/hal/powerdevilhalbackend.h b34b893 daemon/backends/hal/powerdevilhalbackend.cpp 8904f52 daemon/backends/upower/backlighthelper.h cb53ec9 daemon/backends/upower/backlighthelper.cpp bf630fa daemon/backends/upower/powerdevilupowerbackend.h 9c6c38f daemon/backends/upower/powerdevilupowerbackend.cpp ff99137 daemon/backends/upower/xrandrbrightness.h d3a78b1 daemon/backends/upower/xrandrbrightness.cpp 493483b daemon/powerdevilbackendinterface.h f5bc652 daemon/powerdevilbackendinterface.cpp 37d56f4 daemon/powerdevilbrightnesslogic.h 90b42b5 daemon/powerdevilbrightnesslogic.cpp 25c5de0 daemon/backends/upower/backlight_helper_actions.actions 14b714f Diff: https://git.reviewboard.kde.org/r/122602/diff/ Testing --- Seems to work as before but needs more extensive testing Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122602: Get rid of brightness percentage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122602/#review76178 --- Ship it! Ship It! - Lukáš Tinkl On Úno. 17, 2015, 1:06 odp., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122602/ --- (Updated Úno. 17, 2015, 1:06 odp.) Review request for Plasma, Solid and Nikita Skovoroda. Repository: powerdevil Description --- This renames all the fooValue things to just foo, everywhere. Set brightness no longer returns bool since we don't really check success anymore anyway. Also adds a bit of C++11 sugar. Diffs - daemon/actions/bundled/brightnesscontrol.h a802174 daemon/actions/bundled/brightnesscontrol.cpp 84d4f66 daemon/actions/bundled/dimdisplay.h b4b0517 daemon/actions/bundled/dimdisplay.cpp ae578a8 daemon/actions/bundled/keyboardbrightnesscontrol.h cbbbc85 daemon/actions/bundled/keyboardbrightnesscontrol.cpp ee7449c daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.BrightnessControl.xml 63f96f4 daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.KeyboardBrightnessControl.xml 777df2f daemon/actions/dpms/powerdevildpmsaction.h c74b45b daemon/actions/dpms/powerdevildpmsaction.cpp 42ff8f1 daemon/backends/hal/powerdevilhalbackend.h b34b893 daemon/backends/hal/powerdevilhalbackend.cpp 8904f52 daemon/backends/upower/backlighthelper.h cb53ec9 daemon/backends/upower/backlighthelper.cpp bf630fa daemon/backends/upower/powerdevilupowerbackend.h 9c6c38f daemon/backends/upower/powerdevilupowerbackend.cpp ff99137 daemon/backends/upower/xrandrbrightness.h d3a78b1 daemon/backends/upower/xrandrbrightness.cpp 493483b daemon/powerdevilbackendinterface.h f5bc652 daemon/powerdevilbackendinterface.cpp 37d56f4 daemon/powerdevilbrightnesslogic.h 90b42b5 daemon/powerdevilbrightnesslogic.cpp 25c5de0 daemon/backends/upower/backlight_helper_actions.actions 14b714f Diff: https://git.reviewboard.kde.org/r/122602/diff/ Testing --- Seems to work as before but needs more extensive testing Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
