Re: Review Request 122622: Don't show Unknown as author in wallpaper tooltip
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122622/#review76221 --- Ship it! Ship It! - Eike Hein On Feb. 18, 2015, 11:25 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122622/ --- (Updated Feb. 18, 2015, 11:25 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- If there are no metadata, showing by Unknown is a bit strange and serves not much purpose. So let it show only the filename when no metadata available. Diffs - wallpapers/image/backgroundlistmodel.cpp 346bc8f wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml b183653 Diff: https://git.reviewboard.kde.org/r/122622/diff/ Testing --- Images both with and without metadata works show tooltip as intended. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122622: Don't show Unknown as author in wallpaper tooltip
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122622/ --- Review request for Plasma. Repository: plasma-workspace Description --- If there are no metadata, showing by Unknown is a bit strange and serves not much purpose. So let it show only the filename when no metadata available. Diffs - wallpapers/image/backgroundlistmodel.cpp 346bc8f wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml b183653 Diff: https://git.reviewboard.kde.org/r/122622/diff/ Testing --- Images both with and without metadata works show tooltip as intended. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122622: Don't show Unknown as author in wallpaper tooltip
On Feb. 18, 2015, 12:33 p.m., Eike Hein wrote: Ship It! Can i18n strings be removed in stable? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122622/#review76221 --- On Feb. 18, 2015, 12:25 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122622/ --- (Updated Feb. 18, 2015, 12:25 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- If there are no metadata, showing by Unknown is a bit strange and serves not much purpose. So let it show only the filename when no metadata available. Diffs - wallpapers/image/backgroundlistmodel.cpp 346bc8f wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml b183653 Diff: https://git.reviewboard.kde.org/r/122622/diff/ Testing --- Images both with and without metadata works show tooltip as intended. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122622: Don't show Unknown as author in wallpaper tooltip
On Úno. 18, 2015, 12:33 odp., Eike Hein wrote: Ship It! Martin Klapetek wrote: Can i18n strings be removed in stable? Sure, removing is fine, it's like B(I)C rules ;) - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122622/#review76221 --- On Úno. 18, 2015, 12:25 odp., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122622/ --- (Updated Úno. 18, 2015, 12:25 odp.) Review request for Plasma. Repository: plasma-workspace Description --- If there are no metadata, showing by Unknown is a bit strange and serves not much purpose. So let it show only the filename when no metadata available. Diffs - wallpapers/image/backgroundlistmodel.cpp 346bc8f wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml b183653 Diff: https://git.reviewboard.kde.org/r/122622/diff/ Testing --- Images both with and without metadata works show tooltip as intended. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122622: Don't show Unknown as author in wallpaper tooltip
On Feb. 18, 2015, 12:33 p.m., Eike Hein wrote: Ship It! Martin Klapetek wrote: Can i18n strings be removed in stable? Lukáš Tinkl wrote: Sure, removing is fine, it's like B(I)C rules ;) Ah nice, I thought so but just wanted to make double sure, thanks :) - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122622/#review76221 --- On Feb. 18, 2015, 12:25 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122622/ --- (Updated Feb. 18, 2015, 12:25 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- If there are no metadata, showing by Unknown is a bit strange and serves not much purpose. So let it show only the filename when no metadata available. Diffs - wallpapers/image/backgroundlistmodel.cpp 346bc8f wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml b183653 Diff: https://git.reviewboard.kde.org/r/122622/diff/ Testing --- Images both with and without metadata works show tooltip as intended. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122622: Don't show Unknown as author in wallpaper tooltip
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122622/ --- (Updated Feb. 18, 2015, 2:56 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- If there are no metadata, showing by Unknown is a bit strange and serves not much purpose. So let it show only the filename when no metadata available. Diffs - wallpapers/image/backgroundlistmodel.cpp 346bc8f wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml b183653 Diff: https://git.reviewboard.kde.org/r/122622/diff/ Testing --- Images both with and without metadata works show tooltip as intended. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
