Review Request 122894: Add config option for Kickoff icon

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122894/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

This restores the functionality from the 4.x times. The button uses the same 
style used in various places, such as lockscreen and display manager, it has a 
"Choose" action and a, previously missing, convenient "Clear" action.


Diffs
-

  applets/kickoff/package/contents/ui/configGeneral.qml 0b6ec33 

Diff: https://git.reviewboard.kde.org/r/122894/diff/


Testing
---

Choosing an icon works, applying changes the icon, and reset resets it. Is 
there a way to set a config back to its defaults?


File Attachments


Config in action
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/6854d475-e5d1-49a0-b335-19a9028a704c__kickofficondialog.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122894: Add config option for Kickoff icon

[Kai Uwe Broulik]

> On März 10, 2015, 9:23 nachm., Marco Martin wrote:
> > applets/kickoff/package/contents/ui/configGeneral.qml, line 63
> > 
> >
> > this looks a bit hackish, sure is visually really necessary?

In a widget world with the menu attached to the button it stays in its pressed 
state until the menu closes. Since we cannot change the state to pressed from 
the outside, I use the checked property to provide some kind of feedback.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122894/#review77271
---


On März 10, 2015, 8:55 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122894/
> ---
> 
> (Updated März 10, 2015, 8:55 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This restores the functionality from the 4.x times. The button uses the same 
> style used in various places, such as lockscreen and display manager, it has 
> a "Choose" action and a, previously missing, convenient "Clear" action.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/ui/configGeneral.qml 0b6ec33 
> 
> Diff: https://git.reviewboard.kde.org/r/122894/diff/
> 
> 
> Testing
> ---
> 
> Choosing an icon works, applying changes the icon, and reset resets it. Is 
> there a way to set a config back to its defaults?
> 
> 
> File Attachments
> 
> 
> Config in action
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/6854d475-e5d1-49a0-b335-19a9028a704c__kickofficondialog.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122894: Add config option for Kickoff icon

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122894/#review77271
---

Ship it!



applets/kickoff/package/contents/ui/configGeneral.qml


i would find semantically slightly more correct units.smallSpacing*2 
instead of gridUnit/2, but that's not really important, just tastes



applets/kickoff/package/contents/ui/configGeneral.qml


this looks a bit hackish, sure is visually really necessary?


- Marco Martin


On March 10, 2015, 8:55 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122894/
> ---
> 
> (Updated March 10, 2015, 8:55 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This restores the functionality from the 4.x times. The button uses the same 
> style used in various places, such as lockscreen and display manager, it has 
> a "Choose" action and a, previously missing, convenient "Clear" action.
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/ui/configGeneral.qml 0b6ec33 
> 
> Diff: https://git.reviewboard.kde.org/r/122894/diff/
> 
> 
> Testing
> ---
> 
> Choosing an icon works, applying changes the icon, and reset resets it. Is 
> there a way to set a config back to its defaults?
> 
> 
> File Attachments
> 
> 
> Config in action
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/6854d475-e5d1-49a0-b335-19a9028a704c__kickofficondialog.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122894: Add config option for Kickoff icon

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122894/
---

(Updated March 25, 2015, 5:23 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit cc988b74382b8ab49cacb1056c6c7671f0eccc85 by Kai Uwe 
Broulik to branch master.


Repository: plasma-desktop


Description
---

This restores the functionality from the 4.x times. The button uses the same 
style used in various places, such as lockscreen and display manager, it has a 
"Choose" action and a, previously missing, convenient "Clear" action.


Diffs
-

  applets/kickoff/package/contents/ui/configGeneral.qml 0b6ec33 

Diff: https://git.reviewboard.kde.org/r/122894/diff/


Testing
---

Choosing an icon works, applying changes the icon, and reset resets it. Is 
there a way to set a config back to its defaults?


File Attachments


Config in action
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/6854d475-e5d1-49a0-b335-19a9028a704c__kickofficondialog.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel