Re: Review Request 122899: Set directory mimetype for smb protocol
On March 11, 2015, 9:35 a.m., Emmanuel Pescosta wrote: -1 from my side This problem should be fixed by https://git.reviewboard.kde.org/r/121447/, please test it with the latest KIO release. It is certainly better to have this functionality added in KIO core. Discarding this review in favour of review 121447. - Rajeesh --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122899/#review77289 --- On March 10, 2015, 10:18 p.m., Rajeesh K Nambiar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122899/ --- (Updated March 10, 2015, 10:18 p.m.) Review request for Plasma. Repository: kio-extras Description --- Browsing samba shares using Dolphin doesn't show directory icons properly. This is due to missing mimetype in UDSEntry. Set the mimetype inode/directory for directories. Diffs - smb/kio_smb_browse.cpp 67e2fa0 Diff: https://git.reviewboard.kde.org/r/122899/diff/ Testing --- Tested with kio-extras 5.2.1. See attached before and after screenshots of Dolphin. File Attachments samba folder before https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/3ae0a08d-d247-4686-a44b-73b6043cbb57__smb-folder-before.png samba folder after https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/a446c555-e947-42a9-80c0-b5ec18a2ba61__smb-folder-after.png Thanks, Rajeesh K Nambiar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122899: Set directory mimetype for smb protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122899/ --- (Updated March 11, 2015, 10:32 a.m.) Status -- This change has been discarded. Review request for Plasma. Repository: kio-extras Description --- Browsing samba shares using Dolphin doesn't show directory icons properly. This is due to missing mimetype in UDSEntry. Set the mimetype inode/directory for directories. Diffs - smb/kio_smb_browse.cpp 67e2fa0 Diff: https://git.reviewboard.kde.org/r/122899/diff/ Testing --- Tested with kio-extras 5.2.1. See attached before and after screenshots of Dolphin. File Attachments samba folder before https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/3ae0a08d-d247-4686-a44b-73b6043cbb57__smb-folder-before.png samba folder after https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/a446c555-e947-42a9-80c0-b5ec18a2ba61__smb-folder-after.png Thanks, Rajeesh K Nambiar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122899: Set directory mimetype for smb protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122899/#review77289 --- -1 from my side This problem should be fixed by https://git.reviewboard.kde.org/r/121447/, please test it with the latest KIO release. - Emmanuel Pescosta On March 10, 2015, 11:18 p.m., Rajeesh K Nambiar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122899/ --- (Updated March 10, 2015, 11:18 p.m.) Review request for Plasma. Repository: kio-extras Description --- Browsing samba shares using Dolphin doesn't show directory icons properly. This is due to missing mimetype in UDSEntry. Set the mimetype inode/directory for directories. Diffs - smb/kio_smb_browse.cpp 67e2fa0 Diff: https://git.reviewboard.kde.org/r/122899/diff/ Testing --- Tested with kio-extras 5.2.1. See attached before and after screenshots of Dolphin. File Attachments samba folder before https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/3ae0a08d-d247-4686-a44b-73b6043cbb57__smb-folder-before.png samba folder after https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/a446c555-e947-42a9-80c0-b5ec18a2ba61__smb-folder-after.png Thanks, Rajeesh K Nambiar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122899: Set directory mimetype for smb protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122899/#review77284 --- Ship it! smb/kio_smb_browse.cpp https://git.reviewboard.kde.org/r/122899/#comment53075 Correct indentation? - Lukáš Tinkl On Bře. 10, 2015, 11:18 odp., Rajeesh K Nambiar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122899/ --- (Updated Bře. 10, 2015, 11:18 odp.) Review request for Plasma. Repository: kio-extras Description --- Browsing samba shares using Dolphin doesn't show directory icons properly. This is due to missing mimetype in UDSEntry. Set the mimetype inode/directory for directories. Diffs - smb/kio_smb_browse.cpp 67e2fa0 Diff: https://git.reviewboard.kde.org/r/122899/diff/ Testing --- Tested with kio-extras 5.2.1. See attached before and after screenshots of Dolphin. File Attachments samba folder before https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/3ae0a08d-d247-4686-a44b-73b6043cbb57__smb-folder-before.png samba folder after https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/a446c555-e947-42a9-80c0-b5ec18a2ba61__smb-folder-after.png Thanks, Rajeesh K Nambiar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 122899: Set directory mimetype for smb protocol
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122899/ --- Review request for Plasma. Repository: kio-extras Description --- Browsing samba shares using Dolphin doesn't show directory icons properly. This is due to missing mimetype in UDSEntry. Set the mimetype inode/directory for directories. Diffs - smb/kio_smb_browse.cpp 67e2fa0 Diff: https://git.reviewboard.kde.org/r/122899/diff/ Testing --- Tested with kio-extras 5.2.1. See attached before and after screenshots of Dolphin. File Attachments samba folder before https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/3ae0a08d-d247-4686-a44b-73b6043cbb57__smb-folder-before.png samba folder after https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/a446c555-e947-42a9-80c0-b5ec18a2ba61__smb-folder-after.png Thanks, Rajeesh K Nambiar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
