subject:"Review Request 123164\: Add new Bluetooth applet"

Review Request 123164: Add new Bluetooth applet

2015-03-28 Thread David Rosca


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/
---

Review request for Bluedevil and Plasma.


Repository: bluedevil


Description
---

This is a replacement for bluedevil-monolithic.
The code is based on network management plasmoid and it does basically the same 
but for Bluetooth devices.


Diffs
-

  CMakeLists.txt 94b56fb 
  src/CMakeLists.txt b804f2b 
  src/applet/CMakeLists.txt PRE-CREATION 
  src/applet/Messages.sh PRE-CREATION 
  src/applet/package/contents/code/logic.js PRE-CREATION 
  src/applet/package/contents/config/config.qml PRE-CREATION 
  src/applet/package/contents/config/main.xml PRE-CREATION 
  src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
  src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
  src/applet/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
  src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
  src/applet/package/contents/ui/Header.qml PRE-CREATION 
  src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
  src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
  src/applet/package/metadata.desktop PRE-CREATION 
  src/applet/plugin/CMakeLists.txt PRE-CREATION 
  src/applet/plugin/bluetoothplugin.h PRE-CREATION 
  src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
  src/applet/plugin/devicesproxymodel.h PRE-CREATION 
  src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
  src/applet/plugin/launchapp.h PRE-CREATION 
  src/applet/plugin/launchapp.cpp PRE-CREATION 
  src/applet/plugin/notify.h PRE-CREATION 
  src/applet/plugin/notify.cpp PRE-CREATION 
  src/applet/plugin/qmldir PRE-CREATION 
  src/bluedevil.notifyrc 72257ed 

Diff: https://git.reviewboard.kde.org/r/123164/diff/


Testing
---

I've been running it for some time already and it works fine.


File Attachments


snapshot4.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
snapshot5.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78160
---



src/applet/package/contents/ui/CompactRepresentation.qml (line 34)


you should be able to just anchors.fill: parent

and icon item will do the right thing finding the iconsize and centering it.



src/applet/package/contents/ui/Header.qml (line 42)


set left, right anchors and set eliding

otherwise a long name is just going to leak out the box



src/applet/package/contents/ui/SwitchButton.qml (line 1)


is this a direct copy from nm-qt?

Maybe we could put it in plasmaextras?



src/applet/package/contents/ui/SwitchButton.qml (line 42)


units.smallSpacing



src/applet/package/contents/ui/SwitchButton.qml (line 46)


bottomMargin, topMargin are both unused in this case



src/applet/package/contents/ui/Toolbar.qml (lines 84 - 87)


Kai/Bhushan there's an existing import that does this right?



src/applet/plugin/devicesproxymodel.cpp (line 70)


micro optimise:

fetch the names after you compare if connected differs


- David Edmundson


On March 28, 2015, 7:43 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> ---
> 
> (Updated March 28, 2015, 7:43 p.m.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the 
> same but for Bluetooth devices.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 94b56fb 
>   src/CMakeLists.txt b804f2b 
>   src/applet/CMakeLists.txt PRE-CREATION 
>   src/applet/Messages.sh PRE-CREATION 
>   src/applet/package/contents/code/logic.js PRE-CREATION 
>   src/applet/package/contents/config/config.qml PRE-CREATION 
>   src/applet/package/contents/config/main.xml PRE-CREATION 
>   src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
>   src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
>   src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/Header.qml PRE-CREATION 
>   src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
>   src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
>   src/applet/package/metadata.desktop PRE-CREATION 
>   src/applet/plugin/CMakeLists.txt PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.h PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.h PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
>   src/applet/plugin/launchapp.h PRE-CREATION 
>   src/applet/plugin/launchapp.cpp PRE-CREATION 
>   src/applet/plugin/notify.h PRE-CREATION 
>   src/applet/plugin/notify.cpp PRE-CREATION 
>   src/applet/plugin/qmldir PRE-CREATION 
>   src/bluedevil.notifyrc 72257ed 
> 
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
> 
> 
> Testing
> ---
> 
> I've been running it for some time already and it works fine.
> 
> 
> File Attachments
> 
> 
> snapshot4.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
> snapshot5.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78164
---


Forgot to add, this looks ridiculously awesome. 
I love the consistency 

- David Edmundson


On March 28, 2015, 7:43 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> ---
> 
> (Updated March 28, 2015, 7:43 p.m.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the 
> same but for Bluetooth devices.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 94b56fb 
>   src/CMakeLists.txt b804f2b 
>   src/applet/CMakeLists.txt PRE-CREATION 
>   src/applet/Messages.sh PRE-CREATION 
>   src/applet/package/contents/code/logic.js PRE-CREATION 
>   src/applet/package/contents/config/config.qml PRE-CREATION 
>   src/applet/package/contents/config/main.xml PRE-CREATION 
>   src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
>   src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
>   src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/Header.qml PRE-CREATION 
>   src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
>   src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
>   src/applet/package/metadata.desktop PRE-CREATION 
>   src/applet/plugin/CMakeLists.txt PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.h PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.h PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
>   src/applet/plugin/launchapp.h PRE-CREATION 
>   src/applet/plugin/launchapp.cpp PRE-CREATION 
>   src/applet/plugin/notify.h PRE-CREATION 
>   src/applet/plugin/notify.cpp PRE-CREATION 
>   src/applet/plugin/qmldir PRE-CREATION 
>   src/bluedevil.notifyrc 72257ed 
> 
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
> 
> 
> Testing
> ---
> 
> I've been running it for some time already and it works fine.
> 
> 
> File Attachments
> 
> 
> snapshot4.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
> snapshot5.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread David Rosca



> On March 29, 2015, 12:13 p.m., David Edmundson wrote:
> > src/applet/package/contents/ui/SwitchButton.qml, line 1
> > 
> >
> > is this a direct copy from nm-qt?
> > 
> > Maybe we could put it in plasmaextras?

No, it is not. There is a little hack with height being the height of checkbox 
(and not icon as in plasma-nm) because I am not using a svg icon and 
PlasmaCore.IconItem seems to be adding too big margins.

Also, there is a small change in behavior that it is possible to click on 
disabled checkbox. This does not seem to be needed in plasma-nm because there 
is an airplane mode button, but it is needed here.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78160
---


On March 28, 2015, 7:43 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> ---
> 
> (Updated March 28, 2015, 7:43 p.m.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the 
> same but for Bluetooth devices.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 94b56fb 
>   src/CMakeLists.txt b804f2b 
>   src/applet/CMakeLists.txt PRE-CREATION 
>   src/applet/Messages.sh PRE-CREATION 
>   src/applet/package/contents/code/logic.js PRE-CREATION 
>   src/applet/package/contents/config/config.qml PRE-CREATION 
>   src/applet/package/contents/config/main.xml PRE-CREATION 
>   src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
>   src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
>   src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/Header.qml PRE-CREATION 
>   src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
>   src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
>   src/applet/package/metadata.desktop PRE-CREATION 
>   src/applet/plugin/CMakeLists.txt PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.h PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.h PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
>   src/applet/plugin/launchapp.h PRE-CREATION 
>   src/applet/plugin/launchapp.cpp PRE-CREATION 
>   src/applet/plugin/notify.h PRE-CREATION 
>   src/applet/plugin/notify.cpp PRE-CREATION 
>   src/applet/plugin/qmldir PRE-CREATION 
>   src/bluedevil.notifyrc 72257ed 
> 
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
> 
> 
> Testing
> ---
> 
> I've been running it for some time already and it works fine.
> 
> 
> File Attachments
> 
> 
> snapshot4.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
> snapshot5.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread David Rosca


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/
---

(Updated March 29, 2015, 2:14 p.m.)


Review request for Bluedevil and Plasma.


Changes
---

Fix mentioned issues


Repository: bluedevil


Description
---

This is a replacement for bluedevil-monolithic.
The code is based on network management plasmoid and it does basically the same 
but for Bluetooth devices.


Diffs (updated)
-

  CMakeLists.txt 94b56fb 
  src/CMakeLists.txt b804f2b 
  src/applet/CMakeLists.txt PRE-CREATION 
  src/applet/Messages.sh PRE-CREATION 
  src/applet/package/contents/code/logic.js PRE-CREATION 
  src/applet/package/contents/config/config.qml PRE-CREATION 
  src/applet/package/contents/config/main.xml PRE-CREATION 
  src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
  src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
  src/applet/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
  src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
  src/applet/package/contents/ui/Header.qml PRE-CREATION 
  src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
  src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
  src/applet/package/metadata.desktop PRE-CREATION 
  src/applet/plugin/CMakeLists.txt PRE-CREATION 
  src/applet/plugin/bluetoothplugin.h PRE-CREATION 
  src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
  src/applet/plugin/devicesproxymodel.h PRE-CREATION 
  src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
  src/applet/plugin/launchapp.h PRE-CREATION 
  src/applet/plugin/launchapp.cpp PRE-CREATION 
  src/applet/plugin/notify.h PRE-CREATION 
  src/applet/plugin/notify.cpp PRE-CREATION 
  src/applet/plugin/qmldir PRE-CREATION 
  src/bluedevil.notifyrc 72257ed 

Diff: https://git.reviewboard.kde.org/r/123164/diff/


Testing
---

I've been running it for some time already and it works fine.


File Attachments


snapshot4.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
snapshot5.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread David Rosca



> On March 29, 2015, 12:13 p.m., David Edmundson wrote:
> > src/applet/package/contents/ui/Toolbar.qml, lines 84-87
> > 
> >
> > Kai/Bhushan there's an existing import that does this right?

Yup, changed to use KCMShell.open


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78160
---


On March 29, 2015, 2:14 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> ---
> 
> (Updated March 29, 2015, 2:14 p.m.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the 
> same but for Bluetooth devices.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 94b56fb 
>   src/CMakeLists.txt b804f2b 
>   src/applet/CMakeLists.txt PRE-CREATION 
>   src/applet/Messages.sh PRE-CREATION 
>   src/applet/package/contents/code/logic.js PRE-CREATION 
>   src/applet/package/contents/config/config.qml PRE-CREATION 
>   src/applet/package/contents/config/main.xml PRE-CREATION 
>   src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
>   src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
>   src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/Header.qml PRE-CREATION 
>   src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
>   src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
>   src/applet/package/metadata.desktop PRE-CREATION 
>   src/applet/plugin/CMakeLists.txt PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.h PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.h PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
>   src/applet/plugin/launchapp.h PRE-CREATION 
>   src/applet/plugin/launchapp.cpp PRE-CREATION 
>   src/applet/plugin/notify.h PRE-CREATION 
>   src/applet/plugin/notify.cpp PRE-CREATION 
>   src/applet/plugin/qmldir PRE-CREATION 
>   src/bluedevil.notifyrc 72257ed 
> 
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
> 
> 
> Testing
> ---
> 
> I've been running it for some time already and it works fine.
> 
> 
> File Attachments
> 
> 
> snapshot4.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
> snapshot5.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread Bhushan Shah


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78172
---



src/applet/plugin/bluetoothplugin.cpp (lines 32 - 33)


Maybe turn these into singletons?


- Bhushan Shah


On March 29, 2015, 7:44 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> ---
> 
> (Updated March 29, 2015, 7:44 p.m.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the 
> same but for Bluetooth devices.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 94b56fb 
>   src/CMakeLists.txt b804f2b 
>   src/applet/CMakeLists.txt PRE-CREATION 
>   src/applet/Messages.sh PRE-CREATION 
>   src/applet/package/contents/code/logic.js PRE-CREATION 
>   src/applet/package/contents/config/config.qml PRE-CREATION 
>   src/applet/package/contents/config/main.xml PRE-CREATION 
>   src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
>   src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
>   src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/Header.qml PRE-CREATION 
>   src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
>   src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
>   src/applet/package/metadata.desktop PRE-CREATION 
>   src/applet/plugin/CMakeLists.txt PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.h PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.h PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
>   src/applet/plugin/launchapp.h PRE-CREATION 
>   src/applet/plugin/launchapp.cpp PRE-CREATION 
>   src/applet/plugin/notify.h PRE-CREATION 
>   src/applet/plugin/notify.cpp PRE-CREATION 
>   src/applet/plugin/qmldir PRE-CREATION 
>   src/bluedevil.notifyrc 72257ed 
> 
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
> 
> 
> Testing
> ---
> 
> I've been running it for some time already and it works fine.
> 
> 
> File Attachments
> 
> 
> snapshot4.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
> snapshot5.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread David Rosca


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/
---

(Updated March 29, 2015, 5:18 p.m.)


Review request for Bluedevil and Plasma.


Changes
---

Make Notify and LaunchApp singletons


Repository: bluedevil


Description
---

This is a replacement for bluedevil-monolithic.
The code is based on network management plasmoid and it does basically the same 
but for Bluetooth devices.


Diffs (updated)
-

  CMakeLists.txt 94b56fb 
  src/CMakeLists.txt b804f2b 
  src/applet/CMakeLists.txt PRE-CREATION 
  src/applet/Messages.sh PRE-CREATION 
  src/applet/package/contents/code/logic.js PRE-CREATION 
  src/applet/package/contents/config/config.qml PRE-CREATION 
  src/applet/package/contents/config/main.xml PRE-CREATION 
  src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
  src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
  src/applet/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
  src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
  src/applet/package/contents/ui/Header.qml PRE-CREATION 
  src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
  src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
  src/applet/package/metadata.desktop PRE-CREATION 
  src/applet/plugin/CMakeLists.txt PRE-CREATION 
  src/applet/plugin/bluetoothplugin.h PRE-CREATION 
  src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
  src/applet/plugin/devicesproxymodel.h PRE-CREATION 
  src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
  src/applet/plugin/launchapp.h PRE-CREATION 
  src/applet/plugin/launchapp.cpp PRE-CREATION 
  src/applet/plugin/notify.h PRE-CREATION 
  src/applet/plugin/notify.cpp PRE-CREATION 
  src/applet/plugin/qmldir PRE-CREATION 
  src/bluedevil.notifyrc 72257ed 

Diff: https://git.reviewboard.kde.org/r/123164/diff/


Testing
---

I've been running it for some time already and it works fine.


File Attachments


snapshot4.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
snapshot5.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78179
---


Awesome!

A few nitpicks below


File Attachment: snapshot5.png - snapshot5.png


I wouldn't show the ID right at a glance. That's super geeky. Hide that in 
the details section.



File Attachment: snapshot4.png - snapshot4.png


Sending is more of an upload than a download, isn't it?



File Attachment: snapshot4.png - snapshot4.png


It's "Paired", what would "Connect" do?



File Attachment: snapshot4.png - snapshot4.png


Perhaps give the button a text, one could easily miss it.



src/applet/package/contents/code/logic.js (line 54)


Nice ;)



src/applet/package/contents/ui/BluetoothApplet.qml (line 37)


Would be cool to have the icon reflect the state, ie. use 
preferences-system-bluetooth-inactive (I think even the Plasma theme has that 
one)



src/applet/package/contents/ui/BluetoothApplet.qml (line 45)


I don't think that's needed



src/applet/package/contents/ui/ConfigGeneral.qml (lines 29 - 32)


Is it really neccessary to be able to turn sections off?



src/applet/package/contents/ui/DeviceItem.qml (line 79)


Property starting with an uppercase letter looks wrong to me, I wonder why 
that even works.



src/applet/package/contents/ui/FullRepresentation.qml (line 29)


Would it be possible to use Plasma's default proxy model?



src/applet/plugin/devicesproxymodel.h (line 38)


virtual ~DevicesProxyModel() = default; ?



src/applet/plugin/notify.cpp (line 37)


Use setIcon or setIconName or what it is called to avoid sending fixed 
pixmaps around.
Also perhaps set the icon in the notifyrc, and perhaps a Bluetooth icon is 
more descriptive than a generic dialog-warning


- Kai Uwe Broulik


On März 29, 2015, 5:18 nachm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> ---
> 
> (Updated März 29, 2015, 5:18 nachm.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the 
> same but for Bluetooth devices.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 94b56fb 
>   src/CMakeLists.txt b804f2b 
>   src/applet/CMakeLists.txt PRE-CREATION 
>   src/applet/Messages.sh PRE-CREATION 
>   src/applet/package/contents/code/logic.js PRE-CREATION 
>   src/applet/package/contents/config/config.qml PRE-CREATION 
>   src/applet/package/contents/config/main.xml PRE-CREATION 
>   src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
>   src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
>   src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/Header.qml PRE-CREATION 
>   src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
>   src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
>   src/applet/package/metadata.desktop PRE-CREATION 
>   src/applet/plugin/CMakeLists.txt PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.h PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.h PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
>   src/applet/plugin/launchapp.h PRE-CREATION 
>   src/applet/plugin/launchapp.cpp PRE-CREATION 
>   src/applet/plugin/notify.h PRE-CREATION 
>   src/applet/plugin/notify.cpp PRE-CREATION 
>   src/applet/plugin/qmldir PRE-CREATION 
>   src/bluedevil.notifyrc 72257ed 
> 
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
> 
> 
> Testing
> ---
> 
> I've been running it for some time already and it works fine.
> 
> 
> File Attachments
> 
> 
> snapshot4.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5

Re: Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread David Rosca



> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > File Attachment: snapshot4.png - snapshot4.png
> > 
> >
> > It's "Paired", what would "Connect" do?

It would connect to the device :) That means, connect the HID profile (input 
devices), A2DP profile (audio), ...


> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > File Attachment: snapshot5.png - snapshot5.png
> > 
> >
> > I wouldn't show the ID right at a glance. That's super geeky. Hide that 
> > in the details section.

Hmm, you are right. But what to show there instead?


> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > src/applet/package/contents/ui/DeviceItem.qml, line 79
> > 
> >
> > Property starting with an uppercase letter looks wrong to me, I wonder 
> > why that even works.

This is role name from model.


> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > src/applet/package/contents/ui/BluetoothApplet.qml, line 37
> > 
> >
> > Would be cool to have the icon reflect the state, ie. use 
> > preferences-system-bluetooth-inactive (I think even the Plasma theme has 
> > that one)

The icon is already greyed (disabled) when BT is offline. Also 
preferences-system-bluetooth-inactive is not in breeze icon theme.

Ideally, all icons should be in svg and adjusted for this applet - as in 
plasma-nm. Right now, the bluetooth icon in tooltip is small because the 
monochrome version is only in small size (for bluedevil-monolithic).
I'll try to ask vdg :)


> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > src/applet/package/contents/ui/FullRepresentation.qml, line 29
> > 
> >
> > Would it be possible to use Plasma's default proxy model?

I don't think so. It sorts devices and also append a (hciX) to device name if 
there are same devices in multiple adapters.


> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > src/applet/plugin/devicesproxymodel.h, line 38
> > 
> >
> > virtual ~DevicesProxyModel() = default; ?

Isn't it the same as if there is no destructor at all?


> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > src/applet/package/contents/ui/ConfigGeneral.qml, lines 29-32
> > 
> >
> > Is it really neccessary to be able to turn sections off?

No :D Ok, I will drop the whole config.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78179
---


On March 29, 2015, 5:18 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> ---
> 
> (Updated March 29, 2015, 5:18 p.m.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the 
> same but for Bluetooth devices.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 94b56fb 
>   src/CMakeLists.txt b804f2b 
>   src/applet/CMakeLists.txt PRE-CREATION 
>   src/applet/Messages.sh PRE-CREATION 
>   src/applet/package/contents/code/logic.js PRE-CREATION 
>   src/applet/package/contents/config/config.qml PRE-CREATION 
>   src/applet/package/contents/config/main.xml PRE-CREATION 
>   src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
>   src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
>   src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/Header.qml PRE-CREATION 
>   src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
>   src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
>   src/applet/package/metadata.desktop PRE-CREATION 
>   src/applet/plugin/CMakeLists.txt PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.h PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.h PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
>   src/applet/plugin/launchapp.h PRE-CREATION 
>   src/applet/plugin/launchapp.cpp PRE-CREATION 
>   src/applet/plugin/notify.h PRE-CREATION 
>   src/applet/plugin/notify.cpp PRE-CREA

Re: Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread Kai Uwe Broulik



> On März 29, 2015, 6 nachm., Kai Uwe Broulik wrote:
> > File Attachment: snapshot4.png - snapshot4.png
> > 
> >
> > It's "Paired", what would "Connect" do?
> 
> David Rosca wrote:
> It would connect to the device :) That means, connect the HID profile 
> (input devices), A2DP profile (audio), ...

Ah, okay.


> On März 29, 2015, 6 nachm., Kai Uwe Broulik wrote:
> > File Attachment: snapshot5.png - snapshot5.png
> > 
> >
> > I wouldn't show the ID right at a glance. That's super geeky. Hide that 
> > in the details section.
> 
> David Rosca wrote:
> Hmm, you are right. But what to show there instead?

Nothing? :)


> On März 29, 2015, 6 nachm., Kai Uwe Broulik wrote:
> > src/applet/package/contents/ui/BluetoothApplet.qml, line 37
> > 
> >
> > Would be cool to have the icon reflect the state, ie. use 
> > preferences-system-bluetooth-inactive (I think even the Plasma theme has 
> > that one)
> 
> David Rosca wrote:
> The icon is already greyed (disabled) when BT is offline. Also 
> preferences-system-bluetooth-inactive is not in breeze icon theme.
> 
> Ideally, all icons should be in svg and adjusted for this applet - as in 
> plasma-nm. Right now, the bluetooth icon in tooltip is small because the 
> monochrome version is only in small size (for bluedevil-monolithic).
> I'll try to ask vdg :)

You should probably open a VDG forum thread on this.


> On März 29, 2015, 6 nachm., Kai Uwe Broulik wrote:
> > src/applet/package/contents/ui/FullRepresentation.qml, line 29
> > 
> >
> > Would it be possible to use Plasma's default proxy model?
> 
> David Rosca wrote:
> I don't think so. It sorts devices and also append a (hciX) to device 
> name if there are same devices in multiple adapters.

Ok, was just wondering.


> On März 29, 2015, 6 nachm., Kai Uwe Broulik wrote:
> > src/applet/package/contents/ui/DeviceItem.qml, line 79
> > 
> >
> > Property starting with an uppercase letter looks wrong to me, I wonder 
> > why that even works.
> 
> David Rosca wrote:
> This is role name from model.

Ok


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78179
---


On März 29, 2015, 5:18 nachm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> ---
> 
> (Updated März 29, 2015, 5:18 nachm.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the 
> same but for Bluetooth devices.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 94b56fb 
>   src/CMakeLists.txt b804f2b 
>   src/applet/CMakeLists.txt PRE-CREATION 
>   src/applet/Messages.sh PRE-CREATION 
>   src/applet/package/contents/code/logic.js PRE-CREATION 
>   src/applet/package/contents/config/config.qml PRE-CREATION 
>   src/applet/package/contents/config/main.xml PRE-CREATION 
>   src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
>   src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
>   src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/Header.qml PRE-CREATION 
>   src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
>   src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
>   src/applet/package/metadata.desktop PRE-CREATION 
>   src/applet/plugin/CMakeLists.txt PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.h PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.h PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
>   src/applet/plugin/launchapp.h PRE-CREATION 
>   src/applet/plugin/launchapp.cpp PRE-CREATION 
>   src/applet/plugin/notify.h PRE-CREATION 
>   src/applet/plugin/notify.cpp PRE-CREATION 
>   src/applet/plugin/qmldir PRE-CREATION 
>   src/bluedevil.notifyrc 72257ed 
> 
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
> 
> 
> Testing
> ---
> 
> I've been running it for some time already and it works fine.
> 
> 
> File Attachments
> 
> 
> snapshot4.png
>   
> https://git.review

Re: Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread David Rosca



> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > File Attachment: snapshot5.png - snapshot5.png
> > 
> >
> > I wouldn't show the ID right at a glance. That's super geeky. Hide that 
> > in the details section.
> 
> David Rosca wrote:
> Hmm, you are right. But what to show there instead?
> 
> Kai Uwe Broulik wrote:
> Nothing? :)

Maybe type of the device (Phone, Mouse, ...), but that can already be seen from 
the icon.
I don't know .. it looks empty without it.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78179
---


On March 29, 2015, 5:18 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> ---
> 
> (Updated March 29, 2015, 5:18 p.m.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the 
> same but for Bluetooth devices.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 94b56fb 
>   src/CMakeLists.txt b804f2b 
>   src/applet/CMakeLists.txt PRE-CREATION 
>   src/applet/Messages.sh PRE-CREATION 
>   src/applet/package/contents/code/logic.js PRE-CREATION 
>   src/applet/package/contents/config/config.qml PRE-CREATION 
>   src/applet/package/contents/config/main.xml PRE-CREATION 
>   src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
>   src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
>   src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/Header.qml PRE-CREATION 
>   src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
>   src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
>   src/applet/package/metadata.desktop PRE-CREATION 
>   src/applet/plugin/CMakeLists.txt PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.h PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.h PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
>   src/applet/plugin/launchapp.h PRE-CREATION 
>   src/applet/plugin/launchapp.cpp PRE-CREATION 
>   src/applet/plugin/notify.h PRE-CREATION 
>   src/applet/plugin/notify.cpp PRE-CREATION 
>   src/applet/plugin/qmldir PRE-CREATION 
>   src/bluedevil.notifyrc 72257ed 
> 
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
> 
> 
> Testing
> ---
> 
> I've been running it for some time already and it works fine.
> 
> 
> File Attachments
> 
> 
> snapshot4.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
> snapshot5.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

2015-03-29 Thread David Rosca


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/
---

(Updated March 29, 2015, 8:13 p.m.)


Review request for Bluedevil and Plasma.


Changes
---

Drop config + fix some issues


Repository: bluedevil


Description
---

This is a replacement for bluedevil-monolithic.
The code is based on network management plasmoid and it does basically the same 
but for Bluetooth devices.


Diffs (updated)
-

  CMakeLists.txt 94b56fb 
  src/CMakeLists.txt b804f2b 
  src/applet/CMakeLists.txt PRE-CREATION 
  src/applet/Messages.sh PRE-CREATION 
  src/applet/package/contents/code/logic.js PRE-CREATION 
  src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
  src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
  src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
  src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
  src/applet/package/contents/ui/Header.qml PRE-CREATION 
  src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
  src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
  src/applet/package/metadata.desktop PRE-CREATION 
  src/applet/plugin/CMakeLists.txt PRE-CREATION 
  src/applet/plugin/bluetoothplugin.h PRE-CREATION 
  src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
  src/applet/plugin/devicesproxymodel.h PRE-CREATION 
  src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
  src/applet/plugin/launchapp.h PRE-CREATION 
  src/applet/plugin/launchapp.cpp PRE-CREATION 
  src/applet/plugin/notify.h PRE-CREATION 
  src/applet/plugin/notify.cpp PRE-CREATION 
  src/applet/plugin/qmldir PRE-CREATION 
  src/bluedevil.notifyrc 72257ed 

Diff: https://git.reviewboard.kde.org/r/123164/diff/


Testing
---

I've been running it for some time already and it works fine.


File Attachments


snapshot4.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
snapshot5.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

2015-03-30 Thread Emmanuel Pescosta


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78206
---



src/applet/package/contents/code/logic.js (line 34)


array.filter() maybe?



src/applet/package/contents/code/logic.js (line 52)


array.forEach() maybe?


- Emmanuel Pescosta


On March 29, 2015, 10:13 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> ---
> 
> (Updated March 29, 2015, 10:13 p.m.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the 
> same but for Bluetooth devices.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 94b56fb 
>   src/CMakeLists.txt b804f2b 
>   src/applet/CMakeLists.txt PRE-CREATION 
>   src/applet/Messages.sh PRE-CREATION 
>   src/applet/package/contents/code/logic.js PRE-CREATION 
>   src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
>   src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
>   src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/Header.qml PRE-CREATION 
>   src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
>   src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
>   src/applet/package/metadata.desktop PRE-CREATION 
>   src/applet/plugin/CMakeLists.txt PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.h PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.h PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
>   src/applet/plugin/launchapp.h PRE-CREATION 
>   src/applet/plugin/launchapp.cpp PRE-CREATION 
>   src/applet/plugin/notify.h PRE-CREATION 
>   src/applet/plugin/notify.cpp PRE-CREATION 
>   src/applet/plugin/qmldir PRE-CREATION 
>   src/bluedevil.notifyrc 72257ed 
> 
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
> 
> 
> Testing
> ---
> 
> I've been running it for some time already and it works fine.
> 
> 
> File Attachments
> 
> 
> snapshot4.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
> snapshot5.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

2015-03-30 Thread David Rosca



> On March 30, 2015, 8:42 a.m., Emmanuel Pescosta wrote:
> > src/applet/package/contents/code/logic.js, line 34
> > 
> >
> > array.filter() maybe?

Nope, doesn't work:

TypeError: Property 'filter' of object [object Object] is not a function

probably because it is a QQmlListProperty and not a javascript array.


> On March 30, 2015, 8:42 a.m., Emmanuel Pescosta wrote:
> > src/applet/package/contents/code/logic.js, line 52
> > 
> >
> > array.forEach() maybe?

Same as above


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78206
---


On March 29, 2015, 8:13 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> ---
> 
> (Updated March 29, 2015, 8:13 p.m.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the 
> same but for Bluetooth devices.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 94b56fb 
>   src/CMakeLists.txt b804f2b 
>   src/applet/CMakeLists.txt PRE-CREATION 
>   src/applet/Messages.sh PRE-CREATION 
>   src/applet/package/contents/code/logic.js PRE-CREATION 
>   src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
>   src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
>   src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/Header.qml PRE-CREATION 
>   src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
>   src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
>   src/applet/package/metadata.desktop PRE-CREATION 
>   src/applet/plugin/CMakeLists.txt PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.h PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.h PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
>   src/applet/plugin/launchapp.h PRE-CREATION 
>   src/applet/plugin/launchapp.cpp PRE-CREATION 
>   src/applet/plugin/notify.h PRE-CREATION 
>   src/applet/plugin/notify.cpp PRE-CREATION 
>   src/applet/plugin/qmldir PRE-CREATION 
>   src/bluedevil.notifyrc 72257ed 
> 
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
> 
> 
> Testing
> ---
> 
> I've been running it for some time already and it works fine.
> 
> 
> File Attachments
> 
> 
> snapshot4.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
> snapshot5.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

2015-03-30 Thread Xuetian Weng



> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > File Attachment: snapshot5.png - snapshot5.png
> > 
> >
> > I wouldn't show the ID right at a glance. That's super geeky. Hide that 
> > in the details section.
> 
> David Rosca wrote:
> Hmm, you are right. But what to show there instead?
> 
> Kai Uwe Broulik wrote:
> Nothing? :)
> 
> David Rosca wrote:
> Maybe type of the device (Phone, Mouse, ...), but that can already be 
> seen from the icon.
> I don't know .. it looks empty without it.

What about what kinds of profile are being used?


- Xuetian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78179
---


On March 29, 2015, 8:13 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> ---
> 
> (Updated March 29, 2015, 8:13 p.m.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the 
> same but for Bluetooth devices.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 94b56fb 
>   src/CMakeLists.txt b804f2b 
>   src/applet/CMakeLists.txt PRE-CREATION 
>   src/applet/Messages.sh PRE-CREATION 
>   src/applet/package/contents/code/logic.js PRE-CREATION 
>   src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
>   src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
>   src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/Header.qml PRE-CREATION 
>   src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
>   src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
>   src/applet/package/metadata.desktop PRE-CREATION 
>   src/applet/plugin/CMakeLists.txt PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.h PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.h PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
>   src/applet/plugin/launchapp.h PRE-CREATION 
>   src/applet/plugin/launchapp.cpp PRE-CREATION 
>   src/applet/plugin/notify.h PRE-CREATION 
>   src/applet/plugin/notify.cpp PRE-CREATION 
>   src/applet/plugin/qmldir PRE-CREATION 
>   src/bluedevil.notifyrc 72257ed 
> 
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
> 
> 
> Testing
> ---
> 
> I've been running it for some time already and it works fine.
> 
> 
> File Attachments
> 
> 
> snapshot4.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
> snapshot5.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

2015-03-31 Thread David Rosca


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/
---

(Updated March 31, 2015, 9:22 a.m.)


Review request for Bluedevil and Plasma.


Changes
---

Show supported services instead of device address + use better icons for audio 
devices + new screenshots


Repository: bluedevil


Description
---

This is a replacement for bluedevil-monolithic.
The code is based on network management plasmoid and it does basically the same 
but for Bluetooth devices.


Diffs (updated)
-

  CMakeLists.txt 94b56fb 
  src/CMakeLists.txt b804f2b 
  src/applet/CMakeLists.txt PRE-CREATION 
  src/applet/Messages.sh PRE-CREATION 
  src/applet/package/contents/code/logic.js PRE-CREATION 
  src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
  src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
  src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
  src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
  src/applet/package/contents/ui/Header.qml PRE-CREATION 
  src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
  src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
  src/applet/package/metadata.desktop PRE-CREATION 
  src/applet/plugin/CMakeLists.txt PRE-CREATION 
  src/applet/plugin/bluetoothplugin.h PRE-CREATION 
  src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
  src/applet/plugin/devicesproxymodel.h PRE-CREATION 
  src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
  src/applet/plugin/launchapp.h PRE-CREATION 
  src/applet/plugin/launchapp.cpp PRE-CREATION 
  src/applet/plugin/notify.h PRE-CREATION 
  src/applet/plugin/notify.cpp PRE-CREATION 
  src/applet/plugin/qmldir PRE-CREATION 
  src/bluedevil.notifyrc f87dc95 

Diff: https://git.reviewboard.kde.org/r/123164/diff/


Testing
---

I've been running it for some time already and it works fine.


File Attachments (updated)


snapshot4.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
snapshot5.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
btapplet6.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/d8ffae3d-f4f4-4bf1-b5ad-27d1298d4d3f__btapplet6.png
btapplet7.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/957074cc-acf4-40b1-bb08-857ac6937669__btapplet7.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

2015-03-31 Thread David Rosca



> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > File Attachment: snapshot4.png - snapshot4.png
> > 
> >
> > Perhaps give the button a text, one could easily miss it.

It doesn't look good with the text: 
http://wstaw.org/m/2015/03/31/plasma-desktopJYg879.png


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78179
---


On March 31, 2015, 9:22 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> ---
> 
> (Updated March 31, 2015, 9:22 a.m.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the 
> same but for Bluetooth devices.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 94b56fb 
>   src/CMakeLists.txt b804f2b 
>   src/applet/CMakeLists.txt PRE-CREATION 
>   src/applet/Messages.sh PRE-CREATION 
>   src/applet/package/contents/code/logic.js PRE-CREATION 
>   src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
>   src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
>   src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/Header.qml PRE-CREATION 
>   src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
>   src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
>   src/applet/package/metadata.desktop PRE-CREATION 
>   src/applet/plugin/CMakeLists.txt PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.h PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.h PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
>   src/applet/plugin/launchapp.h PRE-CREATION 
>   src/applet/plugin/launchapp.cpp PRE-CREATION 
>   src/applet/plugin/notify.h PRE-CREATION 
>   src/applet/plugin/notify.cpp PRE-CREATION 
>   src/applet/plugin/qmldir PRE-CREATION 
>   src/bluedevil.notifyrc f87dc95 
> 
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
> 
> 
> Testing
> ---
> 
> I've been running it for some time already and it works fine.
> 
> 
> File Attachments
> 
> 
> snapshot4.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
> snapshot5.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
> btapplet6.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/d8ffae3d-f4f4-4bf1-b5ad-27d1298d4d3f__btapplet6.png
> btapplet7.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/957074cc-acf4-40b1-bb08-857ac6937669__btapplet7.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

2015-04-02 Thread David Rosca


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/
---

(Updated April 2, 2015, 10:13 a.m.)


Review request for Bluedevil and Plasma.


Changes
---

I've added a new state when Bluetooth is blocked with rfkill.

If there are no more code issues, I will push it. UI issues can be fixed later 
with feedback from users.


Repository: bluedevil


Description
---

This is a replacement for bluedevil-monolithic.
The code is based on network management plasmoid and it does basically the same 
but for Bluetooth devices.


Diffs (updated)
-

  CMakeLists.txt 94b56fb 
  src/CMakeLists.txt b804f2b 
  src/applet/CMakeLists.txt PRE-CREATION 
  src/applet/Messages.sh PRE-CREATION 
  src/applet/package/contents/code/logic.js PRE-CREATION 
  src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
  src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
  src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
  src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
  src/applet/package/contents/ui/Header.qml PRE-CREATION 
  src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
  src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
  src/applet/package/metadata.desktop PRE-CREATION 
  src/applet/plugin/CMakeLists.txt PRE-CREATION 
  src/applet/plugin/bluetoothplugin.h PRE-CREATION 
  src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
  src/applet/plugin/devicesproxymodel.h PRE-CREATION 
  src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
  src/applet/plugin/launchapp.h PRE-CREATION 
  src/applet/plugin/launchapp.cpp PRE-CREATION 
  src/applet/plugin/notify.h PRE-CREATION 
  src/applet/plugin/notify.cpp PRE-CREATION 
  src/applet/plugin/qmldir PRE-CREATION 
  src/bluedevil.notifyrc f87dc95 

Diff: https://git.reviewboard.kde.org/r/123164/diff/


Testing
---

I've been running it for some time already and it works fine.


File Attachments


snapshot4.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
snapshot5.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
btapplet6.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/d8ffae3d-f4f4-4bf1-b5ad-27d1298d4d3f__btapplet6.png
btapplet7.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/957074cc-acf4-40b1-bb08-857ac6937669__btapplet7.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

2015-04-02 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78395
---


+1 from me.
Maybe wait for another +1 from someone else as it's quite a huge patch.

- David Edmundson


On April 2, 2015, 10:13 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> ---
> 
> (Updated April 2, 2015, 10:13 a.m.)
> 
> 
> Review request for Bluedevil and Plasma.
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the 
> same but for Bluetooth devices.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 94b56fb 
>   src/CMakeLists.txt b804f2b 
>   src/applet/CMakeLists.txt PRE-CREATION 
>   src/applet/Messages.sh PRE-CREATION 
>   src/applet/package/contents/code/logic.js PRE-CREATION 
>   src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
>   src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
>   src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
>   src/applet/package/contents/ui/Header.qml PRE-CREATION 
>   src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
>   src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
>   src/applet/package/metadata.desktop PRE-CREATION 
>   src/applet/plugin/CMakeLists.txt PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.h PRE-CREATION 
>   src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.h PRE-CREATION 
>   src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
>   src/applet/plugin/launchapp.h PRE-CREATION 
>   src/applet/plugin/launchapp.cpp PRE-CREATION 
>   src/applet/plugin/notify.h PRE-CREATION 
>   src/applet/plugin/notify.cpp PRE-CREATION 
>   src/applet/plugin/qmldir PRE-CREATION 
>   src/bluedevil.notifyrc f87dc95 
> 
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
> 
> 
> Testing
> ---
> 
> I've been running it for some time already and it works fine.
> 
> 
> File Attachments
> 
> 
> snapshot4.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
> snapshot5.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
> btapplet6.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/d8ffae3d-f4f4-4bf1-b5ad-27d1298d4d3f__btapplet6.png
> btapplet7.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/957074cc-acf4-40b1-bb08-857ac6937669__btapplet7.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123164: Add new Bluetooth applet

2015-04-04 Thread David Rosca


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/
---

(Updated April 4, 2015, 7:19 a.m.)


Status
--

This change has been marked as submitted.


Review request for Bluedevil and Plasma.


Changes
---

Submitted with commit 25b43374519e189c3c5c0f4ce24ff343da392055 by David Rosca 
to branch bluezqt.


Repository: bluedevil


Description
---

This is a replacement for bluedevil-monolithic.
The code is based on network management plasmoid and it does basically the same 
but for Bluetooth devices.


Diffs
-

  CMakeLists.txt 94b56fb 
  src/CMakeLists.txt b804f2b 
  src/applet/CMakeLists.txt PRE-CREATION 
  src/applet/Messages.sh PRE-CREATION 
  src/applet/package/contents/code/logic.js PRE-CREATION 
  src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
  src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
  src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
  src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
  src/applet/package/contents/ui/Header.qml PRE-CREATION 
  src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
  src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
  src/applet/package/metadata.desktop PRE-CREATION 
  src/applet/plugin/CMakeLists.txt PRE-CREATION 
  src/applet/plugin/bluetoothplugin.h PRE-CREATION 
  src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
  src/applet/plugin/devicesproxymodel.h PRE-CREATION 
  src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
  src/applet/plugin/launchapp.h PRE-CREATION 
  src/applet/plugin/launchapp.cpp PRE-CREATION 
  src/applet/plugin/notify.h PRE-CREATION 
  src/applet/plugin/notify.cpp PRE-CREATION 
  src/applet/plugin/qmldir PRE-CREATION 
  src/bluedevil.notifyrc f87dc95 

Diff: https://git.reviewboard.kde.org/r/123164/diff/


Testing
---

I've been running it for some time already and it works fine.


File Attachments


snapshot4.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
snapshot5.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
btapplet6.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/d8ffae3d-f4f4-4bf1-b5ad-27d1298d4d3f__btapplet6.png
btapplet7.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/957074cc-acf4-40b1-bb08-857ac6937669__btapplet7.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

Re: Review Request 123164: Add new Bluetooth applet

21 matches

Site Navigation

Mail list logo

Footer information