Re: Review Request 123372: Update the date in the calendar/tooltip when user changes clock timezone

2015-04-16 Thread Martin Klapetek

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123372/
---

(Updated April 16, 2015, 9:59 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 5b76b2385b35baa51d0df43cacc88aa3c8f7813e by Martin 
Klapetek to branch Plasma/5.3.


Bugs: 346033
https://bugs.kde.org/show_bug.cgi?id=346033


Repository: plasma-workspace


Description
---

Currently when there are multiple timezones in teh clock, they affect only the 
time. This fixes the date in the calendar and tooltip to reflect to current 
selected timezone.


Diffs
-

  applets/digital-clock/package/contents/ui/CalendarView.qml 0419d71 
  applets/digital-clock/package/contents/ui/DigitalClock.qml 74ffac1 
  applets/digital-clock/package/contents/ui/main.qml 1563d51 

Diff: https://git.reviewboard.kde.org/r/123372/diff/


Testing
---

Added multiple timezones (UTC+-N) and scrolled over, watched calendar switch 
dates and also watched tooltip properly update after midnight


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 123372: Update the date in the calendar/tooltip when user changes clock timezone

2015-04-15 Thread Martin Klapetek

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123372/
---

Review request for Plasma.


Bugs: 346033
https://bugs.kde.org/show_bug.cgi?id=346033


Repository: plasma-workspace


Description
---

Currently when there are multiple timezones in teh clock, they affect only the 
time. This fixes the date in the calendar and tooltip to reflect to current 
selected timezone.


Diffs
-

  applets/digital-clock/package/contents/ui/CalendarView.qml 0419d71 
  applets/digital-clock/package/contents/ui/DigitalClock.qml 74ffac1 
  applets/digital-clock/package/contents/ui/main.qml 1563d51 

Diff: https://git.reviewboard.kde.org/r/123372/diff/


Testing
---

Added multiple timezones (UTC+-N) and scrolled over, watched calendar switch 
dates and also watched tooltip properly update after midnight


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 123372: Update the date in the calendar/tooltip when user changes clock timezone

2015-04-15 Thread Lukáš Tinkl

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123372/#review78970
---

Ship it!


Looks good from me, +1

- Lukáš Tinkl


On Dub. 15, 2015, 5:05 odp., Martin Klapetek wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123372/
 ---
 
 (Updated Dub. 15, 2015, 5:05 odp.)
 
 
 Review request for Plasma.
 
 
 Bugs: 346033
 https://bugs.kde.org/show_bug.cgi?id=346033
 
 
 Repository: plasma-workspace
 
 
 Description
 ---
 
 Currently when there are multiple timezones in teh clock, they affect only 
 the time. This fixes the date in the calendar and tooltip to reflect to 
 current selected timezone.
 
 
 Diffs
 -
 
   applets/digital-clock/package/contents/ui/CalendarView.qml 0419d71 
   applets/digital-clock/package/contents/ui/DigitalClock.qml 74ffac1 
   applets/digital-clock/package/contents/ui/main.qml 1563d51 
 
 Diff: https://git.reviewboard.kde.org/r/123372/diff/
 
 
 Testing
 ---
 
 Added multiple timezones (UTC+-N) and scrolled over, watched calendar switch 
 dates and also watched tooltip properly update after midnight
 
 
 Thanks,
 
 Martin Klapetek
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel