Re: Review Request 123530: Improve interactivity for the user icon and search field in kickoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/ --- (Updated April 28, 2015, 1:36 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and KDE Usability. Changes --- Submitted with commit bae60a355524ca6b88d87aed28d7ecb002369777 by Lukáš Tinkl to branch master. Repository: plasma-desktop Description --- This patch makes the user icon and search field clickable. Upon clicking the former, the User Account kcm is opened, in the latter case the search field gets visible and activated. Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 applets/kickoff/package/contents/ui/Header.qml dfabbe5 Diff: https://git.reviewboard.kde.org/r/123530/diff/ Testing --- Everything works as expected, pressing Esc either cancels the search and/or closes the menu popup. Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123530: Improve interactivity for the user icon and search field in kickoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/#review79622 --- Ship it! Ship It! - David Edmundson On April 27, 2015, 5:04 p.m., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/ --- (Updated April 27, 2015, 5:04 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-desktop Description --- This patch makes the user icon and search field clickable. Upon clicking the former, the User Account kcm is opened, in the latter case the search field gets visible and activated. Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 applets/kickoff/package/contents/ui/Header.qml dfabbe5 Diff: https://git.reviewboard.kde.org/r/123530/diff/ Testing --- Everything works as expected, pressing Esc either cancels the search and/or closes the menu popup. Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123530: Improve interactivity for the user icon and search field in kickoff
On April 27, 2015, 2:56 p.m., David Edmundson wrote: Personally I don't think anyone needs to open the accounts KCM so often we need to link to it. I suspect it'll get more accidental opens than legit ones. The other changes seems good though. Lukáš Tinkl wrote: I for one would expect it to be interactive, and it closely matches what Windows (and Gnome Shell too afaik) does. Thomas Pfeiffer wrote: By User Account kcm you mean the Password and User Account kcm, right? I think that's okay, as it lets you edit the information that is shown there. If we get lots of bug reports form people accidentally clicking it, we might reconsider. Lukáš Tinkl wrote: Yup exactly, it lets you edit what is being shown there - the user name and your face/icon. I must say that I quite like this idea, too. I've seen too many reviews where the user didn't bother to change the face icon in Kickoff, while it looks really cool and is a nice personalization point. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/#review79576 --- On April 27, 2015, 5:04 p.m., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/ --- (Updated April 27, 2015, 5:04 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-desktop Description --- This patch makes the user icon and search field clickable. Upon clicking the former, the User Account kcm is opened, in the latter case the search field gets visible and activated. Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 applets/kickoff/package/contents/ui/Header.qml dfabbe5 Diff: https://git.reviewboard.kde.org/r/123530/diff/ Testing --- Everything works as expected, pressing Esc either cancels the search and/or closes the menu popup. Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123530: Improve interactivity for the user icon and search field in kickoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/ --- Review request for Plasma. Repository: plasma-desktop Description --- This patch makes the user icon and search field clickable. Upon clicking the former, the User Account kcm is opened, in the latter case the search field gets visible and activated. Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 applets/kickoff/package/contents/ui/Header.qml dfabbe5 Diff: https://git.reviewboard.kde.org/r/123530/diff/ Testing --- Everything works as expected, pressing Esc either cancels the search and/or closes the menu popup. Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123530: Improve interactivity for the user icon and search field in kickoff
On Dub. 27, 2015, 4:56 odp., David Edmundson wrote: Personally I don't think anyone needs to open the accounts KCM so often we need to link to it. I suspect it'll get more accidental opens than legit ones. The other changes seems good though. Lukáš Tinkl wrote: I for one would expect it to be interactive, and it closely matches what Windows (and Gnome Shell too afaik) does. Thomas Pfeiffer wrote: By User Account kcm you mean the Password and User Account kcm, right? I think that's okay, as it lets you edit the information that is shown there. If we get lots of bug reports form people accidentally clicking it, we might reconsider. Yup exactly, it lets you edit what is being shown there - the user name and your face/icon. - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/#review79576 --- On Dub. 27, 2015, 7:04 odp., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/ --- (Updated Dub. 27, 2015, 7:04 odp.) Review request for Plasma and KDE Usability. Repository: plasma-desktop Description --- This patch makes the user icon and search field clickable. Upon clicking the former, the User Account kcm is opened, in the latter case the search field gets visible and activated. Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 applets/kickoff/package/contents/ui/Header.qml dfabbe5 Diff: https://git.reviewboard.kde.org/r/123530/diff/ Testing --- Everything works as expected, pressing Esc either cancels the search and/or closes the menu popup. Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123530: Improve interactivity for the user icon and search field in kickoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/#review79576 --- Personally I don't think anyone needs to open the accounts KCM so often we need to link to it. I suspect it'll get more accidental opens than legit ones. The other changes seems good though. - David Edmundson On April 27, 2015, 2:31 p.m., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/ --- (Updated April 27, 2015, 2:31 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-desktop Description --- This patch makes the user icon and search field clickable. Upon clicking the former, the User Account kcm is opened, in the latter case the search field gets visible and activated. Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 applets/kickoff/package/contents/ui/Header.qml dfabbe5 Diff: https://git.reviewboard.kde.org/r/123530/diff/ Testing --- Everything works as expected, pressing Esc either cancels the search and/or closes the menu popup. Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123530: Improve interactivity for the user icon and search field in kickoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/#review79575 --- Good idea! A couple of nitpicky suggestions below :) applets/kickoff/package/contents/ui/Header.qml (line 38) https://git.reviewboard.kde.org/r/123530/#comment54367 !== If you change it below, change it here too ;) applets/kickoff/package/contents/ui/Header.qml (line 95) https://git.reviewboard.kde.org/r/123530/#comment54368 Does this need to be duplicated? I suppose the hit area for both items should be pretty similar so you could place a single MouseArea one level up. applets/kickoff/package/contents/ui/Header.qml (line 166) https://git.reviewboard.kde.org/r/123530/#comment54369 If you put the TextField outside the MouseArea, you could probably just do visible: header.state === hint and safe the cursorShape and enabled dance - Kai Uwe Broulik On April 27, 2015, 2:31 nachm., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/ --- (Updated April 27, 2015, 2:31 nachm.) Review request for Plasma and KDE Usability. Repository: plasma-desktop Description --- This patch makes the user icon and search field clickable. Upon clicking the former, the User Account kcm is opened, in the latter case the search field gets visible and activated. Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 applets/kickoff/package/contents/ui/Header.qml dfabbe5 Diff: https://git.reviewboard.kde.org/r/123530/diff/ Testing --- Everything works as expected, pressing Esc either cancels the search and/or closes the menu popup. Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123530: Improve interactivity for the user icon and search field in kickoff
On Dub. 27, 2015, 4:56 odp., David Edmundson wrote: Personally I don't think anyone needs to open the accounts KCM so often we need to link to it. I suspect it'll get more accidental opens than legit ones. The other changes seems good though. I for one would expect it to be interactive, and it closely matches what Windows (and Gnome Shell too afaik) does. - Lukáš --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/#review79576 --- On Dub. 27, 2015, 4:31 odp., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/ --- (Updated Dub. 27, 2015, 4:31 odp.) Review request for Plasma and KDE Usability. Repository: plasma-desktop Description --- This patch makes the user icon and search field clickable. Upon clicking the former, the User Account kcm is opened, in the latter case the search field gets visible and activated. Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 applets/kickoff/package/contents/ui/Header.qml dfabbe5 Diff: https://git.reviewboard.kde.org/r/123530/diff/ Testing --- Everything works as expected, pressing Esc either cancels the search and/or closes the menu popup. Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123530: Improve interactivity for the user icon and search field in kickoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/ --- (Updated Dub. 27, 2015, 7:04 odp.) Review request for Plasma and KDE Usability. Changes --- Fix a problem with the search text field staying visible between menu opens plus some minor coding style issues pointed out by Kai. Repository: plasma-desktop Description --- This patch makes the user icon and search field clickable. Upon clicking the former, the User Account kcm is opened, in the latter case the search field gets visible and activated. Diffs (updated) - applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 applets/kickoff/package/contents/ui/Header.qml dfabbe5 Diff: https://git.reviewboard.kde.org/r/123530/diff/ Testing --- Everything works as expected, pressing Esc either cancels the search and/or closes the menu popup. Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123530: Improve interactivity for the user icon and search field in kickoff
On April 27, 2015, 2:56 p.m., David Edmundson wrote: Personally I don't think anyone needs to open the accounts KCM so often we need to link to it. I suspect it'll get more accidental opens than legit ones. The other changes seems good though. Lukáš Tinkl wrote: I for one would expect it to be interactive, and it closely matches what Windows (and Gnome Shell too afaik) does. By User Account kcm you mean the Password and User Account kcm, right? I think that's okay, as it lets you edit the information that is shown there. If we get lots of bug reports form people accidentally clicking it, we might reconsider. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/#review79576 --- On April 27, 2015, 5:04 p.m., Lukáš Tinkl wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/ --- (Updated April 27, 2015, 5:04 p.m.) Review request for Plasma and KDE Usability. Repository: plasma-desktop Description --- This patch makes the user icon and search field clickable. Upon clicking the former, the User Account kcm is opened, in the latter case the search field gets visible and activated. Diffs - applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 applets/kickoff/package/contents/ui/Header.qml dfabbe5 Diff: https://git.reviewboard.kde.org/r/123530/diff/ Testing --- Everything works as expected, pressing Esc either cancels the search and/or closes the menu popup. Thanks, Lukáš Tinkl ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
