Re: Review Request 123539: Improve visibility of running widget checkmark

2015-05-04 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123539/
---

(Updated May 4, 2015, 9:32 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, KDE Usability and Andrew Lake.


Changes
---

Submitted with commit 3347ebe87d6c8706873d65de4fc45ac3c21c0b10 by Kai Uwe 
Broulik to branch Plasma/5.3.


Bugs: 342112
https://bugs.kde.org/show_bug.cgi?id=342112


Repository: plasma-desktop


Description
---

As suggested by Andrew show a badge kind of thing with the number of running 
applets inside.


Diffs
-

  desktoppackage/contents/explorer/AppletDelegate.qml 2e53c1e 

Diff: https://git.reviewboard.kde.org/r/123539/diff/


Testing
---

After fixing a nasty bug in the model it shows the proper number now. It also 
doesn't break if you happen to have 10 or more widgets of the same kind. I did 
not know what kind of font color to use.


File Attachments


Badge in action
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/27/1b8483bb-fe3b-4701-92d3-02b437e63843__widgetexplorernumber2.jpg
Fancy effect in action
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/28/289d6677-bb68-4b69-a43a-3becf226ad3b__badgeshader2.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123539: Improve visibility of running widget checkmark

2015-04-28 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123539/
---

(Updated April 28, 2015, 6:34 nachm.)


Review request for Plasma, KDE Usability and Andrew Lake.


Changes
---

Eike came up with this idea:
- No inset gradient, just a solid Rectangle
- Inverted text color
- A section "cut off" from the icon

The seemingly random 1.5 is a compromise between too much of a glow and too big 
of a moat


Bugs: 342112
https://bugs.kde.org/show_bug.cgi?id=342112


Repository: plasma-desktop


Description
---

As suggested by Andrew show a badge kind of thing with the number of running 
applets inside.


Diffs (updated)
-

  desktoppackage/contents/explorer/AppletDelegate.qml 2e53c1e 

Diff: https://git.reviewboard.kde.org/r/123539/diff/


Testing
---

After fixing a nasty bug in the model it shows the proper number now. It also 
doesn't break if you happen to have 10 or more widgets of the same kind. I did 
not know what kind of font color to use.


File Attachments (updated)


Badge in action
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/27/1b8483bb-fe3b-4701-92d3-02b437e63843__widgetexplorernumber2.jpg
Fancy effect in action
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/28/289d6677-bb68-4b69-a43a-3becf226ad3b__badgeshader2.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123539: Improve visibility of running widget checkmark

2015-04-28 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123539/#review79642
---


code looks good.


desktoppackage/contents/explorer/AppletDelegate.qml (line 101)


it's a bit odd that we have background colour on top of the text highlight 
colour.

Though AFAIk that combo is always garunteed to be visible.. so meh.



desktoppackage/contents/explorer/AppletDelegate.qml (line 119)


you can also add 

supportsAtlasTextures: true

as we're not tiling any of the sources.


- David Edmundson


On April 28, 2015, 6:34 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123539/
> ---
> 
> (Updated April 28, 2015, 6:34 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Andrew Lake.
> 
> 
> Bugs: 342112
> https://bugs.kde.org/show_bug.cgi?id=342112
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As suggested by Andrew show a badge kind of thing with the number of running 
> applets inside.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 2e53c1e 
> 
> Diff: https://git.reviewboard.kde.org/r/123539/diff/
> 
> 
> Testing
> ---
> 
> After fixing a nasty bug in the model it shows the proper number now. It also 
> doesn't break if you happen to have 10 or more widgets of the same kind. I 
> did not know what kind of font color to use.
> 
> 
> File Attachments
> 
> 
> Badge in action
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/27/1b8483bb-fe3b-4701-92d3-02b437e63843__widgetexplorernumber2.jpg
> Fancy effect in action
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/28/289d6677-bb68-4b69-a43a-3becf226ad3b__badgeshader2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123539: Improve visibility of running widget checkmark

2015-04-28 Thread Heiko Tietze 


> On April 27, 2015, 10:02 nachm., andreas kainz wrote:
> > colors maybe green and white as used in the mount symbol

Graphics should be theme aware. Please make sure badges are readable with 
Breeze Dark or Wonton Soup.


- Heiko


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123539/#review79609
---


On April 27, 2015, 9:35 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123539/
> ---
> 
> (Updated April 27, 2015, 9:35 nachm.)
> 
> 
> Review request for Plasma, KDE Usability and Andrew Lake.
> 
> 
> Bugs: 342112
> https://bugs.kde.org/show_bug.cgi?id=342112
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As suggested by Andrew show a badge kind of thing with the number of running 
> applets inside.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 2e53c1e 
>   desktoppackage/contents/explorer/WidgetExplorer.qml f164c18 
> 
> Diff: https://git.reviewboard.kde.org/r/123539/diff/
> 
> 
> Testing
> ---
> 
> After fixing a nasty bug in the model it shows the proper number now. It also 
> doesn't break if you happen to have 10 or more widgets of the same kind. I 
> did not know what kind of font color to use.
> 
> 
> File Attachments
> 
> 
> Badge in action
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/27/1b8483bb-fe3b-4701-92d3-02b437e63843__widgetexplorernumber2.jpg
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123539: Improve visibility of running widget checkmark

2015-04-28 Thread Andrew Lake 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123539/#review79628
---

Ship it!


Ship It!

- Andrew Lake


On April 27, 2015, 9:35 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123539/
> ---
> 
> (Updated April 27, 2015, 9:35 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Andrew Lake.
> 
> 
> Bugs: 342112
> https://bugs.kde.org/show_bug.cgi?id=342112
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As suggested by Andrew show a badge kind of thing with the number of running 
> applets inside.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 2e53c1e 
>   desktoppackage/contents/explorer/WidgetExplorer.qml f164c18 
> 
> Diff: https://git.reviewboard.kde.org/r/123539/diff/
> 
> 
> Testing
> ---
> 
> After fixing a nasty bug in the model it shows the proper number now. It also 
> doesn't break if you happen to have 10 or more widgets of the same kind. I 
> did not know what kind of font color to use.
> 
> 
> File Attachments
> 
> 
> Badge in action
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/27/1b8483bb-fe3b-4701-92d3-02b437e63843__widgetexplorernumber2.jpg
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123539: Improve visibility of running widget checkmark

2015-04-28 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123539/#review79626
---

Ship it!


Ship It!

- Marco Martin


On April 27, 2015, 9:35 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123539/
> ---
> 
> (Updated April 27, 2015, 9:35 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Andrew Lake.
> 
> 
> Bugs: 342112
> https://bugs.kde.org/show_bug.cgi?id=342112
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As suggested by Andrew show a badge kind of thing with the number of running 
> applets inside.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 2e53c1e 
>   desktoppackage/contents/explorer/WidgetExplorer.qml f164c18 
> 
> Diff: https://git.reviewboard.kde.org/r/123539/diff/
> 
> 
> Testing
> ---
> 
> After fixing a nasty bug in the model it shows the proper number now. It also 
> doesn't break if you happen to have 10 or more widgets of the same kind. I 
> did not know what kind of font color to use.
> 
> 
> File Attachments
> 
> 
> Badge in action
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/27/1b8483bb-fe3b-4701-92d3-02b437e63843__widgetexplorernumber2.jpg
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123539: Improve visibility of running widget checkmark

2015-04-27 Thread andreas kainz 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123539/#review79609
---


colors maybe green and white as used in the mount symbol

- andreas kainz


On April 27, 2015, 9:35 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123539/
> ---
> 
> (Updated April 27, 2015, 9:35 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Andrew Lake.
> 
> 
> Bugs: 342112
> https://bugs.kde.org/show_bug.cgi?id=342112
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As suggested by Andrew show a badge kind of thing with the number of running 
> applets inside.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 2e53c1e 
>   desktoppackage/contents/explorer/WidgetExplorer.qml f164c18 
> 
> Diff: https://git.reviewboard.kde.org/r/123539/diff/
> 
> 
> Testing
> ---
> 
> After fixing a nasty bug in the model it shows the proper number now. It also 
> doesn't break if you happen to have 10 or more widgets of the same kind. I 
> did not know what kind of font color to use.
> 
> 
> File Attachments
> 
> 
> Badge in action
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/27/1b8483bb-fe3b-4701-92d3-02b437e63843__widgetexplorernumber2.jpg
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 123539: Improve visibility of running widget checkmark

2015-04-27 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123539/
---

Review request for Plasma, KDE Usability and Andrew Lake.


Bugs: 342112
https://bugs.kde.org/show_bug.cgi?id=342112


Repository: plasma-desktop


Description
---

As suggested by Andrew show a badge kind of thing with the number of running 
applets inside.


Diffs
-

  desktoppackage/contents/explorer/AppletDelegate.qml 2e53c1e 
  desktoppackage/contents/explorer/WidgetExplorer.qml f164c18 

Diff: https://git.reviewboard.kde.org/r/123539/diff/


Testing
---

After fixing a nasty bug in the model it shows the proper number now. It also 
doesn't break if you happen to have 10 or more widgets of the same kind. I did 
not know what kind of font color to use.


File Attachments


Badge in action
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/04/27/1b8483bb-fe3b-4701-92d3-02b437e63843__widgetexplorernumber2.jpg


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel