Re: Review Request 123864: Extract messages from Modules/base into the catalog kcminfo

2015-05-21 Thread Burkhard Lück

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123864/
---

(Updated May 21, 2015, 1:29 p.m.)


Status
--

This change has been marked as submitted.


Review request for Localization and Translation (l10n) and Plasma.


Changes
---

Submitted with commit 8ed18417609ef64d1c4002913d9d8f5c36275bad by Burkhard Lück 
to branch Plasma/5.3.


Bugs: 347992
https://bugs.kde.org/show_bug.cgi?id=347992


Repository: kinfocenter


Description
---

Code from Modules/base is pulled into the library generated in Modules/info 
(see info/CMakeLists.txt)
so we need to do that for the translations as well

Patch has to be applied for 5.3 + master and the language catalogs have to be 
merged as well


Diffs
-

  Modules/base/Messages.sh db2becd 
  Modules/info/Messages.sh 2a6e35f 

Diff: https://git.reviewboard.kde.org/r/123864/diff/


Testing
---

Running KInfocenter in locale x-test with translation manually merged from 
catalog kcm_infobase into catalog kcminfo 
shows the prevoiusly untranslated string now translated in the GUI


Thanks,

Burkhard Lück

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 123864: Extract messages from Modules/base into the catalog kcminfo

2015-05-20 Thread Burkhard Lück

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123864/
---

Review request for Localization and Translation (l10n) and Plasma.


Bugs: 347992
https://bugs.kde.org/show_bug.cgi?id=347992


Repository: kinfocenter


Description
---

Code from Modules/base is pulled into the library generated in Modules/info 
(see info/CMakeLists.txt)
so we need to do that for the translations as well

Patch has to be applied for 5.3 + master and the language catalogs have to be 
merged as well


Diffs
-

  Modules/base/Messages.sh db2becd 
  Modules/info/Messages.sh 2a6e35f 

Diff: https://git.reviewboard.kde.org/r/123864/diff/


Testing
---

Running KInfocenter in locale x-test with translation manually merged from 
catalog kcm_infobase into catalog kcminfo 
shows the prevoiusly untranslated string now translated in the GUI


Thanks,

Burkhard Lück

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 123864: Extract messages from Modules/base into the catalog kcminfo

2015-05-20 Thread Lukáš Tinkl

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123864/#review80667
---

Ship it!


Ship It!

- Lukáš Tinkl


On Kvě. 20, 2015, 5:54 odp., Burkhard Lück wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123864/
 ---
 
 (Updated Kvě. 20, 2015, 5:54 odp.)
 
 
 Review request for Localization and Translation (l10n) and Plasma.
 
 
 Bugs: 347992
 https://bugs.kde.org/show_bug.cgi?id=347992
 
 
 Repository: kinfocenter
 
 
 Description
 ---
 
 Code from Modules/base is pulled into the library generated in Modules/info 
 (see info/CMakeLists.txt)
 so we need to do that for the translations as well
 
 Patch has to be applied for 5.3 + master and the language catalogs have to be 
 merged as well
 
 
 Diffs
 -
 
   Modules/base/Messages.sh db2becd 
   Modules/info/Messages.sh 2a6e35f 
 
 Diff: https://git.reviewboard.kde.org/r/123864/diff/
 
 
 Testing
 ---
 
 Running KInfocenter in locale x-test with translation manually merged from 
 catalog kcm_infobase into catalog kcminfo 
 shows the prevoiusly untranslated string now translated in the GUI
 
 
 Thanks,
 
 Burkhard Lück
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel