Re: Review Request 123877: [digital-clock] Bring back font family and color options
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/#review80767 --- In addition to the comments, just one nitpick: The first group header should be Font, not Appearance. - Thomas Pfeiffer On May 22, 2015, 9:05 a.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/ --- (Updated May 22, 2015, 9:05 a.m.) Review request for Plasma and KDE Usability. Bugs: 348072 https://bugs.kde.org/show_bug.cgi?id=348072 Repository: plasma-workspace Description --- This restores the custom font family and font color options; also clean ups the layout a bit - we don't have a FormLayout, so that's the best it can get. Did I mention dealing with ComboBox is horrible? Diffs - applets/digital-clock/package/contents/config/main.xml 5237160 applets/digital-clock/package/contents/ui/DigitalClock.qml a142d33 applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc Diff: https://git.reviewboard.kde.org/r/123877/diff/ Testing --- Checking and unchecking the custom color checkbox properly sets/unsets the color, the Default font option restores the default font, options in the dialog are properly restored when it opens, Apply button does not appear to have become broken. File Attachments The clock https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/1a6c37c2-5a11-4692-b658-241f2c3073af__uglyclock.png Settings https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/226b7028-69cf-4f6e-87db-2ba37ad3be29__uglyclock2.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123877: [digital-clock] Bring back font family and color options
On May 22, 2015, 2:14 a.m., Andrew Lake wrote: Just a couple observations: 1. I think it might be helpful to have a way to restore using the default font specified in the fonts kcm without having to explicitly know/set the font to match the default. A checkbox to enable/disable setting a custom font family as is done for the color might work. 2. Font style in the fonts kcm refers to face within a font family like weight (light, normal, bold, heavy) and emphasis (italic, oblique). So I think the label here should be Font not Font style for consistency. Hope this helps! Kai Uwe Broulik wrote: there is a Default entry at the top of the list which restores whatever font your plasma theme uses. I just took the font style from the Plasma 4 dialog but indeed it's wrong. I'd be for prepending the whole section with a checkbox custom font, so that if users decide later that they want the default look back, they can just uncheck it. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/#review80719 --- On May 22, 2015, 9:05 a.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/ --- (Updated May 22, 2015, 9:05 a.m.) Review request for Plasma and KDE Usability. Bugs: 348072 https://bugs.kde.org/show_bug.cgi?id=348072 Repository: plasma-workspace Description --- This restores the custom font family and font color options; also clean ups the layout a bit - we don't have a FormLayout, so that's the best it can get. Did I mention dealing with ComboBox is horrible? Diffs - applets/digital-clock/package/contents/config/main.xml 5237160 applets/digital-clock/package/contents/ui/DigitalClock.qml a142d33 applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc Diff: https://git.reviewboard.kde.org/r/123877/diff/ Testing --- Checking and unchecking the custom color checkbox properly sets/unsets the color, the Default font option restores the default font, options in the dialog are properly restored when it opens, Apply button does not appear to have become broken. File Attachments The clock https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/1a6c37c2-5a11-4692-b658-241f2c3073af__uglyclock.png Settings https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/226b7028-69cf-4f6e-87db-2ba37ad3be29__uglyclock2.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123877: [digital-clock] Bring back font family and color options
On May 22, 2015, 8:58 a.m., Martin Klapetek wrote: +1 to the font, but color...? Do we really want/need that option? Agreed. We should not add options if we're unsure of whether people actually want/need them. Simple by default, powerful _when needed_. Let's keep it out for now and wait for the wishlist reports. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/#review80726 --- On May 22, 2015, 9:05 a.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/ --- (Updated May 22, 2015, 9:05 a.m.) Review request for Plasma and KDE Usability. Bugs: 348072 https://bugs.kde.org/show_bug.cgi?id=348072 Repository: plasma-workspace Description --- This restores the custom font family and font color options; also clean ups the layout a bit - we don't have a FormLayout, so that's the best it can get. Did I mention dealing with ComboBox is horrible? Diffs - applets/digital-clock/package/contents/config/main.xml 5237160 applets/digital-clock/package/contents/ui/DigitalClock.qml a142d33 applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc Diff: https://git.reviewboard.kde.org/r/123877/diff/ Testing --- Checking and unchecking the custom color checkbox properly sets/unsets the color, the Default font option restores the default font, options in the dialog are properly restored when it opens, Apply button does not appear to have become broken. File Attachments The clock https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/1a6c37c2-5a11-4692-b658-241f2c3073af__uglyclock.png Settings https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/226b7028-69cf-4f6e-87db-2ba37ad3be29__uglyclock2.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123877: [digital-clock] Bring back font family and color options
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/#review80726 --- +1 to the font, but color...? Do we really want/need that option? - Martin Klapetek On May 21, 2015, 11:45 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/ --- (Updated May 21, 2015, 11:45 p.m.) Review request for Plasma. Bugs: 348072 https://bugs.kde.org/show_bug.cgi?id=348072 Repository: plasma-workspace Description --- This restores the custom font family and font color options; also clean ups the layout a bit - we don't have a FormLayout, so that's the best it can get. Did I mention dealing with ComboBox is horrible? Diffs - applets/digital-clock/package/contents/config/main.xml 5237160 applets/digital-clock/package/contents/ui/DigitalClock.qml a142d33 applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc Diff: https://git.reviewboard.kde.org/r/123877/diff/ Testing --- Checking and unchecking the custom color checkbox properly sets/unsets the color, the Default font option restores the default font, options in the dialog are properly restored when it opens, Apply button does not appear to have become broken. File Attachments The clock https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/1a6c37c2-5a11-4692-b658-241f2c3073af__uglyclock.png Settings https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/226b7028-69cf-4f6e-87db-2ba37ad3be29__uglyclock2.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123877: [digital-clock] Bring back font family and color options
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/ --- Review request for Plasma. Bugs: 348072 https://bugs.kde.org/show_bug.cgi?id=348072 Repository: plasma-workspace Description --- This restores the custom font family and font color options; also clean ups the layout a bit - we don't have a FormLayout, so that's the best it can get. Did I mention dealing with ComboBox is horrible? Diffs - applets/digital-clock/package/contents/config/main.xml 5237160 applets/digital-clock/package/contents/ui/DigitalClock.qml a142d33 applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc Diff: https://git.reviewboard.kde.org/r/123877/diff/ Testing --- Checking and unchecking the custom color checkbox properly sets/unsets the color, the Default font option restores the default font, options in the dialog are properly restored when it opens, Apply button does not appear to have become broken. File Attachments The clock https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/1a6c37c2-5a11-4692-b658-241f2c3073af__uglyclock.png Settings https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/226b7028-69cf-4f6e-87db-2ba37ad3be29__uglyclock2.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123877: [digital-clock] Bring back font family and color options
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/#review80719 --- Just a couple observations: 1. I think it might be helpful to have a way to restore using the default font specified in the fonts kcm without having to explicitly know/set the font to match the default. A checkbox to enable/disable setting a custom font family as is done for the color might work. 2. Font style in the fonts kcm refers to face within a font family like weight (light, normal, bold, heavy) and emphasis (italic, oblique). So I think the label here should be Font not Font style for consistency. Hope this helps! - Andrew Lake On May 21, 2015, 9:45 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/ --- (Updated May 21, 2015, 9:45 p.m.) Review request for Plasma. Bugs: 348072 https://bugs.kde.org/show_bug.cgi?id=348072 Repository: plasma-workspace Description --- This restores the custom font family and font color options; also clean ups the layout a bit - we don't have a FormLayout, so that's the best it can get. Did I mention dealing with ComboBox is horrible? Diffs - applets/digital-clock/package/contents/config/main.xml 5237160 applets/digital-clock/package/contents/ui/DigitalClock.qml a142d33 applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc Diff: https://git.reviewboard.kde.org/r/123877/diff/ Testing --- Checking and unchecking the custom color checkbox properly sets/unsets the color, the Default font option restores the default font, options in the dialog are properly restored when it opens, Apply button does not appear to have become broken. File Attachments The clock https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/1a6c37c2-5a11-4692-b658-241f2c3073af__uglyclock.png Settings https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/226b7028-69cf-4f6e-87db-2ba37ad3be29__uglyclock2.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123877: [digital-clock] Bring back font family and color options
On Mai 22, 2015, 2:14 vorm., Andrew Lake wrote: Just a couple observations: 1. I think it might be helpful to have a way to restore using the default font specified in the fonts kcm without having to explicitly know/set the font to match the default. A checkbox to enable/disable setting a custom font family as is done for the color might work. 2. Font style in the fonts kcm refers to face within a font family like weight (light, normal, bold, heavy) and emphasis (italic, oblique). So I think the label here should be Font not Font style for consistency. Hope this helps! there is a Default entry at the top of the list which restores whatever font your plasma theme uses. I just took the font style from the Plasma 4 dialog but indeed it's wrong. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/#review80719 --- On Mai 21, 2015, 9:45 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/ --- (Updated Mai 21, 2015, 9:45 nachm.) Review request for Plasma. Bugs: 348072 https://bugs.kde.org/show_bug.cgi?id=348072 Repository: plasma-workspace Description --- This restores the custom font family and font color options; also clean ups the layout a bit - we don't have a FormLayout, so that's the best it can get. Did I mention dealing with ComboBox is horrible? Diffs - applets/digital-clock/package/contents/config/main.xml 5237160 applets/digital-clock/package/contents/ui/DigitalClock.qml a142d33 applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc Diff: https://git.reviewboard.kde.org/r/123877/diff/ Testing --- Checking and unchecking the custom color checkbox properly sets/unsets the color, the Default font option restores the default font, options in the dialog are properly restored when it opens, Apply button does not appear to have become broken. File Attachments The clock https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/1a6c37c2-5a11-4692-b658-241f2c3073af__uglyclock.png Settings https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/226b7028-69cf-4f6e-87db-2ba37ad3be29__uglyclock2.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
