Re: Review Request 123926: Unbreak Undo notifications on Plasma delete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123926/ --- (Updated May 29, 2015, 7:30 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 6b3900767b6c97916e0e82dd8aa8fa8029ca7616 by Martin Klapetek to branch Plasma/5.3. Repository: plasma-workspace Description --- Somewhere somewhen the applicationDisplayName() got changed to Plasma for plasmashell and that broke the undo notifications if you undo twice in a row. Diffs - dataengines/notifications/notificationsengine.cpp 509f349 Diff: https://git.reviewboard.kde.org/r/123926/diff/ Testing --- Now I get two separate Undo notifications. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123926: Unbreak Undo notifications on Plasma delete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123926/#review80934 --- Ship it! Ship It! - Marco Martin On May 28, 2015, 3:50 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123926/ --- (Updated May 28, 2015, 3:50 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Somewhere somewhen the applicationDisplayName() got changed to Plasma for plasmashell and that broke the undo notifications if you undo twice in a row. Diffs - dataengines/notifications/notificationsengine.cpp 509f349 Diff: https://git.reviewboard.kde.org/r/123926/diff/ Testing --- Now I get two separate Undo notifications. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123926: Unbreak Undo notifications on Plasma delete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123926/ --- Review request for Plasma. Repository: plasma-workspace Description --- Somewhere somewhen the applicationDisplayName() got changed to Plasma for plasmashell and that broke the undo notifications if you undo twice in a row. Diffs - dataengines/notifications/notificationsengine.cpp 509f349 Diff: https://git.reviewboard.kde.org/r/123926/diff/ Testing --- Now I get two separate Undo notifications. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123926: Unbreak Undo notifications on Plasma delete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123926/#review80931 --- Ship it! Ship It! - Bhushan Shah On May 28, 2015, 9:20 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123926/ --- (Updated May 28, 2015, 9:20 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Somewhere somewhen the applicationDisplayName() got changed to Plasma for plasmashell and that broke the undo notifications if you undo twice in a row. Diffs - dataengines/notifications/notificationsengine.cpp 509f349 Diff: https://git.reviewboard.kde.org/r/123926/diff/ Testing --- Now I get two separate Undo notifications. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123926: Unbreak Undo notifications on Plasma delete
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123926/#review80932 --- Ship it! dataengines/notifications/notificationsengine.cpp (line 157) https://git.reviewboard.kde.org/r/123926/#comment55451 QStringLiteral() ? - Lukáš Tinkl On Kvě. 28, 2015, 5:50 odp., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123926/ --- (Updated Kvě. 28, 2015, 5:50 odp.) Review request for Plasma. Repository: plasma-workspace Description --- Somewhere somewhen the applicationDisplayName() got changed to Plasma for plasmashell and that broke the undo notifications if you undo twice in a row. Diffs - dataengines/notifications/notificationsengine.cpp 509f349 Diff: https://git.reviewboard.kde.org/r/123926/diff/ Testing --- Now I get two separate Undo notifications. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123926: Unbreak Undo notifications on Plasma delete
On May 28, 2015, 5:52 p.m., Lukáš Tinkl wrote: dataengines/notifications/notificationsengine.cpp, line 157 https://git.reviewboard.kde.org/r/123926/diff/1/?file=378269#file378269line157 QStringLiteral() ? Nah, QLatin1String is faster for comparisons (and enough for comparisons). - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123926/#review80932 --- On May 28, 2015, 5:50 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123926/ --- (Updated May 28, 2015, 5:50 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Somewhere somewhen the applicationDisplayName() got changed to Plasma for plasmashell and that broke the undo notifications if you undo twice in a row. Diffs - dataengines/notifications/notificationsengine.cpp 509f349 Diff: https://git.reviewboard.kde.org/r/123926/diff/ Testing --- Now I get two separate Undo notifications. Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
