Re: Review Request 123999: Don't crash in XRandrBrightness if not on xcb
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123999/#review81161 --- Ship it! Ship It! - Lukáš Tinkl On Čer. 4, 2015, 1:08 dop., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123999/ --- (Updated Čer. 4, 2015, 1:08 dop.) Review request for Plasma, Solid and Kai Uwe Broulik. Repository: powerdevil Description --- On e.g. platform wayland XRandrBrightness shouldn't do anything. By skipping the initialization the isSupported returns false. Diffs - daemon/backends/upower/xrandrbrightness.cpp f1cd5a5a0958e72aea87bfda88642faaa696f850 Diff: https://git.reviewboard.kde.org/r/123999/diff/ Testing --- kded5 no longer crashes when initializing powerdevil when running with platform wayland. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123999: Don't crash in XRandrBrightness if not on xcb
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123999/#review81154 --- Looks good to me. I'll leave the honours to Kai Uwe. - Sebastian Kügler On June 3, 2015, 11:08 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123999/ --- (Updated June 3, 2015, 11:08 p.m.) Review request for Plasma, Solid and Kai Uwe Broulik. Repository: powerdevil Description --- On e.g. platform wayland XRandrBrightness shouldn't do anything. By skipping the initialization the isSupported returns false. Diffs - daemon/backends/upower/xrandrbrightness.cpp f1cd5a5a0958e72aea87bfda88642faaa696f850 Diff: https://git.reviewboard.kde.org/r/123999/diff/ Testing --- kded5 no longer crashes when initializing powerdevil when running with platform wayland. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel