Re: Review Request 124269: [kcms/access] Do nothing on non X11 platforms
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124269/ --- (Updated July 7, 2015, 11:42 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit da9836e4dc6a59c720af878066f793a0ff0fd881 by Martin Gräßlin to branch master. Repository: plasma-desktop Description --- Code base is very X11 dependent and crashes on other platforms. Checks whether it's not X11 and quits. Diffs - kcms/access/kaccess.h b39558e9d5343f10204f54e9d3ff8760f803ac09 kcms/access/kaccess.cpp 4d57824f6025ccdc1e47dfbfcb0973925307bd71 kcms/access/main.cpp a4590bf135bd00eb34fca74753d43f89cabe017a Diff: https://git.reviewboard.kde.org/r/124269/diff/ Testing --- No longer crashes on Wayland Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124269: [kcms/access] Do nothing on non X11 platforms
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124269/ --- Review request for Plasma. Repository: plasma-desktop Description --- Code base is very X11 dependent and crashes on other platforms. Checks whether it's not X11 and quits. Diffs - kcms/access/kaccess.h b39558e9d5343f10204f54e9d3ff8760f803ac09 kcms/access/kaccess.cpp 4d57824f6025ccdc1e47dfbfcb0973925307bd71 kcms/access/main.cpp a4590bf135bd00eb34fca74753d43f89cabe017a Diff: https://git.reviewboard.kde.org/r/124269/diff/ Testing --- No longer crashes on Wayland Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124269: [kcms/access] Do nothing on non X11 platforms
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124269/#review82119 --- kcms/access/kaccess.cpp (line 147) https://git.reviewboard.kde.org/r/124269/#comment56426 Initialize with the rest of the members on line 145? /me deeply ignores what kaccess is. - Aleix Pol Gonzalez On July 6, 2015, 1:52 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124269/ --- (Updated July 6, 2015, 1:52 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- Code base is very X11 dependent and crashes on other platforms. Checks whether it's not X11 and quits. Diffs - kcms/access/kaccess.h b39558e9d5343f10204f54e9d3ff8760f803ac09 kcms/access/kaccess.cpp 4d57824f6025ccdc1e47dfbfcb0973925307bd71 kcms/access/main.cpp a4590bf135bd00eb34fca74753d43f89cabe017a Diff: https://git.reviewboard.kde.org/r/124269/diff/ Testing --- No longer crashes on Wayland Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
