Re: Review Request 124283: Update kcmstyle docbook to Plasma 5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124283/ --- (Updated July 12, 2015, 2:51 p.m.) Status -- This change has been marked as submitted. Review request for Documentation and Plasma. Changes --- Submitted with commit 87d53433b511a0bab0f9ad2161e42546f356f70f by Burkhard Lück to branch master. Repository: plasma-desktop Description --- see Summary appmenu commented in docbook, because it is not available in Plasma 5, is this correct? Diffs - doc/kcontrol/kcmstyle/index.docbook a0b456b Diff: https://git.reviewboard.kde.org/r/124283/diff/ Testing --- builds Thanks, Burkhard Lück ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124283: Update kcmstyle docbook to Plasma 5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124283/#review82242 --- any comment from docbook team? - Burkhard Lück On Juli 7, 2015, 4:47 nachm., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124283/ --- (Updated Juli 7, 2015, 4:47 nachm.) Review request for Documentation and Plasma. Repository: plasma-desktop Description --- see Summary appmenu commented in docbook, because it is not available in Plasma 5, is this correct? Diffs - doc/kcontrol/kcmstyle/index.docbook a0b456b Diff: https://git.reviewboard.kde.org/r/124283/diff/ Testing --- builds Thanks, Burkhard Lück ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124283: Update kcmstyle docbook to Plasma 5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124283/#review82245 --- Ship it! Not sure about the fate of appmenu as we still depend on dbusmenu, but maybe it's just not implemented there. If sebas says it's fine, then I'm fine. I'm fine with committing as it is, but do we have an entity for plasma; ? - Luigi Toscano On Lug. 7, 2015, 6:47 p.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124283/ --- (Updated Lug. 7, 2015, 6:47 p.m.) Review request for Documentation and Plasma. Repository: plasma-desktop Description --- see Summary appmenu commented in docbook, because it is not available in Plasma 5, is this correct? Diffs - doc/kcontrol/kcmstyle/index.docbook a0b456b Diff: https://git.reviewboard.kde.org/r/124283/diff/ Testing --- builds Thanks, Burkhard Lück ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124283: Update kcmstyle docbook to Plasma 5
On Juli 8, 2015, 9:52 nachm., Luigi Toscano wrote: Not sure about the fate of appmenu as we still depend on dbusmenu, but maybe it's just not implemented there. If sebas says it's fine, then I'm fine. I'm fine with committing as it is, but do we have an entity for plasma; ? fate of appmenu: https://forum.kde.org/viewtopic.php?f=285t=125058p=336313hilit=appmenu#p336313 https://bugs.kde.org/show_bug.cgi?id=341071#c9 I can add this info to the commented varlistentry Menubar Style Yes we should have an entity plasma; but what is the proper markup? - Burkhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124283/#review82245 --- On Juli 7, 2015, 4:47 nachm., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124283/ --- (Updated Juli 7, 2015, 4:47 nachm.) Review request for Documentation and Plasma. Repository: plasma-desktop Description --- see Summary appmenu commented in docbook, because it is not available in Plasma 5, is this correct? Diffs - doc/kcontrol/kcmstyle/index.docbook a0b456b Diff: https://git.reviewboard.kde.org/r/124283/diff/ Testing --- builds Thanks, Burkhard Lück ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124283: Update kcmstyle docbook to Plasma 5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124283/#review82188 --- Ship it! Ship It! - Sebastian Kügler On July 7, 2015, 4:47 p.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124283/ --- (Updated July 7, 2015, 4:47 p.m.) Review request for Documentation and Plasma. Repository: plasma-desktop Description --- see Summary appmenu commented in docbook, because it is not available in Plasma 5, is this correct? Diffs - doc/kcontrol/kcmstyle/index.docbook a0b456b Diff: https://git.reviewboard.kde.org/r/124283/diff/ Testing --- builds Thanks, Burkhard Lück ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124283: Update kcmstyle docbook to Plasma 5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124283/ --- Review request for Documentation and Plasma. Repository: plasma-desktop Description --- see Summary appmenu commented in docbook, because it is not available in Plasma 5, is this correct? Diffs - doc/kcontrol/kcmstyle/index.docbook a0b456b Diff: https://git.reviewboard.kde.org/r/124283/diff/ Testing --- builds Thanks, Burkhard Lück ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
