Re: Review Request 124374: custom inline edit menu for plasma controls

2015-09-02 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124374/#review84743
---


+1

A few style nitpicks I didn't explicitly mention below (spaces at /2 and stuff)


src/declarativeimports/plasmastyle/CursorDelegate.qml (line 2)


;)



src/declarativeimports/plasmastyle/CursorDelegate.qml (line 64)


Remove



src/declarativeimports/plasmastyle/EditMenuTouch.qml (line 53)


Why do you change the Z? it becomes invisible anyway



src/declarativeimports/plasmastyle/EditMenuTouch.qml (line 62)


Imho it's cleaner if we just have a floating paste button if you cannot 
copy/paste but that's up to the designers I guess, though a word will always be 
selected when we bring up the menu? There's no "tap, wait, paste" feature?



src/declarativeimports/plasmastyle/EditMenuTouch.qml (line 64)


control.cut() and co? makes it more explicit


- Kai Uwe Broulik


On Sept. 1, 2015, 12:14 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124374/
> ---
> 
> (Updated Sept. 1, 2015, 12:14 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This depends from https://codereview.qt-project.org/#/c/121659/
> provides the needed elements for touch based text selection and inline (no 
> separate window) menu for cut/copy/paste
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmastyle/CursorDelegate.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 
>   src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 
> 
> Diff: https://git.reviewboard.kde.org/r/124374/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot1.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124374: custom inline edit menu for plasma controls

2015-09-02 Thread Marco Martin 


> On Sept. 2, 2015, 9:15 a.m., Kai Uwe Broulik wrote:
> > src/declarativeimports/plasmastyle/EditMenuTouch.qml, line 62
> > 
> >
> > Imho it's cleaner if we just have a floating paste button if you cannot 
> > copy/paste but that's up to the designers I guess, though a word will 
> > always be selected when we bring up the menu? There's no "tap, wait, paste" 
> > feature?

a simple tap just moves the cursor and opens the menu, without selecting.
a long press selects the word


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124374/#review84743
---


On Sept. 1, 2015, 12:14 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124374/
> ---
> 
> (Updated Sept. 1, 2015, 12:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This depends from https://codereview.qt-project.org/#/c/121659/
> provides the needed elements for touch based text selection and inline (no 
> separate window) menu for cut/copy/paste
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmastyle/CursorDelegate.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 
>   src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 
> 
> Diff: https://git.reviewboard.kde.org/r/124374/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot1.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124374: custom inline edit menu for plasma controls

2015-09-02 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124374/#review84746
---

Ship it!


Ship It!

- Kai Uwe Broulik


On Sept. 2, 2015, 9:45 vorm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124374/
> ---
> 
> (Updated Sept. 2, 2015, 9:45 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This depends from https://codereview.qt-project.org/#/c/121659/
> provides the needed elements for touch based text selection and inline (no 
> separate window) menu for cut/copy/paste
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmastyle/CursorDelegate.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 
>   src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 
> 
> Diff: https://git.reviewboard.kde.org/r/124374/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot1.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124374: custom inline edit menu for plasma controls

2015-09-02 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124374/
---

(Updated Sept. 2, 2015, 9:45 a.m.)


Review request for Plasma.


Repository: plasma-framework


Description
---

This depends from https://codereview.qt-project.org/#/c/121659/
provides the needed elements for touch based text selection and inline (no 
separate window) menu for cut/copy/paste


Diffs (updated)
-

  src/declarativeimports/plasmastyle/CursorDelegate.qml PRE-CREATION 
  src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION 
  src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION 
  src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION 
  src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 
  src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 

Diff: https://git.reviewboard.kde.org/r/124374/diff/


Testing
---


File Attachments


snapshot1.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124374: custom inline edit menu for plasma controls

2015-09-02 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124374/
---

(Updated Sept. 2, 2015, 9:58 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 573d2985ba61dba6a73a79840b87b54f0f63b282 by Marco Martin 
to branch master.


Repository: plasma-framework


Description
---

This depends from https://codereview.qt-project.org/#/c/121659/
provides the needed elements for touch based text selection and inline (no 
separate window) menu for cut/copy/paste


Diffs
-

  src/declarativeimports/plasmastyle/CursorDelegate.qml PRE-CREATION 
  src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION 
  src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION 
  src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION 
  src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 
  src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 

Diff: https://git.reviewboard.kde.org/r/124374/diff/


Testing
---


File Attachments


snapshot1.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124374: custom inline edit menu for plasma controls

2015-09-01 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124374/
---

(Updated Sept. 1, 2015, 12:14 p.m.)


Review request for Plasma.


Repository: plasma-framework


Description
---

This depends from https://codereview.qt-project.org/#/c/121659/
provides the needed elements for touch based text selection and inline (no 
separate window) menu for cut/copy/paste


Diffs (updated)
-

  src/declarativeimports/plasmastyle/CursorDelegate.qml PRE-CREATION 
  src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION 
  src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION 
  src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION 
  src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 
  src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 

Diff: https://git.reviewboard.kde.org/r/124374/diff/


Testing
---


File Attachments


snapshot1.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124374: custom inline edit menu for plasma controls

2015-07-21 Thread Marco Martin 


 On July 21, 2015, 4:20 p.m., Andrew Lake wrote:
  Very nice. A couple questions:
  1. Are the inline selectiion handles grab-able? I assume yes.
  2. Does this automatically appear when a selection is made or on 
  right-click? I assume the former.
  
  It would eventually be nice to have this solution for main application 
  controls as well (or at least QtQuick controls)
  
  Anyway, quite nice.

It's purely for touchscreen interfaces, on a desktop system none of this would 
appear/have effect: the menu would be a normal qmenu and only appear on right 
click.
so the blue things are draggable. The thing is supported by qtquickcontrols out 
of the box, but is style-dependent and the upstream qstyle based style doesn't 
support it


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124374/#review82771
---


On July 21, 2015, 9:35 a.m., Marco Martin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124374/
 ---
 
 (Updated July 21, 2015, 9:35 a.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-framework
 
 
 Description
 ---
 
 This depends from https://codereview.qt-project.org/#/c/121659/
 provides the needed elements for touch based text selection and inline (no 
 separate window) menu for cut/copy/paste
 
 
 Diffs
 -
 
   src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION 
   src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION 
   src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION 
   src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 
   src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 
 
 Diff: https://git.reviewboard.kde.org/r/124374/diff/
 
 
 Testing
 ---
 
 
 File Attachments
 
 
 snapshot1.png
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png
 
 
 Thanks,
 
 Marco Martin
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124374: custom inline edit menu for plasma controls

2015-07-21 Thread Andrew Lake 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124374/#review82771
---


Very nice. A couple questions:
1. Are the inline selectiion handles grab-able? I assume yes.
2. Does this automatically appear when a selection is made or on right-click? I 
assume the former.

It would eventually be nice to have this solution for main application controls 
as well (or at least QtQuick controls)

Anyway, quite nice.

- Andrew Lake


On July 21, 2015, 9:35 a.m., Marco Martin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124374/
 ---
 
 (Updated July 21, 2015, 9:35 a.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-framework
 
 
 Description
 ---
 
 This depends from https://codereview.qt-project.org/#/c/121659/
 provides the needed elements for touch based text selection and inline (no 
 separate window) menu for cut/copy/paste
 
 
 Diffs
 -
 
   src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION 
   src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION 
   src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION 
   src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 
   src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 
 
 Diff: https://git.reviewboard.kde.org/r/124374/diff/
 
 
 Testing
 ---
 
 
 File Attachments
 
 
 snapshot1.png
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png
 
 
 Thanks,
 
 Marco Martin
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124374: custom inline edit menu for plasma controls

2015-07-21 Thread Andrew Lake 


 On July 21, 2015, 4:20 p.m., Andrew Lake wrote:
  Very nice. A couple questions:
  1. Are the inline selectiion handles grab-able? I assume yes.
  2. Does this automatically appear when a selection is made or on 
  right-click? I assume the former.
  
  It would eventually be nice to have this solution for main application 
  controls as well (or at least QtQuick controls)
  
  Anyway, quite nice.
 
 Marco Martin wrote:
 It's purely for touchscreen interfaces, on a desktop system none of this 
 would appear/have effect: the menu would be a normal qmenu and only appear on 
 right click.
 so the blue things are draggable. The thing is supported by 
 qtquickcontrols out of the box, but is style-dependent and the upstream 
 qstyle based style doesn't support it

Very cool, thanks.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124374/#review82771
---


On July 21, 2015, 9:35 a.m., Marco Martin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124374/
 ---
 
 (Updated July 21, 2015, 9:35 a.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-framework
 
 
 Description
 ---
 
 This depends from https://codereview.qt-project.org/#/c/121659/
 provides the needed elements for touch based text selection and inline (no 
 separate window) menu for cut/copy/paste
 
 
 Diffs
 -
 
   src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION 
   src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION 
   src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION 
   src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 
   src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 
 
 Diff: https://git.reviewboard.kde.org/r/124374/diff/
 
 
 Testing
 ---
 
 
 File Attachments
 
 
 snapshot1.png
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png
 
 
 Thanks,
 
 Marco Martin
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124374: custom inline edit menu for plasma controls

2015-07-21 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124374/
---

(Updated July 21, 2015, 9:35 a.m.)


Review request for Plasma.


Repository: plasma-framework


Description
---

This depends from https://codereview.qt-project.org/#/c/121659/
provides the needed elements for touch based text selection and inline (no 
separate window) menu for cut/copy/paste


Diffs (updated)
-

  src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION 
  src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION 
  src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION 
  src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 
  src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 

Diff: https://git.reviewboard.kde.org/r/124374/diff/


Testing
---


File Attachments


snapshot1.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 124374: custom inline edit menu for plasma controls

2015-07-16 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124374/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

This depends from https://codereview.qt-project.org/#/c/121659/
provides the needed elements for touch based text selection and inline (no 
separate window) menu for cut/copy/paste


Diffs
-

  src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION 
  src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION 
  src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION 
  src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 
  src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 

Diff: https://git.reviewboard.kde.org/r/124374/diff/


Testing
---


File Attachments


snapshot1.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124374: custom inline edit menu for plasma controls

2015-07-16 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124374/#review82573
---



src/declarativeimports/plasmastyle/EditMenuTouch.qml (line 40)
https://git.reviewboard.kde.org/r/124374/#comment56949

Urgh, can't you assign that at the end? Repeatedly changing the parent 
sounds dangerous



src/declarativeimports/plasmastyle/EditMenuTouch.qml (line 59)
https://git.reviewboard.kde.org/r/124374/#comment56946

enabled / visible only when there is a selection



src/declarativeimports/plasmastyle/EditMenuTouch.qml (line 75)
https://git.reviewboard.kde.org/r/124374/#comment56947

enabled: control.canPaste



src/declarativeimports/plasmastyle/EditMenuTouch.qml (line 104)
https://git.reviewboard.kde.org/r/124374/#comment56948

unused



src/declarativeimports/plasmastyle/SelectionHandleStyle.qml (line 33)
https://git.reviewboard.kde.org/r/124374/#comment56950

Oh the wonders of QtQuick Rectangle which cannot to different corner radii


- Kai Uwe Broulik


On Juli 16, 2015, 1:57 nachm., Marco Martin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124374/
 ---
 
 (Updated Juli 16, 2015, 1:57 nachm.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-framework
 
 
 Description
 ---
 
 This depends from https://codereview.qt-project.org/#/c/121659/
 provides the needed elements for touch based text selection and inline (no 
 separate window) menu for cut/copy/paste
 
 
 Diffs
 -
 
   src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION 
   src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION 
   src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION 
   src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 
   src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 
 
 Diff: https://git.reviewboard.kde.org/r/124374/diff/
 
 
 Testing
 ---
 
 
 File Attachments
 
 
 snapshot1.png
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png
 
 
 Thanks,
 
 Marco Martin
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel