Re: Review Request 124694: Drop build option KWIN_PLASMA_ACTIVE

2015-08-11 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124694/
---

(Updated Aug. 11, 2015, 11:22 a.m.)


Status
--

This change has been marked as submitted.


Review request for kwin and Plasma.


Changes
---

Submitted with commit 2635243650f88322e5bfd124859cdc622c619fc0 by Martin 
Gräßlin to branch master.


Repository: kwin


Description
---

The build option wasn't used for 5.x at all and in this way doesn't make
any sense nowadays. We want to have a converged desktop which also means
that the window manager should be able to switch to a different form
factor with a full feature set (plug in external screen to smartphone and
it should be full desktop). A trimmed down KWin with compiled out
functionality cannot do that. Also the need for trimmed down KWin becomes
less and less important given the improved hardware we target nowadays.

This change got triggered by the announcement to close down the Plasma
Active mailinglist [1], which shows that having a build option called
Plasma Active is no longer needed.

[1] http://permalink.gmane.org/gmane.comp.kde.devel.active/4343


Diffs
-

  CMakeLists.txt 4d2aeed4f5ee9d0765e1b902ac51859e0ae1150b 

Diff: https://git.reviewboard.kde.org/r/124694/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 124694: Drop build option KWIN_PLASMA_ACTIVE

2015-08-11 Thread Sebastian Kügler

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124694/#review83700
---

Ship it!


Ship It!

- Sebastian Kügler


On Aug. 11, 2015, 6:52 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124694/
> ---
> 
> (Updated Aug. 11, 2015, 6:52 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> The build option wasn't used for 5.x at all and in this way doesn't make
> any sense nowadays. We want to have a converged desktop which also means
> that the window manager should be able to switch to a different form
> factor with a full feature set (plug in external screen to smartphone and
> it should be full desktop). A trimmed down KWin with compiled out
> functionality cannot do that. Also the need for trimmed down KWin becomes
> less and less important given the improved hardware we target nowadays.
> 
> This change got triggered by the announcement to close down the Plasma
> Active mailinglist [1], which shows that having a build option called
> Plasma Active is no longer needed.
> 
> [1] http://permalink.gmane.org/gmane.comp.kde.devel.active/4343
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 4d2aeed4f5ee9d0765e1b902ac51859e0ae1150b 
> 
> Diff: https://git.reviewboard.kde.org/r/124694/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 124694: Drop build option KWIN_PLASMA_ACTIVE

2015-08-11 Thread Thomas Lübking

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124694/#review83692
---

Ship it!


and, most important, you can still turn off the parts by hand (if you've 
special usecases for kwin outside plasma, ie. lxqt etc.)

- Thomas Lübking


On Aug. 11, 2015, 6:52 vorm., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124694/
> ---
> 
> (Updated Aug. 11, 2015, 6:52 vorm.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> The build option wasn't used for 5.x at all and in this way doesn't make
> any sense nowadays. We want to have a converged desktop which also means
> that the window manager should be able to switch to a different form
> factor with a full feature set (plug in external screen to smartphone and
> it should be full desktop). A trimmed down KWin with compiled out
> functionality cannot do that. Also the need for trimmed down KWin becomes
> less and less important given the improved hardware we target nowadays.
> 
> This change got triggered by the announcement to close down the Plasma
> Active mailinglist [1], which shows that having a build option called
> Plasma Active is no longer needed.
> 
> [1] http://permalink.gmane.org/gmane.comp.kde.devel.active/4343
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 4d2aeed4f5ee9d0765e1b902ac51859e0ae1150b 
> 
> Diff: https://git.reviewboard.kde.org/r/124694/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 124694: Drop build option KWIN_PLASMA_ACTIVE

2015-08-10 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124694/
---

Review request for kwin and Plasma.


Repository: kwin


Description
---

The build option wasn't used for 5.x at all and in this way doesn't make
any sense nowadays. We want to have a converged desktop which also means
that the window manager should be able to switch to a different form
factor with a full feature set (plug in external screen to smartphone and
it should be full desktop). A trimmed down KWin with compiled out
functionality cannot do that. Also the need for trimmed down KWin becomes
less and less important given the improved hardware we target nowadays.

This change got triggered by the announcement to close down the Plasma
Active mailinglist [1], which shows that having a build option called
Plasma Active is no longer needed.

[1] http://permalink.gmane.org/gmane.comp.kde.devel.active/4343


Diffs
-

  CMakeLists.txt 4d2aeed4f5ee9d0765e1b902ac51859e0ae1150b 

Diff: https://git.reviewboard.kde.org/r/124694/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel