Re: Review Request 124702: Set component display name for all actions
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124702/ --- (Updated Aug. 12, 2015, 7:09 a.m.) Status -- This change has been marked as submitted. Review request for Plasma and Martin Gräßlin. Changes --- Submitted with commit f22611c6304221d0244fe0114720accbfc0ec2c9 by Jan Grulich to branch master. Repository: plasma-desktop Description --- Each action needs component display name to be set, otherwise it's always empty and the application display name is used as fallback (introduced in https://git.reviewboard.kde.org/r/124208). Using fallback leads to broken KCM for keyboard shortcuts (see https://git.reviewboard.kde.org/r/124208/#review83642). Diffs - kcms/keys/kglobalshortcutseditor.cpp 553b10d Diff: https://git.reviewboard.kde.org/r/124702/diff/ Testing --- Thanks, Jan Grulich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124702: Set component display name for all actions
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124702/#review83721 --- As the review is for master: please remember that this must go intp 5.4! And thanks for fixing it, I'll do now the same for all KWin Effects KCMs :-( - Martin Gräßlin On Aug. 11, 2015, 10:56 p.m., Jan Grulich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124702/ --- (Updated Aug. 11, 2015, 10:56 p.m.) Review request for Plasma and Martin Gräßlin. Repository: plasma-desktop Description --- Each action needs component display name to be set, otherwise it's always empty and the application display name is used as fallback (introduced in https://git.reviewboard.kde.org/r/124208). Using fallback leads to broken KCM for keyboard shortcuts (see https://git.reviewboard.kde.org/r/124208/#review83642). Diffs - kcms/keys/kglobalshortcutseditor.cpp 553b10d Diff: https://git.reviewboard.kde.org/r/124702/diff/ Testing --- Thanks, Jan Grulich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124702: Set component display name for all actions
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124702/ --- Review request for Plasma and Martin Gräßlin. Repository: plasma-desktop Description --- Each action needs component display name to be set, otherwise it's always empty and the application display name is used as fallback (introduced in https://git.reviewboard.kde.org/r/124208). Using fallback leads to broken KCM for keyboard shortcuts (see https://git.reviewboard.kde.org/r/124208/#review83642). Diffs - kcms/keys/kglobalshortcutseditor.cpp 553b10d Diff: https://git.reviewboard.kde.org/r/124702/diff/ Testing --- Thanks, Jan Grulich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124702: Set component display name for all actions
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124702/#review83718 --- Ship it! Ship It! - David Edmundson On Aug. 11, 2015, 8:56 p.m., Jan Grulich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124702/ --- (Updated Aug. 11, 2015, 8:56 p.m.) Review request for Plasma and Martin Gräßlin. Repository: plasma-desktop Description --- Each action needs component display name to be set, otherwise it's always empty and the application display name is used as fallback (introduced in https://git.reviewboard.kde.org/r/124208). Using fallback leads to broken KCM for keyboard shortcuts (see https://git.reviewboard.kde.org/r/124208/#review83642). Diffs - kcms/keys/kglobalshortcutseditor.cpp 553b10d Diff: https://git.reviewboard.kde.org/r/124702/diff/ Testing --- Thanks, Jan Grulich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
