Review Request 124734: [client] Extend Registry by providing name and version of announced interfaces

2015-08-14 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124734/
---

Review request for Plasma and Sebastian Kügler.


Repository: kwayland


Description
---

This change addresses the sometimes cumbersome to use API of Registry.
So far to bind an interface one needed to connect to the signals when
setting up the registry. There was no other way to get the name and
version at a later point. This made it difficult to use one Registry
in different parts of an Wayland application.

This change adds a convenient:
QPair interface(Interface) const
QVector> interfaces(Interface) const

The first one is meant for interfaces like wl_shm which is normally only
announced once. The latter one is meant for interfaces like wl_output
for which normally multiple interfaces can get announced.

Those methods can be used without having to connect to the announced
spy.


Diffs
-

  autotests/client/test_wayland_registry.cpp 
d3f6863f4173eab2b497391070bc6cc3f966ce1d 
  src/client/registry.h 572ddeaa2588cb46a6c3d1dd4c1084479851daee 
  src/client/registry.cpp e6d237b4bfd2fe8299ab35f283086fcf38daaf79 

Diff: https://git.reviewboard.kde.org/r/124734/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 124734: [client] Extend Registry by providing name and version of announced interfaces

2015-08-16 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124734/
---

(Updated Aug. 17, 2015, 8:28 a.m.)


Review request for Plasma and Sebastian Kügler.


Changes
---

changed the QPair to a struct


Repository: kwayland


Description (updated)
---

This change addresses the sometimes cumbersome to use API of Registry.
So far to bind an interface one needed to connect to the signals when
setting up the registry. There was no other way to get the name and
version at a later point. This made it difficult to use one Registry
in different parts of an Wayland application.

This change adds a convenient:
struct AnnouncedInterface { quint32 name; quint32 version;};
AnnouncedInterface interface(Interface) const
QVector interfaces(Interface) const

The first one is meant for interfaces like wl_shm which is normally only
announced once. The latter one is meant for interfaces like wl_output
for which normally multiple interfaces can get announced.

Those methods can be used without having to connect to the announced
spy.


Diffs (updated)
-

  autotests/client/test_wayland_registry.cpp 
d3f6863f4173eab2b497391070bc6cc3f966ce1d 
  src/client/registry.h 572ddeaa2588cb46a6c3d1dd4c1084479851daee 
  src/client/registry.cpp e6d237b4bfd2fe8299ab35f283086fcf38daaf79 

Diff: https://git.reviewboard.kde.org/r/124734/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 124734: [client] Extend Registry by providing name and version of announced interfaces

2015-08-18 Thread Sebastian Kügler

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124734/#review83981
---

Ship it!


Some minor comments, otherwise looks useful and good to me.


autotests/client/test_wayland_registry.cpp (line 146)


let's



autotests/client/test_wayland_registry.cpp (line 160)


know



src/client/registry.h (line 195)


well-known sounds a bit weird, perhaps "already known"?


- Sebastian Kügler


On Aug. 17, 2015, 6:28 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124734/
> ---
> 
> (Updated Aug. 17, 2015, 6:28 a.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Repository: kwayland
> 
> 
> Description
> ---
> 
> This change addresses the sometimes cumbersome to use API of Registry.
> So far to bind an interface one needed to connect to the signals when
> setting up the registry. There was no other way to get the name and
> version at a later point. This made it difficult to use one Registry
> in different parts of an Wayland application.
> 
> This change adds a convenient:
> struct AnnouncedInterface { quint32 name; quint32 version;};
> AnnouncedInterface interface(Interface) const
> QVector interfaces(Interface) const
> 
> The first one is meant for interfaces like wl_shm which is normally only
> announced once. The latter one is meant for interfaces like wl_output
> for which normally multiple interfaces can get announced.
> 
> Those methods can be used without having to connect to the announced
> spy.
> 
> 
> Diffs
> -
> 
>   autotests/client/test_wayland_registry.cpp 
> d3f6863f4173eab2b497391070bc6cc3f966ce1d 
>   src/client/registry.h 572ddeaa2588cb46a6c3d1dd4c1084479851daee 
>   src/client/registry.cpp e6d237b4bfd2fe8299ab35f283086fcf38daaf79 
> 
> Diff: https://git.reviewboard.kde.org/r/124734/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 124734: [client] Extend Registry by providing name and version of announced interfaces

2015-08-18 Thread Martin Gräßlin


> On Aug. 18, 2015, 1:58 p.m., Sebastian Kügler wrote:
> > src/client/registry.h, line 195
> > 
> >
> > well-known sounds a bit weird, perhaps "already known"?

well-known as that are the interfaces Registry knows about unlike wl_fooBar 
which Registry might never have heard about.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124734/#review83981
---


On Aug. 17, 2015, 8:28 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124734/
> ---
> 
> (Updated Aug. 17, 2015, 8:28 a.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Repository: kwayland
> 
> 
> Description
> ---
> 
> This change addresses the sometimes cumbersome to use API of Registry.
> So far to bind an interface one needed to connect to the signals when
> setting up the registry. There was no other way to get the name and
> version at a later point. This made it difficult to use one Registry
> in different parts of an Wayland application.
> 
> This change adds a convenient:
> struct AnnouncedInterface { quint32 name; quint32 version;};
> AnnouncedInterface interface(Interface) const
> QVector interfaces(Interface) const
> 
> The first one is meant for interfaces like wl_shm which is normally only
> announced once. The latter one is meant for interfaces like wl_output
> for which normally multiple interfaces can get announced.
> 
> Those methods can be used without having to connect to the announced
> spy.
> 
> 
> Diffs
> -
> 
>   autotests/client/test_wayland_registry.cpp 
> d3f6863f4173eab2b497391070bc6cc3f966ce1d 
>   src/client/registry.h 572ddeaa2588cb46a6c3d1dd4c1084479851daee 
>   src/client/registry.cpp e6d237b4bfd2fe8299ab35f283086fcf38daaf79 
> 
> Diff: https://git.reviewboard.kde.org/r/124734/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 124734: [client] Extend Registry by providing name and version of announced interfaces

2015-08-18 Thread Sebastian Kügler


> On Aug. 18, 2015, 11:58 a.m., Sebastian Kügler wrote:
> > src/client/registry.h, line 195
> > 
> >
> > well-known sounds a bit weird, perhaps "already known"?
> 
> Martin Gräßlin wrote:
> well-known as that are the interfaces Registry knows about unlike 
> wl_fooBar which Registry might never have heard about.

Perhaps just enlist them in the docs, that sounds like the clearest option.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124734/#review83981
---


On Aug. 17, 2015, 6:28 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124734/
> ---
> 
> (Updated Aug. 17, 2015, 6:28 a.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Repository: kwayland
> 
> 
> Description
> ---
> 
> This change addresses the sometimes cumbersome to use API of Registry.
> So far to bind an interface one needed to connect to the signals when
> setting up the registry. There was no other way to get the name and
> version at a later point. This made it difficult to use one Registry
> in different parts of an Wayland application.
> 
> This change adds a convenient:
> struct AnnouncedInterface { quint32 name; quint32 version;};
> AnnouncedInterface interface(Interface) const
> QVector interfaces(Interface) const
> 
> The first one is meant for interfaces like wl_shm which is normally only
> announced once. The latter one is meant for interfaces like wl_output
> for which normally multiple interfaces can get announced.
> 
> Those methods can be used without having to connect to the announced
> spy.
> 
> 
> Diffs
> -
> 
>   autotests/client/test_wayland_registry.cpp 
> d3f6863f4173eab2b497391070bc6cc3f966ce1d 
>   src/client/registry.h 572ddeaa2588cb46a6c3d1dd4c1084479851daee 
>   src/client/registry.cpp e6d237b4bfd2fe8299ab35f283086fcf38daaf79 
> 
> Diff: https://git.reviewboard.kde.org/r/124734/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 124734: [client] Extend Registry by providing name and version of announced interfaces

2015-08-18 Thread Martin Gräßlin


> On Aug. 18, 2015, 1:58 p.m., Sebastian Kügler wrote:
> > src/client/registry.h, line 195
> > 
> >
> > well-known sounds a bit weird, perhaps "already known"?
> 
> Martin Gräßlin wrote:
> well-known as that are the interfaces Registry knows about unlike 
> wl_fooBar which Registry might never have heard about.
> 
> Sebastian Kügler wrote:
> Perhaps just enlist them in the docs, that sounds like the clearest 
> option.

well they are. That's the Registry::Interface enum, which are also called 
well-known.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124734/#review83981
---


On Aug. 17, 2015, 8:28 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124734/
> ---
> 
> (Updated Aug. 17, 2015, 8:28 a.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Repository: kwayland
> 
> 
> Description
> ---
> 
> This change addresses the sometimes cumbersome to use API of Registry.
> So far to bind an interface one needed to connect to the signals when
> setting up the registry. There was no other way to get the name and
> version at a later point. This made it difficult to use one Registry
> in different parts of an Wayland application.
> 
> This change adds a convenient:
> struct AnnouncedInterface { quint32 name; quint32 version;};
> AnnouncedInterface interface(Interface) const
> QVector interfaces(Interface) const
> 
> The first one is meant for interfaces like wl_shm which is normally only
> announced once. The latter one is meant for interfaces like wl_output
> for which normally multiple interfaces can get announced.
> 
> Those methods can be used without having to connect to the announced
> spy.
> 
> 
> Diffs
> -
> 
>   autotests/client/test_wayland_registry.cpp 
> d3f6863f4173eab2b497391070bc6cc3f966ce1d 
>   src/client/registry.h 572ddeaa2588cb46a6c3d1dd4c1084479851daee 
>   src/client/registry.cpp e6d237b4bfd2fe8299ab35f283086fcf38daaf79 
> 
> Diff: https://git.reviewboard.kde.org/r/124734/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 124734: [client] Extend Registry by providing name and version of announced interfaces

2015-08-18 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124734/
---

(Updated Aug. 19, 2015, 6:11 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Sebastian Kügler.


Changes
---

Submitted with commit 14a32321140c6983da6d4cde931ab52d21866e94 by Martin 
Gräßlin to branch master.


Repository: kwayland


Description
---

This change addresses the sometimes cumbersome to use API of Registry.
So far to bind an interface one needed to connect to the signals when
setting up the registry. There was no other way to get the name and
version at a later point. This made it difficult to use one Registry
in different parts of an Wayland application.

This change adds a convenient:
struct AnnouncedInterface { quint32 name; quint32 version;};
AnnouncedInterface interface(Interface) const
QVector interfaces(Interface) const

The first one is meant for interfaces like wl_shm which is normally only
announced once. The latter one is meant for interfaces like wl_output
for which normally multiple interfaces can get announced.

Those methods can be used without having to connect to the announced
spy.


Diffs
-

  autotests/client/test_wayland_registry.cpp 
d3f6863f4173eab2b497391070bc6cc3f966ce1d 
  src/client/registry.h 572ddeaa2588cb46a6c3d1dd4c1084479851daee 
  src/client/registry.cpp e6d237b4bfd2fe8299ab35f283086fcf38daaf79 

Diff: https://git.reviewboard.kde.org/r/124734/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel