Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList
> On 9月 11, 2015, 8:12 p.m., Takahiro Hashimoto wrote: > > I finally have had rights to commit KDE repos. If all are OK (already > > flaged 'Ship it' I understand), I'd like to commit it by myself:) > > Eike Hein wrote: > Go ahead! > > Takahiro Hashimoto wrote: > Thank you so much!! :) > > Eike Hein wrote: > Welcome to the team~ Thank you!! - Takahiro --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125012/#review85170 --- On 9月 11, 2015, 9:46 p.m., Takahiro Hashimoto wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125012/ > --- > > (Updated 9月 11, 2015, 9:46 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > Now new Kicker dashboard's filterList isn't wraped by up/down key navigation. > This simple patch make it enabled by setting 'keyNavigationWraps' property of > ListView. > > > Diffs > - > > applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 > > Diff: https://git.reviewboard.kde.org/r/125012/diff/ > > > Testing > --- > > Press up key on the top of filterList menu. : highlight moved to bottom. > Press down key on the bottom of filterList menu: highlight moved to top. > > > Thanks, > > Takahiro Hashimoto > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList
> On Sept. 11, 2015, 11:12 a.m., Takahiro Hashimoto wrote: > > I finally have had rights to commit KDE repos. If all are OK (already > > flaged 'Ship it' I understand), I'd like to commit it by myself:) > > Eike Hein wrote: > Go ahead! > > Takahiro Hashimoto wrote: > Thank you so much!! :) Welcome to the team~ - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125012/#review85170 --- On Sept. 11, 2015, 12:46 p.m., Takahiro Hashimoto wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125012/ > --- > > (Updated Sept. 11, 2015, 12:46 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > Now new Kicker dashboard's filterList isn't wraped by up/down key navigation. > This simple patch make it enabled by setting 'keyNavigationWraps' property of > ListView. > > > Diffs > - > > applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 > > Diff: https://git.reviewboard.kde.org/r/125012/diff/ > > > Testing > --- > > Press up key on the top of filterList menu. : highlight moved to bottom. > Press down key on the bottom of filterList menu: highlight moved to top. > > > Thanks, > > Takahiro Hashimoto > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125012/ --- (Updated Sept. 11, 2015, 12:46 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit fcff88497f464b3e4ddeec166f008f1c0c6e9c1f by Takahiro Hashimoto to branch master. Repository: plasma-desktop Description --- Now new Kicker dashboard's filterList isn't wraped by up/down key navigation. This simple patch make it enabled by setting 'keyNavigationWraps' property of ListView. Diffs - applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 Diff: https://git.reviewboard.kde.org/r/125012/diff/ Testing --- Press up key on the top of filterList menu. : highlight moved to bottom. Press down key on the bottom of filterList menu: highlight moved to top. Thanks, Takahiro Hashimoto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList
> On 9月 11, 2015, 8:12 p.m., Takahiro Hashimoto wrote: > > I finally have had rights to commit KDE repos. If all are OK (already > > flaged 'Ship it' I understand), I'd like to commit it by myself:) > > Eike Hein wrote: > Go ahead! Thank you so much!! :) - Takahiro --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125012/#review85170 --- On 9月 3, 2015, 10:22 a.m., Takahiro Hashimoto wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125012/ > --- > > (Updated 9月 3, 2015, 10:22 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > Now new Kicker dashboard's filterList isn't wraped by up/down key navigation. > This simple patch make it enabled by setting 'keyNavigationWraps' property of > ListView. > > > Diffs > - > > applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 > > Diff: https://git.reviewboard.kde.org/r/125012/diff/ > > > Testing > --- > > Press up key on the top of filterList menu. : highlight moved to bottom. > Press down key on the bottom of filterList menu: highlight moved to top. > > > Thanks, > > Takahiro Hashimoto > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList
> On Sept. 11, 2015, 11:12 a.m., Takahiro Hashimoto wrote: > > I finally have had rights to commit KDE repos. If all are OK (already > > flaged 'Ship it' I understand), I'd like to commit it by myself:) Go ahead! - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125012/#review85170 --- On Sept. 3, 2015, 1:22 a.m., Takahiro Hashimoto wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125012/ > --- > > (Updated Sept. 3, 2015, 1:22 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > Now new Kicker dashboard's filterList isn't wraped by up/down key navigation. > This simple patch make it enabled by setting 'keyNavigationWraps' property of > ListView. > > > Diffs > - > > applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 > > Diff: https://git.reviewboard.kde.org/r/125012/diff/ > > > Testing > --- > > Press up key on the top of filterList menu. : highlight moved to bottom. > Press down key on the bottom of filterList menu: highlight moved to top. > > > Thanks, > > Takahiro Hashimoto > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125012/#review85170 --- I finally have had rights to commit KDE repos. If all are OK (already flaged 'Ship it' I understand), I'd like to commit it by myself:) - Takahiro Hashimoto On 9月 3, 2015, 10:22 a.m., Takahiro Hashimoto wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125012/ > --- > > (Updated 9月 3, 2015, 10:22 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > Now new Kicker dashboard's filterList isn't wraped by up/down key navigation. > This simple patch make it enabled by setting 'keyNavigationWraps' property of > ListView. > > > Diffs > - > > applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 > > Diff: https://git.reviewboard.kde.org/r/125012/diff/ > > > Testing > --- > > Press up key on the top of filterList menu. : highlight moved to bottom. > Press down key on the bottom of filterList menu: highlight moved to top. > > > Thanks, > > Takahiro Hashimoto > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList
On 09/04/2015 09:31 AM, Takahiro Hashimoto wrote: > Should I apply developer account? Yup, let's get you on there. Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList
> On 9月 3, 2015, 7:05 p.m., David Edmundson wrote: > > do you have commit access? > > Takahiro Hashimoto wrote: > No. Should I apply developer account? - Takahiro --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125012/#review84783 --- On 9月 3, 2015, 10:22 a.m., Takahiro Hashimoto wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125012/ > --- > > (Updated 9月 3, 2015, 10:22 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > Now new Kicker dashboard's filterList isn't wraped by up/down key navigation. > This simple patch make it enabled by setting 'keyNavigationWraps' property of > ListView. > > > Diffs > - > > applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 > > Diff: https://git.reviewboard.kde.org/r/125012/diff/ > > > Testing > --- > > Press up key on the top of filterList menu. : highlight moved to bottom. > Press down key on the bottom of filterList menu: highlight moved to top. > > > Thanks, > > Takahiro Hashimoto > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList
> On 9月 3, 2015, 7:05 p.m., David Edmundson wrote: > > do you have commit access? No. - Takahiro --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125012/#review84783 --- On 9月 3, 2015, 10:22 a.m., Takahiro Hashimoto wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125012/ > --- > > (Updated 9月 3, 2015, 10:22 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > Now new Kicker dashboard's filterList isn't wraped by up/down key navigation. > This simple patch make it enabled by setting 'keyNavigationWraps' property of > ListView. > > > Diffs > - > > applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 > > Diff: https://git.reviewboard.kde.org/r/125012/diff/ > > > Testing > --- > > Press up key on the top of filterList menu. : highlight moved to bottom. > Press down key on the bottom of filterList menu: highlight moved to top. > > > Thanks, > > Takahiro Hashimoto > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125012/#review84783 --- do you have commit access? - David Edmundson On Sept. 3, 2015, 1:22 a.m., Takahiro Hashimoto wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125012/ > --- > > (Updated Sept. 3, 2015, 1:22 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > Now new Kicker dashboard's filterList isn't wraped by up/down key navigation. > This simple patch make it enabled by setting 'keyNavigationWraps' property of > ListView. > > > Diffs > - > > applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 > > Diff: https://git.reviewboard.kde.org/r/125012/diff/ > > > Testing > --- > > Press up key on the top of filterList menu. : highlight moved to bottom. > Press down key on the bottom of filterList menu: highlight moved to top. > > > Thanks, > > Takahiro Hashimoto > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125012/ --- (Updated 9月 3, 2015, 10:22 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- Now new Kicker dashboard's filterList isn't wraped by up/down key navigation. This simple patch make it enabled by setting 'keyNavigationWraps' property of ListView. Diffs - applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 Diff: https://git.reviewboard.kde.org/r/125012/diff/ Testing (updated) --- Press up key on the top of filterList menu. : highlight moved to bottom. Press down key on the bottom of filterList menu: highlight moved to top. Thanks, Takahiro Hashimoto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125012/#review84692 --- Ship it! Ship It! - Eike Hein On Sept. 1, 2015, 3:54 a.m., Takahiro Hashimoto wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125012/ > --- > > (Updated Sept. 1, 2015, 3:54 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > Now new Kicker dashboard's filterList isn't wraped by up/down key navigation. > This simple patch make it enabled by setting 'keyNavigationWraps' property of > ListView. > > > Diffs > - > > applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 > > Diff: https://git.reviewboard.kde.org/r/125012/diff/ > > > Testing > --- > > > Thanks, > > Takahiro Hashimoto > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 125012: [kicker] add key navigation wrap to dashboard filterList
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125012/ --- Review request for Plasma. Repository: plasma-desktop Description --- Now new Kicker dashboard's filterList isn't wraped by up/down key navigation. This simple patch make it enabled by setting 'keyNavigationWraps' property of ListView. Diffs - applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 Diff: https://git.reviewboard.kde.org/r/125012/diff/ Testing --- Thanks, Takahiro Hashimoto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
