Re: Review Request 125019: [kicker] make dashboard icon size scalable
> On 9月 13, 2015, 5:07 a.m., Eike Hein wrote: > > I currently don't want to make this configurable because I want to retain > > control over how Dashboard is presented to users and not allow it to be > > configured to a state that looks bad (this is a corner we've painted > > ourselves into too many times). The Dashboard layout will also be tweaked > > further, and until it settles down it's not clear what can be safely made > > configurable. Beyond that this patch would have some implementation issues, > > e.g. we don't want to expose icon sizes in numeric form to the user. I > > appreciate the idea and the attempt, but I'm going to reject this patch for > > now. > > Takahiro Hashimoto wrote: > Thank you for your comment. I understand your concept and status of the > Dashboard development. Even if The implementation issue could be fixed and > enhanced (it's one of the purpose of review, i think :) ), I understand it's > not time to do it. I apprecate you for your clear comment. I'd like to > discard this requiest:) Sorry for incorrect use of English... Thank you again for your clear comment:) - Takahiro --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125019/#review85277 --- On 9月 13, 2015, 8:30 a.m., Takahiro Hashimoto wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125019/ > --- > > (Updated 9月 13, 2015, 8:30 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > The kicker dashboard icons are auto-adjusted by screen size (small or not) > now. In certain environment (especially high-DPI screen like 4k) it would be > nice to change icon size manually, I think. > This patch makes icon size of dashboard changeable from dashboard settings. > The default behavior is auto setting by screen size. > > It's request for comment. I also think the simple implementation is better to > avoid complex settings. > > Screenshot attached. > > 1. current icon size (determined by screen size, units.iconSizes.huge (equals > 64) > 2. scale to 128 by this change (=units.iconSizeds.Enormous (equals 128) > 3. dashboard settings to change icon size (slidebar) > > Could we discuss about this? > > > Diffs > - > > applets/kicker/package/contents/config/main.xml 17cd29a > applets/kicker/package/contents/ui/ConfigGeneral.qml ebb1342 > applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 > > Diff: https://git.reviewboard.kde.org/r/125019/diff/ > > > Testing > --- > > Tested on the two environment: > > high-dpi 3200x1800 DPI 150 > normal-dpi 1024x768 DPI 96 > > Both are tested with my Dell XPS 13 (2015) QHD+ machine. > > > File Attachments > > > 1. current icon size (auto) QHD+ > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/12/ba2fedc2-b1cf-490f-9912-16fe41d02191__dash_icon_auto_QHD.png > 2. scale icon size to 128 with this change > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/12/7a1e4257-6214-4597-b1ff-db0e6dbdf78d__dash_icon_scaleto128_QHD2.png > 3. dashboard settings gui for changef icon size > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/12/d302f514-e9bb-4e42-a600-4f636f646990__dash_icon_gui_settings_menu.png > > > Thanks, > > Takahiro Hashimoto > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125019: [kicker] make dashboard icon size scalable
> On 9月 13, 2015, 5:07 a.m., Eike Hein wrote: > > I currently don't want to make this configurable because I want to retain > > control over how Dashboard is presented to users and not allow it to be > > configured to a state that looks bad (this is a corner we've painted > > ourselves into too many times). The Dashboard layout will also be tweaked > > further, and until it settles down it's not clear what can be safely made > > configurable. Beyond that this patch would have some implementation issues, > > e.g. we don't want to expose icon sizes in numeric form to the user. I > > appreciate the idea and the attempt, but I'm going to reject this patch for > > now. Thank you for your comment. I understand your concept and status of the Dashboard development. Even if The implementation issue could be fixed and enhanced (it's one of the purpose of review, i think :) ), I understand it's not time to do it. I apprecate you for your clear comment. I'd like to discard this requiest:) - Takahiro --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125019/#review85277 --- On 9月 12, 2015, 9:41 a.m., Takahiro Hashimoto wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125019/ > --- > > (Updated 9月 12, 2015, 9:41 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > The kicker dashboard icons are auto-adjusted by screen size (small or not) > now. In certain environment (especially high-DPI screen like 4k) it would be > nice to change icon size manually, I think. > This patch makes icon size of dashboard changeable from dashboard settings. > The default behavior is auto setting by screen size. > > It's request for comment. I also think the simple implementation is better to > avoid complex settings. > > Screenshot attached. > > 1. current icon size (determined by screen size, units.iconSizes.huge (equals > 64) > 2. scale to 128 by this change (=units.iconSizeds.Enormous (equals 128) > 3. dashboard settings to change icon size (slidebar) > > Could we discuss about this? > > > Diffs > - > > applets/kicker/package/contents/config/main.xml 17cd29a > applets/kicker/package/contents/ui/ConfigGeneral.qml ebb1342 > applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 > > Diff: https://git.reviewboard.kde.org/r/125019/diff/ > > > Testing > --- > > Tested on the two environment: > > high-dpi 3200x1800 DPI 150 > normal-dpi 1024x768 DPI 96 > > Both are tested with my Dell XPS 13 (2015) QHD+ machine. > > > File Attachments > > > 1. current icon size (auto) QHD+ > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/12/ba2fedc2-b1cf-490f-9912-16fe41d02191__dash_icon_auto_QHD.png > 2. scale icon size to 128 with this change > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/12/7a1e4257-6214-4597-b1ff-db0e6dbdf78d__dash_icon_scaleto128_QHD2.png > 3. dashboard settings gui for changef icon size > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/12/d302f514-e9bb-4e42-a600-4f636f646990__dash_icon_gui_settings_menu.png > > > Thanks, > > Takahiro Hashimoto > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125019: [kicker] make dashboard icon size scalable
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125019/ --- (Updated 9月 13, 2015, 8:30 a.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-desktop Description --- The kicker dashboard icons are auto-adjusted by screen size (small or not) now. In certain environment (especially high-DPI screen like 4k) it would be nice to change icon size manually, I think. This patch makes icon size of dashboard changeable from dashboard settings. The default behavior is auto setting by screen size. It's request for comment. I also think the simple implementation is better to avoid complex settings. Screenshot attached. 1. current icon size (determined by screen size, units.iconSizes.huge (equals 64) 2. scale to 128 by this change (=units.iconSizeds.Enormous (equals 128) 3. dashboard settings to change icon size (slidebar) Could we discuss about this? Diffs - applets/kicker/package/contents/config/main.xml 17cd29a applets/kicker/package/contents/ui/ConfigGeneral.qml ebb1342 applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 Diff: https://git.reviewboard.kde.org/r/125019/diff/ Testing --- Tested on the two environment: high-dpi 3200x1800 DPI 150 normal-dpi 1024x768 DPI 96 Both are tested with my Dell XPS 13 (2015) QHD+ machine. File Attachments 1. current icon size (auto) QHD+ https://git.reviewboard.kde.org/media/uploaded/files/2015/09/12/ba2fedc2-b1cf-490f-9912-16fe41d02191__dash_icon_auto_QHD.png 2. scale icon size to 128 with this change https://git.reviewboard.kde.org/media/uploaded/files/2015/09/12/7a1e4257-6214-4597-b1ff-db0e6dbdf78d__dash_icon_scaleto128_QHD2.png 3. dashboard settings gui for changef icon size https://git.reviewboard.kde.org/media/uploaded/files/2015/09/12/d302f514-e9bb-4e42-a600-4f636f646990__dash_icon_gui_settings_menu.png Thanks, Takahiro Hashimoto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125019: [kicker] make dashboard icon size scalable
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125019/#review85277 --- I currently don't want to make this configurable because I want to retain control over how Dashboard is presented to users and not allow it to be configured to a state that looks bad (this is a corner we've painted ourselves into too many times). The Dashboard layout will also be tweaked further, and until it settles down it's not clear what can be safely made configurable. Beyond that this patch would have some implementation issues, e.g. we don't want to expose icon sizes in numeric form to the user. I appreciate the idea and the attempt, but I'm going to reject this patch for now. - Eike Hein On Sept. 12, 2015, 12:41 a.m., Takahiro Hashimoto wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125019/ > --- > > (Updated Sept. 12, 2015, 12:41 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > The kicker dashboard icons are auto-adjusted by screen size (small or not) > now. In certain environment (especially high-DPI screen like 4k) it would be > nice to change icon size manually, I think. > This patch makes icon size of dashboard changeable from dashboard settings. > The default behavior is auto setting by screen size. > > It's request for comment. I also think the simple implementation is better to > avoid complex settings. > > Screenshot attached. > > 1. current icon size (determined by screen size, units.iconSizes.huge (equals > 64) > 2. scale to 128 by this change (=units.iconSizeds.Enormous (equals 128) > 3. dashboard settings to change icon size (slidebar) > > Could we discuss about this? > > > Diffs > - > > applets/kicker/package/contents/config/main.xml 17cd29a > applets/kicker/package/contents/ui/ConfigGeneral.qml ebb1342 > applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 > > Diff: https://git.reviewboard.kde.org/r/125019/diff/ > > > Testing > --- > > Tested on the two environment: > > high-dpi 3200x1800 DPI 150 > normal-dpi 1024x768 DPI 96 > > Both are tested with my Dell XPS 13 (2015) QHD+ machine. > > > File Attachments > > > 1. current icon size (auto) QHD+ > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/12/ba2fedc2-b1cf-490f-9912-16fe41d02191__dash_icon_auto_QHD.png > 2. scale icon size to 128 with this change > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/12/7a1e4257-6214-4597-b1ff-db0e6dbdf78d__dash_icon_scaleto128_QHD2.png > 3. dashboard settings gui for changef icon size > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/12/d302f514-e9bb-4e42-a600-4f636f646990__dash_icon_gui_settings_menu.png > > > Thanks, > > Takahiro Hashimoto > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125019: [kicker] make dashboard icon size scalable
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125019/ --- (Updated 9月 12, 2015, 9:41 a.m.) Review request for Plasma. Changes --- add screenshots Repository: plasma-desktop Description (updated) --- The kicker dashboard icons are auto-adjusted by screen size (small or not) now. In certain environment (especially high-DPI screen like 4k) it would be nice to change icon size manually, I think. This patch makes icon size of dashboard changeable from dashboard settings. The default behavior is auto setting by screen size. It's request for comment. I also think the simple implementation is better to avoid complex settings. Screenshot attached. 1. current icon size (determined by screen size, units.iconSizes.huge (equals 64) 2. scale to 128 by this change (=units.iconSizeds.Enormous (equals 128) 3. dashboard settings to change icon size (slidebar) Could we discuss about this? Diffs - applets/kicker/package/contents/config/main.xml 17cd29a applets/kicker/package/contents/ui/ConfigGeneral.qml ebb1342 applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 Diff: https://git.reviewboard.kde.org/r/125019/diff/ Testing --- Tested on the two environment: high-dpi 3200x1800 DPI 150 normal-dpi 1024x768 DPI 96 Both are tested with my Dell XPS 13 (2015) QHD+ machine. File Attachments (updated) 1. current icon size (auto) QHD+ https://git.reviewboard.kde.org/media/uploaded/files/2015/09/12/ba2fedc2-b1cf-490f-9912-16fe41d02191__dash_icon_auto_QHD.png 2. scale icon size to 128 with this change https://git.reviewboard.kde.org/media/uploaded/files/2015/09/12/7a1e4257-6214-4597-b1ff-db0e6dbdf78d__dash_icon_scaleto128_QHD2.png 3. dashboard settings gui for changef icon size https://git.reviewboard.kde.org/media/uploaded/files/2015/09/12/d302f514-e9bb-4e42-a600-4f636f646990__dash_icon_gui_settings_menu.png Thanks, Takahiro Hashimoto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125019: [kicker] make dashboard icon size scalable
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125019/ --- (Updated 9月 2, 2015, 12:19 a.m.) Review request for Plasma. Changes --- make it better a bit Repository: plasma-desktop Description --- The kicker dashboard icons are auto-adjusted by screen size (small or not) now. In certain environment (especially high-DPI screen like 4k) it would be nice to change icon size manually, I think. This patch makes icon size of dashboard changeable from dashboard settings. The default behavior is auto setting by screen size. It's request for comment. I also think the simple implementation is better to avoid complex settings. Diffs (updated) - applets/kicker/package/contents/config/main.xml 17cd29a applets/kicker/package/contents/ui/ConfigGeneral.qml ebb1342 applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 Diff: https://git.reviewboard.kde.org/r/125019/diff/ Testing --- Tested on the two environment: high-dpi 3200x1800 DPI 150 normal-dpi 1024x768 DPI 96 Both are tested with my Dell XPS 13 (2015) QHD+ machine. Thanks, Takahiro Hashimoto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125019: [kicker] make dashboard icon size scalable
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125019/ --- (Updated 9月 2, 2015, 12:14 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- The kicker dashboard icons are auto-adjusted by screen size (small or not) now. In certain environment (especially high-DPI screen like 4k) it would be nice to change icon size manually, I think. This patch makes icon size of dashboard changeable from dashboard settings. The default behavior is auto setting by screen size. It's request for comment. I also think the simple implementation is better to avoid complex settings. Diffs - applets/kicker/package/contents/config/main.xml 17cd29a applets/kicker/package/contents/ui/ConfigGeneral.qml ebb1342 applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 Diff: https://git.reviewboard.kde.org/r/125019/diff/ Testing (updated) --- Tested on the two environment: high-dpi 3200x1800 DPI 150 normal-dpi 1024x768 DPI 96 Both are tested with my Dell XPS 13 (2015) QHD+ machine. Thanks, Takahiro Hashimoto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 125019: [kicker] make dashboard icon size scalable
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125019/ --- Review request for Plasma. Repository: plasma-desktop Description --- The kicker dashboard icons are auto-adjusted by screen size (small or not) now. In certain environment (especially high-DPI screen like 4k) it would be nice to change icon size manually, I think. This patch makes icon size of dashboard changeable from dashboard settings. The default behavior is auto setting by screen size. It's request for comment. I also think the simple implementation is better to avoid complex settings. Diffs - applets/kicker/package/contents/config/main.xml 17cd29a applets/kicker/package/contents/ui/ConfigGeneral.qml ebb1342 applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 Diff: https://git.reviewboard.kde.org/r/125019/diff/ Testing --- Tested on the to environment: high-dpi 3200x1800 DPI 150 normal-dpi 1024x768 DPI 96 Both are tested with my Dell XPS 13 (2015) QHD+ machine. Thanks, Takahiro Hashimoto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
