Re: Review Request 125135: show screenshots in the widget explorer

[andreas kainz]

> On Sept. 16, 2015, 4:22 nachm., andreas kainz wrote:
> > Hi I add some applet icons in 256x256px in kde:breeeze 
> > (https://quickgit.kde.org/?p=breeze.git&a=commit&h=f75b729531a75df1536b7340fcb016a5752ebf69)
> > I need feedback how it looks and if it would work for you
> 
> Marco Martin wrote:
> snapshot8 that's how the calendar svg looks on the current code
> (had to copy it by hand as they are not installed atm, also i'm not sure 
> applets/ subfolder in the icon theme would work)
> 
> Marco Martin wrote:
> for how iconloader works i think they should be in the apps folder, even 
> tough technically thye are anot apps...

I would wrote an mail to plasma now. so you are to fast for me.

Hi,

only to your information as we sugested in the past. we will add for the 
plasma-xxx applets, application icons.

you can find them in kde:breeze in the folder /icons/applets/256/xxx

the application icons are no screenshots and will be available for breeze and 
breeze-dark (so breeze dark will have the plasma dark border)

icon name is something like org.kde.plasma.xxx

as Marco wrote they are still applications.


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/#review85500
---


On Sept. 21, 2015, 1:20 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125135/
> ---
> 
> (Updated Sept. 21, 2015, 1:20 nachm.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As requested by the VDG, show screenshots in the widget explorer when 
> available, to have a look similar to the activity manager (they'll do 
> screenshots for all our plasmoids).
> when a screenshot is not available, it falls back to the old design.
> this is an in-between design, the latest design would be with two columns 
> instead of one, but that would need to be tested as well beforehand, both in 
> the widget explorer and the activity switcher
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 
>   desktoppackage/contents/explorer/WidgetExplorer.qml f164c18 
> 
> Diff: https://git.reviewboard.kde.org/r/125135/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot6.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png
> more near to the intended design
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/955b1dbc-2347-4e17-beb1-c5153b3d0087__snapshot7.png
> snapshot8.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/16/23447d32-815e-48c0-9a00-3234ee28249e__snapshot8.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125135: show screenshots in the widget explorer

[Marco Martin]

> On Sept. 16, 2015, 4:22 p.m., andreas kainz wrote:
> > Hi I add some applet icons in 256x256px in kde:breeeze 
> > (https://quickgit.kde.org/?p=breeze.git&a=commit&h=f75b729531a75df1536b7340fcb016a5752ebf69)
> > I need feedback how it looks and if it would work for you
> 
> Marco Martin wrote:
> snapshot8 that's how the calendar svg looks on the current code
> (had to copy it by hand as they are not installed atm, also i'm not sure 
> applets/ subfolder in the icon theme would work)

for how iconloader works i think they should be in the apps folder, even tough 
technically thye are anot apps...


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/#review85500
---


On Sept. 21, 2015, 1:20 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125135/
> ---
> 
> (Updated Sept. 21, 2015, 1:20 p.m.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As requested by the VDG, show screenshots in the widget explorer when 
> available, to have a look similar to the activity manager (they'll do 
> screenshots for all our plasmoids).
> when a screenshot is not available, it falls back to the old design.
> this is an in-between design, the latest design would be with two columns 
> instead of one, but that would need to be tested as well beforehand, both in 
> the widget explorer and the activity switcher
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 
>   desktoppackage/contents/explorer/WidgetExplorer.qml f164c18 
> 
> Diff: https://git.reviewboard.kde.org/r/125135/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot6.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png
> more near to the intended design
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/955b1dbc-2347-4e17-beb1-c5153b3d0087__snapshot7.png
> snapshot8.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/16/23447d32-815e-48c0-9a00-3234ee28249e__snapshot8.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125135: show screenshots in the widget explorer

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/
---

(Updated Sept. 21, 2015, 1:20 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and andreas kainz.


Repository: plasma-desktop


Description
---

As requested by the VDG, show screenshots in the widget explorer when 
available, to have a look similar to the activity manager (they'll do 
screenshots for all our plasmoids).
when a screenshot is not available, it falls back to the old design.
this is an in-between design, the latest design would be with two columns 
instead of one, but that would need to be tested as well beforehand, both in 
the widget explorer and the activity switcher


Diffs
-

  desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 
  desktoppackage/contents/explorer/WidgetExplorer.qml f164c18 

Diff: https://git.reviewboard.kde.org/r/125135/diff/


Testing
---


File Attachments


snapshot6.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png
more near to the intended design
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/955b1dbc-2347-4e17-beb1-c5153b3d0087__snapshot7.png
snapshot8.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/16/23447d32-815e-48c0-9a00-3234ee28249e__snapshot8.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125135: show screenshots in the widget explorer

[Marco Martin]

> On Sept. 16, 2015, 4:22 p.m., andreas kainz wrote:
> > Hi I add some applet icons in 256x256px in kde:breeeze 
> > (https://quickgit.kde.org/?p=breeze.git&a=commit&h=f75b729531a75df1536b7340fcb016a5752ebf69)
> > I need feedback how it looks and if it would work for you

snapshot8 that's how the calendar svg looks on the current code
(had to copy it by hand as they are not installed atm, also i'm not sure 
applets/ subfolder in the icon theme would work)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/#review85500
---


On Sept. 16, 2015, 5:59 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125135/
> ---
> 
> (Updated Sept. 16, 2015, 5:59 p.m.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As requested by the VDG, show screenshots in the widget explorer when 
> available, to have a look similar to the activity manager (they'll do 
> screenshots for all our plasmoids).
> when a screenshot is not available, it falls back to the old design.
> this is an in-between design, the latest design would be with two columns 
> instead of one, but that would need to be tested as well beforehand, both in 
> the widget explorer and the activity switcher
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 
>   desktoppackage/contents/explorer/WidgetExplorer.qml f164c18 
> 
> Diff: https://git.reviewboard.kde.org/r/125135/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot6.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png
> more near to the intended design
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/955b1dbc-2347-4e17-beb1-c5153b3d0087__snapshot7.png
> snapshot8.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/16/23447d32-815e-48c0-9a00-3234ee28249e__snapshot8.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125135: show screenshots in the widget explorer

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/
---

(Updated Sept. 16, 2015, 5:59 p.m.)


Review request for Plasma and andreas kainz.


Repository: plasma-desktop


Description
---

As requested by the VDG, show screenshots in the widget explorer when 
available, to have a look similar to the activity manager (they'll do 
screenshots for all our plasmoids).
when a screenshot is not available, it falls back to the old design.
this is an in-between design, the latest design would be with two columns 
instead of one, but that would need to be tested as well beforehand, both in 
the widget explorer and the activity switcher


Diffs
-

  desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 
  desktoppackage/contents/explorer/WidgetExplorer.qml f164c18 

Diff: https://git.reviewboard.kde.org/r/125135/diff/


Testing
---


File Attachments (updated)


snapshot6.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png
more near to the intended design
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/955b1dbc-2347-4e17-beb1-c5153b3d0087__snapshot7.png
snapshot8.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/16/23447d32-815e-48c0-9a00-3234ee28249e__snapshot8.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125135: show screenshots in the widget explorer

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/#review85500
---


Hi I add some applet icons in 256x256px in kde:breeeze 
(https://quickgit.kde.org/?p=breeze.git&a=commit&h=f75b729531a75df1536b7340fcb016a5752ebf69)
I need feedback how it looks and if it would work for you

- andreas kainz


On Sept. 11, 2015, 3:59 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125135/
> ---
> 
> (Updated Sept. 11, 2015, 3:59 p.m.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As requested by the VDG, show screenshots in the widget explorer when 
> available, to have a look similar to the activity manager (they'll do 
> screenshots for all our plasmoids).
> when a screenshot is not available, it falls back to the old design.
> this is an in-between design, the latest design would be with two columns 
> instead of one, but that would need to be tested as well beforehand, both in 
> the widget explorer and the activity switcher
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 
>   desktoppackage/contents/explorer/WidgetExplorer.qml f164c18 
> 
> Diff: https://git.reviewboard.kde.org/r/125135/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot6.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png
> more near to the intended design
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/955b1dbc-2347-4e17-beb1-c5153b3d0087__snapshot7.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125135: show screenshots in the widget explorer

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/
---

(Updated Sept. 11, 2015, 3:59 p.m.)


Review request for Plasma and andreas kainz.


Changes
---

code quality still WIP, gives an idea on the design


Repository: plasma-desktop


Description
---

As requested by the VDG, show screenshots in the widget explorer when 
available, to have a look similar to the activity manager (they'll do 
screenshots for all our plasmoids).
when a screenshot is not available, it falls back to the old design.
this is an in-between design, the latest design would be with two columns 
instead of one, but that would need to be tested as well beforehand, both in 
the widget explorer and the activity switcher


Diffs (updated)
-

  desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 
  desktoppackage/contents/explorer/WidgetExplorer.qml f164c18 

Diff: https://git.reviewboard.kde.org/r/125135/diff/


Testing
---


File Attachments


snapshot6.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png
more near to the intended design
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/955b1dbc-2347-4e17-beb1-c5153b3d0087__snapshot7.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125135: show screenshots in the widget explorer

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/
---

(Updated Sept. 11, 2015, 3:57 p.m.)


Review request for Plasma and andreas kainz.


Repository: plasma-desktop


Description
---

As requested by the VDG, show screenshots in the widget explorer when 
available, to have a look similar to the activity manager (they'll do 
screenshots for all our plasmoids).
when a screenshot is not available, it falls back to the old design.
this is an in-between design, the latest design would be with two columns 
instead of one, but that would need to be tested as well beforehand, both in 
the widget explorer and the activity switcher


Diffs
-

  desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 

Diff: https://git.reviewboard.kde.org/r/125135/diff/


Testing
---


File Attachments (updated)


snapshot6.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png
more near to the intended design
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/955b1dbc-2347-4e17-beb1-c5153b3d0087__snapshot7.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125135: show screenshots in the widget explorer

[andreas kainz]

> On Sept. 10, 2015, 11:43 a.m., Kai Uwe Broulik wrote:
> > First of all, I like the idea.
> > 
> > However, I think we should go with PNG with alpha channel rather than 
> > having the Breeze default wallpaper there which changes every release. 
> > Showing a fully working Plasmoid is probably too much in this list in terms 
> > of performance but might be worth thinking allowing a plasmoid to provide a 
> > demo.qml (eg.  analog clock's face is pretty isolated) which is then shown 
> > there and in sync with the actual Plasmoid by using parts of it.
> > On the other hand, Android also just shows screenshots :)
> 
> Marco Martin wrote:
> i think as well having an alpha channel would be much prettier, however 
> would require a specialized tool and would be slightly harder to do, needs to 
> be as easy and fast for the VDG people to do them quickly. (also applets that 
> make sense only as an expanded popup like kickoff would work better with the 
> wallpaper i think?)
> 
> Martin Gräßlin wrote:
> maybe we could get an easy "screenshot mode" into plasmoidviewer? So that 
> it
> - hides the background
> - uses correct size
> - saves it with a standardized name
>  
> Kickoff exposes another problem: some applets will need KWin help. Taking 
> the screenshot without a background won't work for them, though the 
> background hardly matters if we get the area around as translucent.
> 
> Martin Klapetek wrote:
> I too am worried about the screenshots getting out of date. Just for this 
> release the digital-clock got some serious overhaul in its looks. Now I'm not 
> opposed to the idea itself, but I don't think this scales too well. This 
> would need a dedicated person to review _all_ applets before release and 
> compare the screenshots...and from experience I don't believe we can keep 
> this up.
> 
> andreas kainz wrote:
> ok the proposal from the VDG (Uri and me)
> 
> 1. we will push 128x128px Previews in our kde:breeze icon set in 
> breeze/icons/apps/128 in an first step we ONLY have screenshots
> 2. we will make 128x128px colorefull Icons and remove the screenshots 
> with svg breeze and breeze dark icons where the user can recognize the 
> difference behavior for the different widgets instead of something like this 
> (https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/screenshot1.png)
> 
> So in the first step you have to live with screenshots BUT in the end you 
> get large widget icons where the user can recognize the widget.
> 
> Also for GHNS most widgets will only have at lease screenshots so it will 
> be always a mix between icons and screenshots, but as you know me will focus 
> on feature complete.
> 
> would this way work for you? For now the screenshots would work and 
> before the screenshots are not up to date the screenshots will be removed 
> with icons AND the widget icons are useing in the same behavior than all 
> other icons so the screenshots are in our structure and we will care about it.
> 
> Marco Martin wrote:
> that's ok for me, so it will have screenshots in the short term and ad 
> hoc icons in the long term.
> the icon names will be the same as the plugin name, so all desktop files 
> will need to have an updated Icon=org.kde.plasma.analogclock entry.
> screenshots inside the plasmoid package still supported, intended for 
> kdelook plasmoids that won't have an icon in the breeze theme.
> how does it sound?
> 
> Martin Klapetek wrote:
> I don't want to discourage you from your effort, not at all, but isn't it 
> kind of a wasted work? I mean, you spend all that time on making all those 
> screenshots and then just remove then again anyway...? Wouldn't it be better 
> to spend the time on the icons directly?
> 
> andreas kainz wrote:
> No it would be much more usefull to use the screenshots instead of some 
> app icons cause you add widgets cause you want to have the screenshot on your 
> desktop. The Icons are the wast of time cause they doesn't make sense but 
> make widget icons is better for the user than it is now.
> 
> Martin Klapetek wrote:
> I'm just worried that the screenshots will get outdated very soon. At 
> which point the icon is indeed better for the user than shipping outdated 
> screenshots.

e.g. the kicker screenshot could be outdated BUT only in some look and feel 
e.g. but there will always be an different behavior to kickoff and the user 
will always see the difference. doesn't matter if the screenshot is outdated.

I really understand you I will remove the wallpaper.


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/#review85105
---


On Sept. 10, 2015, 10:53 a.m., Marco Martin wrote:
> 
> ---
> This is an automatical

Re: Review Request 125135: show screenshots in the widget explorer

[Martin Klapetek]

> On Sept. 10, 2015, 1:43 p.m., Kai Uwe Broulik wrote:
> > First of all, I like the idea.
> > 
> > However, I think we should go with PNG with alpha channel rather than 
> > having the Breeze default wallpaper there which changes every release. 
> > Showing a fully working Plasmoid is probably too much in this list in terms 
> > of performance but might be worth thinking allowing a plasmoid to provide a 
> > demo.qml (eg.  analog clock's face is pretty isolated) which is then shown 
> > there and in sync with the actual Plasmoid by using parts of it.
> > On the other hand, Android also just shows screenshots :)
> 
> Marco Martin wrote:
> i think as well having an alpha channel would be much prettier, however 
> would require a specialized tool and would be slightly harder to do, needs to 
> be as easy and fast for the VDG people to do them quickly. (also applets that 
> make sense only as an expanded popup like kickoff would work better with the 
> wallpaper i think?)
> 
> Martin Gräßlin wrote:
> maybe we could get an easy "screenshot mode" into plasmoidviewer? So that 
> it
> - hides the background
> - uses correct size
> - saves it with a standardized name
>  
> Kickoff exposes another problem: some applets will need KWin help. Taking 
> the screenshot without a background won't work for them, though the 
> background hardly matters if we get the area around as translucent.
> 
> Martin Klapetek wrote:
> I too am worried about the screenshots getting out of date. Just for this 
> release the digital-clock got some serious overhaul in its looks. Now I'm not 
> opposed to the idea itself, but I don't think this scales too well. This 
> would need a dedicated person to review _all_ applets before release and 
> compare the screenshots...and from experience I don't believe we can keep 
> this up.
> 
> andreas kainz wrote:
> ok the proposal from the VDG (Uri and me)
> 
> 1. we will push 128x128px Previews in our kde:breeze icon set in 
> breeze/icons/apps/128 in an first step we ONLY have screenshots
> 2. we will make 128x128px colorefull Icons and remove the screenshots 
> with svg breeze and breeze dark icons where the user can recognize the 
> difference behavior for the different widgets instead of something like this 
> (https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/screenshot1.png)
> 
> So in the first step you have to live with screenshots BUT in the end you 
> get large widget icons where the user can recognize the widget.
> 
> Also for GHNS most widgets will only have at lease screenshots so it will 
> be always a mix between icons and screenshots, but as you know me will focus 
> on feature complete.
> 
> would this way work for you? For now the screenshots would work and 
> before the screenshots are not up to date the screenshots will be removed 
> with icons AND the widget icons are useing in the same behavior than all 
> other icons so the screenshots are in our structure and we will care about it.
> 
> Marco Martin wrote:
> that's ok for me, so it will have screenshots in the short term and ad 
> hoc icons in the long term.
> the icon names will be the same as the plugin name, so all desktop files 
> will need to have an updated Icon=org.kde.plasma.analogclock entry.
> screenshots inside the plasmoid package still supported, intended for 
> kdelook plasmoids that won't have an icon in the breeze theme.
> how does it sound?
> 
> Martin Klapetek wrote:
> I don't want to discourage you from your effort, not at all, but isn't it 
> kind of a wasted work? I mean, you spend all that time on making all those 
> screenshots and then just remove then again anyway...? Wouldn't it be better 
> to spend the time on the icons directly?
> 
> andreas kainz wrote:
> No it would be much more usefull to use the screenshots instead of some 
> app icons cause you add widgets cause you want to have the screenshot on your 
> desktop. The Icons are the wast of time cause they doesn't make sense but 
> make widget icons is better for the user than it is now.

I'm just worried that the screenshots will get outdated very soon. At which 
point the icon is indeed better for the user than shipping outdated screenshots.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/#review85105
---


On Sept. 10, 2015, 12:53 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125135/
> ---
> 
> (Updated Sept. 10, 2015, 12:53 p.m.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As requested by th

Re: Review Request 125135: show screenshots in the widget explorer

[andreas kainz]

> On Sept. 10, 2015, 11:43 a.m., Kai Uwe Broulik wrote:
> > First of all, I like the idea.
> > 
> > However, I think we should go with PNG with alpha channel rather than 
> > having the Breeze default wallpaper there which changes every release. 
> > Showing a fully working Plasmoid is probably too much in this list in terms 
> > of performance but might be worth thinking allowing a plasmoid to provide a 
> > demo.qml (eg.  analog clock's face is pretty isolated) which is then shown 
> > there and in sync with the actual Plasmoid by using parts of it.
> > On the other hand, Android also just shows screenshots :)
> 
> Marco Martin wrote:
> i think as well having an alpha channel would be much prettier, however 
> would require a specialized tool and would be slightly harder to do, needs to 
> be as easy and fast for the VDG people to do them quickly. (also applets that 
> make sense only as an expanded popup like kickoff would work better with the 
> wallpaper i think?)
> 
> Martin Gräßlin wrote:
> maybe we could get an easy "screenshot mode" into plasmoidviewer? So that 
> it
> - hides the background
> - uses correct size
> - saves it with a standardized name
>  
> Kickoff exposes another problem: some applets will need KWin help. Taking 
> the screenshot without a background won't work for them, though the 
> background hardly matters if we get the area around as translucent.
> 
> Martin Klapetek wrote:
> I too am worried about the screenshots getting out of date. Just for this 
> release the digital-clock got some serious overhaul in its looks. Now I'm not 
> opposed to the idea itself, but I don't think this scales too well. This 
> would need a dedicated person to review _all_ applets before release and 
> compare the screenshots...and from experience I don't believe we can keep 
> this up.
> 
> andreas kainz wrote:
> ok the proposal from the VDG (Uri and me)
> 
> 1. we will push 128x128px Previews in our kde:breeze icon set in 
> breeze/icons/apps/128 in an first step we ONLY have screenshots
> 2. we will make 128x128px colorefull Icons and remove the screenshots 
> with svg breeze and breeze dark icons where the user can recognize the 
> difference behavior for the different widgets instead of something like this 
> (https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/screenshot1.png)
> 
> So in the first step you have to live with screenshots BUT in the end you 
> get large widget icons where the user can recognize the widget.
> 
> Also for GHNS most widgets will only have at lease screenshots so it will 
> be always a mix between icons and screenshots, but as you know me will focus 
> on feature complete.
> 
> would this way work for you? For now the screenshots would work and 
> before the screenshots are not up to date the screenshots will be removed 
> with icons AND the widget icons are useing in the same behavior than all 
> other icons so the screenshots are in our structure and we will care about it.
> 
> Marco Martin wrote:
> that's ok for me, so it will have screenshots in the short term and ad 
> hoc icons in the long term.
> the icon names will be the same as the plugin name, so all desktop files 
> will need to have an updated Icon=org.kde.plasma.analogclock entry.
> screenshots inside the plasmoid package still supported, intended for 
> kdelook plasmoids that won't have an icon in the breeze theme.
> how does it sound?
> 
> Martin Klapetek wrote:
> I don't want to discourage you from your effort, not at all, but isn't it 
> kind of a wasted work? I mean, you spend all that time on making all those 
> screenshots and then just remove then again anyway...? Wouldn't it be better 
> to spend the time on the icons directly?

No it would be much more usefull to use the screenshots instead of some app 
icons cause you add widgets cause you want to have the screenshot on your 
desktop. The Icons are the wast of time cause they doesn't make sense but make 
widget icons is better for the user than it is now.


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/#review85105
---


On Sept. 10, 2015, 10:53 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125135/
> ---
> 
> (Updated Sept. 10, 2015, 10:53 a.m.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As requested by the VDG, show screenshots in the widget explorer when 
> available, to have a look similar to the activity manager (they'll do 
> screenshots for all our plasmoids).
> when a screenshot is not ava

Re: Review Request 125135: show screenshots in the widget explorer

[Martin Klapetek]

> On Sept. 10, 2015, 1:43 p.m., Kai Uwe Broulik wrote:
> > First of all, I like the idea.
> > 
> > However, I think we should go with PNG with alpha channel rather than 
> > having the Breeze default wallpaper there which changes every release. 
> > Showing a fully working Plasmoid is probably too much in this list in terms 
> > of performance but might be worth thinking allowing a plasmoid to provide a 
> > demo.qml (eg.  analog clock's face is pretty isolated) which is then shown 
> > there and in sync with the actual Plasmoid by using parts of it.
> > On the other hand, Android also just shows screenshots :)
> 
> Marco Martin wrote:
> i think as well having an alpha channel would be much prettier, however 
> would require a specialized tool and would be slightly harder to do, needs to 
> be as easy and fast for the VDG people to do them quickly. (also applets that 
> make sense only as an expanded popup like kickoff would work better with the 
> wallpaper i think?)
> 
> Martin Gräßlin wrote:
> maybe we could get an easy "screenshot mode" into plasmoidviewer? So that 
> it
> - hides the background
> - uses correct size
> - saves it with a standardized name
>  
> Kickoff exposes another problem: some applets will need KWin help. Taking 
> the screenshot without a background won't work for them, though the 
> background hardly matters if we get the area around as translucent.
> 
> Martin Klapetek wrote:
> I too am worried about the screenshots getting out of date. Just for this 
> release the digital-clock got some serious overhaul in its looks. Now I'm not 
> opposed to the idea itself, but I don't think this scales too well. This 
> would need a dedicated person to review _all_ applets before release and 
> compare the screenshots...and from experience I don't believe we can keep 
> this up.
> 
> andreas kainz wrote:
> ok the proposal from the VDG (Uri and me)
> 
> 1. we will push 128x128px Previews in our kde:breeze icon set in 
> breeze/icons/apps/128 in an first step we ONLY have screenshots
> 2. we will make 128x128px colorefull Icons and remove the screenshots 
> with svg breeze and breeze dark icons where the user can recognize the 
> difference behavior for the different widgets instead of something like this 
> (https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/screenshot1.png)
> 
> So in the first step you have to live with screenshots BUT in the end you 
> get large widget icons where the user can recognize the widget.
> 
> Also for GHNS most widgets will only have at lease screenshots so it will 
> be always a mix between icons and screenshots, but as you know me will focus 
> on feature complete.
> 
> would this way work for you? For now the screenshots would work and 
> before the screenshots are not up to date the screenshots will be removed 
> with icons AND the widget icons are useing in the same behavior than all 
> other icons so the screenshots are in our structure and we will care about it.
> 
> Marco Martin wrote:
> that's ok for me, so it will have screenshots in the short term and ad 
> hoc icons in the long term.
> the icon names will be the same as the plugin name, so all desktop files 
> will need to have an updated Icon=org.kde.plasma.analogclock entry.
> screenshots inside the plasmoid package still supported, intended for 
> kdelook plasmoids that won't have an icon in the breeze theme.
> how does it sound?

I don't want to discourage you from your effort, not at all, but isn't it kind 
of a wasted work? I mean, you spend all that time on making all those 
screenshots and then just remove then again anyway...? Wouldn't it be better to 
spend the time on the icons directly?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/#review85105
---


On Sept. 10, 2015, 12:53 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125135/
> ---
> 
> (Updated Sept. 10, 2015, 12:53 p.m.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As requested by the VDG, show screenshots in the widget explorer when 
> available, to have a look similar to the activity manager (they'll do 
> screenshots for all our plasmoids).
> when a screenshot is not available, it falls back to the old design.
> this is an in-between design, the latest design would be with two columns 
> instead of one, but that would need to be tested as well beforehand, both in 
> the widget explorer and the activity switcher
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml

Re: Review Request 125135: show screenshots in the widget explorer

[Marco Martin]

> On Sept. 10, 2015, 11:43 a.m., Kai Uwe Broulik wrote:
> > First of all, I like the idea.
> > 
> > However, I think we should go with PNG with alpha channel rather than 
> > having the Breeze default wallpaper there which changes every release. 
> > Showing a fully working Plasmoid is probably too much in this list in terms 
> > of performance but might be worth thinking allowing a plasmoid to provide a 
> > demo.qml (eg.  analog clock's face is pretty isolated) which is then shown 
> > there and in sync with the actual Plasmoid by using parts of it.
> > On the other hand, Android also just shows screenshots :)
> 
> Marco Martin wrote:
> i think as well having an alpha channel would be much prettier, however 
> would require a specialized tool and would be slightly harder to do, needs to 
> be as easy and fast for the VDG people to do them quickly. (also applets that 
> make sense only as an expanded popup like kickoff would work better with the 
> wallpaper i think?)
> 
> Martin Gräßlin wrote:
> maybe we could get an easy "screenshot mode" into plasmoidviewer? So that 
> it
> - hides the background
> - uses correct size
> - saves it with a standardized name
>  
> Kickoff exposes another problem: some applets will need KWin help. Taking 
> the screenshot without a background won't work for them, though the 
> background hardly matters if we get the area around as translucent.
> 
> Martin Klapetek wrote:
> I too am worried about the screenshots getting out of date. Just for this 
> release the digital-clock got some serious overhaul in its looks. Now I'm not 
> opposed to the idea itself, but I don't think this scales too well. This 
> would need a dedicated person to review _all_ applets before release and 
> compare the screenshots...and from experience I don't believe we can keep 
> this up.
> 
> andreas kainz wrote:
> ok the proposal from the VDG (Uri and me)
> 
> 1. we will push 128x128px Previews in our kde:breeze icon set in 
> breeze/icons/apps/128 in an first step we ONLY have screenshots
> 2. we will make 128x128px colorefull Icons and remove the screenshots 
> with svg breeze and breeze dark icons where the user can recognize the 
> difference behavior for the different widgets instead of something like this 
> (https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/screenshot1.png)
> 
> So in the first step you have to live with screenshots BUT in the end you 
> get large widget icons where the user can recognize the widget.
> 
> Also for GHNS most widgets will only have at lease screenshots so it will 
> be always a mix between icons and screenshots, but as you know me will focus 
> on feature complete.
> 
> would this way work for you? For now the screenshots would work and 
> before the screenshots are not up to date the screenshots will be removed 
> with icons AND the widget icons are useing in the same behavior than all 
> other icons so the screenshots are in our structure and we will care about it.

that's ok for me, so it will have screenshots in the short term and ad hoc 
icons in the long term.
the icon names will be the same as the plugin name, so all desktop files will 
need to have an updated Icon=org.kde.plasma.analogclock entry.
screenshots inside the plasmoid package still supported, intended for kdelook 
plasmoids that won't have an icon in the breeze theme.
how does it sound?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/#review85105
---


On Sept. 10, 2015, 10:53 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125135/
> ---
> 
> (Updated Sept. 10, 2015, 10:53 a.m.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As requested by the VDG, show screenshots in the widget explorer when 
> available, to have a look similar to the activity manager (they'll do 
> screenshots for all our plasmoids).
> when a screenshot is not available, it falls back to the old design.
> this is an in-between design, the latest design would be with two columns 
> instead of one, but that would need to be tested as well beforehand, both in 
> the widget explorer and the activity switcher
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 
> 
> Diff: https://git.reviewboard.kde.org/r/125135/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot6.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

_

Re: Review Request 125135: show screenshots in the widget explorer

[andreas kainz]

> On Sept. 10, 2015, 11:43 a.m., Kai Uwe Broulik wrote:
> > First of all, I like the idea.
> > 
> > However, I think we should go with PNG with alpha channel rather than 
> > having the Breeze default wallpaper there which changes every release. 
> > Showing a fully working Plasmoid is probably too much in this list in terms 
> > of performance but might be worth thinking allowing a plasmoid to provide a 
> > demo.qml (eg.  analog clock's face is pretty isolated) which is then shown 
> > there and in sync with the actual Plasmoid by using parts of it.
> > On the other hand, Android also just shows screenshots :)
> 
> Marco Martin wrote:
> i think as well having an alpha channel would be much prettier, however 
> would require a specialized tool and would be slightly harder to do, needs to 
> be as easy and fast for the VDG people to do them quickly. (also applets that 
> make sense only as an expanded popup like kickoff would work better with the 
> wallpaper i think?)
> 
> Martin Gräßlin wrote:
> maybe we could get an easy "screenshot mode" into plasmoidviewer? So that 
> it
> - hides the background
> - uses correct size
> - saves it with a standardized name
>  
> Kickoff exposes another problem: some applets will need KWin help. Taking 
> the screenshot without a background won't work for them, though the 
> background hardly matters if we get the area around as translucent.
> 
> Martin Klapetek wrote:
> I too am worried about the screenshots getting out of date. Just for this 
> release the digital-clock got some serious overhaul in its looks. Now I'm not 
> opposed to the idea itself, but I don't think this scales too well. This 
> would need a dedicated person to review _all_ applets before release and 
> compare the screenshots...and from experience I don't believe we can keep 
> this up.

ok the proposal from the VDG (Uri and me)

1. we will push 128x128px Previews in our kde:breeze icon set in 
breeze/icons/apps/128 in an first step we ONLY have screenshots
2. we will make 128x128px colorefull Icons and remove the screenshots with svg 
breeze and breeze dark icons where the user can recognize the difference 
behavior for the different widgets instead of something like this 
(https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/screenshot1.png)

So in the first step you have to live with screenshots BUT in the end you get 
large widget icons where the user can recognize the widget.

Also for GHNS most widgets will only have at lease screenshots so it will be 
always a mix between icons and screenshots, but as you know me will focus on 
feature complete.

would this way work for you? For now the screenshots would work and before the 
screenshots are not up to date the screenshots will be removed with icons AND 
the widget icons are useing in the same behavior than all other icons so the 
screenshots are in our structure and we will care about it.


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/#review85105
---


On Sept. 10, 2015, 10:53 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125135/
> ---
> 
> (Updated Sept. 10, 2015, 10:53 a.m.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As requested by the VDG, show screenshots in the widget explorer when 
> available, to have a look similar to the activity manager (they'll do 
> screenshots for all our plasmoids).
> when a screenshot is not available, it falls back to the old design.
> this is an in-between design, the latest design would be with two columns 
> instead of one, but that would need to be tested as well beforehand, both in 
> the widget explorer and the activity switcher
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 
> 
> Diff: https://git.reviewboard.kde.org/r/125135/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot6.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125135: show screenshots in the widget explorer

[kainz.a]

and when the Screenshot was only shown when the Screenshot is e.g. 6 month
old.
Am 10.09.2015 15:36 schrieb "Martin Klapetek" :

> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125135/
>
> On September 10th, 2015, 1:43 p.m. CEST, *Kai Uwe Broulik* wrote:
>
> First of all, I like the idea.
>
> However, I think we should go with PNG with alpha channel rather than having 
> the Breeze default wallpaper there which changes every release. Showing a 
> fully working Plasmoid is probably too much in this list in terms of 
> performance but might be worth thinking allowing a plasmoid to provide a 
> demo.qml (eg.  analog clock's face is pretty isolated) which is then shown 
> there and in sync with the actual Plasmoid by using parts of it.
> On the other hand, Android also just shows screenshots :)
>
> On September 10th, 2015, 1:51 p.m. CEST, *Marco Martin* wrote:
>
> i think as well having an alpha channel would be much prettier, however would 
> require a specialized tool and would be slightly harder to do, needs to be as 
> easy and fast for the VDG people to do them quickly. (also applets that make 
> sense only as an expanded popup like kickoff would work better with the 
> wallpaper i think?)
>
> On September 10th, 2015, 2:06 p.m. CEST, *Martin Gräßlin* wrote:
>
> maybe we could get an easy "screenshot mode" into plasmoidviewer? So that it
> - hides the background
> - uses correct size
> - saves it with a standardized name
>
> Kickoff exposes another problem: some applets will need KWin help. Taking the 
> screenshot without a background won't work for them, though the background 
> hardly matters if we get the area around as translucent.
>
> I too am worried about the screenshots getting out of date. Just for this 
> release the digital-clock got some serious overhaul in its looks. Now I'm not 
> opposed to the idea itself, but I don't think this scales too well. This 
> would need a dedicated person to review _all_ applets before release and 
> compare the screenshots...and from experience I don't believe we can keep 
> this up.
>
>
> - Martin
>
> On September 10th, 2015, 12:53 p.m. CEST, Marco Martin wrote:
> Review request for Plasma and andreas kainz.
> By Marco Martin.
>
> *Updated Sept. 10, 2015, 12:53 p.m.*
> *Repository: * plasma-desktop
> Description
>
> As requested by the VDG, show screenshots in the widget explorer when 
> available, to have a look similar to the activity manager (they'll do 
> screenshots for all our plasmoids).
> when a screenshot is not available, it falls back to the old design.
> this is an in-between design, the latest design would be with two columns 
> instead of one, but that would need to be tested as well beforehand, both in 
> the widget explorer and the activity switcher
>
> Diffs
>
>- desktoppackage/contents/explorer/AppletDelegate.qml (7ded06e)
>
> View Diff 
> File Attachments
> - snapshot6.png
> 
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125135: show screenshots in the widget explorer

[Martin Klapetek]

> On Sept. 10, 2015, 1:43 p.m., Kai Uwe Broulik wrote:
> > First of all, I like the idea.
> > 
> > However, I think we should go with PNG with alpha channel rather than 
> > having the Breeze default wallpaper there which changes every release. 
> > Showing a fully working Plasmoid is probably too much in this list in terms 
> > of performance but might be worth thinking allowing a plasmoid to provide a 
> > demo.qml (eg.  analog clock's face is pretty isolated) which is then shown 
> > there and in sync with the actual Plasmoid by using parts of it.
> > On the other hand, Android also just shows screenshots :)
> 
> Marco Martin wrote:
> i think as well having an alpha channel would be much prettier, however 
> would require a specialized tool and would be slightly harder to do, needs to 
> be as easy and fast for the VDG people to do them quickly. (also applets that 
> make sense only as an expanded popup like kickoff would work better with the 
> wallpaper i think?)
> 
> Martin Gräßlin wrote:
> maybe we could get an easy "screenshot mode" into plasmoidviewer? So that 
> it
> - hides the background
> - uses correct size
> - saves it with a standardized name
>  
> Kickoff exposes another problem: some applets will need KWin help. Taking 
> the screenshot without a background won't work for them, though the 
> background hardly matters if we get the area around as translucent.

I too am worried about the screenshots getting out of date. Just for this 
release the digital-clock got some serious overhaul in its looks. Now I'm not 
opposed to the idea itself, but I don't think this scales too well. This would 
need a dedicated person to review _all_ applets before release and compare the 
screenshots...and from experience I don't believe we can keep this up.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/#review85105
---


On Sept. 10, 2015, 12:53 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125135/
> ---
> 
> (Updated Sept. 10, 2015, 12:53 p.m.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As requested by the VDG, show screenshots in the widget explorer when 
> available, to have a look similar to the activity manager (they'll do 
> screenshots for all our plasmoids).
> when a screenshot is not available, it falls back to the old design.
> this is an in-between design, the latest design would be with two columns 
> instead of one, but that would need to be tested as well beforehand, both in 
> the widget explorer and the activity switcher
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 
> 
> Diff: https://git.reviewboard.kde.org/r/125135/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot6.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125135: show screenshots in the widget explorer

[kainz.a]

I can also make it with transparent background. no Problem. we also can say
we move the Screenshot into KDE:breeze with the APP Name for the linking so
it would be more in or focus to change something.

whatever you like. it is an improvement for our users and it is according
to our guidelines.

Andreas
Am 10.09.2015 14:06 schrieb "Martin Gräßlin" :

> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125135/
>
> On September 10th, 2015, 1:43 p.m. CEST, *Kai Uwe Broulik* wrote:
>
> First of all, I like the idea.
>
> However, I think we should go with PNG with alpha channel rather than having 
> the Breeze default wallpaper there which changes every release. Showing a 
> fully working Plasmoid is probably too much in this list in terms of 
> performance but might be worth thinking allowing a plasmoid to provide a 
> demo.qml (eg.  analog clock's face is pretty isolated) which is then shown 
> there and in sync with the actual Plasmoid by using parts of it.
> On the other hand, Android also just shows screenshots :)
>
> On September 10th, 2015, 1:51 p.m. CEST, *Marco Martin* wrote:
>
> i think as well having an alpha channel would be much prettier, however would 
> require a specialized tool and would be slightly harder to do, needs to be as 
> easy and fast for the VDG people to do them quickly. (also applets that make 
> sense only as an expanded popup like kickoff would work better with the 
> wallpaper i think?)
>
> maybe we could get an easy "screenshot mode" into plasmoidviewer? So that it
> - hides the background
> - uses correct size
> - saves it with a standardized name
>
> Kickoff exposes another problem: some applets will need KWin help. Taking the 
> screenshot without a background won't work for them, though the background 
> hardly matters if we get the area around as translucent.
>
>
> - Martin
>
> On September 10th, 2015, 12:53 p.m. CEST, Marco Martin wrote:
> Review request for Plasma and andreas kainz.
> By Marco Martin.
>
> *Updated Sept. 10, 2015, 12:53 p.m.*
> *Repository: * plasma-desktop
> Description
>
> As requested by the VDG, show screenshots in the widget explorer when 
> available, to have a look similar to the activity manager (they'll do 
> screenshots for all our plasmoids).
> when a screenshot is not available, it falls back to the old design.
> this is an in-between design, the latest design would be with two columns 
> instead of one, but that would need to be tested as well beforehand, both in 
> the widget explorer and the activity switcher
>
> Diffs
>
>- desktoppackage/contents/explorer/AppletDelegate.qml (7ded06e)
>
> View Diff 
> File Attachments
> - snapshot6.png
> 
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125135: show screenshots in the widget explorer

[Martin Gräßlin]

> On Sept. 10, 2015, 1:43 p.m., Kai Uwe Broulik wrote:
> > First of all, I like the idea.
> > 
> > However, I think we should go with PNG with alpha channel rather than 
> > having the Breeze default wallpaper there which changes every release. 
> > Showing a fully working Plasmoid is probably too much in this list in terms 
> > of performance but might be worth thinking allowing a plasmoid to provide a 
> > demo.qml (eg.  analog clock's face is pretty isolated) which is then shown 
> > there and in sync with the actual Plasmoid by using parts of it.
> > On the other hand, Android also just shows screenshots :)
> 
> Marco Martin wrote:
> i think as well having an alpha channel would be much prettier, however 
> would require a specialized tool and would be slightly harder to do, needs to 
> be as easy and fast for the VDG people to do them quickly. (also applets that 
> make sense only as an expanded popup like kickoff would work better with the 
> wallpaper i think?)

maybe we could get an easy "screenshot mode" into plasmoidviewer? So that it
- hides the background
- uses correct size
- saves it with a standardized name
 
Kickoff exposes another problem: some applets will need KWin help. Taking the 
screenshot without a background won't work for them, though the background 
hardly matters if we get the area around as translucent.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/#review85105
---


On Sept. 10, 2015, 12:53 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125135/
> ---
> 
> (Updated Sept. 10, 2015, 12:53 p.m.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As requested by the VDG, show screenshots in the widget explorer when 
> available, to have a look similar to the activity manager (they'll do 
> screenshots for all our plasmoids).
> when a screenshot is not available, it falls back to the old design.
> this is an in-between design, the latest design would be with two columns 
> instead of one, but that would need to be tested as well beforehand, both in 
> the widget explorer and the activity switcher
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 
> 
> Diff: https://git.reviewboard.kde.org/r/125135/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot6.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125135: show screenshots in the widget explorer

[Marco Martin]

> On Sept. 10, 2015, 11:43 a.m., Kai Uwe Broulik wrote:
> > First of all, I like the idea.
> > 
> > However, I think we should go with PNG with alpha channel rather than 
> > having the Breeze default wallpaper there which changes every release. 
> > Showing a fully working Plasmoid is probably too much in this list in terms 
> > of performance but might be worth thinking allowing a plasmoid to provide a 
> > demo.qml (eg.  analog clock's face is pretty isolated) which is then shown 
> > there and in sync with the actual Plasmoid by using parts of it.
> > On the other hand, Android also just shows screenshots :)

i think as well having an alpha channel would be much prettier, however would 
require a specialized tool and would be slightly harder to do, needs to be as 
easy and fast for the VDG people to do them quickly. (also applets that make 
sense only as an expanded popup like kickoff would work better with the 
wallpaper i think?)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/#review85105
---


On Sept. 10, 2015, 10:53 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125135/
> ---
> 
> (Updated Sept. 10, 2015, 10:53 a.m.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As requested by the VDG, show screenshots in the widget explorer when 
> available, to have a look similar to the activity manager (they'll do 
> screenshots for all our plasmoids).
> when a screenshot is not available, it falls back to the old design.
> this is an in-between design, the latest design would be with two columns 
> instead of one, but that would need to be tested as well beforehand, both in 
> the widget explorer and the activity switcher
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 
> 
> Diff: https://git.reviewboard.kde.org/r/125135/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot6.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125135: show screenshots in the widget explorer

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/#review85105
---


First of all, I like the idea.

However, I think we should go with PNG with alpha channel rather than having 
the Breeze default wallpaper there which changes every release. Showing a fully 
working Plasmoid is probably too much in this list in terms of performance but 
might be worth thinking allowing a plasmoid to provide a demo.qml (eg.  analog 
clock's face is pretty isolated) which is then shown there and in sync with the 
actual Plasmoid by using parts of it.
On the other hand, Android also just shows screenshots :)

- Kai Uwe Broulik


On Sept. 10, 2015, 10:53 vorm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125135/
> ---
> 
> (Updated Sept. 10, 2015, 10:53 vorm.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As requested by the VDG, show screenshots in the widget explorer when 
> available, to have a look similar to the activity manager (they'll do 
> screenshots for all our plasmoids).
> when a screenshot is not available, it falls back to the old design.
> this is an in-between design, the latest design would be with two columns 
> instead of one, but that would need to be tested as well beforehand, both in 
> the widget explorer and the activity switcher
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 
> 
> Diff: https://git.reviewboard.kde.org/r/125135/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot6.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125135: show screenshots in the widget explorer

[Martin Gräßlin]

> On Sept. 10, 2015, 1:13 p.m., andreas kainz wrote:
> > the thing is that it is not easy for the user to add or use an alternative 
> > plasmoid cause the plasmoids don't have specific application icons. now it 
> > is a mix between the user application icons, action icons, 
> > 
> > the VDG discuss to make for all widgets specific application icons. But 
> > first it is much work and second an preview would be much better cause the 
> > user will know what will be added. In addition the activity sidebar and the 
> > application switcher sidebar also have previews so we start talking about 
> > an global look and feel see 
> > user-prompt.com/look-and-feel-of-plasma-sidebars/
> > 
> > For the user previews would be the best way to show what the widget is used 
> > for. For the VDG it is less work to make screenshots than application icons 
> > and for the overall design it would be more consistent.
> > 
> > The problem that screenshots could be fast outdated is true but as long as 
> > the plasma theme don't change that much the widgets would have the same 
> > screenshot. In addition plasmoids from ghns have also screenshots to show 
> > the user what he will download. If there is no screenshot the app icon was 
> > shown.
> > 
> > About the size. Now the list is quite long so it would be nice to have two 
> > columns and we prefere also to have two columns in addition the use can 
> > resize the panel to get an better overview.
> > 
> > This is an rewrite for plasma mobile and I think we had a good solution for 
> > an consistant look and feel and should use it for the rewrite.

> The problem that screenshots could be fast outdated is true but as long as 
> the plasma theme don't change that much the widgets would have the same 
> screenshot.

If we use history as a factor: it changes a lot. The plasma theme had tweaks to 
it in almost every release. We shouldn't just ignore that point.

I'm not opposed to the feature, but I think we should think about the long term 
scalability of the feature. I'm in this situation now with kwin effects, which 
all got created just a month or two before breeze got started. So please 
consider this point as experience talking to you ;-)

For KWin I think the solution will be live preview: start a nested kwin which 
demonstrates the effect. Maybe something like that could also be done in this 
case. Instead of showing a screenshot, start plasmoidviewer in a dedicated mode 
to truly preview it (including interaction).


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/#review85102
---


On Sept. 10, 2015, 12:53 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125135/
> ---
> 
> (Updated Sept. 10, 2015, 12:53 p.m.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As requested by the VDG, show screenshots in the widget explorer when 
> available, to have a look similar to the activity manager (they'll do 
> screenshots for all our plasmoids).
> when a screenshot is not available, it falls back to the old design.
> this is an in-between design, the latest design would be with two columns 
> instead of one, but that would need to be tested as well beforehand, both in 
> the widget explorer and the activity switcher
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 
> 
> Diff: https://git.reviewboard.kde.org/r/125135/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot6.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125135: show screenshots in the widget explorer

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/#review85102
---


the thing is that it is not easy for the user to add or use an alternative 
plasmoid cause the plasmoids don't have specific application icons. now it is a 
mix between the user application icons, action icons, 

the VDG discuss to make for all widgets specific application icons. But first 
it is much work and second an preview would be much better cause the user will 
know what will be added. In addition the activity sidebar and the application 
switcher sidebar also have previews so we start talking about an global look 
and feel see user-prompt.com/look-and-feel-of-plasma-sidebars/

For the user previews would be the best way to show what the widget is used 
for. For the VDG it is less work to make screenshots than application icons and 
for the overall design it would be more consistent.

The problem that screenshots could be fast outdated is true but as long as the 
plasma theme don't change that much the widgets would have the same screenshot. 
In addition plasmoids from ghns have also screenshots to show the user what he 
will download. If there is no screenshot the app icon was shown.

About the size. Now the list is quite long so it would be nice to have two 
columns and we prefere also to have two columns in addition the use can resize 
the panel to get an better overview.

This is an rewrite for plasma mobile and I think we had a good solution for an 
consistant look and feel and should use it for the rewrite.

- andreas kainz


On Sept. 10, 2015, 10:53 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125135/
> ---
> 
> (Updated Sept. 10, 2015, 10:53 a.m.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> As requested by the VDG, show screenshots in the widget explorer when 
> available, to have a look similar to the activity manager (they'll do 
> screenshots for all our plasmoids).
> when a screenshot is not available, it falls back to the old design.
> this is an in-between design, the latest design would be with two columns 
> instead of one, but that would need to be tested as well beforehand, both in 
> the widget explorer and the activity switcher
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 
> 
> Diff: https://git.reviewboard.kde.org/r/125135/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot6.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125135: show screenshots in the widget explorer

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/
---

(Updated Sept. 10, 2015, 10:33 a.m.)


Review request for Plasma.


Repository: plasma-desktop


Description (updated)
---

As requested by the VDG, show screenshots in the widget explorer when 
available, to have a look similar to the activity manager (they'll do 
screenshots for all our plasmoids).
when a screenshot is not available, it falls back to the old design.
this is an in-between design, the latest design would be with two columns 
instead of one, but that would need to be tested as well beforehand, both in 
the widget explorer and the activity switcher


Diffs
-

  desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 

Diff: https://git.reviewboard.kde.org/r/125135/diff/


Testing
---


File Attachments


snapshot6.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125135: show screenshots in the widget explorer

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125135/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

As requested by the VDG, show screenshots in the widget explorer when 
available, to have a look similar to the activity manager (they'll do 
screenshots for all our plasmoids).
this is an in-between design, the latest design would be with two columns 
instead of one, but that would need to be tested as well beforehand, both in 
the widget explorer and the activity switcher


Diffs
-

  desktoppackage/contents/explorer/AppletDelegate.qml 7ded06e 

Diff: https://git.reviewboard.kde.org/r/125135/diff/


Testing
---


File Attachments


snapshot6.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/10/73db8a25-adaa-4d18-9aa5-35f2c5156ad4__snapshot6.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel