Re: Review Request 125190: Daemonize the forked kwalletd process.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125190/ --- (Updated Sept. 14, 2015, 6:46 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Àlex Fiestas and Martin Klapetek. Changes --- Submitted with commit 115ad562baf0cb0534876cbcb705fd9190e290b4 by Weng Xuetian to branch master. Repository: kwallet-pam Description --- For example, if desktop is started by sddm, - for kwalletd5, it will be a subprocess of sddm-helper. - for kwalletd, there will be zombie subprocess of sddm-helper. Here we make use of the old trick to fork twice and collect the status of intermediate process with waitpid to avoid zombie process. --nofork is used for kwalletd case to avoid it fork yet another process. Diffs - pam_kwallet.c a84585e Diff: https://git.reviewboard.kde.org/r/125190/diff/ Testing --- No more zombie process, kwalletd and kwalletd5 become subprocess of pid 1. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125190: Daemonize the forked kwalletd process.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125190/#review85341 --- Ship it! The change looks good. - Àlex Fiestas On set. 12, 2015, 10:37 a.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125190/ > --- > > (Updated set. 12, 2015, 10:37 a.m.) > > > Review request for Plasma, Àlex Fiestas and Martin Klapetek. > > > Repository: kwallet-pam > > > Description > --- > > For example, if desktop is started by sddm, > - for kwalletd5, it will be a subprocess of sddm-helper. > - for kwalletd, there will be zombie subprocess of sddm-helper. > > Here we make use of the old trick to fork twice and collect the status of > intermediate process with waitpid to avoid zombie process. --nofork is used > for kwalletd case to avoid it fork yet another process. > > > Diffs > - > > pam_kwallet.c a84585e > > Diff: https://git.reviewboard.kde.org/r/125190/diff/ > > > Testing > --- > > No more zombie process, kwalletd and kwalletd5 become subprocess of pid 1. > > > Thanks, > > Xuetian Weng > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 125190: Daemonize the forked kwalletd process.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125190/ --- Review request for Plasma and Àlex Fiestas. Repository: kwallet-pam Description --- For example, currently if desktop is started by sddm. For kwalletd5, it will be a subprocess of sddm-helper. For kwalletd, there will be zombie subprocess. Here we make use of the old trick to fork twice and collect the status of intermediate process with waitpid to avoid zombie process. --nofork is used for kwalletd case to avoid it fork yet another process. Diffs - pam_kwallet.c a84585e Diff: https://git.reviewboard.kde.org/r/125190/diff/ Testing --- No more zombie process, kwalletd and kwalletd5 become subprocess of pid 1. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125190: Daemonize the forked kwalletd process.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125190/ --- (Updated Sept. 12, 2015, 10:35 a.m.) Review request for Plasma and Àlex Fiestas. Repository: kwallet-pam Description (updated) --- For example, if desktop is started by sddm, For kwalletd5, it will be a subprocess of sddm-helper. For kwalletd, there will be zombie subprocess. Here we make use of the old trick to fork twice and collect the status of intermediate process with waitpid to avoid zombie process. --nofork is used for kwalletd case to avoid it fork yet another process. Diffs - pam_kwallet.c a84585e Diff: https://git.reviewboard.kde.org/r/125190/diff/ Testing --- No more zombie process, kwalletd and kwalletd5 become subprocess of pid 1. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125190: Daemonize the forked kwalletd process.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125190/ --- (Updated Sept. 12, 2015, 10:37 a.m.) Review request for Plasma, Àlex Fiestas and Martin Klapetek. Changes --- add mklapetek as reviewer Repository: kwallet-pam Description (updated) --- For example, if desktop is started by sddm, - for kwalletd5, it will be a subprocess of sddm-helper. - for kwalletd, there will be zombie subprocess of sddm-helper. Here we make use of the old trick to fork twice and collect the status of intermediate process with waitpid to avoid zombie process. --nofork is used for kwalletd case to avoid it fork yet another process. Diffs - pam_kwallet.c a84585e Diff: https://git.reviewboard.kde.org/r/125190/diff/ Testing --- No more zombie process, kwalletd and kwalletd5 become subprocess of pid 1. Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
