Re: Review Request 125323: Continue even if script returns errors
> On Oct. 6, 2015, 1:30 a.m., Rex Dieter wrote: > > Wrapping this in a subshell effectively makes the source'ing ineffective, > > fyi. Adding the ||: at the end is sufficient. Fixed. thanks for the reminder. Siddartha above said the same thing, but it got a bit lost in the comments. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125323/#review86400 --- On Sept. 20, 2015, 3:59 p.m., Steven Franzen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125323/ > --- > > (Updated Sept. 20, 2015, 3:59 p.m.) > > > Review request for Plasma and Luca Beltrame. > > > Bugs: 352491 > https://bugs.kde.org/show_bug.cgi?id=352491 > > > Repository: plasma-workspace > > > Description > --- > > /bin/sh stops execution upon finding a nonzero exit code, which means that > startkde will not continue if a script in .config/plasma-workspace/env/ > produces an error. This small fix will execute a no-op in such a case, so > that errors will not affect startkde's progress, while still being visible in > .xsession-errors. > > > Diffs > - > > startkde/startkde.cmake 8948489c63c1bce0974bd2b3ce83515b1870af3a > > Diff: https://git.reviewboard.kde.org/r/125323/diff/ > > > Testing > --- > > Tested both env-old.sh and env-new.sh with envvars.sh in ./testing, which > refers to a location that no longer exists on my system. Confirmed that only > env-new.sh performs the echo at the end. > > > File Attachments > > > The current section from startkde > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/3ac48cee-7656-48dc-9cb9-c119c93a87da__env-old.sh > The fix > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f40c8612-27d0-4df0-a53f-47f5ff8220a1__env-new.sh > Script from the bug report > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/87cf8534-2a6a-42b1-8f6c-c8f59f4a8537__envvars.sh > > > Thanks, > > Steven Franzen > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125323: Continue even if script returns errors
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125323/#review86400 --- Wrapping this in a subshell effectively makes the source'ing ineffective, fyi. Adding the ||: at the end is sufficient. - Rex Dieter On Sept. 20, 2015, 3:59 p.m., Steven Franzen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125323/ > --- > > (Updated Sept. 20, 2015, 3:59 p.m.) > > > Review request for Plasma and Luca Beltrame. > > > Bugs: 352491 > https://bugs.kde.org/show_bug.cgi?id=352491 > > > Repository: plasma-workspace > > > Description > --- > > /bin/sh stops execution upon finding a nonzero exit code, which means that > startkde will not continue if a script in .config/plasma-workspace/env/ > produces an error. This small fix will execute a no-op in such a case, so > that errors will not affect startkde's progress, while still being visible in > .xsession-errors. > > > Diffs > - > > startkde/startkde.cmake 8948489c63c1bce0974bd2b3ce83515b1870af3a > > Diff: https://git.reviewboard.kde.org/r/125323/diff/ > > > Testing > --- > > Tested both env-old.sh and env-new.sh with envvars.sh in ./testing, which > refers to a location that no longer exists on my system. Confirmed that only > env-new.sh performs the echo at the end. > > > File Attachments > > > The current section from startkde > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/3ac48cee-7656-48dc-9cb9-c119c93a87da__env-old.sh > The fix > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f40c8612-27d0-4df0-a53f-47f5ff8220a1__env-new.sh > Script from the bug report > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/87cf8534-2a6a-42b1-8f6c-c8f59f4a8537__envvars.sh > > > Thanks, > > Steven Franzen > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125323: Continue even if script returns errors
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125323/#review86067 --- The scripts are being sourced in a subshell, so echo will work, but the sourced variabled are then discarded. It should be `test -r "$file" && . "$file" || true` (lets use `true` instead of `:` for better clarity?) - Siddhartha Sahu On Sept. 20, 2015, 9:29 p.m., Steven Franzen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125323/ > --- > > (Updated Sept. 20, 2015, 9:29 p.m.) > > > Review request for Plasma and Luca Beltrame. > > > Bugs: 352491 > https://bugs.kde.org/show_bug.cgi?id=352491 > > > Repository: plasma-workspace > > > Description > --- > > /bin/sh stops execution upon finding a nonzero exit code, which means that > startkde will not continue if a script in .config/plasma-workspace/env/ > produces an error. This small fix will execute a no-op in such a case, so > that errors will not affect startkde's progress, while still being visible in > .xsession-errors. > > > Diffs > - > > startkde/startkde.cmake 8948489c63c1bce0974bd2b3ce83515b1870af3a > > Diff: https://git.reviewboard.kde.org/r/125323/diff/ > > > Testing > --- > > Tested both env-old.sh and env-new.sh with envvars.sh in ./testing, which > refers to a location that no longer exists on my system. Confirmed that only > env-new.sh performs the echo at the end. > > > File Attachments > > > The current section from startkde > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/3ac48cee-7656-48dc-9cb9-c119c93a87da__env-old.sh > The fix > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f40c8612-27d0-4df0-a53f-47f5ff8220a1__env-new.sh > Script from the bug report > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/87cf8534-2a6a-42b1-8f6c-c8f59f4a8537__envvars.sh > > > Thanks, > > Steven Franzen > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125323: Continue even if script returns errors
> On Sept. 20, 2015, 1:31 p.m., David Edmundson wrote: > > Thanks > > > > Do you have commit access? Nope, I don't - Steven --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125323/#review85686 --- On Sept. 20, 2015, 1:11 p.m., Steven Franzen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125323/ > --- > > (Updated Sept. 20, 2015, 1:11 p.m.) > > > Review request for Plasma and Luca Beltrame. > > > Bugs: 352491 > https://bugs.kde.org/show_bug.cgi?id=352491 > > > Repository: plasma-workspace > > > Description > --- > > /bin/sh stops execution upon finding a nonzero exit code, which means that > startkde will not continue if a script in .config/plasma-workspace/env/ > produces an error. This small fix will execute a no-op in such a case, so > that errors will not affect startkde's progress, while still being visible in > .xsession-errors. > > > Diffs > - > > startkde/startkde.cmake 8948489c63c1bce0974bd2b3ce83515b1870af3a > > Diff: https://git.reviewboard.kde.org/r/125323/diff/ > > > Testing > --- > > Tested both env-old.sh and env-new.sh with envvars.sh in ./testing, which > refers to a location that no longer exists on my system. Confirmed that only > env-new.sh performs the echo at the end. > > > File Attachments > > > The current section from startkde > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/3ac48cee-7656-48dc-9cb9-c119c93a87da__env-old.sh > The fix > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f40c8612-27d0-4df0-a53f-47f5ff8220a1__env-new.sh > Script from the bug report > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/87cf8534-2a6a-42b1-8f6c-c8f59f4a8537__envvars.sh > > > Thanks, > > Steven Franzen > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125323: Continue even if script returns errors
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125323/#review85691 --- Ship it! Assuming you tested this with /bin/sh, I'm fine with it. - Luca Beltrame On Set. 20, 2015, 3:11 p.m., Steven Franzen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125323/ > --- > > (Updated Set. 20, 2015, 3:11 p.m.) > > > Review request for Plasma and Luca Beltrame. > > > Bugs: 352491 > https://bugs.kde.org/show_bug.cgi?id=352491 > > > Repository: plasma-workspace > > > Description > --- > > /bin/sh stops execution upon finding a nonzero exit code, which means that > startkde will not continue if a script in .config/plasma-workspace/env/ > produces an error. This small fix will execute a no-op in such a case, so > that errors will not affect startkde's progress, while still being visible in > .xsession-errors. > > > Diffs > - > > startkde/startkde.cmake 8948489c63c1bce0974bd2b3ce83515b1870af3a > > Diff: https://git.reviewboard.kde.org/r/125323/diff/ > > > Testing > --- > > Tested both env-old.sh and env-new.sh with envvars.sh in ./testing, which > refers to a location that no longer exists on my system. Confirmed that only > env-new.sh performs the echo at the end. > > > File Attachments > > > The current section from startkde > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/3ac48cee-7656-48dc-9cb9-c119c93a87da__env-old.sh > The fix > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f40c8612-27d0-4df0-a53f-47f5ff8220a1__env-new.sh > Script from the bug report > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/87cf8534-2a6a-42b1-8f6c-c8f59f4a8537__envvars.sh > > > Thanks, > > Steven Franzen > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125323: Continue even if script returns errors
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125323/#review85686 --- Ship it! Thanks Do you have commit access? - David Edmundson On Sept. 20, 2015, 1:11 p.m., Steven Franzen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125323/ > --- > > (Updated Sept. 20, 2015, 1:11 p.m.) > > > Review request for Plasma and Luca Beltrame. > > > Bugs: 352491 > https://bugs.kde.org/show_bug.cgi?id=352491 > > > Repository: plasma-workspace > > > Description > --- > > /bin/sh stops execution upon finding a nonzero exit code, which means that > startkde will not continue if a script in .config/plasma-workspace/env/ > produces an error. This small fix will execute a no-op in such a case, so > that errors will not affect startkde's progress, while still being visible in > .xsession-errors. > > > Diffs > - > > startkde/startkde.cmake 8948489c63c1bce0974bd2b3ce83515b1870af3a > > Diff: https://git.reviewboard.kde.org/r/125323/diff/ > > > Testing > --- > > Tested both env-old.sh and env-new.sh with envvars.sh in ./testing, which > refers to a location that no longer exists on my system. Confirmed that only > env-new.sh performs the echo at the end. > > > File Attachments > > > The current section from startkde > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/3ac48cee-7656-48dc-9cb9-c119c93a87da__env-old.sh > The fix > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f40c8612-27d0-4df0-a53f-47f5ff8220a1__env-new.sh > Script from the bug report > > https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/87cf8534-2a6a-42b1-8f6c-c8f59f4a8537__envvars.sh > > > Thanks, > > Steven Franzen > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 125323: Continue even if script returns errors
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125323/ --- Review request for Plasma and Luca Beltrame. Bugs: 352491 https://bugs.kde.org/show_bug.cgi?id=352491 Repository: plasma-workspace Description --- /bin/sh stops execution upon finding a nonzero exit code, which means that startkde will not continue if a script in .config/plasma-workspace/env/ produces an error. This small fix will execute a no-op in such a case, so that errors will not affect startkde's progress, while still being visible in .xsession-errors. Diffs - startkde/startkde.cmake 8948489c63c1bce0974bd2b3ce83515b1870af3a Diff: https://git.reviewboard.kde.org/r/125323/diff/ Testing --- Tested both env-old.sh and env-new.sh with envvars.sh in ./testing, which refers to a location that no longer exists on my system. Confirmed that only env-new.sh performs the echo at the end. File Attachments The current section from startkde https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/3ac48cee-7656-48dc-9cb9-c119c93a87da__env-old.sh The fix https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f40c8612-27d0-4df0-a53f-47f5ff8220a1__env-new.sh Script from the bug report https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/87cf8534-2a6a-42b1-8f6c-c8f59f4a8537__envvars.sh Thanks, Steven Franzen ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125323: Continue even if script returns errors
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125323/ --- (Updated Sept. 20, 2015, 3:59 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Luca Beltrame. Changes --- Submitted with commit 2870b5e69bf892c3d08df2d8ee11491542e0d796 by David Edmundson on behalf of Steven Franzen to branch Plasma/5.4. Bugs: 352491 https://bugs.kde.org/show_bug.cgi?id=352491 Repository: plasma-workspace Description --- /bin/sh stops execution upon finding a nonzero exit code, which means that startkde will not continue if a script in .config/plasma-workspace/env/ produces an error. This small fix will execute a no-op in such a case, so that errors will not affect startkde's progress, while still being visible in .xsession-errors. Diffs - startkde/startkde.cmake 8948489c63c1bce0974bd2b3ce83515b1870af3a Diff: https://git.reviewboard.kde.org/r/125323/diff/ Testing --- Tested both env-old.sh and env-new.sh with envvars.sh in ./testing, which refers to a location that no longer exists on my system. Confirmed that only env-new.sh performs the echo at the end. File Attachments The current section from startkde https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/3ac48cee-7656-48dc-9cb9-c119c93a87da__env-old.sh The fix https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f40c8612-27d0-4df0-a53f-47f5ff8220a1__env-new.sh Script from the bug report https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/87cf8534-2a6a-42b1-8f6c-c8f59f4a8537__envvars.sh Thanks, Steven Franzen ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel