Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-20 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/
---

(Updated Oct. 20, 2015, 9:11 a.m.)


Review request for Plasma.


Repository: plasma-framework


Description
---

This makes IconItem try to load global icons from the theme with Plasma::Svg as 
well, making it assign the colors from the stylesheet if the breeze monochrome 
icons are treated, that should be scriptable, from some attempts i did the 
script seems to convert them correctly, without any change in rendering.

This will automatically color monochrome breeze icons only in plasmashell, and 
more specifically only those that use IconItem, not QIconItem (iconitem should 
probably have an animation-less mode to be able to be used in taskmanager and 
stuff)
perhaps in the future we'll be able somehow to hook all this stuff in 
QIconEngine to be able to use it in QWidget applications, but since QIcon does 
have any idea where it is, is not usable yet for things like the fullscreen 
fixed-dark gwenview view.


Diffs (updated)
-

  src/declarativeimports/core/iconitem.h 3ef0306 
  src/declarativeimports/core/iconitem.cpp 692cd8d 
  src/plasma/private/svg_p.h ab91c42 
  src/plasma/svg.h 3ad21ce 
  src/plasma/svg.cpp 37ced22 

Diff: https://git.reviewboard.kde.org/r/125657/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-20 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/
---

(Updated Oct. 20, 2015, 9:49 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit c1065ccf399877c0738ab50a110e35b12a34c390 by Marco Martin 
to branch master.


Repository: plasma-framework


Description
---

This makes IconItem try to load global icons from the theme with Plasma::Svg as 
well, making it assign the colors from the stylesheet if the breeze monochrome 
icons are treated, that should be scriptable, from some attempts i did the 
script seems to convert them correctly, without any change in rendering.

This will automatically color monochrome breeze icons only in plasmashell, and 
more specifically only those that use IconItem, not QIconItem (iconitem should 
probably have an animation-less mode to be able to be used in taskmanager and 
stuff)
perhaps in the future we'll be able somehow to hook all this stuff in 
QIconEngine to be able to use it in QWidget applications, but since QIcon does 
have any idea where it is, is not usable yet for things like the fullscreen 
fixed-dark gwenview view.


Diffs
-

  src/declarativeimports/core/iconitem.h 3ef0306 
  src/declarativeimports/core/iconitem.cpp 692cd8d 
  src/plasma/private/svg_p.h ab91c42 
  src/plasma/svg.h 3ad21ce 
  src/plasma/svg.cpp 37ced22 

Diff: https://git.reviewboard.kde.org/r/125657/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-16 Thread Marco Martin 


> On Oct. 16, 2015, 3:14 p.m., Andrew Lake wrote:
> > Is it fair to interpret this as a possible path to reducing the duplication 
> > of icons between the main icon theme and the plasma theme?

yes, I want to keep some main ones in the plasma theme as some icons are 
actually composed from multiple elements in the same file and in general is 
slightly faster, but apart the main classical systray ones, some duplication 
could be removed


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/#review86927
---


On Oct. 16, 2015, 2:48 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125657/
> ---
> 
> (Updated Oct. 16, 2015, 2:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This makes IconItem try to load global icons from the theme with Plasma::Svg 
> as well, making it assign the colors from the stylesheet if the breeze 
> monochrome icons are treated, that should be scriptable, from some attempts i 
> did the script seems to convert them correctly, without any change in 
> rendering.
> 
> This will automatically color monochrome breeze icons only in plasmashell, 
> and more specifically only those that use IconItem, not QIconItem (iconitem 
> should probably have an animation-less mode to be able to be used in 
> taskmanager and stuff)
> perhaps in the future we'll be able somehow to hook all this stuff in 
> QIconEngine to be able to use it in QWidget applications, but since QIcon 
> does have any idea where it is, is not usable yet for things like the 
> fullscreen fixed-dark gwenview view.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3ef0306 
>   src/declarativeimports/core/iconitem.cpp 692cd8d 
>   src/plasma/private/svg_p.h ab91c42 
>   src/plasma/svg.h 3ad21ce 
>   src/plasma/svg.cpp 37ced22 
> 
> Diff: https://git.reviewboard.kde.org/r/125657/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-16 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

This makes IconItem try to load global icons from the theme with Plasma::Svg as 
well, making it assign the colors from the stylesheet if the breeze monochrome 
icons are treated, that should be scriptable, from some attempts i did the 
script seems to convert them correctly, without any change in rendering.

This will automatically color monochrome breeze icons only in plasmashell, and 
more specifically only those that use IconItem, not QIconItem (iconitem should 
probably have an animation-less mode to be able to be used in taskmanager and 
stuff)
perhaps in the future we'll be able somehow to hook all this stuff in 
QIconEngine to be able to use it in QWidget applications, but since QIcon does 
have any idea where it is, is not usable yet for things like the fullscreen 
fixed-dark gwenview view.


Diffs
-

  src/declarativeimports/core/iconitem.h 3ef0306 
  src/declarativeimports/core/iconitem.cpp 692cd8d 
  src/plasma/private/svg_p.h ab91c42 
  src/plasma/svg.h 3ad21ce 
  src/plasma/svg.cpp 37ced22 
  src/tools/apply-stylesheet.sh 797c5fd 

Diff: https://git.reviewboard.kde.org/r/125657/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-16 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/#review86916
---



src/declarativeimports/core/iconitem.cpp (line 134)


update this



src/declarativeimports/core/iconitem.cpp (line 141)






src/declarativeimports/core/iconitem.cpp (lines 341 - 348)


it looks like you already do all this on line 142 of this diff.


- David Edmundson


On Oct. 16, 2015, 1:10 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125657/
> ---
> 
> (Updated Oct. 16, 2015, 1:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This makes IconItem try to load global icons from the theme with Plasma::Svg 
> as well, making it assign the colors from the stylesheet if the breeze 
> monochrome icons are treated, that should be scriptable, from some attempts i 
> did the script seems to convert them correctly, without any change in 
> rendering.
> 
> This will automatically color monochrome breeze icons only in plasmashell, 
> and more specifically only those that use IconItem, not QIconItem (iconitem 
> should probably have an animation-less mode to be able to be used in 
> taskmanager and stuff)
> perhaps in the future we'll be able somehow to hook all this stuff in 
> QIconEngine to be able to use it in QWidget applications, but since QIcon 
> does have any idea where it is, is not usable yet for things like the 
> fullscreen fixed-dark gwenview view.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3ef0306 
>   src/declarativeimports/core/iconitem.cpp 692cd8d 
>   src/plasma/private/svg_p.h ab91c42 
>   src/plasma/svg.h 3ad21ce 
>   src/plasma/svg.cpp 37ced22 
>   src/tools/apply-stylesheet.sh 797c5fd 
> 
> Diff: https://git.reviewboard.kde.org/r/125657/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-16 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/
---

(Updated Oct. 16, 2015, 1:26 p.m.)


Review request for Plasma.


Repository: plasma-framework


Description
---

This makes IconItem try to load global icons from the theme with Plasma::Svg as 
well, making it assign the colors from the stylesheet if the breeze monochrome 
icons are treated, that should be scriptable, from some attempts i did the 
script seems to convert them correctly, without any change in rendering.

This will automatically color monochrome breeze icons only in plasmashell, and 
more specifically only those that use IconItem, not QIconItem (iconitem should 
probably have an animation-less mode to be able to be used in taskmanager and 
stuff)
perhaps in the future we'll be able somehow to hook all this stuff in 
QIconEngine to be able to use it in QWidget applications, but since QIcon does 
have any idea where it is, is not usable yet for things like the fullscreen 
fixed-dark gwenview view.


Diffs (updated)
-

  src/declarativeimports/core/iconitem.h 3ef0306 
  src/declarativeimports/core/iconitem.cpp 692cd8d 
  src/plasma/private/svg_p.h ab91c42 
  src/plasma/svg.h 3ad21ce 
  src/plasma/svg.cpp 37ced22 

Diff: https://git.reviewboard.kde.org/r/125657/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-16 Thread Andrew Lake 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/#review86927
---


Is it fair to interpret this as a possible path to reducing the duplication of 
icons between the main icon theme and the plasma theme?

- Andrew Lake


On Oct. 16, 2015, 2:48 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125657/
> ---
> 
> (Updated Oct. 16, 2015, 2:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This makes IconItem try to load global icons from the theme with Plasma::Svg 
> as well, making it assign the colors from the stylesheet if the breeze 
> monochrome icons are treated, that should be scriptable, from some attempts i 
> did the script seems to convert them correctly, without any change in 
> rendering.
> 
> This will automatically color monochrome breeze icons only in plasmashell, 
> and more specifically only those that use IconItem, not QIconItem (iconitem 
> should probably have an animation-less mode to be able to be used in 
> taskmanager and stuff)
> perhaps in the future we'll be able somehow to hook all this stuff in 
> QIconEngine to be able to use it in QWidget applications, but since QIcon 
> does have any idea where it is, is not usable yet for things like the 
> fullscreen fixed-dark gwenview view.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3ef0306 
>   src/declarativeimports/core/iconitem.cpp 692cd8d 
>   src/plasma/private/svg_p.h ab91c42 
>   src/plasma/svg.h 3ad21ce 
>   src/plasma/svg.cpp 37ced22 
> 
> Diff: https://git.reviewboard.kde.org/r/125657/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-16 Thread David Rosca 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/#review86922
---



src/declarativeimports/core/iconitem.cpp (line 144)


useSystemColors is false by default


- David Rosca


On Oct. 16, 2015, 1:26 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125657/
> ---
> 
> (Updated Oct. 16, 2015, 1:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This makes IconItem try to load global icons from the theme with Plasma::Svg 
> as well, making it assign the colors from the stylesheet if the breeze 
> monochrome icons are treated, that should be scriptable, from some attempts i 
> did the script seems to convert them correctly, without any change in 
> rendering.
> 
> This will automatically color monochrome breeze icons only in plasmashell, 
> and more specifically only those that use IconItem, not QIconItem (iconitem 
> should probably have an animation-less mode to be able to be used in 
> taskmanager and stuff)
> perhaps in the future we'll be able somehow to hook all this stuff in 
> QIconEngine to be able to use it in QWidget applications, but since QIcon 
> does have any idea where it is, is not usable yet for things like the 
> fullscreen fixed-dark gwenview view.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3ef0306 
>   src/declarativeimports/core/iconitem.cpp 692cd8d 
>   src/plasma/private/svg_p.h ab91c42 
>   src/plasma/svg.h 3ad21ce 
>   src/plasma/svg.cpp 37ced22 
> 
> Diff: https://git.reviewboard.kde.org/r/125657/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-16 Thread Marco Martin 


> On Oct. 16, 2015, 1:19 p.m., David Edmundson wrote:
> > src/declarativeimports/core/iconitem.cpp, lines 341-348
> > 
> >
> > it looks like you already do all this on line 142 of this diff.

yeah, this is due the peculiarity of icon themes, since they can have different 
images on different sizes (that happens on svgs too, breeze does this a lot) so 
I may have to reload the svg when it gets resized


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/#review86916
---


On Oct. 16, 2015, 1:26 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125657/
> ---
> 
> (Updated Oct. 16, 2015, 1:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This makes IconItem try to load global icons from the theme with Plasma::Svg 
> as well, making it assign the colors from the stylesheet if the breeze 
> monochrome icons are treated, that should be scriptable, from some attempts i 
> did the script seems to convert them correctly, without any change in 
> rendering.
> 
> This will automatically color monochrome breeze icons only in plasmashell, 
> and more specifically only those that use IconItem, not QIconItem (iconitem 
> should probably have an animation-less mode to be able to be used in 
> taskmanager and stuff)
> perhaps in the future we'll be able somehow to hook all this stuff in 
> QIconEngine to be able to use it in QWidget applications, but since QIcon 
> does have any idea where it is, is not usable yet for things like the 
> fullscreen fixed-dark gwenview view.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3ef0306 
>   src/declarativeimports/core/iconitem.cpp 692cd8d 
>   src/plasma/private/svg_p.h ab91c42 
>   src/plasma/svg.h 3ad21ce 
>   src/plasma/svg.cpp 37ced22 
> 
> Diff: https://git.reviewboard.kde.org/r/125657/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-16 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/
---

(Updated Oct. 16, 2015, 2:48 p.m.)


Review request for Plasma.


Repository: plasma-framework


Description
---

This makes IconItem try to load global icons from the theme with Plasma::Svg as 
well, making it assign the colors from the stylesheet if the breeze monochrome 
icons are treated, that should be scriptable, from some attempts i did the 
script seems to convert them correctly, without any change in rendering.

This will automatically color monochrome breeze icons only in plasmashell, and 
more specifically only those that use IconItem, not QIconItem (iconitem should 
probably have an animation-less mode to be able to be used in taskmanager and 
stuff)
perhaps in the future we'll be able somehow to hook all this stuff in 
QIconEngine to be able to use it in QWidget applications, but since QIcon does 
have any idea where it is, is not usable yet for things like the fullscreen 
fixed-dark gwenview view.


Diffs (updated)
-

  src/declarativeimports/core/iconitem.h 3ef0306 
  src/declarativeimports/core/iconitem.cpp 692cd8d 
  src/plasma/private/svg_p.h ab91c42 
  src/plasma/svg.h 3ad21ce 
  src/plasma/svg.cpp 37ced22 

Diff: https://git.reviewboard.kde.org/r/125657/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-16 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/#review86932
---



src/declarativeimports/core/iconitem.cpp (line 342)


spaces between operators



src/plasma/svg.h (line 401)


Mention the default (false), please


- Kai Uwe Broulik


On Okt. 16, 2015, 2:48 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125657/
> ---
> 
> (Updated Okt. 16, 2015, 2:48 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This makes IconItem try to load global icons from the theme with Plasma::Svg 
> as well, making it assign the colors from the stylesheet if the breeze 
> monochrome icons are treated, that should be scriptable, from some attempts i 
> did the script seems to convert them correctly, without any change in 
> rendering.
> 
> This will automatically color monochrome breeze icons only in plasmashell, 
> and more specifically only those that use IconItem, not QIconItem (iconitem 
> should probably have an animation-less mode to be able to be used in 
> taskmanager and stuff)
> perhaps in the future we'll be able somehow to hook all this stuff in 
> QIconEngine to be able to use it in QWidget applications, but since QIcon 
> does have any idea where it is, is not usable yet for things like the 
> fullscreen fixed-dark gwenview view.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.h 3ef0306 
>   src/declarativeimports/core/iconitem.cpp 692cd8d 
>   src/plasma/private/svg_p.h ab91c42 
>   src/plasma/svg.h 3ad21ce 
>   src/plasma/svg.cpp 37ced22 
> 
> Diff: https://git.reviewboard.kde.org/r/125657/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel