Re: Review Request 125793: [Task Manager] Add proper close button to tooltip
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125793/ --- (Updated Feb. 1, 2016, 11:06 vorm.) Status -- This change has been discarded. Review request for Plasma, KDE Usability and Andrew Lake. Bugs: 350705 https://bugs.kde.org/show_bug.cgi?id=350705 Repository: plasma-desktop Description --- I just found this patch I made a while ago. This turns the handmade close button into a regular ToolButton (which is only shown when hovering) with a proper size. Also, the button is always in the top right corner of the *thumbnail* rather than the dialog Diffs - applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 Diff: https://git.reviewboard.kde.org/r/125793/diff/ Testing --- Works. File Attachments New close button https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125793: [Task Manager] Add proper close button to tooltip
> On Oct. 25, 2015, 11:08 p.m., Uri Herrera wrote: > > I agree with Thomas that having the button inside the thumbnail is > > confusing. > > > >  > > > > On this image I moved the button outside the thumbnail, used the actual > > window-close icon in the icon theme and removed the round button background. > > > >  > > > > On this the button is inside and there's no button background. > > Uri Herrera wrote: > I also made the button bigger, currently the button looks really tiny for > me. The button is mostly on the thumbnail because there could be multiple windows in the tooltip. - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125793/#review87385 --- On Oct. 25, 2015, 9:42 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125793/ > --- > > (Updated Oct. 25, 2015, 9:42 p.m.) > > > Review request for Plasma, KDE Usability and Andrew Lake. > > > Bugs: 350705 > https://bugs.kde.org/show_bug.cgi?id=350705 > > > Repository: plasma-desktop > > > Description > --- > > I just found this patch I made a while ago. This turns the handmade close > button into a regular ToolButton (which is only shown when hovering) with a > proper size. Also, the button is always in the top right corner of the > *thumbnail* rather than the dialog > > > Diffs > - > > applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 > > Diff: https://git.reviewboard.kde.org/r/125793/diff/ > > > Testing > --- > > Works. > > > File Attachments > > > New close button > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125793: [Task Manager] Add proper close button to tooltip
> On Oct. 26, 2015, 3:22 a.m., Andrew Lake wrote: > > Proper close button is welcome. Generally looks good to me, though I do > > think the close button works better with the consistency of the normal > > background rather than the randomness of the thumbnail as a background. > > Other than that, thumbs up from me! hey that's not fair. For years there was complaint that we cannot put the close button on the window. Now finally we made that possible and what? Move close button outside again. /me grumbles about waisted time and that I don't want to invest the time to make that work on Wayland as it's really, really a difficult task. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125793/#review87395 --- On Oct. 25, 2015, 10:42 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125793/ > --- > > (Updated Oct. 25, 2015, 10:42 p.m.) > > > Review request for Plasma, KDE Usability and Andrew Lake. > > > Bugs: 350705 > https://bugs.kde.org/show_bug.cgi?id=350705 > > > Repository: plasma-desktop > > > Description > --- > > I just found this patch I made a while ago. This turns the handmade close > button into a regular ToolButton (which is only shown when hovering) with a > proper size. Also, the button is always in the top right corner of the > *thumbnail* rather than the dialog > > > Diffs > - > > applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 > > Diff: https://git.reviewboard.kde.org/r/125793/diff/ > > > Testing > --- > > Works. > > > File Attachments > > > New close button > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125793: [Task Manager] Add proper close button to tooltip
> On Okt. 26, 2015, 2:22 vorm., Andrew Lake wrote: > > Proper close button is welcome. Generally looks good to me, though I do > > think the close button works better with the consistency of the normal > > background rather than the randomness of the thumbnail as a background. > > Other than that, thumbs up from me! > > Martin Gräßlin wrote: > hey that's not fair. For years there was complaint that we cannot put the > close button on the window. Now finally we made that possible and what? Move > close button outside again. > > /me grumbles about waisted time and that I don't want to invest the time > to make that work on Wayland as it's really, really a difficult task. Also note that depending on the window geometry the thumbnail would get wider eventually partially or entirely leaking behind the close button. The partial case was what I wanted to avoid. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125793/#review87395 --- On Okt. 25, 2015, 9:42 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125793/ > --- > > (Updated Okt. 25, 2015, 9:42 nachm.) > > > Review request for Plasma, KDE Usability and Andrew Lake. > > > Bugs: 350705 > https://bugs.kde.org/show_bug.cgi?id=350705 > > > Repository: plasma-desktop > > > Description > --- > > I just found this patch I made a while ago. This turns the handmade close > button into a regular ToolButton (which is only shown when hovering) with a > proper size. Also, the button is always in the top right corner of the > *thumbnail* rather than the dialog > > > Diffs > - > > applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 > > Diff: https://git.reviewboard.kde.org/r/125793/diff/ > > > Testing > --- > > Works. > > > File Attachments > > > New close button > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125793: [Task Manager] Add proper close button to tooltip
> On Oct. 26, 2015, 2:22 a.m., Andrew Lake wrote: > > Proper close button is welcome. Generally looks good to me, though I do > > think the close button works better with the consistency of the normal > > background rather than the randomness of the thumbnail as a background. > > Other than that, thumbs up from me! > > Martin Gräßlin wrote: > hey that's not fair. For years there was complaint that we cannot put the > close button on the window. Now finally we made that possible and what? Move > close button outside again. > > /me grumbles about waisted time and that I don't want to invest the time > to make that work on Wayland as it's really, really a difficult task. > > Kai Uwe Broulik wrote: > Also note that depending on the window geometry the thumbnail would get > wider eventually partially or entirely leaking behind the close button. The > partial case was what I wanted to avoid. with the button outside the thumbnail, how would it look when there are more thumbnails in the tooltip due to grouped windows? - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125793/#review87395 --- On Oct. 25, 2015, 9:42 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125793/ > --- > > (Updated Oct. 25, 2015, 9:42 p.m.) > > > Review request for Plasma, KDE Usability and Andrew Lake. > > > Bugs: 350705 > https://bugs.kde.org/show_bug.cgi?id=350705 > > > Repository: plasma-desktop > > > Description > --- > > I just found this patch I made a while ago. This turns the handmade close > button into a regular ToolButton (which is only shown when hovering) with a > proper size. Also, the button is always in the top right corner of the > *thumbnail* rather than the dialog > > > Diffs > - > > applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 > > Diff: https://git.reviewboard.kde.org/r/125793/diff/ > > > Testing > --- > > Works. > > > File Attachments > > > New close button > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125793: [Task Manager] Add proper close button to tooltip
> On Oct. 26, 2015, 2:22 a.m., Andrew Lake wrote: > > Proper close button is welcome. Generally looks good to me, though I do > > think the close button works better with the consistency of the normal > > background rather than the randomness of the thumbnail as a background. > > Other than that, thumbs up from me! > > Martin Gräßlin wrote: > hey that's not fair. For years there was complaint that we cannot put the > close button on the window. Now finally we made that possible and what? Move > close button outside again. > > /me grumbles about waisted time and that I don't want to invest the time > to make that work on Wayland as it's really, really a difficult task. > > Kai Uwe Broulik wrote: > Also note that depending on the window geometry the thumbnail would get > wider eventually partially or entirely leaking behind the close button. The > partial case was what I wanted to avoid. > > Marco Martin wrote: > with the button outside the thumbnail, how would it look when there are > more thumbnails in the tooltip due to grouped windows? I'm not sure I remember which complaint was "we cannot put the close button on the window" and what discussion resulted in putting it on the window, but sorry if my observation resulted betrays some inconsistency. If we want to leave the close button on the the thumbnail itself, then all I'd suggest is that we provide some kind of consistent background for the thing to sit on. As it is, I think the noise of the thumbnail background makes the button difficult to distinguish. Maybe moving it outside is not the right solution for that. And maybe that suggestion conflicts with something we already provided guidance on. I'd simply request we please assume any inconsistency in what I've said is because of my awful memory, not because I'm running some consistency-checker against what I previously said to screw over the hard work anyone has done. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125793/#review87395 --- On Oct. 25, 2015, 9:42 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125793/ > --- > > (Updated Oct. 25, 2015, 9:42 p.m.) > > > Review request for Plasma, KDE Usability and Andrew Lake. > > > Bugs: 350705 > https://bugs.kde.org/show_bug.cgi?id=350705 > > > Repository: plasma-desktop > > > Description > --- > > I just found this patch I made a while ago. This turns the handmade close > button into a regular ToolButton (which is only shown when hovering) with a > proper size. Also, the button is always in the top right corner of the > *thumbnail* rather than the dialog > > > Diffs > - > > applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 > > Diff: https://git.reviewboard.kde.org/r/125793/diff/ > > > Testing > --- > > Works. > > > File Attachments > > > New close button > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125793: [Task Manager] Add proper close button to tooltip
> On Oct. 25, 2015, 11:08 p.m., Uri Herrera wrote: > > I agree with Thomas that having the button inside the thumbnail is > > confusing. > > > >  > > > > On this image I moved the button outside the thumbnail, used the actual > > window-close icon in the icon theme and removed the round button background. > > > >  > > > > On this the button is inside and there's no button background. I also made the button bigger, currently the button looks really tiny for me. - Uri --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125793/#review87385 --- On Oct. 25, 2015, 9:42 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125793/ > --- > > (Updated Oct. 25, 2015, 9:42 p.m.) > > > Review request for Plasma, KDE Usability and Andrew Lake. > > > Bugs: 350705 > https://bugs.kde.org/show_bug.cgi?id=350705 > > > Repository: plasma-desktop > > > Description > --- > > I just found this patch I made a while ago. This turns the handmade close > button into a regular ToolButton (which is only shown when hovering) with a > proper size. Also, the button is always in the top right corner of the > *thumbnail* rather than the dialog > > > Diffs > - > > applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 > > Diff: https://git.reviewboard.kde.org/r/125793/diff/ > > > Testing > --- > > Works. > > > File Attachments > > > New close button > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125793: [Task Manager] Add proper close button to tooltip
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125793/#review87385 --- I agree with Thomas that having the button inside the thumbnail is confusing.  On this image I moved the button outside the thumbnail, used the actual window-close icon in the icon theme and removed the round button background.  On this the button is inside and there's no button background. - Uri Herrera On Oct. 25, 2015, 9:42 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125793/ > --- > > (Updated Oct. 25, 2015, 9:42 p.m.) > > > Review request for Plasma, KDE Usability and Andrew Lake. > > > Bugs: 350705 > https://bugs.kde.org/show_bug.cgi?id=350705 > > > Repository: plasma-desktop > > > Description > --- > > I just found this patch I made a while ago. This turns the handmade close > button into a regular ToolButton (which is only shown when hovering) with a > proper size. Also, the button is always in the top right corner of the > *thumbnail* rather than the dialog > > > Diffs > - > > applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 > > Diff: https://git.reviewboard.kde.org/r/125793/diff/ > > > Testing > --- > > Works. > > > File Attachments > > > New close button > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125793: [Task Manager] Add proper close button to tooltip
> On Okt. 25, 2015, 9:12 nachm., Thomas Pfeiffer wrote: > > Can you please add Andrew for design review? > > From a usability perspective, it would be better if the button was outside > > the actual thumbnail, to be sure that it cannot be mistaken as part of the > > thumbnail. the button only appears on hovering, so it should be obvious it's not part of the thumbnail - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125793/#review87381 --- On Okt. 25, 2015, 5:06 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125793/ > --- > > (Updated Okt. 25, 2015, 5:06 nachm.) > > > Review request for Plasma and KDE Usability. > > > Bugs: 350705 > https://bugs.kde.org/show_bug.cgi?id=350705 > > > Repository: plasma-desktop > > > Description > --- > > I just found this patch I made a while ago. This turns the handmade close > button into a regular ToolButton (which is only shown when hovering) with a > proper size. Also, the button is always in the top right corner of the > *thumbnail* rather than the dialog > > > Diffs > - > > applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 > > Diff: https://git.reviewboard.kde.org/r/125793/diff/ > > > Testing > --- > > Works. > > > File Attachments > > > New close button > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125793: [Task Manager] Add proper close button to tooltip
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125793/#review87395 --- Proper close button is welcome. Generally looks good to me, though I do think the close button works better with the consistency of the normal background rather than the randomness of the thumbnail as a background. Other than that, thumbs up from me! - Andrew Lake On Oct. 25, 2015, 9:42 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125793/ > --- > > (Updated Oct. 25, 2015, 9:42 p.m.) > > > Review request for Plasma, KDE Usability and Andrew Lake. > > > Bugs: 350705 > https://bugs.kde.org/show_bug.cgi?id=350705 > > > Repository: plasma-desktop > > > Description > --- > > I just found this patch I made a while ago. This turns the handmade close > button into a regular ToolButton (which is only shown when hovering) with a > proper size. Also, the button is always in the top right corner of the > *thumbnail* rather than the dialog > > > Diffs > - > > applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 > > Diff: https://git.reviewboard.kde.org/r/125793/diff/ > > > Testing > --- > > Works. > > > File Attachments > > > New close button > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 125793: [Task Manager] Add proper close button to tooltip
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125793/ --- Review request for Plasma and KDE Usability. Bugs: 350705 https://bugs.kde.org/show_bug.cgi?id=350705 Repository: plasma-desktop Description --- I just found this patch I made a while ago. This turns the handmade close button into a regular ToolButton (which is only shown when hovering) with a proper size. Also, the button is always in the top right corner of the *thumbnail* rather than the dialog Diffs - applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 Diff: https://git.reviewboard.kde.org/r/125793/diff/ Testing --- Works. File Attachments New close button https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125793: [Task Manager] Add proper close button to tooltip
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125793/#review87376 --- +1 - David Edmundson On Oct. 25, 2015, 5:06 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125793/ > --- > > (Updated Oct. 25, 2015, 5:06 p.m.) > > > Review request for Plasma and KDE Usability. > > > Bugs: 350705 > https://bugs.kde.org/show_bug.cgi?id=350705 > > > Repository: plasma-desktop > > > Description > --- > > I just found this patch I made a while ago. This turns the handmade close > button into a regular ToolButton (which is only shown when hovering) with a > proper size. Also, the button is always in the top right corner of the > *thumbnail* rather than the dialog > > > Diffs > - > > applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 > > Diff: https://git.reviewboard.kde.org/r/125793/diff/ > > > Testing > --- > > Works. > > > File Attachments > > > New close button > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125793: [Task Manager] Add proper close button to tooltip
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125793/#review87381 --- Can you please add Andrew for design review? >From a usability perspective, it would be better if the button was outside the >actual thumbnail, to be sure that it cannot be mistaken as part of the >thumbnail. - Thomas Pfeiffer On Oct. 25, 2015, 5:06 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125793/ > --- > > (Updated Oct. 25, 2015, 5:06 p.m.) > > > Review request for Plasma and KDE Usability. > > > Bugs: 350705 > https://bugs.kde.org/show_bug.cgi?id=350705 > > > Repository: plasma-desktop > > > Description > --- > > I just found this patch I made a while ago. This turns the handmade close > button into a regular ToolButton (which is only shown when hovering) with a > proper size. Also, the button is always in the top right corner of the > *thumbnail* rather than the dialog > > > Diffs > - > > applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 > > Diff: https://git.reviewboard.kde.org/r/125793/diff/ > > > Testing > --- > > Works. > > > File Attachments > > > New close button > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
