Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-27 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125810/
---

(Updated Oct. 27, 2015, 10:02 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 6e3c17e5c846eccc4fa6c744c5ab6bd4885df196 by Marco Martin 
to branch master.


Repository: plasma-workspace


Description
---

added some formfactor keywords in the applets metadata. once the explorer model 
filters them accordingly, it should remove a bit of applets problematic on the 
phone for one reason or another


Diffs
-

  applets/activitybar/metadata.desktop d6cf69c 
  applets/batterymonitor/package/metadata.desktop a4ee702 
  applets/clipboard/metadata.desktop 1d699d2 
  applets/lock_logout/metadata.desktop f53f541 
  applets/systemmonitor/cpu/metadata.desktop 76cd74d 
  applets/systemmonitor/diskactivity/metadata.desktop 2a1ceaa 
  applets/systemmonitor/diskusage/metadata.desktop 08344a8 
  applets/systemmonitor/memory/metadata.desktop d0cfe97 
  applets/systemmonitor/net/metadata.desktop 6671fba 
  applets/systemtray/package/metadata.desktop 0ce0512 

Diff: https://git.reviewboard.kde.org/r/125810/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-27 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125810/
---

(Updated Oct. 27, 2015, 9:43 a.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

added some formfactor keywords in the applets metadata. once the explorer model 
filters them accordingly, it should remove a bit of applets problematic on the 
phone for one reason or another


Diffs (updated)
-

  applets/activitybar/metadata.desktop d6cf69c 
  applets/batterymonitor/package/metadata.desktop a4ee702 
  applets/clipboard/metadata.desktop 1d699d2 
  applets/lock_logout/metadata.desktop f53f541 
  applets/systemmonitor/cpu/metadata.desktop 76cd74d 
  applets/systemmonitor/diskactivity/metadata.desktop 2a1ceaa 
  applets/systemmonitor/diskusage/metadata.desktop 08344a8 
  applets/systemmonitor/memory/metadata.desktop d0cfe97 
  applets/systemmonitor/net/metadata.desktop 6671fba 
  applets/systemtray/package/metadata.desktop 0ce0512 

Diff: https://git.reviewboard.kde.org/r/125810/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-27 Thread Marco Martin 


> On Oct. 26, 2015, 9:12 p.m., Sebastian Kügler wrote:
> > applets/notifications/package/metadata.desktop, line 170
> > 
> >
> > We have a special notifications applet for handsets in plasma-mobile, 
> > so this should probably be more limited (exactly the opposite keys of 
> > plasma-mobile's notifications applet).

recently on the phone it switched to using the desktop applet as well, as was 
decided to move it in the top panel (since on the desktop wasn't possible to 
"peek", and being easy to remove it was quite a problem)
so unless they diverge again, it would exist only this one for now


> On Oct. 26, 2015, 9:12 p.m., Sebastian Kügler wrote:
> > applets/devicenotifier/package/metadata.desktop, line 172
> > 
> >
> > Could you share the reasoning for this choice?

mainly because doesn't make a lot of sense on the targeted device, perhaps on 
one with a microsd slot would make sense, so yeah, should probably be in


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125810/#review87465
---


On Oct. 26, 2015, 4:26 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125810/
> ---
> 
> (Updated Oct. 26, 2015, 4:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> added some formfactor keywords in the applets metadata. once the explorer 
> model filters them accordingly, it should remove a bit of applets problematic 
> on the phone for one reason or another
> 
> 
> Diffs
> -
> 
>   applets/activitybar/metadata.desktop d6cf69c 
>   applets/analog-clock/metadata.desktop 4246c6e 
>   applets/batterymonitor/package/metadata.desktop a4ee702 
>   applets/calendar/metadata.desktop 5891264 
>   applets/clipboard/metadata.desktop 1d699d2 
>   applets/devicenotifier/package/metadata.desktop d71ce72 
>   applets/digital-clock/package/metadata.desktop b881453 
>   applets/lock_logout/metadata.desktop f53f541 
>   applets/mediacontroller/metadata.desktop d4ea37a 
>   applets/notifications/package/metadata.desktop 2beb20d 
>   applets/systemmonitor/cpu/metadata.desktop 76cd74d 
>   applets/systemmonitor/diskactivity/metadata.desktop 2a1ceaa 
>   applets/systemmonitor/diskusage/metadata.desktop 08344a8 
>   applets/systemmonitor/net/metadata.desktop 6671fba 
>   applets/systemtray/package/metadata.desktop 0ce0512 
> 
> Diff: https://git.reviewboard.kde.org/r/125810/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-27 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125810/#review87498
---

Ship it!


Ship It!

- Sebastian Kügler


On Oct. 27, 2015, 9:43 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125810/
> ---
> 
> (Updated Oct. 27, 2015, 9:43 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> added some formfactor keywords in the applets metadata. once the explorer 
> model filters them accordingly, it should remove a bit of applets problematic 
> on the phone for one reason or another
> 
> 
> Diffs
> -
> 
>   applets/activitybar/metadata.desktop d6cf69c 
>   applets/batterymonitor/package/metadata.desktop a4ee702 
>   applets/clipboard/metadata.desktop 1d699d2 
>   applets/lock_logout/metadata.desktop f53f541 
>   applets/systemmonitor/cpu/metadata.desktop 76cd74d 
>   applets/systemmonitor/diskactivity/metadata.desktop 2a1ceaa 
>   applets/systemmonitor/diskusage/metadata.desktop 08344a8 
>   applets/systemmonitor/memory/metadata.desktop d0cfe97 
>   applets/systemmonitor/net/metadata.desktop 6671fba 
>   applets/systemtray/package/metadata.desktop 0ce0512 
> 
> Diff: https://git.reviewboard.kde.org/r/125810/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-26 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125810/#review87465
---


Some remarks, but otherwise, thanks for taking care of this.


applets/devicenotifier/package/metadata.desktop (line 172)


Could you share the reasoning for this choice?



applets/notifications/package/metadata.desktop (line 170)


We have a special notifications applet for handsets in plasma-mobile, so 
this should probably be more limited (exactly the opposite keys of 
plasma-mobile's notifications applet).


- Sebastian Kügler


On Oct. 26, 2015, 4:26 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125810/
> ---
> 
> (Updated Oct. 26, 2015, 4:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> added some formfactor keywords in the applets metadata. once the explorer 
> model filters them accordingly, it should remove a bit of applets problematic 
> on the phone for one reason or another
> 
> 
> Diffs
> -
> 
>   applets/activitybar/metadata.desktop d6cf69c 
>   applets/analog-clock/metadata.desktop 4246c6e 
>   applets/batterymonitor/package/metadata.desktop a4ee702 
>   applets/calendar/metadata.desktop 5891264 
>   applets/clipboard/metadata.desktop 1d699d2 
>   applets/devicenotifier/package/metadata.desktop d71ce72 
>   applets/digital-clock/package/metadata.desktop b881453 
>   applets/lock_logout/metadata.desktop f53f541 
>   applets/mediacontroller/metadata.desktop d4ea37a 
>   applets/notifications/package/metadata.desktop 2beb20d 
>   applets/systemmonitor/cpu/metadata.desktop 76cd74d 
>   applets/systemmonitor/diskactivity/metadata.desktop 2a1ceaa 
>   applets/systemmonitor/diskusage/metadata.desktop 08344a8 
>   applets/systemmonitor/net/metadata.desktop 6671fba 
>   applets/systemtray/package/metadata.desktop 0ce0512 
> 
> Diff: https://git.reviewboard.kde.org/r/125810/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-26 Thread Sebastian Kügler 


> On Oct. 26, 2015, 5:26 p.m., Kai Uwe Broulik wrote:
> > applets/analog-clock/metadata.desktop, line 170
> > 
> >
> > Why not "not specified = everywhere"?
> 
> Marco Martin wrote:
> yeah, in some of those are probably redundant

Yes, the formfactor stuff is meant as a specialization, if you specify them 
all, might as well leave them out. I've specified that in the examples on my 
blog as well: http://vizzzion.org/blog/2015/07/convergence-through-divergence/


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125810/#review87443
---


On Oct. 26, 2015, 4:26 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125810/
> ---
> 
> (Updated Oct. 26, 2015, 4:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> added some formfactor keywords in the applets metadata. once the explorer 
> model filters them accordingly, it should remove a bit of applets problematic 
> on the phone for one reason or another
> 
> 
> Diffs
> -
> 
>   applets/activitybar/metadata.desktop d6cf69c 
>   applets/analog-clock/metadata.desktop 4246c6e 
>   applets/batterymonitor/package/metadata.desktop a4ee702 
>   applets/calendar/metadata.desktop 5891264 
>   applets/clipboard/metadata.desktop 1d699d2 
>   applets/devicenotifier/package/metadata.desktop d71ce72 
>   applets/digital-clock/package/metadata.desktop b881453 
>   applets/lock_logout/metadata.desktop f53f541 
>   applets/mediacontroller/metadata.desktop d4ea37a 
>   applets/notifications/package/metadata.desktop 2beb20d 
>   applets/systemmonitor/cpu/metadata.desktop 76cd74d 
>   applets/systemmonitor/diskactivity/metadata.desktop 2a1ceaa 
>   applets/systemmonitor/diskusage/metadata.desktop 08344a8 
>   applets/systemmonitor/net/metadata.desktop 6671fba 
>   applets/systemtray/package/metadata.desktop 0ce0512 
> 
> Diff: https://git.reviewboard.kde.org/r/125810/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-26 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125810/#review87443
---



applets/analog-clock/metadata.desktop (line 170)


Why not "not specified = everywhere"?


- Kai Uwe Broulik


On Okt. 26, 2015, 4:26 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125810/
> ---
> 
> (Updated Okt. 26, 2015, 4:26 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> added some formfactor keywords in the applets metadata. once the explorer 
> model filters them accordingly, it should remove a bit of applets problematic 
> on the phone for one reason or another
> 
> 
> Diffs
> -
> 
>   applets/activitybar/metadata.desktop d6cf69c 
>   applets/analog-clock/metadata.desktop 4246c6e 
>   applets/batterymonitor/package/metadata.desktop a4ee702 
>   applets/calendar/metadata.desktop 5891264 
>   applets/clipboard/metadata.desktop 1d699d2 
>   applets/devicenotifier/package/metadata.desktop d71ce72 
>   applets/digital-clock/package/metadata.desktop b881453 
>   applets/lock_logout/metadata.desktop f53f541 
>   applets/mediacontroller/metadata.desktop d4ea37a 
>   applets/notifications/package/metadata.desktop 2beb20d 
>   applets/systemmonitor/cpu/metadata.desktop 76cd74d 
>   applets/systemmonitor/diskactivity/metadata.desktop 2a1ceaa 
>   applets/systemmonitor/diskusage/metadata.desktop 08344a8 
>   applets/systemmonitor/net/metadata.desktop 6671fba 
>   applets/systemtray/package/metadata.desktop 0ce0512 
> 
> Diff: https://git.reviewboard.kde.org/r/125810/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-26 Thread Marco Martin 


> On Oct. 26, 2015, 5:26 p.m., Kai Uwe Broulik wrote:
> > applets/analog-clock/metadata.desktop, line 170
> > 
> >
> > Why not "not specified = everywhere"?

yeah, in some of those are probably redundant


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125810/#review87443
---


On Oct. 26, 2015, 4:26 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125810/
> ---
> 
> (Updated Oct. 26, 2015, 4:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> added some formfactor keywords in the applets metadata. once the explorer 
> model filters them accordingly, it should remove a bit of applets problematic 
> on the phone for one reason or another
> 
> 
> Diffs
> -
> 
>   applets/activitybar/metadata.desktop d6cf69c 
>   applets/analog-clock/metadata.desktop 4246c6e 
>   applets/batterymonitor/package/metadata.desktop a4ee702 
>   applets/calendar/metadata.desktop 5891264 
>   applets/clipboard/metadata.desktop 1d699d2 
>   applets/devicenotifier/package/metadata.desktop d71ce72 
>   applets/digital-clock/package/metadata.desktop b881453 
>   applets/lock_logout/metadata.desktop f53f541 
>   applets/mediacontroller/metadata.desktop d4ea37a 
>   applets/notifications/package/metadata.desktop 2beb20d 
>   applets/systemmonitor/cpu/metadata.desktop 76cd74d 
>   applets/systemmonitor/diskactivity/metadata.desktop 2a1ceaa 
>   applets/systemmonitor/diskusage/metadata.desktop 08344a8 
>   applets/systemmonitor/net/metadata.desktop 6671fba 
>   applets/systemtray/package/metadata.desktop 0ce0512 
> 
> Diff: https://git.reviewboard.kde.org/r/125810/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-26 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125810/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

added some formfactor keywords in the applets metadata. once the explorer model 
filters them accordingly, it should remove a bit of applets problematic on the 
phone for one reason or another


Diffs
-

  applets/activitybar/metadata.desktop d6cf69c 
  applets/analog-clock/metadata.desktop 4246c6e 
  applets/batterymonitor/package/metadata.desktop a4ee702 
  applets/calendar/metadata.desktop 5891264 
  applets/clipboard/metadata.desktop 1d699d2 
  applets/devicenotifier/package/metadata.desktop d71ce72 
  applets/digital-clock/package/metadata.desktop b881453 
  applets/lock_logout/metadata.desktop f53f541 
  applets/mediacontroller/metadata.desktop d4ea37a 
  applets/notifications/package/metadata.desktop 2beb20d 
  applets/systemmonitor/cpu/metadata.desktop 76cd74d 
  applets/systemmonitor/diskactivity/metadata.desktop 2a1ceaa 
  applets/systemmonitor/diskusage/metadata.desktop 08344a8 
  applets/systemmonitor/net/metadata.desktop 6671fba 
  applets/systemtray/package/metadata.desktop 0ce0512 

Diff: https://git.reviewboard.kde.org/r/125810/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel