Re: Review Request 125926: [Image Wallpaper] Take into account orientation

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125926/
---

(Updated Feb. 8, 2017, 3:30 nachm.)


Status
--

This change has been discarded.


Review request for Plasma.


Bugs: 352555
https://bugs.kde.org/show_bug.cgi?id=352555


Repository: plasma-workspace


Description
---

The distance method only cares for a match in terms of pixel numbers, not the 
actual orientation.


Diffs
-

  wallpapers/image/image.cpp 1b8d2dd 

Diff: https://git.reviewboard.kde.org/r/125926/diff/


Testing
---

Placed a 1440x2560 picture in my image package, it used to get picked and 
stretched, not it properly takes the 2560x1440 image consistently, or if not 
present, fall back to a different resolution image.


Thanks,

Kai Uwe Broulik

Re: Review Request 125926: [Image Wallpaper] Take into account orientation

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125926/#review87911
---



wallpapers/image/image.cpp (line 199)


how does it behave with images rotated via exif info?


- Marco Martin


On Nov. 2, 2015, 9:27 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125926/
> ---
> 
> (Updated Nov. 2, 2015, 9:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 352555
> https://bugs.kde.org/show_bug.cgi?id=352555
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The distance method only cares for a match in terms of pixel numbers, not the 
> actual orientation.
> 
> 
> Diffs
> -
> 
>   wallpapers/image/image.cpp 1b8d2dd 
> 
> Diff: https://git.reviewboard.kde.org/r/125926/diff/
> 
> 
> Testing
> ---
> 
> Placed a 1440x2560 picture in my image package, it used to get picked and 
> stretched, not it properly takes the 2560x1440 image consistently, or if not 
> present, fall back to a different resolution image.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125926: [Image Wallpaper] Take into account orientation

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125926/#review87889
---


Damn, of course, it should take the non-fitting orientation as a last resort if 
it actually is a vertical photograph...

- Kai Uwe Broulik


On Nov. 2, 2015, 9:27 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125926/
> ---
> 
> (Updated Nov. 2, 2015, 9:27 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 352555
> https://bugs.kde.org/show_bug.cgi?id=352555
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The distance method only cares for a match in terms of pixel numbers, not the 
> actual orientation.
> 
> 
> Diffs
> -
> 
>   wallpapers/image/image.cpp 1b8d2dd 
> 
> Diff: https://git.reviewboard.kde.org/r/125926/diff/
> 
> 
> Testing
> ---
> 
> Placed a 1440x2560 picture in my image package, it used to get picked and 
> stretched, not it properly takes the 2560x1440 image consistently, or if not 
> present, fall back to a different resolution image.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125926: [Image Wallpaper] Take into account orientation

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125926/
---

Review request for Plasma.


Bugs: 352555
https://bugs.kde.org/show_bug.cgi?id=352555


Repository: plasma-workspace


Description
---

The distance method only cares for a match in terms of pixel numbers, not the 
actual orientation.


Diffs
-

  wallpapers/image/image.cpp 1b8d2dd 

Diff: https://git.reviewboard.kde.org/r/125926/diff/


Testing
---

Placed a 1440x2560 picture in my image package, it used to get picked and 
stretched, not it properly takes the 2560x1440 image consistently, or if not 
present, fall back to a different resolution image.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel