Review Request 125997: Catch other openGL error gracefully
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125997/ --- Review request for Plasma. Repository: plasma-workspace Description --- CCBUG: 354966 CCBUG: 355054 Diffs - shell/main.cpp a774cb4e8d18032ff3fd39892b8171b96a94cc92 Diff: https://git.reviewboard.kde.org/r/125997/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125997: Catch other openGL error gracefully
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125997/#review88172 --- Could you please explain the change? Reduce string comparison? Anyway: we should probably extend the checks to also include the EGL/XCB error messages an EGL/Wayland error messages - Martin Gräßlin On Nov. 8, 2015, 10:07 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125997/ > --- > > (Updated Nov. 8, 2015, 10:07 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > CCBUG: 354966 > CCBUG: 355054 > > > Diffs > - > > shell/main.cpp a774cb4e8d18032ff3fd39892b8171b96a94cc92 > > Diff: https://git.reviewboard.kde.org/r/125997/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125997: Catch other openGL error gracefully
> On Nov. 9, 2015, 6:57 a.m., Martin Gräßlin wrote: > > Could you please explain the change? Reduce string comparison? > > > > Anyway: we should probably extend the checks to also include the EGL/XCB > > error messages an EGL/Wayland error messages there's a second if message == "blah" which is the main important change then I added the if Q_UNLIKELY to potentially speed things up as 99.% of the time it will be debug not fatal messages. then I reformatted it so it was a bit cleaner as I ended up 4 brackets deep - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125997/#review88172 --- On Nov. 8, 2015, 9:07 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125997/ > --- > > (Updated Nov. 8, 2015, 9:07 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > CCBUG: 354966 > CCBUG: 355054 > > > Diffs > - > > shell/main.cpp a774cb4e8d18032ff3fd39892b8171b96a94cc92 > > Diff: https://git.reviewboard.kde.org/r/125997/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125997: Catch other openGL error gracefully
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125997/#review88188 --- Ship it! Ship It! - Martin Gräßlin On Nov. 8, 2015, 10:07 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125997/ > --- > > (Updated Nov. 8, 2015, 10:07 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > CCBUG: 354966 > CCBUG: 355054 > > > Diffs > - > > shell/main.cpp a774cb4e8d18032ff3fd39892b8171b96a94cc92 > > Diff: https://git.reviewboard.kde.org/r/125997/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125997: Catch other openGL error gracefully
> On Nov. 9, 2015, 7:57 a.m., Martin Gräßlin wrote: > > Could you please explain the change? Reduce string comparison? > > > > Anyway: we should probably extend the checks to also include the EGL/XCB > > error messages an EGL/Wayland error messages > > David Edmundson wrote: > there's a second > > if message == "blah" > which is the main important change > > then I added the if Q_UNLIKELY to potentially speed things up as 99.% > of the time it will be debug not fatal messages. > > then I reformatted it so it was a bit cleaner as I ended up 4 brackets > deep thanks. Now I see the change to the second message. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125997/#review88172 --- On Nov. 8, 2015, 10:07 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125997/ > --- > > (Updated Nov. 8, 2015, 10:07 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > CCBUG: 354966 > CCBUG: 355054 > > > Diffs > - > > shell/main.cpp a774cb4e8d18032ff3fd39892b8171b96a94cc92 > > Diff: https://git.reviewboard.kde.org/r/125997/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125997: Catch other openGL error gracefully
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125997/ --- (Updated Nov. 9, 2015, 10:30 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit e20c4c6b7a2910bef752a19a414488e257a49419 by David Edmundson to branch master. Repository: plasma-workspace Description --- CCBUG: 354966 CCBUG: 355054 Diffs - shell/main.cpp a774cb4e8d18032ff3fd39892b8171b96a94cc92 Diff: https://git.reviewboard.kde.org/r/125997/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
