Re: Review Request 126022: [ksmserver] Add a dedicated --no-lockscreen command line option

2015-11-16 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126022/
---

(Updated Nov. 16, 2015, 8:14 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Bhushan Shah.


Changes
---

Submitted with commit 1d7af8c97164d3416bfa0d103c9f3c883cea3083 by Martin 
Gräßlin to branch master.


Repository: plasma-workspace


Description
---

On Wayland ksmserver should not be responsible for the lockscreen,
but the compositor takes care of providing the lock screen. To prevent
conflicts KSMServer gets a new command line option to enable it.

The code is slightly changed to not pass a series of boolean flags to
KSMServer, but a flags type.

The startplasma script for Wayland is adjusted to start ksmserver with
the new command line option.


Diffs
-

  ksmserver/main.cpp b1f1b68fe41b86da42d7bea2c088db6d89f0d844 
  ksmserver/server.h 87e46cbad70913b83f976ea2938606042c653c69 
  ksmserver/server.cpp ffb15d230b927c5ee28b7196904e0061a14b2d09 
  startkde/startplasma.cmake 4fab3b1597fee40bf69551af895d5248955eadea 

Diff: https://git.reviewboard.kde.org/r/126022/diff/


Testing
---

Started a Plasma/Wayland session with the change.

* ksmserver is started with --no-lockscreen
* Using loginctl lock-session gives me one lock window, instead of two as before


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126022: [ksmserver] Add a dedicated --no-lockscreen command line option

2015-11-15 Thread Bhushan Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126022/#review88378
---

Ship it!


Ship It!

- Bhushan Shah


On Nov. 11, 2015, 2:40 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126022/
> ---
> 
> (Updated Nov. 11, 2015, 2:40 p.m.)
> 
> 
> Review request for Plasma and Bhushan Shah.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> On Wayland ksmserver should not be responsible for the lockscreen,
> but the compositor takes care of providing the lock screen. To prevent
> conflicts KSMServer gets a new command line option to enable it.
> 
> The code is slightly changed to not pass a series of boolean flags to
> KSMServer, but a flags type.
> 
> The startplasma script for Wayland is adjusted to start ksmserver with
> the new command line option.
> 
> 
> Diffs
> -
> 
>   ksmserver/main.cpp b1f1b68fe41b86da42d7bea2c088db6d89f0d844 
>   ksmserver/server.h 87e46cbad70913b83f976ea2938606042c653c69 
>   ksmserver/server.cpp ffb15d230b927c5ee28b7196904e0061a14b2d09 
>   startkde/startplasma.cmake 4fab3b1597fee40bf69551af895d5248955eadea 
> 
> Diff: https://git.reviewboard.kde.org/r/126022/diff/
> 
> 
> Testing
> ---
> 
> Started a Plasma/Wayland session with the change.
> 
> * ksmserver is started with --no-lockscreen
> * Using loginctl lock-session gives me one lock window, instead of two as 
> before
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126022: [ksmserver] Add a dedicated --no-lockscreen command line option

2015-11-15 Thread Bhushan Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126022/#review88377
---



startkde/startplasma.cmake (line 35)


Please adjust kwin_wayland call to use this environment variable, i.e pass 
--lockscreen to kwin_wayland if it is set.


- Bhushan Shah


On Nov. 11, 2015, 2:40 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126022/
> ---
> 
> (Updated Nov. 11, 2015, 2:40 p.m.)
> 
> 
> Review request for Plasma and Bhushan Shah.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> On Wayland ksmserver should not be responsible for the lockscreen,
> but the compositor takes care of providing the lock screen. To prevent
> conflicts KSMServer gets a new command line option to enable it.
> 
> The code is slightly changed to not pass a series of boolean flags to
> KSMServer, but a flags type.
> 
> The startplasma script for Wayland is adjusted to start ksmserver with
> the new command line option.
> 
> 
> Diffs
> -
> 
>   ksmserver/main.cpp b1f1b68fe41b86da42d7bea2c088db6d89f0d844 
>   ksmserver/server.h 87e46cbad70913b83f976ea2938606042c653c69 
>   ksmserver/server.cpp ffb15d230b927c5ee28b7196904e0061a14b2d09 
>   startkde/startplasma.cmake 4fab3b1597fee40bf69551af895d5248955eadea 
> 
> Diff: https://git.reviewboard.kde.org/r/126022/diff/
> 
> 
> Testing
> ---
> 
> Started a Plasma/Wayland session with the change.
> 
> * ksmserver is started with --no-lockscreen
> * Using loginctl lock-session gives me one lock window, instead of two as 
> before
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126022: [ksmserver] Add a dedicated --no-lockscreen command line option

2015-11-15 Thread Martin Gräßlin 


> On Nov. 15, 2015, 11:36 a.m., Bhushan Shah wrote:
> > startkde/startplasma.cmake, line 35
> > 
> >
> > Please adjust kwin_wayland call to use this environment variable, i.e 
> > pass --lockscreen to kwin_wayland if it is set.

There are two possible ways to do it: we can change the startplasmacompositor 
to pass --lockscreen or we read the env variable in KWin. I'm open to both.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126022/#review88377
---


On Nov. 11, 2015, 10:10 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126022/
> ---
> 
> (Updated Nov. 11, 2015, 10:10 a.m.)
> 
> 
> Review request for Plasma and Bhushan Shah.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> On Wayland ksmserver should not be responsible for the lockscreen,
> but the compositor takes care of providing the lock screen. To prevent
> conflicts KSMServer gets a new command line option to enable it.
> 
> The code is slightly changed to not pass a series of boolean flags to
> KSMServer, but a flags type.
> 
> The startplasma script for Wayland is adjusted to start ksmserver with
> the new command line option.
> 
> 
> Diffs
> -
> 
>   ksmserver/main.cpp b1f1b68fe41b86da42d7bea2c088db6d89f0d844 
>   ksmserver/server.h 87e46cbad70913b83f976ea2938606042c653c69 
>   ksmserver/server.cpp ffb15d230b927c5ee28b7196904e0061a14b2d09 
>   startkde/startplasma.cmake 4fab3b1597fee40bf69551af895d5248955eadea 
> 
> Diff: https://git.reviewboard.kde.org/r/126022/diff/
> 
> 
> Testing
> ---
> 
> Started a Plasma/Wayland session with the change.
> 
> * ksmserver is started with --no-lockscreen
> * Using loginctl lock-session gives me one lock window, instead of two as 
> before
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126022: [ksmserver] Add a dedicated --no-lockscreen command line option

2015-11-15 Thread Bhushan Shah 


> On Nov. 15, 2015, 4:06 p.m., Bhushan Shah wrote:
> > startkde/startplasma.cmake, line 35
> > 
> >
> > Please adjust kwin_wayland call to use this environment variable, i.e 
> > pass --lockscreen to kwin_wayland if it is set.
> 
> Martin Gräßlin wrote:
> There are two possible ways to do it: we can change the 
> startplasmacompositor to pass --lockscreen or we read the env variable in 
> KWin. I'm open to both.

Okay, then we can do it from kwin. Ship it!


- Bhushan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126022/#review88377
---


On Nov. 11, 2015, 2:40 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126022/
> ---
> 
> (Updated Nov. 11, 2015, 2:40 p.m.)
> 
> 
> Review request for Plasma and Bhushan Shah.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> On Wayland ksmserver should not be responsible for the lockscreen,
> but the compositor takes care of providing the lock screen. To prevent
> conflicts KSMServer gets a new command line option to enable it.
> 
> The code is slightly changed to not pass a series of boolean flags to
> KSMServer, but a flags type.
> 
> The startplasma script for Wayland is adjusted to start ksmserver with
> the new command line option.
> 
> 
> Diffs
> -
> 
>   ksmserver/main.cpp b1f1b68fe41b86da42d7bea2c088db6d89f0d844 
>   ksmserver/server.h 87e46cbad70913b83f976ea2938606042c653c69 
>   ksmserver/server.cpp ffb15d230b927c5ee28b7196904e0061a14b2d09 
>   startkde/startplasma.cmake 4fab3b1597fee40bf69551af895d5248955eadea 
> 
> Diff: https://git.reviewboard.kde.org/r/126022/diff/
> 
> 
> Testing
> ---
> 
> Started a Plasma/Wayland session with the change.
> 
> * ksmserver is started with --no-lockscreen
> * Using loginctl lock-session gives me one lock window, instead of two as 
> before
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126022: [ksmserver] Add a dedicated --no-lockscreen command line option

2015-11-11 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126022/
---

Review request for Plasma and Bhushan Shah.


Repository: plasma-workspace


Description
---

On Wayland ksmserver should not be responsible for the lockscreen,
but the compositor takes care of providing the lock screen. To prevent
conflicts KSMServer gets a new command line option to enable it.

The code is slightly changed to not pass a series of boolean flags to
KSMServer, but a flags type.

The startplasma script for Wayland is adjusted to start ksmserver with
the new command line option.


Diffs
-

  ksmserver/main.cpp b1f1b68fe41b86da42d7bea2c088db6d89f0d844 
  ksmserver/server.h 87e46cbad70913b83f976ea2938606042c653c69 
  ksmserver/server.cpp ffb15d230b927c5ee28b7196904e0061a14b2d09 
  startkde/startplasma.cmake 4fab3b1597fee40bf69551af895d5248955eadea 

Diff: https://git.reviewboard.kde.org/r/126022/diff/


Testing
---

Started a Plasma/Wayland session with the change.

* ksmserver is started with --no-lockscreen
* Using loginctl lock-session gives me one lock window, instead of two as before


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126022: [ksmserver] Add a dedicated --no-lockscreen command line option

2015-11-11 Thread Bhushan Shah 
I kinda don't like idea of the command line option.. For instance if
someone uses this option on X11 they are lift without lockscreen.. Any
other solution possible?

Ideally ksmserver should just retire in Wayland world imo and other
functionality of it should be split out of it..
On Nov 11, 2015 2:40 PM, "Martin Gräßlin"  wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126022/
> Review request for Plasma and Bhushan Shah.
> By Martin Gräßlin.
> *Repository: * plasma-workspace
> Description
>
> On Wayland ksmserver should not be responsible for the lockscreen,
> but the compositor takes care of providing the lock screen. To prevent
> conflicts KSMServer gets a new command line option to enable it.
>
> The code is slightly changed to not pass a series of boolean flags to
> KSMServer, but a flags type.
>
> The startplasma script for Wayland is adjusted to start ksmserver with
> the new command line option.
>
> Testing
>
> Started a Plasma/Wayland session with the change.
>
>- ksmserver is started with --no-lockscreen
>- Using loginctl lock-session gives me one lock window, instead of two as 
> before
>
> Diffs
>
>- ksmserver/main.cpp (b1f1b68fe41b86da42d7bea2c088db6d89f0d844)
>- ksmserver/server.h (87e46cbad70913b83f976ea2938606042c653c69)
>- ksmserver/server.cpp (ffb15d230b927c5ee28b7196904e0061a14b2d09)
>- startkde/startplasma.cmake (4fab3b1597fee40bf69551af895d5248955eadea)
>
> View Diff 
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126022: [ksmserver] Add a dedicated --no-lockscreen command line option

2015-11-11 Thread Martin Graesslin 
On Wednesday, November 11, 2015 3:45:53 PM CET Bhushan Shah wrote:
> I kinda don't like idea of the command line option.. For instance if
> someone uses this option on X11 they are lift without lockscreen.. Any
> other solution possible?

I don't think that is an actual threat. This requires modifying startkde 
(which needs root privs). If users want to shoot into their feet: sure let 
them.

> 
> Ideally ksmserver should just retire in Wayland world imo and other
> functionality of it should be split out of it..

Ideally yes. Practically: I run away from that screaming. It still has a lot 
of startup code and I don't think we will be able to migrate that code fast. 
So we need a solution till ksmserver gets retired.

Cheers
Martin

> 
> On Nov 11, 2015 2:40 PM, "Martin Gräßlin"  wrote:
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/126022/
> > Review request for Plasma and Bhushan Shah.
> > By Martin Gräßlin.
> > *Repository: * plasma-workspace
> > Description
> > 
> > On Wayland ksmserver should not be responsible for the lockscreen,
> > but the compositor takes care of providing the lock screen. To prevent
> > conflicts KSMServer gets a new command line option to enable it.
> > 
> > The code is slightly changed to not pass a series of boolean flags to
> > KSMServer, but a flags type.
> > 
> > The startplasma script for Wayland is adjusted to start ksmserver with
> > the new command line option.
> > 
> > Testing
> > 
> > Started a Plasma/Wayland session with the change.
> > 
> >- ksmserver is started with --no-lockscreen
> >- Using loginctl lock-session gives me one lock window, instead of two
> >as before> 
> > Diffs
> > 
> >- ksmserver/main.cpp (b1f1b68fe41b86da42d7bea2c088db6d89f0d844)
> >- ksmserver/server.h (87e46cbad70913b83f976ea2938606042c653c69)
> >- ksmserver/server.cpp (ffb15d230b927c5ee28b7196904e0061a14b2d09)
> >- startkde/startplasma.cmake (4fab3b1597fee40bf69551af895d5248955eadea)
> > 
> > View Diff 


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel