Re: Review Request 126276: Disable ptrace on kdesu

2015-12-17 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126276/
---

(Updated Dec. 17, 2015, 12:28 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 034b5c39e49ce946ca97f0d003a4b4f144b10d39 by Martin 
Gräßlin to branch master.


Repository: kde-cli-tools


Description
---

This change protects against other user processes attaching to the kdesu
process to gain the root password.


Diffs
-

  CMakeLists.txt 31209e049b0f054f88a8471cdfa34eb99b2d38da 
  config-kde-cli-tools.h.cmake f7eb81e3ab541faee2d8d6a15c870c68dd649dd2 
  kdesu/kdesu.cpp b82bdd4d7bdb3f8cf47fa46ac7d878d01f4cc551 

Diff: https://git.reviewboard.kde.org/r/126276/diff/


Testing
---

with the change: ptrace: Operation not permitted.
without I was able to set breakpoint in the checkPassword method.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126276: Disable ptrace on kdesu

2015-12-17 Thread Harald Sitter 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126276/#review89641
---

Ship it!


ptrace: Operation not permitted.

:'<

shipit!

- Harald Sitter


On Dec. 8, 2015, noon, Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126276/
> ---
> 
> (Updated Dec. 8, 2015, noon)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> ---
> 
> This change protects against other user processes attaching to the kdesu
> process to gain the root password.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 31209e049b0f054f88a8471cdfa34eb99b2d38da 
>   config-kde-cli-tools.h.cmake f7eb81e3ab541faee2d8d6a15c870c68dd649dd2 
>   kdesu/kdesu.cpp b82bdd4d7bdb3f8cf47fa46ac7d878d01f4cc551 
> 
> Diff: https://git.reviewboard.kde.org/r/126276/diff/
> 
> 
> Testing
> ---
> 
> with the change: ptrace: Operation not permitted.
> without I was able to set breakpoint in the checkPassword method.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126276: Disable ptrace on kdesu

2015-12-16 Thread Martin Gräßlin 


> On Dec. 16, 2015, 10:15 a.m., Harald Sitter wrote:
> > CMakeLists.txt, line 93
> > 
> >
> > description needs update for kdesu

good spot!


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126276/#review89585
---


On Dec. 8, 2015, 1 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126276/
> ---
> 
> (Updated Dec. 8, 2015, 1 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> ---
> 
> This change protects against other user processes attaching to the kdesu
> process to gain the root password.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 31209e049b0f054f88a8471cdfa34eb99b2d38da 
>   config-kde-cli-tools.h.cmake f7eb81e3ab541faee2d8d6a15c870c68dd649dd2 
>   kdesu/kdesu.cpp b82bdd4d7bdb3f8cf47fa46ac7d878d01f4cc551 
> 
> Diff: https://git.reviewboard.kde.org/r/126276/diff/
> 
> 
> Testing
> ---
> 
> with the change: ptrace: Operation not permitted.
> without I was able to set breakpoint in the checkPassword method.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126276: Disable ptrace on kdesu

2015-12-16 Thread Harald Sitter 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126276/#review89585
---



CMakeLists.txt (line 93)


description needs update for kdesu


- Harald Sitter


On Dec. 8, 2015, noon, Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126276/
> ---
> 
> (Updated Dec. 8, 2015, noon)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> ---
> 
> This change protects against other user processes attaching to the kdesu
> process to gain the root password.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 31209e049b0f054f88a8471cdfa34eb99b2d38da 
>   config-kde-cli-tools.h.cmake f7eb81e3ab541faee2d8d6a15c870c68dd649dd2 
>   kdesu/kdesu.cpp b82bdd4d7bdb3f8cf47fa46ac7d878d01f4cc551 
> 
> Diff: https://git.reviewboard.kde.org/r/126276/diff/
> 
> 
> Testing
> ---
> 
> with the change: ptrace: Operation not permitted.
> without I was able to set breakpoint in the checkPassword method.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126276: Disable ptrace on kdesu

2015-12-08 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126276/
---

Review request for Plasma.


Repository: kde-cli-tools


Description
---

This change protects against other user processes attaching to the kdesu
process to gain the root password.


Diffs
-

  CMakeLists.txt 31209e049b0f054f88a8471cdfa34eb99b2d38da 
  config-kde-cli-tools.h.cmake f7eb81e3ab541faee2d8d6a15c870c68dd649dd2 
  kdesu/kdesu.cpp b82bdd4d7bdb3f8cf47fa46ac7d878d01f4cc551 

Diff: https://git.reviewboard.kde.org/r/126276/diff/


Testing
---

with the change: ptrace: Operation not permitted.
without I was able to set breakpoint in the checkPassword method.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel