Re: Review Request 126472: Don't always load the timetracker
> On Dec. 22, 2015, 2:36 p.m., Sebastian Kügler wrote: > > Nice. > > > > I agree with Aleix that the env var would be good to have documented. (Is > > that even English?) But then, where? > > Martin Gräßlin wrote: > as an idea check: https://community.kde.org/KWin/Environment_Variables ok, done. https://community.kde.org/Plasma/Environment_Variables - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126472/#review89924 --- On Dec. 27, 2015, 7:38 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126472/ > --- > > (Updated Dec. 27, 2015, 7:38 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Don't always load the timetracker > > It has a timer that wakes up every 2 seconds and drains my battery just > simply because I have debug builds. This make it on demand. > > Don't track containments twice. > Containments inherit from Applets which also have the same line > > > Diffs > - > > src/plasma/corona.cpp 316b225ecafcfa6e0b8b894cfea082046c296238 > src/plasma/private/applet_p.cpp 511b45119f6d91605f36c8b7073a0b0bb4560e5f > src/plasma/private/containment_p.cpp > 86d27c43f36b9e1741ab13f8153080fb6b92b321 > > Diff: https://git.reviewboard.kde.org/r/126472/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126472: Don't always load the timetracker
> On Dec. 22, 2015, 3:36 p.m., Sebastian Kügler wrote: > > Nice. > > > > I agree with Aleix that the env var would be good to have documented. (Is > > that even English?) But then, where? as an idea check: https://community.kde.org/KWin/Environment_Variables - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126472/#review89924 --- On Dec. 27, 2015, 8:38 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126472/ > --- > > (Updated Dec. 27, 2015, 8:38 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Don't always load the timetracker > > It has a timer that wakes up every 2 seconds and drains my battery just > simply because I have debug builds. This make it on demand. > > Don't track containments twice. > Containments inherit from Applets which also have the same line > > > Diffs > - > > src/plasma/corona.cpp 316b225ecafcfa6e0b8b894cfea082046c296238 > src/plasma/private/applet_p.cpp 511b45119f6d91605f36c8b7073a0b0bb4560e5f > src/plasma/private/containment_p.cpp > 86d27c43f36b9e1741ab13f8153080fb6b92b321 > > Diff: https://git.reviewboard.kde.org/r/126472/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126472: Don't always load the timetracker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126472/ --- (Updated Dec. 27, 2015, 7:38 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit ab135f4e8ed451f4f310732e6f5bc084aff69519 by David Edmundson to branch master. Repository: plasma-framework Description --- Don't always load the timetracker It has a timer that wakes up every 2 seconds and drains my battery just simply because I have debug builds. This make it on demand. Don't track containments twice. Containments inherit from Applets which also have the same line Diffs - src/plasma/corona.cpp 316b225ecafcfa6e0b8b894cfea082046c296238 src/plasma/private/applet_p.cpp 511b45119f6d91605f36c8b7073a0b0bb4560e5f src/plasma/private/containment_p.cpp 86d27c43f36b9e1741ab13f8153080fb6b92b321 Diff: https://git.reviewboard.kde.org/r/126472/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 126472: Don't always load the timetracker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126472/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Don't always load the timetracker It has a timer that wakes up every 2 seconds and drains my battery just simply because I have debug builds. This make it on demand. Don't track containments twice. Containments inherit from Applets which also have the same line Diffs - src/plasma/corona.cpp 316b225ecafcfa6e0b8b894cfea082046c296238 src/plasma/private/applet_p.cpp 511b45119f6d91605f36c8b7073a0b0bb4560e5f src/plasma/private/containment_p.cpp 86d27c43f36b9e1741ab13f8153080fb6b92b321 Diff: https://git.reviewboard.kde.org/r/126472/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126472: Don't always load the timetracker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126472/#review89924 --- Ship it! Nice. I agree with Aleix that the env var would be good to have documented. (Is that even English?) But then, where? - Sebastian Kügler On Dec. 22, 2015, 2:14 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126472/ > --- > > (Updated Dec. 22, 2015, 2:14 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Don't always load the timetracker > > It has a timer that wakes up every 2 seconds and drains my battery just > simply because I have debug builds. This make it on demand. > > Don't track containments twice. > Containments inherit from Applets which also have the same line > > > Diffs > - > > src/plasma/corona.cpp 316b225ecafcfa6e0b8b894cfea082046c296238 > src/plasma/private/applet_p.cpp 511b45119f6d91605f36c8b7073a0b0bb4560e5f > src/plasma/private/containment_p.cpp > 86d27c43f36b9e1741ab13f8153080fb6b92b321 > > Diff: https://git.reviewboard.kde.org/r/126472/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126472: Don't always load the timetracker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126472/#review89921 --- I'm ok with this, although it wasn't guarded initially because it was asked not to. IIRC. Anyway, +1. - Aleix Pol Gonzalez On Dec. 22, 2015, 3:14 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126472/ > --- > > (Updated Dec. 22, 2015, 3:14 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Don't always load the timetracker > > It has a timer that wakes up every 2 seconds and drains my battery just > simply because I have debug builds. This make it on demand. > > Don't track containments twice. > Containments inherit from Applets which also have the same line > > > Diffs > - > > src/plasma/corona.cpp 316b225ecafcfa6e0b8b894cfea082046c296238 > src/plasma/private/applet_p.cpp 511b45119f6d91605f36c8b7073a0b0bb4560e5f > src/plasma/private/containment_p.cpp > 86d27c43f36b9e1741ab13f8153080fb6b92b321 > > Diff: https://git.reviewboard.kde.org/r/126472/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126472: Don't always load the timetracker
> On Dec. 22, 2015, 3:21 p.m., Aleix Pol Gonzalez wrote: > > I'm ok with this, although it wasn't guarded initially because it was asked > > not to. IIRC. > > > > Anyway, +1. Some small documentation about the environment variable would be neat. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126472/#review89921 --- On Dec. 22, 2015, 3:14 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126472/ > --- > > (Updated Dec. 22, 2015, 3:14 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Don't always load the timetracker > > It has a timer that wakes up every 2 seconds and drains my battery just > simply because I have debug builds. This make it on demand. > > Don't track containments twice. > Containments inherit from Applets which also have the same line > > > Diffs > - > > src/plasma/corona.cpp 316b225ecafcfa6e0b8b894cfea082046c296238 > src/plasma/private/applet_p.cpp 511b45119f6d91605f36c8b7073a0b0bb4560e5f > src/plasma/private/containment_p.cpp > 86d27c43f36b9e1741ab13f8153080fb6b92b321 > > Diff: https://git.reviewboard.kde.org/r/126472/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
