Re: Review Request 126742: Add clearActions() to remove every applet interface action.

2016-01-16 Thread James Smith

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126742/
---

(Updated Jan. 16, 2016, 5:03 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit d11c7535bafe7a9bae2d72ab003da77137a22b8f by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

Add clearActions() to remove every applet interface action. Is there an 
equivalent way to do this in the plasmoid?


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.h ad68499 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 8e4979a 

Diff: https://git.reviewboard.kde.org/r/126742/diff/


Testing
---

Compile, runtime.


Thanks,

James Smith

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 126742: Add clearActions() to remove every applet interface action.

2016-01-15 Thread James Smith


> On Jan. 15, 2016, 1:54 a.m., David Edmundson wrote:
> > do you have commit access?

no.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126742/#review91122
---


On Jan. 15, 2016, 1:52 a.m., James Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126742/
> ---
> 
> (Updated Jan. 15, 2016, 1:52 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Add clearActions() to remove every applet interface action. Is there an 
> equivalent way to do this in the plasmoid?
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h ad68499 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 8e4979a 
> 
> Diff: https://git.reviewboard.kde.org/r/126742/diff/
> 
> 
> Testing
> ---
> 
> Compile, runtime.
> 
> 
> Thanks,
> 
> James Smith
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 126742: Add clearActions() to remove every applet interface action.

2016-01-14 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126742/#review91122
---

Ship it!


do you have commit access?

- David Edmundson


On Jan. 15, 2016, 1:52 a.m., James Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126742/
> ---
> 
> (Updated Jan. 15, 2016, 1:52 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Add clearActions() to remove every applet interface action. Is there an 
> equivalent way to do this in the plasmoid?
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h ad68499 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 8e4979a 
> 
> Diff: https://git.reviewboard.kde.org/r/126742/diff/
> 
> 
> Testing
> ---
> 
> Compile, runtime.
> 
> 
> Thanks,
> 
> James Smith
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 126742: Add clearActions() to remove every applet interface action.

2016-01-14 Thread James Smith

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126742/
---

(Updated Jan. 15, 2016, 1:52 a.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

removeAllActions() ->clearActions().


Summary (updated)
-

Add clearActions() to remove every applet interface action.


Repository: plasma-framework


Description (updated)
---

Add clearActions() to remove every applet interface action. Is there an 
equivalent way to do this in the plasmoid?


Diffs (updated)
-

  src/scriptengines/qml/plasmoid/appletinterface.h ad68499 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 8e4979a 

Diff: https://git.reviewboard.kde.org/r/126742/diff/


Testing
---

Compile, runtime.


Thanks,

James Smith

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel