Re: Review Request 126801: Don't show drop applet placeholder on desktop in immutable state
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126801/#review91295 --- Ship it! Ship It! - Eike Hein On Jan. 18, 2016, 6:47 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126801/ > --- > > (Updated Jan. 18, 2016, 6:47 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > No applet will be created on drop in immutable state, so don't show the drop > placeholder. > > > Diffs > - > > containments/desktop/package/contents/ui/main.qml 26bd5d2 > > Diff: https://git.reviewboard.kde.org/r/126801/diff/ > > > Testing > --- > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126801: Don't show drop applet placeholder on desktop in immutable state
> On Jan. 18, 2016, 8:45 p.m., Kai Uwe Broulik wrote: > > Can we perhaps go a step further and just reject a drop, ie. disable the > > drop area? > > > > We have the problem of Firefox not opening a window because we eat the drop > > event. Of course doing that won't solve the root cause but at least > > alleviate it. > > David Rosca wrote: > It's currently not possible with KDeclarative DragAndDrop, you can only > disable the whole DropArea. > > But yeah, that would be better. Right now plasma just accepts drops > everywhere. This would be a welcome addition to DropArea. :) - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126801/#review91282 --- On Jan. 18, 2016, 6:47 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126801/ > --- > > (Updated Jan. 18, 2016, 6:47 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > No applet will be created on drop in immutable state, so don't show the drop > placeholder. > > > Diffs > - > > containments/desktop/package/contents/ui/main.qml 26bd5d2 > > Diff: https://git.reviewboard.kde.org/r/126801/diff/ > > > Testing > --- > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126801: Don't show drop applet placeholder on desktop in immutable state
> On Jan. 18, 2016, 8:45 p.m., Kai Uwe Broulik wrote: > > Can we perhaps go a step further and just reject a drop, ie. disable the > > drop area? > > > > We have the problem of Firefox not opening a window because we eat the drop > > event. Of course doing that won't solve the root cause but at least > > alleviate it. It's currently not possible with KDeclarative DragAndDrop, you can only disable the whole DropArea. But yeah, that would be better. Right now plasma just accepts drops everywhere. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126801/#review91282 --- On Jan. 18, 2016, 6:47 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126801/ > --- > > (Updated Jan. 18, 2016, 6:47 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > No applet will be created on drop in immutable state, so don't show the drop > placeholder. > > > Diffs > - > > containments/desktop/package/contents/ui/main.qml 26bd5d2 > > Diff: https://git.reviewboard.kde.org/r/126801/diff/ > > > Testing > --- > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126801: Don't show drop applet placeholder on desktop in immutable state
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126801/#review91282 --- Can we perhaps go a step further and just reject a drop, ie. disable the drop area? We have the problem of Firefox not opening a window because we eat the drop event. Of course doing that won't solve the root cause but at least alleviate it. - Kai Uwe Broulik On Jan. 18, 2016, 6:47 nachm., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126801/ > --- > > (Updated Jan. 18, 2016, 6:47 nachm.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > No applet will be created on drop in immutable state, so don't show the drop > placeholder. > > > Diffs > - > > containments/desktop/package/contents/ui/main.qml 26bd5d2 > > Diff: https://git.reviewboard.kde.org/r/126801/diff/ > > > Testing > --- > > > Thanks, > > David Rosca > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 126801: Don't show drop applet placeholder on desktop in immutable state
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126801/ --- Review request for Plasma. Repository: plasma-desktop Description --- No applet will be created on drop in immutable state, so don't show the drop placeholder. Diffs - containments/desktop/package/contents/ui/main.qml 26bd5d2 Diff: https://git.reviewboard.kde.org/r/126801/diff/ Testing --- Thanks, David Rosca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
