Re: Review Request 126879: [digital-clock] Use iso-codes for country names

2016-03-02 Thread Pino Toscano 


> On Mar. 1, 2016, 1:31 p.m., Martin Klapetek wrote:
> > Turns out pkg_get_variable is available only in cmake 3.4, while minimum 
> > requirement is "2.8.12".
> > 
> > Can you perhaps change the cmake module to not use pkg_get_variable for now?

Yessir, will change it soon.

Thanks for the notice.


- Pino


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126879/#review92995
---


On Feb. 14, 2016, 12:09 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126879/
> ---
> 
> (Updated Feb. 14, 2016, 12:09 p.m.)
> 
> 
> Review request for Localization and Translation (l10n), Plasma and John Layt.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of an hardcoded list of translations of country names, look them up 
> in the iso_3166 domain, provided by iso-codes.  The names of countries are 
> changes to their ISO 3166 versions in iso-codes.
> 
> Look for iso-codes in cmake, but just as indication of it as runtime 
> dependency.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/CMakeLists.txt 
> c22c82a75fe6efecc4a249ebd7e045a6f0385ac5 
>   applets/digital-clock/plugin/timezonesi18n.cpp 
> 6bb465e68bfba4695c79898d630dec5a7075a058 
>   cmake/FindIsoCodes.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126879/diff/
> 
> 
> Testing
> ---
> 
> With Plasma 5.3 (but this code is the same as in master), the configuration 
> of timezoned in the digital clock is translated according to iso-codes.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

2016-03-01 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126879/#review92995
---



Turns out pkg_get_variable is available only in cmake 3.4, while minimum 
requirement is "2.8.12".

Can you perhaps change the cmake module to not use pkg_get_variable for now?

- Martin Klapetek


On Feb. 14, 2016, 1:09 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126879/
> ---
> 
> (Updated Feb. 14, 2016, 1:09 p.m.)
> 
> 
> Review request for Localization and Translation (l10n), Plasma and John Layt.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of an hardcoded list of translations of country names, look them up 
> in the iso_3166 domain, provided by iso-codes.  The names of countries are 
> changes to their ISO 3166 versions in iso-codes.
> 
> Look for iso-codes in cmake, but just as indication of it as runtime 
> dependency.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/CMakeLists.txt 
> c22c82a75fe6efecc4a249ebd7e045a6f0385ac5 
>   applets/digital-clock/plugin/timezonesi18n.cpp 
> 6bb465e68bfba4695c79898d630dec5a7075a058 
>   cmake/FindIsoCodes.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126879/diff/
> 
> 
> Testing
> ---
> 
> With Plasma 5.3 (but this code is the same as in master), the configuration 
> of timezoned in the digital clock is translated according to iso-codes.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

2016-02-14 Thread Pino Toscano 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126879/
---

(Updated Feb. 14, 2016, 1:09 p.m.)


Status
--

This change has been marked as submitted.


Review request for Localization and Translation (l10n), Plasma and John Layt.


Changes
---

Submitted with commit fea67bd2ae7549e88952ac6dbcf90392d0ee1458 by Pino Toscano 
to branch master.


Repository: plasma-workspace


Description
---

Instead of an hardcoded list of translations of country names, look them up in 
the iso_3166 domain, provided by iso-codes.  The names of countries are changes 
to their ISO 3166 versions in iso-codes.

Look for iso-codes in cmake, but just as indication of it as runtime dependency.


Diffs
-

  applets/digital-clock/plugin/CMakeLists.txt 
c22c82a75fe6efecc4a249ebd7e045a6f0385ac5 
  applets/digital-clock/plugin/timezonesi18n.cpp 
6bb465e68bfba4695c79898d630dec5a7075a058 
  cmake/FindIsoCodes.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126879/diff/


Testing
---

With Plasma 5.3 (but this code is the same as in master), the configuration of 
timezoned in the digital clock is translated according to iso-codes.


Thanks,

Pino Toscano

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

2016-01-25 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126879/#review91586
---


Ship it!




Looks good, thanks!

- Martin Klapetek


On Jan. 24, 2016, 10:58 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126879/
> ---
> 
> (Updated Jan. 24, 2016, 10:58 p.m.)
> 
> 
> Review request for Localization and Translation (l10n), Plasma and John Layt.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of an hardcoded list of translations of country names, look them up 
> in the iso_3166 domain, provided by iso-codes.  The names of countries are 
> changes to their ISO 3166 versions in iso-codes.
> 
> Look for iso-codes in cmake, but just as indication of it as runtime 
> dependency.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/CMakeLists.txt 
> c22c82a75fe6efecc4a249ebd7e045a6f0385ac5 
>   applets/digital-clock/plugin/timezonesi18n.cpp 
> 6bb465e68bfba4695c79898d630dec5a7075a058 
>   cmake/FindIsoCodes.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126879/diff/
> 
> 
> Testing
> ---
> 
> With Plasma 5.3 (but this code is the same as in master), the configuration 
> of timezoned in the digital clock is translated according to iso-codes.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126879: [digital-clock] Use iso-codes for country names

2016-01-24 Thread Pino Toscano 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126879/
---

Review request for Localization and Translation (l10n), Plasma and John Layt.


Repository: plasma-workspace


Description
---

Instead of an hardcoded list of translations of country names, look them up in 
the iso_3166 domain, provided by iso-codes.  The names of countries are changes 
to their ISO 3166 versions in iso-codes.

Look for iso-codes in cmake, but just as indication of it as runtime dependency.


Diffs
-

  applets/digital-clock/plugin/CMakeLists.txt 
c22c82a75fe6efecc4a249ebd7e045a6f0385ac5 
  applets/digital-clock/plugin/timezonesi18n.cpp 
6bb465e68bfba4695c79898d630dec5a7075a058 
  cmake/FindIsoCodes.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126879/diff/


Testing
---

With Plasma 5.3 (but this code is the same as in master), the configuration of 
timezoned in the digital clock is translated according to iso-codes.


Thanks,

Pino Toscano

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

2016-01-24 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126879/#review91552
---



+1


applets/digital-clock/plugin/timezonesi18n.cpp (line 517)


may as well keep the comment from the i18n?


- David Edmundson


On Jan. 24, 2016, 9:58 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126879/
> ---
> 
> (Updated Jan. 24, 2016, 9:58 p.m.)
> 
> 
> Review request for Localization and Translation (l10n), Plasma and John Layt.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of an hardcoded list of translations of country names, look them up 
> in the iso_3166 domain, provided by iso-codes.  The names of countries are 
> changes to their ISO 3166 versions in iso-codes.
> 
> Look for iso-codes in cmake, but just as indication of it as runtime 
> dependency.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/CMakeLists.txt 
> c22c82a75fe6efecc4a249ebd7e045a6f0385ac5 
>   applets/digital-clock/plugin/timezonesi18n.cpp 
> 6bb465e68bfba4695c79898d630dec5a7075a058 
>   cmake/FindIsoCodes.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126879/diff/
> 
> 
> Testing
> ---
> 
> With Plasma 5.3 (but this code is the same as in master), the configuration 
> of timezoned in the digital clock is translated according to iso-codes.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

2016-01-24 Thread Pino Toscano 


> On Gen. 24, 2016, 10:39 p.m., David Edmundson wrote:
> > applets/digital-clock/plugin/timezonesi18n.cpp, line 517
> > 
> >
> > may as well keep the comment from the i18n?

Not sure what you mean. The point here is load the translations from the 
iso_3166 domain (the .mo file, basically), and they have no context there. 
After this patch, there will be 247 strings less to translate in the digital 
clock messages, they won't be extracted anymore.


- Pino


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126879/#review91552
---


On Gen. 24, 2016, 9:58 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126879/
> ---
> 
> (Updated Gen. 24, 2016, 9:58 p.m.)
> 
> 
> Review request for Localization and Translation (l10n), Plasma and John Layt.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of an hardcoded list of translations of country names, look them up 
> in the iso_3166 domain, provided by iso-codes.  The names of countries are 
> changes to their ISO 3166 versions in iso-codes.
> 
> Look for iso-codes in cmake, but just as indication of it as runtime 
> dependency.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/CMakeLists.txt 
> c22c82a75fe6efecc4a249ebd7e045a6f0385ac5 
>   applets/digital-clock/plugin/timezonesi18n.cpp 
> 6bb465e68bfba4695c79898d630dec5a7075a058 
>   cmake/FindIsoCodes.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126879/diff/
> 
> 
> Testing
> ---
> 
> With Plasma 5.3 (but this code is the same as in master), the configuration 
> of timezoned in the digital clock is translated according to iso-codes.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

2016-01-24 Thread David Edmundson 


> On Jan. 24, 2016, 10:39 p.m., David Edmundson wrote:
> > applets/digital-clock/plugin/timezonesi18n.cpp, line 517
> > 
> >
> > may as well keep the comment from the i18n?
> 
> Pino Toscano wrote:
> Not sure what you mean. The point here is load the translations from the 
> iso_3166 domain (the .mo file, basically), and they have no context there. 
> After this patch, there will be 247 strings less to translate in the digital 
> clock messages, they won't be extracted anymore.

oh you're right.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126879/#review91552
---


On Jan. 24, 2016, 9:58 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126879/
> ---
> 
> (Updated Jan. 24, 2016, 9:58 p.m.)
> 
> 
> Review request for Localization and Translation (l10n), Plasma and John Layt.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of an hardcoded list of translations of country names, look them up 
> in the iso_3166 domain, provided by iso-codes.  The names of countries are 
> changes to their ISO 3166 versions in iso-codes.
> 
> Look for iso-codes in cmake, but just as indication of it as runtime 
> dependency.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/CMakeLists.txt 
> c22c82a75fe6efecc4a249ebd7e045a6f0385ac5 
>   applets/digital-clock/plugin/timezonesi18n.cpp 
> 6bb465e68bfba4695c79898d630dec5a7075a058 
>   cmake/FindIsoCodes.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126879/diff/
> 
> 
> Testing
> ---
> 
> With Plasma 5.3 (but this code is the same as in master), the configuration 
> of timezoned in the digital clock is translated according to iso-codes.
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel