Re: Review Request 128070: Update mouse kcm docbook to 5.6

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128070/#review96265
---


Ship it!




Ship It!

- Sebastian Kügler


On June 1, 2016, 9:22 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128070/
> ---
> 
> (Updated June 1, 2016, 9:22 a.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> bump date + releaseinfo
> single / double click setting was removed from dolphin / konqueror
> remove Change Pointer + Automatically select icons settings, no longer in the 
> code
> change kde -> plasma
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/mouse/index.docbook b09f8e7 
> 
> Diff: https://git.reviewboard.kde.org/r/128070/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128070: Update mouse kcm docbook to 5.6

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128070/#review96264
---



ping?

- Burkhard Lück


On Juni 1, 2016, 9:22 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128070/
> ---
> 
> (Updated Juni 1, 2016, 9:22 vorm.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> bump date + releaseinfo
> single / double click setting was removed from dolphin / konqueror
> remove Change Pointer + Automatically select icons settings, no longer in the 
> code
> change kde -> plasma
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/mouse/index.docbook b09f8e7 
> 
> Diff: https://git.reviewboard.kde.org/r/128070/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128070: Update mouse kcm docbook to 5.6

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128070/#review96131
---



Looks good to me, but let's have others also a look on it.

Btw. I just checked git log to verify that logitech related code got deleted: 
gone with a029fb591ae6ddba5e23c5d5874afa7f2935fbd9

- Martin Gräßlin


On June 1, 2016, 11:22 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128070/
> ---
> 
> (Updated June 1, 2016, 11:22 a.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> bump date + releaseinfo
> single / double click setting was removed from dolphin / konqueror
> remove Change Pointer + Automatically select icons settings, no longer in the 
> code
> change kde -> plasma
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/mouse/index.docbook b09f8e7 
> 
> Diff: https://git.reviewboard.kde.org/r/128070/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128070: Update mouse kcm docbook to 5.6

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128070/
---

(Updated Juni 1, 2016, 9:22 vorm.)


Review request for Documentation and Plasma.


Changes
---

remove plasma + sect logitech


Repository: plasma-desktop


Description
---

bump date + releaseinfo
single / double click setting was removed from dolphin / konqueror
remove Change Pointer + Automatically select icons settings, no longer in the 
code
change kde -> plasma


Diffs (updated)
-

  doc/kcontrol/mouse/index.docbook b09f8e7 

Diff: https://git.reviewboard.kde.org/r/128070/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128070: Update mouse kcm docbook to 5.6

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128070/#review96118
---




doc/kcontrol/mouse/index.docbook (lines 152 - 157)


Hmm I'm not overly happy with this documentation. It's actually not Plasma 
(neither was it KDE). It's a setting which gets passed to applications. The 
setting should work for all Qt applications and on X11 for all GTK applications 
and whatever else is there and listens to the signal.

So overall I think it would be better to say it's for applications. Plasma 
has nothing to do with it.



doc/kcontrol/mouse/index.docbook (line 176)


Similar concern to above point: it's not Plasma which has anything to do 
with it. It's a setting for applications.



doc/kcontrol/mouse/index.docbook (lines 263 - 270)


isn't the logitech stuff killed from the KCM?


- Martin Gräßlin


On June 1, 2016, 6:35 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128070/
> ---
> 
> (Updated June 1, 2016, 6:35 a.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> bump date + releaseinfo
> single / double click setting was removed from dolphin / konqueror
> remove Change Pointer + Automatically select icons settings, no longer in the 
> code
> change kde -> plasma
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/mouse/index.docbook b09f8e7 
> 
> Diff: https://git.reviewboard.kde.org/r/128070/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 128070: Update mouse kcm docbook to 5.6

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128070/
---

Review request for Documentation and Plasma.


Repository: plasma-desktop


Description
---

bump date + releaseinfo
single / double click setting was removed from dolphin / konqueror
remove Change Pointer + Automatically select icons settings, no longer in the 
code
change kde -> plasma


Diffs
-

  doc/kcontrol/mouse/index.docbook b09f8e7 

Diff: https://git.reviewboard.kde.org/r/128070/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel