Re: Review Request 128148: Fix check to keep QMenu on screen for multiscreen layouts
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128148/ --- (Updated June 10, 2016, 1:57 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit f5ad210742c9fe27e7dd7988221777a1346976d0 by David Edmundson to branch master. Repository: plasma-framework Description --- If x > screenWidth should be if x > screenLeft + screenWidth otherwise all right hand screens get offset Diffs - src/declarativeimports/plasmacomponents/qmenu.cpp 926df31c0c6db48549d340207d11fd298b52b629 Diff: https://git.reviewboard.kde.org/r/128148/diff/ Testing --- TaskManager context menus open in the right place. (alternately qmenu seems to do this anyway, so I think we can just delete this entire section) Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 128148: Fix check to keep QMenu on screen for multiscreen layouts
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128148/#review96343 --- Ship it! Ship It! - Eike Hein On June 10, 2016, 9:56 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128148/ > --- > > (Updated June 10, 2016, 9:56 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > If x > screenWidth should be if x > screenLeft + screenWidth > > otherwise all right hand screens get offset > > > Diffs > - > > src/declarativeimports/plasmacomponents/qmenu.cpp > 926df31c0c6db48549d340207d11fd298b52b629 > > Diff: https://git.reviewboard.kde.org/r/128148/diff/ > > > Testing > --- > > TaskManager context menus open in the right place. > > (alternately qmenu seems to do this anyway, so I think we can just delete > this entire section) > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 128148: Fix check to keep QMenu on screen for multiscreen layouts
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128148/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- If x > screenWidth should be if x > screenLeft + screenWidth otherwise all right hand screens get offset Diffs - src/declarativeimports/plasmacomponents/qmenu.cpp 926df31c0c6db48549d340207d11fd298b52b629 Diff: https://git.reviewboard.kde.org/r/128148/diff/ Testing --- TaskManager context menus open in the right place. (alternately qmenu seems to do this anyway, so I think we can just delete this entire section) Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
