Re: Review Request 128152: Remove apparently deprecated search for applet plugins using the old .desktop files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128152/ --- (Updated June 13, 2016, 10:02 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- As well as searching for applets using the embedded metadata we also searched for the older style of separate .desktop files for plugins. However this includes al the non applet subclassed based applets (most of them) which naturallly don't have a plugin which is why we get all the warnings about "unversioned plugin detected". There is a TODO to move the old version after Plasma 5.4. This does that. Diffs - src/plasma/pluginloader.cpp 62dffaccb014828645674a4989be6c92a0726cae Diff: https://git.reviewboard.kde.org/r/128152/diff/ Testing --- Desktop loads still Weather applet still loads No more spam in my debug output! Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 128152: Remove apparently deprecated search for applet plugins using the old .desktop files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128152/#review96410 --- Ship it! Ship It! - Eike Hein On June 11, 2016, 2:16 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128152/ > --- > > (Updated June 11, 2016, 2:16 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > As well as searching for applets using the embedded metadata we also > searched for the older style of separate .desktop files for plugins. > > However this includes al the non applet subclassed based applets (most of > them) which > naturallly don't have a plugin which is why we get all the warnings > about "unversioned plugin detected". > > There is a TODO to move the old version after Plasma 5.4. This does > that. > > > Diffs > - > > src/plasma/pluginloader.cpp 62dffaccb014828645674a4989be6c92a0726cae > > Diff: https://git.reviewboard.kde.org/r/128152/diff/ > > > Testing > --- > > Desktop loads still > Weather applet still loads > > No more spam in my debug output! > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 128152: Remove apparently deprecated search for applet plugins using the old .desktop files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128152/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- As well as searching for applets using the embedded metadata we also searched for the older style of separate .desktop files for plugins. However this includes al the non applet subclassed based applets (most of them) which naturallly don't have a plugin which is why we get all the warnings about "unversioned plugin detected". There is a TODO to move the old version after Plasma 5.4. This does that. Diffs - src/plasma/pluginloader.cpp 62dffaccb014828645674a4989be6c92a0726cae Diff: https://git.reviewboard.kde.org/r/128152/diff/ Testing --- Desktop loads still Weather applet still loads No more spam in my debug output! Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
