Re: Review Request 128445: add a subsection for removable devices
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128445/ --- (Updated July 16, 2016, 10:11 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Thomas Pfeiffer. Changes --- Submitted with commit 2f17be5f7fb618b97d811afd718708adc414728d by andreas kainz to branch master. Repository: systemsettings Description --- now we have some kcm modules which are not connected to an subgroup the following kcm modules will be added to the subgroup removable devices when the patch was submitted hardware - removable devices - removable devices - digital camera - device actions how it will look like when I add the patch for the different kcm's https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png this patch don't change anything it's only an preparation. Diffs - categories/CMakeLists.txt 9bc8307 categories/old/settings-removable-devices.desktop 00098ad Diff: https://git.reviewboard.kde.org/r/128445/diff/ Testing --- Thanks, Andreas Kainz ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 128445: add a subsection for removable devices
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128445/ --- (Updated July 14, 2016, 1:03 p.m.) Review request for Plasma and Thomas Pfeiffer. Changes --- now with automatic mounting the docbook I will update when everything is finished but there is some renaming still open. Repository: systemsettings Description --- now we have some kcm modules which are not connected to an subgroup the following kcm modules will be added to the subgroup removable devices when the patch was submitted hardware - removable devices - removable devices - digital camera - device actions how it will look like when I add the patch for the different kcm's https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png this patch don't change anything it's only an preparation. Diffs (updated) - categories/CMakeLists.txt 9bc8307 categories/old/settings-removable-devices.desktop 00098ad Diff: https://git.reviewboard.kde.org/r/128445/diff/ Testing --- Thanks, Andreas Kainz ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 128445: add a subsection for removable devices
> On July 14, 2016, 12:33 p.m., Thomas Pfeiffer wrote: > > I just realized that we should rename the sub-group to "Removable Storage" > > (or "Removable Storage Media" if that isn't too long) and just treat > > cameras as storage media (because that's basically what they act like when > > connected to a PC). > > I'll add that to the other review request. > > With that name, this change is fine. And please rename the "Removable Devices" KCM to "Automatic Mounting", because that's all it does configure. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128445/#review97396 --- On July 14, 2016, 10:39 a.m., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128445/ > --- > > (Updated July 14, 2016, 10:39 a.m.) > > > Review request for Plasma and Thomas Pfeiffer. > > > Repository: systemsettings > > > Description > --- > > now we have some kcm modules which are not connected to an subgroup the > following kcm modules will be added to the subgroup removable devices when > the patch was submitted > > hardware > - removable devices > - removable devices > - digital camera > - device actions > > how it will look like when I add the patch for the different kcm's > https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png > > this patch don't change anything it's only an preparation. > > > Diffs > - > > categories/CMakeLists.txt 9bc8307 > categories/old/settings-removable-devices.desktop 00098ad > > Diff: https://git.reviewboard.kde.org/r/128445/diff/ > > > Testing > --- > > > Thanks, > > Andreas Kainz > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 128445: add a subsection for removable devices
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128445/#review97396 --- I just realized that we should rename the sub-group to "Removable Storage" (or "Removable Storage Media" if that isn't too long) and just treat cameras as storage media (because that's basically what they act like when connected to a PC). I'll add that to the other review request. With that name, this change is fine. - Thomas Pfeiffer On July 14, 2016, 10:39 a.m., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128445/ > --- > > (Updated July 14, 2016, 10:39 a.m.) > > > Review request for Plasma and Thomas Pfeiffer. > > > Repository: systemsettings > > > Description > --- > > now we have some kcm modules which are not connected to an subgroup the > following kcm modules will be added to the subgroup removable devices when > the patch was submitted > > hardware > - removable devices > - removable devices > - digital camera > - device actions > > how it will look like when I add the patch for the different kcm's > https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png > > this patch don't change anything it's only an preparation. > > > Diffs > - > > categories/CMakeLists.txt 9bc8307 > categories/old/settings-removable-devices.desktop 00098ad > > Diff: https://git.reviewboard.kde.org/r/128445/diff/ > > > Testing > --- > > > Thanks, > > Andreas Kainz > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 128445: add a subsection for removable devices
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128445/ --- Review request for Plasma. Repository: systemsettings Description --- now we have some kcm modules which are not connected to an subgroup the following kcm modules will be added to the subgroup removable devices when the patch was submitted hardware - removable devices - removable devices - digital camera - device actions how it will look like when I add the patch for the different kcm's https://git.reviewboard.kde.org/media/uploaded/files/2016/07/13/ac3e5c78-9bb4-4e80-a5ce-0e4dfb38ae22__SystemSettings.png this patch don't change anything it's only an preparation. Diffs - categories/CMakeLists.txt 9bc8307 categories/old/settings-removable-devices.desktop 00098ad Diff: https://git.reviewboard.kde.org/r/128445/diff/ Testing --- Thanks, Andreas Kainz ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
