Re: Review Request 129308: Calendar: clear selection on opening

2016-12-14 Thread David Edmundson 


> On Nov. 2, 2016, 2:49 p.m., David Edmundson wrote:
> > do you have commit access?
> 
> Miklós Máté wrote:
> I don't have commit access.
> 
> Miklós Máté wrote:
> I noticed that this hasn't been committed yet. Is there something wrong 
> with the patch?

Done, sorry about that. Thanks for the patch.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129308/#review100506
---


On Dec. 14, 2016, 11:15 p.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129308/
> ---
> 
> (Updated Dec. 14, 2016, 11:15 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> When opening the calendar popup of the digital clock plasmoid, the selection 
> is on the day the popup was last opened -- possibly days or weeks ago. This 
> patch fixes that.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml 87c77da 
> 
> Diff: https://git.reviewboard.kde.org/r/129308/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

Re: Review Request 129308: Calendar: clear selection on opening

2016-12-14 Thread Miklós Máté 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129308/
---

(Updated Dec. 14, 2016, 11:15 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit c30edd9bedfd13459eecdf110fcb61d8f465523a by David 
Edmundson on behalf of Miklós Máté to branch Plasma/5.8.


Repository: plasma-workspace


Description
---

When opening the calendar popup of the digital clock plasmoid, the selection is 
on the day the popup was last opened -- possibly days or weeks ago. This patch 
fixes that.


Diffs
-

  applets/digital-clock/package/contents/ui/CalendarView.qml 87c77da 

Diff: https://git.reviewboard.kde.org/r/129308/diff/


Testing
---


Thanks,

Miklós Máté

Re: Review Request 129308: Calendar: clear selection on opening

2016-12-14 Thread Miklós Máté 


> On Nov. 2, 2016, 3:49 p.m., David Edmundson wrote:
> > do you have commit access?
> 
> Miklós Máté wrote:
> I don't have commit access.

I noticed that this hasn't been committed yet. Is there something wrong with 
the patch?


- Miklós


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129308/#review100506
---


On Nov. 2, 2016, 1:30 a.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129308/
> ---
> 
> (Updated Nov. 2, 2016, 1:30 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> When opening the calendar popup of the digital clock plasmoid, the selection 
> is on the day the popup was last opened -- possibly days or weeks ago. This 
> patch fixes that.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml 87c77da 
> 
> Diff: https://git.reviewboard.kde.org/r/129308/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

Re: Review Request 129308: Calendar: clear selection on opening

2016-11-02 Thread Miklós Máté 


> On Nov. 2, 2016, 2:49 p.m., David Edmundson wrote:
> > do you have commit access?

I don't have commit access.


- Miklós


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129308/#review100506
---


On Nov. 2, 2016, 12:30 a.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129308/
> ---
> 
> (Updated Nov. 2, 2016, 12:30 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> When opening the calendar popup of the digital clock plasmoid, the selection 
> is on the day the popup was last opened -- possibly days or weeks ago. This 
> patch fixes that.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml 87c77da 
> 
> Diff: https://git.reviewboard.kde.org/r/129308/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

Re: Review Request 129308: Calendar: clear selection on opening

2016-11-02 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129308/#review100506
---


Ship it!




do you have commit access?

- David Edmundson


On Nov. 2, 2016, 12:30 a.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129308/
> ---
> 
> (Updated Nov. 2, 2016, 12:30 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> When opening the calendar popup of the digital clock plasmoid, the selection 
> is on the day the popup was last opened -- possibly days or weeks ago. This 
> patch fixes that.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml 87c77da 
> 
> Diff: https://git.reviewboard.kde.org/r/129308/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

Re: Review Request 129308: Calendar: clear selection on opening

2016-11-02 Thread David Edmundson 


> On Nov. 2, 2016, 1:53 p.m., David Edmundson wrote:
> > applets/digital-clock/package/contents/ui/CalendarView.qml, line 53
> > 
> >
> > This original code is trying to make sure we only reset once instead of 
> > twice as one will be wasteful.
> > 
> > Wouldn't changing it to if (isExpanded) work correctly too?
> 
> Miklós Máté wrote:
> I don't know how expensive it is to reset the selection, but sure, using 
> "if (isExpanded)" works too.

not very expensive. Lets ship this.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129308/#review100502
---


On Nov. 2, 2016, 12:30 a.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129308/
> ---
> 
> (Updated Nov. 2, 2016, 12:30 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> When opening the calendar popup of the digital clock plasmoid, the selection 
> is on the day the popup was last opened -- possibly days or weeks ago. This 
> patch fixes that.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml 87c77da 
> 
> Diff: https://git.reviewboard.kde.org/r/129308/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

Re: Review Request 129308: Calendar: clear selection on opening

2016-11-02 Thread Miklós Máté 


> On Nov. 2, 2016, 1:53 p.m., David Edmundson wrote:
> > applets/digital-clock/package/contents/ui/CalendarView.qml, line 53
> > 
> >
> > This original code is trying to make sure we only reset once instead of 
> > twice as one will be wasteful.
> > 
> > Wouldn't changing it to if (isExpanded) work correctly too?

I don't know how expensive it is to reset the selection, but sure, using "if 
(isExpanded)" works too.


- Miklós


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129308/#review100502
---


On Nov. 2, 2016, 12:30 a.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129308/
> ---
> 
> (Updated Nov. 2, 2016, 12:30 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> When opening the calendar popup of the digital clock plasmoid, the selection 
> is on the day the popup was last opened -- possibly days or weeks ago. This 
> patch fixes that.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml 87c77da 
> 
> Diff: https://git.reviewboard.kde.org/r/129308/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

Re: Review Request 129308: Calendar: clear selection on opening

2016-11-02 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129308/#review100502
---




applets/digital-clock/package/contents/ui/CalendarView.qml (line 53)


This original code is trying to make sure we only reset once instead of 
twice as one will be wasteful.

Wouldn't changing it to if (isExpanded) work correctly too?


- David Edmundson


On Nov. 2, 2016, 12:30 a.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129308/
> ---
> 
> (Updated Nov. 2, 2016, 12:30 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> When opening the calendar popup of the digital clock plasmoid, the selection 
> is on the day the popup was last opened -- possibly days or weeks ago. This 
> patch fixes that.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml 87c77da 
> 
> Diff: https://git.reviewboard.kde.org/r/129308/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>