Re: Scrollbars in add widget ui
On Monday 12 July 2010, Aurélien Gâteau wrote: > Hi, > > I have been playing a bit with the Add Widget UI on the plane back from > Akademy and replaced the scroll buttons with a scrollbar. Attached patch > is a first step at it, largely unfinished as I would like to know if you > are interested in getting this integrated before I finish it. > > Screenshots: > - Horizontal: http://imagebin.ca/view/NkxkAG.html > - Vertical: http://imagebin.ca/view/XnBxX8vt.html > > What do you think? > > Aurélien by the way, what did end up with this patch? Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On July 14, 2010, Markus Slopianka wrote: > On Tuesday 13 July 2010 22:35:50 Aaron J. Seigo wrote: > > sorry, but it's not coming back. > > Oh, then offloading all useful info into tooltips is good? > Is this how you definition of elegance? Markus, it sounds like you are frustrated or perhaps using agressive conversation techniques to get your point across is just a habit of yours. Unfortunately, that is not how we do things in Plasma. Productive and useful input is how we work, _especially_ when we have different preferred answers or don't agree on the current implementation. This keeps things moving productively along, allowing all of us to create and explore solutions without getting frustrated and angry with each other. It's why we've remained an active and productive project. I will not allow people to jeopardize that. This is why non-constructive rhetorical techniques are not only discouraged here but quite simply are not accepted. I'm going to request that you alter your approach or please stop participating in Plasma. If the latter is your choice, we'll understand and there are many other places in KDE that can benefit from participation. Thanks for your understanding. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On Thursday 15 July 2010, Aurélien Gâteau wrote: > On 13/07/2010 22:33, Aaron J. Seigo wrote: > > On July 11, 2010, Aurélien Gâteau wrote: > >> What do you think? > > > > clean up the patch and get it in... huzzah for copromise! we'll get this > > rocking yet ;) thanks for your dogged attention on this. > > My current patch adds the scrollbar by hand, but I just noticed there is > a Plasma::ScrollWidget. Would it be better to use it instead of > implementing a scroll view by hand? they do almost the same thing (the scrollwidget was imlpemented after this) and yes i think it would make sense to use the same thing the scrollwidget has flicking too, that here could be problematic for drag and drop, it is easy to disable (setfilterschildevents(false)) but i would like to try some solution to have both -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On 13/07/2010 22:33, Aaron J. Seigo wrote: > On July 11, 2010, Aurélien Gâteau wrote: >> What do you think? > > clean up the patch and get it in... huzzah for copromise! we'll get this > rocking yet ;) thanks for your dogged attention on this. My current patch adds the scrollbar by hand, but I just noticed there is a Plasma::ScrollWidget. Would it be better to use it instead of implementing a scroll view by hand? Aurélien ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On Wed 14 July 2010 4:09:08 pm Thomas Fjellstrom wrote: > On July 14, 2010, Markus Slopianka wrote: > > Oh, and btw: It's impossible to click on URLs in those Plasma tooltips, > > while it's perfectly possible in all other "About" windows. > > Hmm, maybe a regression? It works here on 4.4.4. > As well as in a trunk build from somewhere between RC1 and today. Ryan -- Ryan Rix == http://hackersramblings.wordpress.com | http://rix.si/ == == http://rix.si/page/contact/ if you need a word == signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
- Original message - > I take this as a proposal to remove the "i" from the systray. Yes, thats exactly what I want: to prpose that. *Sigh*. And the problem with the mockup isnt that it doesnt solve the issue of showing the information but that it brings back all the problems we had with the old widgets explorer. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On July 14, 2010, Markus Slopianka wrote: > Oh, and btw: It's impossible to click on URLs in those Plasma tooltips, > while it's perfectly possible in all other "About" windows. Hmm, maybe a regression? It works here on 4.4.4. > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel -- Thomas Fjellstrom tfjellst...@shaw.ca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
Oh, and btw: It's impossible to click on URLs in those Plasma tooltips, while it's perfectly possible in all other "About" windows. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On Thursday 15 July 2010 00:04:45 Artur Souza (MoRpHeUz) wrote: > Yep, it's way more elegant than having an icon with an "i" that when > clicked shows all the "useful" information. In the old window as well as Aurelien's mockup the applet description is visible right away, without the need to click "i", so your argument simply isn't valid. > Specially that my mother > doesn't need to figure out what the hell the "i" icon means (it could > be something related to uninstall on my native language) I take this as a proposal to remove the "i" from the systray. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On Wed, Jul 14, 2010 at 6:51 PM, Markus Slopianka wrote: > Oh, then offloading all useful info into tooltips is good? > Is this how you definition of elegance? Constructive feedback is great, isn't it? It's awesome when every developer out there has the right(tm) solution in mind but are never here when things needs to get done. I would love to change positions and be the one to ignore all the work and research that was done before some work and just complain about it and say why I have the best idea ever. *sigh*. Back to technical: Yep, it's way more elegant than having an icon with an "i" that when clicked shows all the "useful" information. Specially that my mother doesn't need to figure out what the hell the "i" icon means (it could be something related to uninstall on my native language) and just hovers the mouse over what she wants to figure out what that plasmoid is without yet another mouse interaction. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On Tuesday 13 July 2010 22:35:50 Aaron J. Seigo wrote: > sorry, but it's not coming back. Oh, then offloading all useful info into tooltips is good? Is this how you definition of elegance? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On July 14, 2010, Aaron J. Seigo wrote: > On July 14, 2010, Thomas Fjellstrom wrote: > > On July 14, 2010, Aaron J. Seigo wrote: > > > On July 14, 2010, Thomas Fjellstrom wrote: > > > > Normally I would agree. Do you volunteer to make sure the bug never > > > > appears again? > > > > > > yes, we do. now that we're at the point of such questions, though, > > > it's safe to say that this thread has reached the end of its ability > > > to produce useful input. let's stop here. > > > > I happen to think its a perfectly valid point. If you can't guarantee > > the bug won't reappear, an easily discoverable work around is going to > > have to be made for it. > > if the bug has a very low possibility of reappearing and if it does the > consequences are nominal, then hobbling the default interface for > everyone all the time is a really bad idea. so no, it isn't a valid > point at all. I sure wouldn't call it hobbling the interface. > > Just a little bit of brain storming, but some place, an interface > > showing a list of the current running plasmoids (one item per plasmoid > > instance), which when hovered over with the mouse cause them to be > > highlighted by plasma itself. It would make the most sense if it were > > to hide all normal windows, or bring plasma forward. > > last time we discussed this (on this list even, iirc), the possibility of > having a listing of running plasmoids in the tasks (ctrl+escape) window > from krunner sounded pretty nice. and it could be without all the other > problems of adding removal to the "add widgets" interface. That might indeed be nice. > > Possibly tie it into the ZUI to show all > > current containments. > > there is no ZUI anymore. As of 4.4.4 it still zooms. > > That said, a much simpler and easier to implement idea would be to add > > back that minus button and just force people to add back instances > > they wanted (if theres more than one running). > > which was exactly the problem: it doesn't say what is being removed, > leading to loss of desired items. this made the minus sign less than > useful. adding finer granularity to it just makes it harder to use. > simpler does not always mean better. I fully understand the reasoning. But now I have no way to remove lost widgets. I'd call that a hobbled interface. > so, no, this feature will not be re-appearing. that is final. > > > Maybe as an option. > > that isn't how we work here. if there is a solution to a problem that > isn't workable, we don't simply say "well, just throw it in there and > make it an option, even if it does suck." that's just a way to make the > software suck twice as hard: now it has a poor solution -and- a > configuration option for people to deal with. lose. It sucks more now than it did before. > > > p.s. the javascript console lets you get to any plasmoid using > > > scripting. > > > > And I'm sure its fully documented, > > it is. > > > easily discoverable, and understandable by mere users. > > it isn't. and i don't think it's a solution for "mere users" (a phrase > that's a bit ... un-nice to the people who use kde software, imho). it's > an option for those of us who run into such situations during > development. Most of the time I'm a /mere/ user. I don't think its un-nice. Most people doing day to day regular tasks really don't want nor need to worry about some script console. Heck, most of the time I can't remember the various key shortcuts to various things. Took me an age to fully memorize ALT+F2, and just recently I may have fully memorized the "Disable compositing" short cut, but I tend to forget it over and over, so I have to go at it the long way. -- Thomas Fjellstrom tfjellst...@shaw.ca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On July 14, 2010, Thomas Fjellstrom wrote: > On July 14, 2010, Aaron J. Seigo wrote: > > On July 14, 2010, Thomas Fjellstrom wrote: > > > Normally I would agree. Do you volunteer to make sure the bug never > > > appears again? > > > > yes, we do. now that we're at the point of such questions, though, it's > > safe to say that this thread has reached the end of its ability to > > produce useful input. let's stop here. > > I happen to think its a perfectly valid point. If you can't guarantee the > bug won't reappear, an easily discoverable work around is going to have to > be made for it. if the bug has a very low possibility of reappearing and if it does the consequences are nominal, then hobbling the default interface for everyone all the time is a really bad idea. so no, it isn't a valid point at all. > Just a little bit of brain storming, but some place, an interface showing a > list of the current running plasmoids (one item per plasmoid instance), > which when hovered over with the mouse cause them to be highlighted by > plasma itself. It would make the most sense if it were to hide all normal > windows, or bring plasma forward. last time we discussed this (on this list even, iirc), the possibility of having a listing of running plasmoids in the tasks (ctrl+escape) window from krunner sounded pretty nice. and it could be without all the other problems of adding removal to the "add widgets" interface. > Possibly tie it into the ZUI to show all > current containments. there is no ZUI anymore. > That said, a much simpler and easier to implement idea would be to add back > that minus button and just force people to add back instances they wanted > (if theres more than one running). which was exactly the problem: it doesn't say what is being removed, leading to loss of desired items. this made the minus sign less than useful. adding finer granularity to it just makes it harder to use. simpler does not always mean better. so, no, this feature will not be re-appearing. that is final. > Maybe as an option. that isn't how we work here. if there is a solution to a problem that isn't workable, we don't simply say "well, just throw it in there and make it an option, even if it does suck." that's just a way to make the software suck twice as hard: now it has a poor solution -and- a configuration option for people to deal with. lose. > > p.s. the javascript console lets you get to any plasmoid using scripting. > > And I'm sure its fully documented, it is. > easily discoverable, and understandable by mere users. it isn't. and i don't think it's a solution for "mere users" (a phrase that's a bit ... un-nice to the people who use kde software, imho). it's an option for those of us who run into such situations during development. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On July 14, 2010, Aaron J. Seigo wrote: > On July 14, 2010, Thomas Fjellstrom wrote: > > Normally I would agree. Do you volunteer to make sure the bug never > > appears again? > > yes, we do. now that we're at the point of such questions, though, it's > safe to say that this thread has reached the end of its ability to > produce useful input. let's stop here. I happen to think its a perfectly valid point. If you can't guarantee the bug won't reappear, an easily discoverable work around is going to have to be made for it. Just a little bit of brain storming, but some place, an interface showing a list of the current running plasmoids (one item per plasmoid instance), which when hovered over with the mouse cause them to be highlighted by plasma itself. It would make the most sense if it were to hide all normal windows, or bring plasma forward. Possibly tie it into the ZUI to show all current containments. That said, a much simpler and easier to implement idea would be to add back that minus button and just force people to add back instances they wanted (if theres more than one running). Maybe as an option. > p.s. the javascript console lets you get to any plasmoid using scripting. And I'm sure its fully documented, easily discoverable, and understandable by mere users. -- Thomas Fjellstrom tfjellst...@shaw.ca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On July 13, 2010, Thomas Fjellstrom wrote: > You have to agree that a "one size fit all" solution /never/ fits all > scenarios. we're not trying to. we're trying to fit the use cases that should be able to be consolidated. notably, mobile and app dashboard use are not included. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On July 14, 2010, Thomas Fjellstrom wrote: > Normally I would agree. Do you volunteer to make sure the bug never appears > again? yes, we do. now that we're at the point of such questions, though, it's safe to say that this thread has reached the end of its ability to produce useful input. let's stop here. p.s. the javascript console lets you get to any plasmoid using scripting. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On July 14, 2010, Artur Souza (MoRpHeUz) wrote: > On Wed, Jul 14, 2010 at 3:34 AM, Thomas Fjellstrom wrote: > > I see your point. But it seems like a bug that will pop up now and > > again, and it would be nice to have a list of all the > > plasmoids/widgets that are currently created so they can be removed, > > or re positioned if they ever get lost. > > If the bug pops up "now and again", then there is something really > wrong that should get fixed and not "work arounded". I understand the > "I don't like it" argument (besides not agreeing), but a bug that > should never happen is not a pro argument for changing the add widgets > dialog. Normally I would agree. Do you volunteer to make sure the bug never appears again? > Cheers, > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel -- Thomas Fjellstrom tfjellst...@shaw.ca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On Wed, Jul 14, 2010 at 3:34 AM, Thomas Fjellstrom wrote: > I see your point. But it seems like a bug that will pop up now and again, > and it would be nice to have a list of all the plasmoids/widgets that are > currently created so they can be removed, or re positioned if they ever get > lost. If the bug pops up "now and again", then there is something really wrong that should get fixed and not "work arounded". I understand the "I don't like it" argument (besides not agreeing), but a bug that should never happen is not a pro argument for changing the add widgets dialog. Cheers, ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On July 13, 2010, Aaron J. Seigo wrote: > On July 12, 2010, Markus Slopianka wrote: > > I had absolutely no problems with the 4.3 one. > > i'm glad. but we had problems with it elsewhere. we need a consistent UI > that works everywhere: > > * with panels (with a high degree of visual affinity) > > * with the desktop > > * with the screen saver > > * with the dashboard > > * with netbook / tablet > > etc ... > > sorry, but it's not coming back. You have to agree that a "one size fit all" solution /never/ fits all scenarios. -- Thomas Fjellstrom tfjellst...@shaw.ca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On July 13, 2010, Aaron J. Seigo wrote: > On July 11, 2010, Thomas Fjellstrom wrote: > > I kind-of agree, I still can't figure out how to remove widgets once > > they've been "lost". There's no remove button in the new selector like > > there used to be. > > not relevant. widgets shouldn't get lost in the first place (that would > be a bug), and "remove" is pretty ambiguous in a world where we can > pause activities. it was a stop gap feature, not a clear one to > everyone, didn't have enough fine grained control. it was time to move > on. I see your point. But it seems like a bug that will pop up now and again, and it would be nice to have a list of all the plasmoids/widgets that are currently created so they can be removed, or re positioned if they ever get lost. -- Thomas Fjellstrom tfjellst...@shaw.ca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On July 12, 2010, Markus Slopianka wrote: > I had absolutely no problems with the 4.3 one. i'm glad. but we had problems with it elsewhere. we need a consistent UI that works everywhere: * with panels (with a high degree of visual affinity) * with the desktop * with the screen saver * with the dashboard * with netbook / tablet etc ... sorry, but it's not coming back. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On July 11, 2010, Thomas Fjellstrom wrote: > I kind-of agree, I still can't figure out how to remove widgets once > they've been "lost". There's no remove button in the new selector like > there used to be. not relevant. widgets shouldn't get lost in the first place (that would be a bug), and "remove" is pretty ambiguous in a world where we can pause activities. it was a stop gap feature, not a clear one to everyone, didn't have enough fine grained control. it was time to move on. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On July 11, 2010, Aurélien Gâteau wrote: > What do you think? clean up the patch and get it in... huzzah for copromise! we'll get this rocking yet ;) thanks for your dogged attention on this. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
> I have been playing a bit with the Add Widget UI on the plane back from > Akademy and replaced the scroll buttons with a scrollbar. Attached patch > is a first step at it, largely unfinished as I would like to know if you > are interested in getting this integrated before I finish it. > > [...] > > What do you think? I don't know if this has been discussed already, but how about making the list scroll vertically regardless of its orientation (that is, make the horizontal UI scroll vertically as well)? I think that most users are more used to / comfortable with scrolling vertically than horizontally and it also maps better to the mouse wheel (which currently is the fastest way of scrolling through the widget list IMHO). Additionally it wouldn't take away vertical space which so many people seem to value these days. Making the UI go away on drag leave would also be a great idea (as long as it returns after the widget has been dropped). Best regards, Ingo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On 12/07/2010 16:34, Artur Souza (MoRpHeUz) wrote: > Hi Aurélien! > > 2010/7/11 Aurélien Gâteau : >> I have been playing a bit with the Add Widget UI on the plane back from >> Akademy and replaced the scroll buttons with a scrollbar. Attached patch is >> a first step at it, largely unfinished as I would like to know if you are >> interested in getting this integrated before I finish it. > > Scrollbars are good improvements. I'm just a little bit unsure that it > may not work well with touch oriented interfaces (like the ones we > tested plasma during Tokamak4). While scrollbars are great to give you > an idea of "position" in the list, it doesn't work very well to > actually scroll with the fingers. That's a problem indeed. Are Plasma widgets affected by the application global strut? I used to work for a company where we implemented a touch-screen application back in the days, and increasing the global strut made quite a few widgets bigger, thus easier to use. This might cause some space issues if it gets too big though. Aurélien ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On 12/07/2010 16:42, Marco Martin wrote:
> On Monday 12 July 2010, Markus Slopianka wrote:
>> On Monday 12 July 2010 15:33:24 Aurélien Gâteau wrote:
>>> It looked like this:
>>>
>>> http://agateau.files.wordpress.com/2010/07/add-widget-e1278885892283.png
>>>
>>> It was rejected because it had the same problems as the KDE 4.3 dialog:
>>> taking too much screen space.
>>
>> The people who rejected it obviously never saw KRunner, because your
>> proposal looks exactly the same.
>
> with the slight difference that when you are using krunner you don't need to
> access the desktop space
>
Well, the {fade/slide}-out on drag would have avoided that problem, but
let's not rehash that discussion, as I don't think this is going to
change the decision anyway.
Aurélien
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On Monday 12 July 2010, Artur Souza (MoRpHeUz) wrote: > Hi Aurélien! > > 2010/7/11 Aurélien Gâteau : > > I have been playing a bit with the Add Widget UI on the plane back from > > Akademy and replaced the scroll buttons with a scrollbar. Attached patch > > is a first step at it, largely unfinished as I would like to know if you > > are interested in getting this integrated before I finish it. > > Scrollbars are good improvements. I'm just a little bit unsure that it > may not work well with touch oriented interfaces (like the ones we > tested plasma during Tokamak4). While scrollbars are great to give you > an idea of "position" in the list, it doesn't work very well to > actually scroll with the fingers. > i would like to try the following thing (that i'm already doing in the netbook sal favourites): scroll with an horizontal drag, start a drag event with a vertical drag. the tradeoff would be that the drag event would need to begin after a way bigger dragged distance than now. -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On Monday 12 July 2010, Markus Slopianka wrote: > On Monday 12 July 2010 15:33:24 Aurélien Gâteau wrote: > > It looked like this: > > > > http://agateau.files.wordpress.com/2010/07/add-widget-e1278885892283.png > > > > It was rejected because it had the same problems as the KDE 4.3 dialog: > > taking too much screen space. > > The people who rejected it obviously never saw KRunner, because your > proposal looks exactly the same. with the slight difference that when you are using krunner you don't need to access the desktop space -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
Hi Aurélien! 2010/7/11 Aurélien Gâteau : > I have been playing a bit with the Add Widget UI on the plane back from > Akademy and replaced the scroll buttons with a scrollbar. Attached patch is > a first step at it, largely unfinished as I would like to know if you are > interested in getting this integrated before I finish it. Scrollbars are good improvements. I'm just a little bit unsure that it may not work well with touch oriented interfaces (like the ones we tested plasma during Tokamak4). While scrollbars are great to give you an idea of "position" in the list, it doesn't work very well to actually scroll with the fingers. Cheers! ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On Monday 12 July 2010 15:33:24 Aurélien Gâteau wrote: > It looked like this: > > http://agateau.files.wordpress.com/2010/07/add-widget-e1278885892283.png > > It was rejected because it had the same problems as the KDE 4.3 dialog: > taking too much screen space. The people who rejected it obviously never saw KRunner, because your proposal looks exactly the same. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On 12/07/2010 15:07, Markus Slopianka wrote: > On Monday 12 July 2010 13:53:10 Aurélien Gâteau wrote: > >> I agree. I made a proposal for an alternative version which would >> requires no hovering to get the widget descriptions but it was rejected. > > Huh? Why? > Was it like the one in 4.3? I had absolutely no problems with the 4.3 one. It looked like this: http://agateau.files.wordpress.com/2010/07/add-widget-e1278885892283.png It was rejected because it had the same problems as the KDE 4.3 dialog: taking too much screen space. Aurélien ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On Monday 12 July 2010 13:53:10 Aurélien Gâteau wrote: > I agree. I made a proposal for an alternative version which would > requires no hovering to get the widget descriptions but it was rejected. Huh? Why? Was it like the one in 4.3? I had absolutely no problems with the 4.3 one. > Therefore I am trying to get some less drastic changes in. Thanks. Better than nothing. While you're at it, fix the text input field, please. It does not have focus by default. :-) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On 12/07/2010 01:00, Markus Slopianka wrote: > On Monday 12 July 2010 00:18:03 Aurélien Gâteau wrote: >> What do you think? > > I think that the scrollbars are an improvement, but I like the window from > 4.3 > better: The current one requires to hover over an icon to see the description. > I have yet to see any improvement of the "Add widget" bar over the window, > but > I also didn't participate in the discussion before SC 4.4 over which one is > better. So I'm not aware of the exchanged arguments. (I hope there was a > discussion.) I agree. I made a proposal for an alternative version which would requires no hovering to get the widget descriptions but it was rejected. Therefore I am trying to get some less drastic changes in. Aurélien ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On 12/07/2010 02:47, Chani wrote: > +1 from me :) just being able to see where in the list I am makes me happier. > how does it look if there aren't enough to scroll? For now it's not very nice because the scrollbar does not hide itself. I'll look into it. > P.S. Reviewboard Is Your Friend ;) Don't worry, I will use reviewboard when it's done. I didn't feel it would be appropriate right now because I would not want the patch to go in in its current state. I just attached it in case someone wanted to give it a try. Aurélien ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On Monday 12 July 2010, Aurélien Gâteau wrote: > Hi, > > I have been playing a bit with the Add Widget UI on the plane back from > Akademy and replaced the scroll buttons with a scrollbar. Attached patch > is a first step at it, largely unfinished as I would like to know if you > are interested in getting this integrated before I finish it. > > Screenshots: > - Horizontal: http://imagebin.ca/view/NkxkAG.html > - Vertical: http://imagebin.ca/view/XnBxX8vt.html > > What do you think? > > Aurélien i was yhinking about t just yesterday while a scrollbar takes a bit of vertical space, it improves things a bit. i was tinking about just showing 2 3-4 pixels high hint, that on mouse over becomes a full sized scrollbar, a bit like the new flash player of youtube... on the other hand, if we do as discussed at akademy, partially sliding away the window when a drag is done, having a full sized scrollbar will become not an issue anymore Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On July 11, 2010, Markus Slopianka wrote: > On Monday 12 July 2010 00:18:03 Aurélien Gâteau wrote: > > What do you think? > > I think that the scrollbars are an improvement, but I like the window > from 4.3 better: The current one requires to hover over an icon to see > the description. I have yet to see any improvement of the "Add widget" > bar over the window, but I also didn't participate in the discussion > before SC 4.4 over which one is better. So I'm not aware of the > exchanged arguments. (I hope there was a discussion.) I kind-of agree, I still can't figure out how to remove widgets once they've been "lost". There's no remove button in the new selector like there used to be. > > Markus > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel -- Thomas Fjellstrom tfjellst...@shaw.ca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On Sunday, July 11, 2010 03:18:03 pm Aurélien Gâteau wrote: > Hi, > > I have been playing a bit with the Add Widget UI on the plane back from > Akademy and replaced the scroll buttons with a scrollbar. Attached patch > is a first step at it, largely unfinished as I would like to know if you > are interested in getting this integrated before I finish it. > > Screenshots: > - Horizontal: http://imagebin.ca/view/NkxkAG.html > - Vertical: http://imagebin.ca/view/XnBxX8vt.html > > What do you think? > > Aurélien +1 from me :) just being able to see where in the list I am makes me happier. how does it look if there aren't enough to scroll? P.S. Reviewboard Is Your Friend ;) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On Monday 12 July 2010 00:18:03 Aurélien Gâteau wrote: > What do you think? I think that the scrollbars are an improvement, but I like the window from 4.3 better: The current one requires to hover over an icon to see the description. I have yet to see any improvement of the "Add widget" bar over the window, but I also didn't participate in the discussion before SC 4.4 over which one is better. So I'm not aware of the exchanged arguments. (I hope there was a discussion.) Markus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Scrollbars in add widget ui
Hi,
I have been playing a bit with the Add Widget UI on the plane back from
Akademy and replaced the scroll buttons with a scrollbar. Attached patch
is a first step at it, largely unfinished as I would like to know if you
are interested in getting this integrated before I finish it.
Screenshots:
- Horizontal: http://imagebin.ca/view/NkxkAG.html
- Vertical: http://imagebin.ca/view/XnBxX8vt.html
What do you think?
Aurélien
diff --git a/workspace/libs/plasmagenericshell/abstracticonlist.cpp b/workspace/libs/plasmagenericshell/abstracticonlist.cpp
index 78a1fd1..3141516 100644
--- a/workspace/libs/plasmagenericshell/abstracticonlist.cpp
+++ b/workspace/libs/plasmagenericshell/abstracticonlist.cpp
@@ -37,6 +37,7 @@
#include
#include
#include
+#include
#include
#include
@@ -102,6 +103,11 @@ void AbstractIconList::init()
m_downRightArrow->setPreferredSize(IconSize(KIconLoader::Panel), IconSize(KIconLoader::Panel));
m_downRightArrow->setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Expanding);
+m_scrollBar = new Plasma::ScrollBar(this);
+m_scrollBar->setOrientation(m_orientation);
+m_scrollBar->setSingleStep(128);
+connect(m_scrollBar, SIGNAL(valueChanged(int)), SLOT(scrollListWidget(int)));
+/*
if (m_orientation == Qt::Horizontal) {
m_upLeftArrow->setIcon(KIcon(m_arrowsSvg->pixmap("left-arrow")));
m_downRightArrow->setIcon(KIcon(m_arrowsSvg->pixmap("right-arrow")));
@@ -113,6 +119,7 @@ void AbstractIconList::init()
m_upLeftArrow->setMaximumSize(-1, IconSize(KIconLoader::Panel));
m_downRightArrow->setMaximumSize(-1, IconSize(KIconLoader::Panel));
}
+*/
connect(m_downRightArrow, SIGNAL(pressed()), this, SLOT(scrollDownRight()));
connect(m_upLeftArrow, SIGNAL(pressed()), this, SLOT(scrollUpLeft()));
@@ -136,6 +143,7 @@ void AbstractIconList::init()
m_appletListWindowWidget->installEventFilter(this);
//layouts
+/*
m_arrowsLayout = new QGraphicsLinearLayout(m_orientation);
m_arrowsLayout->addItem(m_appletListWindowWidget);
@@ -145,7 +153,14 @@ void AbstractIconList::init()
m_arrowsLayout->setAlignment(m_downRightArrow, Qt::AlignVCenter | Qt::AlignHCenter);
m_arrowsLayout->setAlignment(m_upLeftArrow, Qt::AlignVCenter | Qt::AlignHCenter);
m_arrowsLayout->setAlignment(m_appletListWindowWidget, Qt::AlignVCenter | Qt::AlignHCenter);
-
+*/
+if (m_orientation == Qt::Horizontal) {
+m_arrowsLayout = new QGraphicsLinearLayout(Qt::Vertical);
+} else {
+m_arrowsLayout = new QGraphicsLinearLayout(Qt::Horizontal);
+}
+m_arrowsLayout->addItem(m_appletListWindowWidget);
+m_arrowsLayout->addItem(m_scrollBar);
//m_hoverIndicator = new Plasma::ItemBackground(m_appletListWindowWidget);
m_hoverIndicator = new Plasma::ItemBackground(m_appletListWidget);
setLayout(m_arrowsLayout);
@@ -344,6 +359,7 @@ void AbstractIconList::updateList()
updateGeometry();
m_hoverIndicator->hide();
resetScroll();
+updateScrollBar();
}
void AbstractIconList::wheelEvent(QGraphicsSceneWheelEvent *event)
@@ -462,11 +478,30 @@ void AbstractIconList::resetScroll()
manageArrows();
}
+void AbstractIconList::scrollListWidget(int value)
+{
+qreal pos = -value;
+if (m_orientation == Qt::Horizontal) {
+m_appletListWidget->setPos(pos, 0);
+} else {
+m_appletListWidget->setPos(0, pos);
+}
+}
+
+void AbstractIconList::updateScrollBar()
+{
+int ws = windowSize();
+m_scrollBar->setPageStep(ws);
+m_scrollBar->setRange(0, listSize() - ws);
+}
+
void AbstractIconList::manageArrows()
{
qreal list_size = listSize();
qreal window_size = windowSize();
+updateScrollBar();
+
if (list_size <= window_size || m_currentAppearingAppletsOnList.isEmpty()) {
m_upLeftArrow->setEnabled(false);
m_downRightArrow->setEnabled(false);
diff --git a/workspace/libs/plasmagenericshell/abstracticonlist.h b/workspace/libs/plasmagenericshell/abstracticonlist.h
index cd14cd5..d7dbaf5 100644
--- a/workspace/libs/plasmagenericshell/abstracticonlist.h
+++ b/workspace/libs/plasmagenericshell/abstracticonlist.h
@@ -38,6 +38,7 @@ namespace Plasma
{
class Animation;
class ItemBackground;
+class ScrollBar;
class ToolButton;
class PLASMAGENERICSHELL_EXPORT AbstractIconList : public QGraphicsWidget
@@ -110,6 +111,8 @@ private:
void wheelEvent(QGraphicsSceneWheelEvent *event);
+void updateScrollBar();
+
public Q_SLOTS:
void searchTermChanged(const QString &text);
void updateList();
@@ -137,6 +140,7 @@ private Q_SLOTS:
void iconHoverEnter(Plasma::AbstractIcon *icon);
void setSearch();
+void scrollListWidget(int);
private:
//list containing the applet icons of the filter proxy model
@@ -147,6 +151,7 @@ private:
QGraphicsWidget *m_appletListWindowWidget;
QGraphicsLinearLayout *m_arrowsLayout;
+Plasma::ScrollBar
