Strange ampersand in Plasma tooltips

2010-03-01 Thread Mark Kretschmann
Heya,

I'm having a weird issue here, and I wonder if it's just me, or if
it's maybe a bug in Plasma:

Many of the tooltips of the Plasma::IconWidget buttons we use in
Amarok (like in the toolbar and in applets) contain weird ampersand
characters, that is "&". I assume they come from keyboard shortcuts,
but surely they shouldn't be shown in the tooltip, no?

I've asked about this in the #plasma IRC channel before, but noone had
an idea. Do you have any? :)


Attaching a screenshot of this issue.

-- 
Mark Kretschmann
Amarok Developer, Software Engineer at Collabora Ltd
Fellow of the Free Software Foundation Europe
http://amarok.kde.org - http://www.fsfe.org - http://collabora.co.uk
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Strange ampersand in Plasma tooltips

2010-03-01 Thread Mark Kretschmann
On Mon, Mar 1, 2010 at 8:32 AM, Mark Kretschmann  wrote:
> Attaching a screenshot of this issue.

Erm. Somehow the attachment didn't work, trying again, sorry :)


I've also made the file accessible here:

http://mark.kollide.net/ampersand_in_tooltips.png

-- 
Mark Kretschmann
Amarok Developer, Software Engineer at Collabora Ltd
Fellow of the Free Software Foundation Europe
http://amarok.kde.org - http://www.fsfe.org - http://collabora.co.uk
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Strange ampersand in Plasma tooltips

2010-03-02 Thread Myriam Schweingruber
Hi all,

On Mon, Mar 1, 2010 at 08:32, Mark Kretschmann  wrote:
> Heya,
>
> I'm having a weird issue here, and I wonder if it's just me, or if
> it's maybe a bug in Plasma:
>
> Many of the tooltips of the Plasma::IconWidget buttons we use in
> Amarok (like in the toolbar and in applets) contain weird ampersand
> characters, that is "&". I assume they come from keyboard shortcuts,
> but surely they shouldn't be shown in the tooltip, no?
>
> I've asked about this in the #plasma IRC channel before, but noone had
> an idea. Do you have any? :)

Strange, AFAIK I have exactly the same configuration as you have, but
don't see those ampersands here. I also can't remember ever having
seen those before.


Regards, Myriam.

-- 
Protect your freedom and join the Fellowship of FSFE:
http://www.fsfe.org
Please don't send me proprietary file formats,
use ISO standard ODF instead (ISO/IEC 26300)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Strange ampersand in Plasma tooltips

2010-03-02 Thread Artur Souza (MoRpHeUz)
On Tuesday 02 March 2010, 08:10 Myriam Schweingruber wrote:
> Strange, AFAIK I have exactly the same configuration as you have, but
> don't see those ampersands here. I also can't remember ever having
> seen those before.

To add more funny to the equation, I had an open bug for the pastebin applet 
where the user is complaining about almost the same issue but for the context 
menu (right click) on pastebin applet and plasma is restarted. I couldn't 
reproduce it here too...

Cheers,

--
Artur Duque de Souza
openBossa
INdT - Instituto Nokia de Tecnologia
--
Blog: http://blog.morpheuz.cc
PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net
--


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Strange ampersand in Plasma tooltips

2010-03-02 Thread Marco Martin
On Monday 01 March 2010, Mark Kretschmann wrote:
> On Mon, Mar 1, 2010 at 8:32 AM, Mark Kretschmann  
wrote:
> > Attaching a screenshot of this issue.
> 
> Erm. Somehow the attachment didn't work, trying again, sorry :)
> 
> 
> I've also made the file accessible here:
> 
> http://mark.kollide.net/ampersand_in_tooltips.png

probably a KLocale::removeAcceleratorMarker() is missing somewhere :)

Cheers,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Strange ampersand in Plasma tooltips

2010-03-02 Thread Will Stephenson
On Monday 01 March 2010 08:32:55 Mark Kretschmann wrote:
> I'm having a weird issue here, and I wonder if it's just me, or if
> it's maybe a bug in Plasma:
> 
> Many of the tooltips of the Plasma::IconWidget buttons we use in
> Amarok (like in the toolbar and in applets) contain weird ampersand
> characters, that is "&". I assume they come from keyboard shortcuts,
> but surely they shouldn't be shown in the tooltip, no?
> 
> I've asked about this in the #plasma IRC channel before, but noone had
> an idea. Do you have any? :)

What KUIT tags are you using in the i18n'ed strings? Some @info KUIT markup 
adds rich text for use in actions which looks weird in a widget not expecting 
it.

Will
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Strange ampersand in Plasma tooltips

2010-03-02 Thread Marco Martin
On Monday 01 March 2010, Mark Kretschmann wrote:
> Heya,
> 
> I'm having a weird issue here, and I wonder if it's just me, or if
> it's maybe a bug in Plasma:
> 
> Many of the tooltips of the Plasma::IconWidget buttons we use in
> Amarok (like in the toolbar and in applets) contain weird ampersand
> characters, that is "&". I assume they come from keyboard shortcuts,
> but surely they shouldn't be shown in the tooltip, no?
> 
> I've asked about this in the #plasma IRC channel before, but noone had
> an idea. Do you have any? :)
> 
> 
> Attaching a screenshot of this issue.

they should be gone now :)
(both on trunk and 4.4 branch)

Cheers,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Strange ampersand in Plasma tooltips

2010-03-02 Thread Artur Souza (MoRpHeUz)
On Tuesday 02 March 2010, 10:07 Marco Martin wrote:
> they should be gone now :)
> (both on trunk and 4.4 branch)

For pastebin too ? :)

Cheers,

--
Artur Duque de Souza
openBossa
INdT - Instituto Nokia de Tecnologia
--
Blog: http://blog.morpheuz.cc
PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net
--


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Strange ampersand in Plasma tooltips

2010-03-02 Thread Marco Martin
On Tuesday 02 March 2010, Artur Souza (MoRpHeUz) wrote:
> On Tuesday 02 March 2010, 10:07 Marco Martin wrote:
> > they should be gone now :)
> > (both on trunk and 4.4 branch)
> 
> For pastebin too ? :)
> 

no, just for IconWidget tooltips

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Strange ampersand in Plasma tooltips

2010-03-02 Thread Michael Jansen
On Tuesday 02 March 2010 14:40:25 Marco Martin wrote:
> On Tuesday 02 March 2010, Artur Souza (MoRpHeUz) wrote:
> > On Tuesday 02 March 2010, 10:07 Marco Martin wrote:
> > > they should be gone now :)
> > > (both on trunk and 4.4 branch)
> > 
> > For pastebin too ? :)
> 
> no, just for IconWidget tooltips

It would be a nice thing to post the solution too. In case someone find this 
thread when having the 
same problem.

Mike
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Strange ampersand in Plasma tooltips

2010-03-02 Thread Marco Martin
On Tuesday 02 March 2010, Michael Jansen wrote:
> On Tuesday 02 March 2010 14:40:25 Marco Martin wrote:
> > On Tuesday 02 March 2010, Artur Souza (MoRpHeUz) wrote:
> > > On Tuesday 02 March 2010, 10:07 Marco Martin wrote:
> > > > they should be gone now :)
> > > > (both on trunk and 4.4 branch)
> > > 
> > > For pastebin too ? :)
> > 
> > no, just for IconWidget tooltips
> 
> It would be a nice thing to post the solution too. In case someone find
> this thread when having the same problem.
> 

just this one liner

http://websvn.kde.org/trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp?r1=1097929&r2=1097986

Cheers,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Strange ampersand in Plasma tooltips

2010-03-03 Thread Mark Kretschmann
On Tue, Mar 2, 2010 at 6:31 PM, Marco Martin  wrote:
> On Tuesday 02 March 2010, Michael Jansen wrote:
>> On Tuesday 02 March 2010 14:40:25 Marco Martin wrote:
>> > On Tuesday 02 March 2010, Artur Souza (MoRpHeUz) wrote:
>> > > On Tuesday 02 March 2010, 10:07 Marco Martin wrote:
>> > > > they should be gone now :)
>> > > > (both on trunk and 4.4 branch)
>> > >
>> > > For pastebin too ? :)
>> >
>> > no, just for IconWidget tooltips
>>
>> It would be a nice thing to post the solution too. In case someone find
>> this thread when having the same problem.
>>
>
> just this one liner
>
> http://websvn.kde.org/trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp?r1=1097929&r2=1097986

Big thanks, Marco :)

-- 
Mark Kretschmann
Amarok Developer, Software Engineer at Collabora Ltd
Fellow of the Free Software Foundation Europe
http://amarok.kde.org - http://www.fsfe.org - http://collabora.co.uk
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel